Prevent NPE with rootLogger shorthand when no appenders are specified #3650
+29
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request addresses issue #3206, which could lead to a
NullPointerExceptionwhen using the shorthand notation for the root logger (e.g., rootLogger = INFO) inlog4j2.propertieswithout explicitly defining any appender references.To resolve this, the static helper method
LoggerConfig.getLevelAndRefs()has been updated to ensure that theLevelAndRefscontainer always holds a non-null list ofAppenderRefobjects. When no appenders are specified in the shorthand string, the method has been updated to return an empty list instead ofnull.Checklist
2.xbranch if you are targeting Log4j 2; usemainotherwise./mvnw verifysucceeds (if it fails due to code formatting issues reported by Spotless, simply run./mvnw spotless:applyand retry)src/changelog/.2.x.xdirectory