Skip to content

Conversation

Kcruz28
Copy link
Contributor

@Kcruz28 Kcruz28 commented Oct 17, 2025

I increased the Awaitility wait in AbstractAsyncThreadContextTestBase from 500 ms to 5 seconds to avoid a timing flake where the async logger ring buffer was not freed quickly enough on some machines. This is a minimal, test only change that keeps the same assertions but gives more time for slow or busy CI runners, especially on Windows. Five seconds should absorb temporary scheduling or I/O delays while keeping tests fast. We can adjust the timeout or make it configurable later if needed.

Fixes #3005.

The test  was failing intermittently due to a race condition in the test's base class, .

This commit replaces the fixed  with a more robust polling mechanism using the  library to ensure the test is stable and reliable.
@Kcruz28 Kcruz28 changed the title Fix/2.x/flaky syslog appender test base Increase Awaitility timeout to 5s in AbstractAsyncThreadContextTestBase Oct 17, 2025
@vy vy self-assigned this Oct 17, 2025
@vy vy added tests Pull requests or issues related to tests async Affects asynchronous loggers or appenders labels Oct 17, 2025
@vy
Copy link
Member

vy commented Oct 17, 2025

@Kcruz28, thanks so much for the contribution. Would you mind signing all your commits, please?

@vy vy added the waiting-for-user More information is needed from the user label Oct 17, 2025
@Kcruz28 Kcruz28 force-pushed the fix/2.x/flaky-syslog-appender-test-base branch 2 times, most recently from 7c11feb to 2a6f9b6 Compare October 19, 2025 00:36
@Kcruz28 Kcruz28 force-pushed the fix/2.x/flaky-syslog-appender-test-base branch from 2a6f9b6 to 168aea0 Compare October 19, 2025 00:40
@Kcruz28
Copy link
Contributor Author

Kcruz28 commented Oct 19, 2025

No problem! I’ve signed all my commits. Everything should be ready now. Please let me know if you encounter any issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

async Affects asynchronous loggers or appenders tests Pull requests or issues related to tests waiting-for-user More information is needed from the user

Projects

Status: To triage

Development

Successfully merging this pull request may close these issues.

AsyncThreadContextDefaultTest is unreliable

2 participants