Increase Awaitility timeout to 5s in AbstractAsyncThreadContextTestBase
#3956
+14
−17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The test was failing intermittently due to a race condition in the test's base class, . This commit replaces the fixed with a more robust polling mechanism using the library to ensure the test is stable and reliable.
Kcruz28
changed the title
AbstractAsyncThreadContextTestBase
vy
added
tests
vy
approved these changes
Oct 17, 2025
|
@Kcruz28, thanks so much for the contribution. Would you mind signing all your commits, please? |
Kcruz28
force-pushed
the
fix/2.x/flaky-syslog-appender-test-base
branch
2 times, most recently
from
7c11feb to
2a6f9b6
Compare
…ase to 5s to reduce flakiness
Kcruz28
force-pushed
the
fix/2.x/flaky-syslog-appender-test-base
branch
from
2a6f9b6 to
168aea0
Compare
|
No problem! I’ve signed all my commits. Everything should be ready now. Please let me know if you encounter any issues. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I increased the Awaitility wait in
AbstractAsyncThreadContextTestBasefrom 500 ms to 5 seconds to avoid a timing flake where the async logger ring buffer was not freed quickly enough on some machines. This is a minimal, test only change that keeps the same assertions but gives more time for slow or busy CI runners, especially on Windows. Five seconds should absorb temporary scheduling or I/O delays while keeping tests fast. We can adjust the timeout or make it configurable later if needed.Fixes #3005.