fix CA1031 - https://learn.microsoft.com/en-us/dotnet/fundamentals/code-analysis/quality-rules/ca1031

Do not catch general exception types

Author: FreeAndNil

src/Directory.Build.props

@@ -6,15 +6,25 @@
     <LangVersion>latest</LangVersion>
     <Nullable>Enable</Nullable>
     <WarningsAsErrors>nullable</WarningsAsErrors>
+    <AnalysisLevel>8</AnalysisLevel>
+    <RunAnalyzersDuringBuild>true</RunAnalyzersDuringBuild>
+    <RunAnalyzersDuringLiveAnalysis>true</RunAnalyzersDuringLiveAnalysis>
+    <_SkipUpgradeNetAnalyzersNuGetWarning>true</_SkipUpgradeNetAnalyzersNuGetWarning>
+    <AccelerateBuildsInVisualStudio>true</AccelerateBuildsInVisualStudio>
   </PropertyGroup>
   <PropertyGroup Label="Package Versions">
     <SystemConfigurationConfigurationManagerPackageVersion>4.5.0</SystemConfigurationConfigurationManagerPackageVersion>
     <MicrosoftSourceLinkGitHubPackageVersion>8.0.0</MicrosoftSourceLinkGitHubPackageVersion>
+    <!-- Analyzer packages -->
+    <MicrosoftNetAnalyzersPackageVersion>8.0.0</MicrosoftNetAnalyzersPackageVersion>
     <!-- Test Packages -->
     <MicrosoftNetTestSdkPackageVersion>17.11.1</MicrosoftNetTestSdkPackageVersion>
     <NUnitAnalyzersPackageVersion>4.3.0</NUnitAnalyzersPackageVersion>
     <NUnitPackageVersion>4.2.2</NUnitPackageVersion>
     <NUnit3TestAdapterPackageVersion>4.6.0</NUnit3TestAdapterPackageVersion>
     <QuackersTestLoggerPackageVersion>1.0.25</QuackersTestLoggerPackageVersion>
   </PropertyGroup>
+  <ItemGroup>
+    <GlobalAnalyzerConfigFiles Include="$(MSBuildThisFileDirectory)\log4net.globalconfig" />
+  </ItemGroup>
 </Project>

src/log4net.Tests/Appender/RollingFileAppenderTest.cs

@@ -170,7 +170,7 @@ private static void CreateFile(int iFileNumber)
         {
           fileStream.Close();
         }
-        catch
+        catch (Exception e) when (e is not null)
         {
           // Ignore
         }
@@ -250,9 +250,9 @@ private static void DeleteTestFiles()
         Debug.WriteLine("Deleting test file " + sFile);
         File.Delete(sFile);
       }
-      catch (Exception ex)
+      catch (Exception e) when (e is not null)
       {
-        Debug.WriteLine("Exception while deleting test file " + ex);
+        Debug.WriteLine("Exception while deleting test file " + e);
       }
     }
   }

src/log4net.Tests/Util/PatternStringTest.cs

@@ -88,6 +88,7 @@ public void TestAppSettingPathConverter()
 
   private void TestAppSettingPathConverterInConfiguredDomain()
   {
+    _ = this; // force instance method for AppDomain-Call
     string pattern = "%appSetting{TestKey}";
     PatternString patternString = new(pattern);
     string evaluatedPattern = patternString.Format();