fixed CA1812:AvoidUninstantiatedInternalClasses

Author: FreeAndNil

src/log4net.Tests/Appender/AdoNet/Log4NetConnection.cs

@@ -21,9 +21,11 @@
 
 using System;
 using System.Data;
+using System.Diagnostics.CodeAnalysis;
 
 namespace log4net.Tests.Appender.AdoNet;
 
+[SuppressMessage("Microsoft.Performance", "CA1812:AvoidUninstantiatedInternalClasses", Justification = "Reflection")]
 internal sealed class Log4NetConnection : IDbConnection
 {
   private bool _open;

src/log4net.Tests/Layout/PatternLayoutTest.cs

@@ -30,6 +30,7 @@
 using log4net.Util;
 
 using NUnit.Framework;
+using System.Diagnostics.CodeAnalysis;
 
 namespace log4net.Tests.Layout;
 
@@ -310,6 +311,7 @@ public void NamedPatternConverterWithPrecision2ShouldStripLessLeadingStuffIfPres
   /// <summary>
   /// Converter to include event message
   /// </summary>
+  [SuppressMessage("Microsoft.Performance", "CA1812:AvoidUninstantiatedInternalClasses", Justification = "Reflection")]
   private sealed class TestMessagePatternConverter : PatternLayoutConverter
   {
     /// <summary>
@@ -341,6 +343,7 @@ public void TestExceptionPattern()
     stringAppender.Reset();
   }
 
+  [SuppressMessage("Microsoft.Performance", "CA1812:AvoidUninstantiatedInternalClasses", Justification = "Reflection")]
   private sealed class MessageAsNamePatternConverter : NamedPatternConverter
   {
     protected override string GetFullyQualifiedName(LoggingEvent loggingEvent) => loggingEvent.MessageObject?.ToString() ?? string.Empty;

src/log4net/Appender/RollingFileAppender.DateTime.cs

@@ -18,6 +18,7 @@
 #endregion
 
 using System;
+using System.Diagnostics.CodeAnalysis;
 
 namespace log4net.Appender;
 
@@ -65,6 +66,7 @@ private sealed class LocalDateTime : IDateTime
   /// <summary>
   /// Implementation of <see cref="IDateTime"/> that returns the current time as the coordinated universal time (UTC).
   /// </summary>
+  [SuppressMessage("Microsoft.Performance", "CA1812:AvoidUninstantiatedInternalClasses", Justification = "Reflection")]
   private sealed class UniversalDateTime : IDateTime
   {
     /// <summary>

src/log4net/Config/XmlConfigurator.cs

@@ -137,10 +137,8 @@ private static void InternalConfigure(ILoggerRepository repository)
   /// </para>
   /// </remarks>
   /// <seealso cref="Log4NetConfigurationSectionHandler"/>
-  public static ICollection Configure()
-  {
-    return Configure(LogManager.GetRepository(Assembly.GetCallingAssembly()));
-  }
+  public static ICollection Configure() 
+    => Configure(LogManager.GetRepository(Assembly.GetCallingAssembly()));
 
   /// <summary>
   /// Configures log4net using a <c>log4net</c> element

src/log4net/Layout/Pattern/AppDomainPatternConverter.cs

@@ -17,6 +17,7 @@
 //
 #endregion
 
+using System.Diagnostics.CodeAnalysis;
 using System.IO;
 
 using log4net.Core;
@@ -33,6 +34,7 @@ namespace log4net.Layout.Pattern;
 /// </remarks>
 /// <author>Daniel Cazzulino</author>
 /// <author>Nicko Cadell</author>
+[SuppressMessage("Microsoft.Performance", "CA1812:AvoidUninstantiatedInternalClasses", Justification = "Reflection")]
 internal sealed class AppDomainPatternConverter : PatternLayoutConverter
 {
   /// <summary>
@@ -45,8 +47,6 @@ internal sealed class AppDomainPatternConverter : PatternLayoutConverter
   /// Writes the <see cref="LoggingEvent.Domain"/> to the output <paramref name="writer"/>.
   /// </para>
   /// </remarks>
-  protected override void Convert(TextWriter writer, LoggingEvent loggingEvent)
-  {
-    writer.Write(loggingEvent.Domain);
-  }
+  protected override void Convert(TextWriter writer, LoggingEvent loggingEvent) 
+    => writer.Write(loggingEvent.Domain);
 }

src/log4net/Layout/Pattern/AspNetCachePatternConverter.cs

@@ -18,6 +18,7 @@
 //
 #endregion
 
+using System.Diagnostics.CodeAnalysis;
 using System.IO;
 using System.Web;
 using log4net.Core;
@@ -34,6 +35,7 @@ namespace log4net.Layout.Pattern;
 /// </para>
 /// </remarks>
 /// <author>Ron Grabowski</author>
+[SuppressMessage("Microsoft.Performance", "CA1812:AvoidUninstantiatedInternalClasses", Justification = "Reflection")]
 internal sealed class AspNetCachePatternConverter : AspNetPatternLayoutConverter
 {
   /// <summary>

src/log4net/Layout/Pattern/AspNetContextPatternConverter.cs

@@ -18,6 +18,7 @@
 //
 #endregion
 
+using System.Diagnostics.CodeAnalysis;
 using System.IO;
 using System.Web;
 using log4net.Core;
@@ -33,6 +34,7 @@ namespace log4net.Layout.Pattern;
 /// </para>
 /// </remarks>
 /// <author>Ron Grabowski</author>
+[SuppressMessage("Microsoft.Performance", "CA1812:AvoidUninstantiatedInternalClasses", Justification = "Reflection")]
 internal sealed class AspNetContextPatternConverter : AspNetPatternLayoutConverter
 {
   /// <summary>

src/log4net/Layout/Pattern/AspNetRequestPatternConverter.cs

@@ -18,6 +18,7 @@
 //
 #endregion
 
+using System.Diagnostics.CodeAnalysis;
 using System.IO;
 using System.Web;
 using log4net.Core;
@@ -34,6 +35,7 @@ namespace log4net.Layout.Pattern;
 /// </para>
 /// </remarks>
 /// <author>Ron Grabowski</author>
+[SuppressMessage("Microsoft.Performance", "CA1812:AvoidUninstantiatedInternalClasses", Justification = "Reflection")]
 internal sealed class AspNetRequestPatternConverter : AspNetPatternLayoutConverter
 {
   /// <summary>

src/log4net/Layout/Pattern/AspNetSessionPatternConverter.cs

@@ -18,6 +18,7 @@
 //
 #endregion
 
+using System.Diagnostics.CodeAnalysis;
 using System.IO;
 using System.Web;
 using log4net.Core;
@@ -34,6 +35,7 @@ namespace log4net.Layout.Pattern;
 /// </para>
 /// </remarks>
 /// <author>Ron Grabowski</author>
+[SuppressMessage("Microsoft.Performance", "CA1812:AvoidUninstantiatedInternalClasses", Justification = "Reflection")]
 internal sealed class AspNetSessionPatternConverter : AspNetPatternLayoutConverter
 {
   /// <summary>

src/log4net/Layout/Pattern/DatePatternConverter.cs

@@ -155,20 +155,13 @@ protected override void Convert(TextWriter writer, LoggingEvent loggingEvent)
   {
     try
     {
-      m_dateFormatter!.FormatDate(loggingEvent.TimeStamp, writer);
+      m_dateFormatter.EnsureNotNull().FormatDate(loggingEvent.TimeStamp, writer);
     }
     catch (Exception e) when (!e.IsFatal())
     {
       LogLog.Error(_declaringType, "Error occurred while converting date.", e);
     }
   }
 
-  /// <summary>
-  /// The fully qualified type of the DatePatternConverter class.
-  /// </summary>
-  /// <remarks>
-  /// Used by the internal logger to record the Type of the
-  /// log message.
-  /// </remarks>
   private static readonly Type _declaringType = typeof(DatePatternConverter);
 }