exclude tests with different behaviour on mono

Author: FreeAndNil

src/log4net.Tests/Appender/RollingFileAppenderTest.cs

@@ -41,8 +41,6 @@ namespace log4net.Tests.Appender
   [TestFixture]
   public sealed class RollingFileAppenderTest
   {
-    private static readonly bool isMono = Type.GetType("Mono.Runtime") is not null;
-
     private const string c_fileName = "test_41d3d834_4320f4da.log";
 
     private const string c_testMessage98Chars =
@@ -1381,6 +1379,7 @@ private static void AssertFileEquals(string filename, string contents)
     [Test]
     public void TestLogOutput()
     {
+      Utils.InconclusiveOnMono();
       string filename = "test_simple.log";
       SilentErrorHandler sh = new();
       ILogger log = CreateLogger(filename, new FileAppender.ExclusiveLock(), sh);
@@ -1421,6 +1420,7 @@ public void TestExclusiveLockFails()
     [Test]
     public void TestExclusiveLockRecovers()
     {
+      Utils.InconclusiveOnMono();
       string filename = "test_exclusive_lock_recovers.log";
 
       FileStream fs = new(filename, FileMode.Create, FileAccess.Write, FileShare.None);
@@ -1444,10 +1444,7 @@ public void TestExclusiveLockRecovers()
     [Test]
     public void TestExclusiveLockLocks()
     {
-      if (isMono)
-      {
-        Assert.Inconclusive("mono has a different behaviour");
-      }
+      Utils.InconclusiveOnMono();
       string filename = "test_exclusive_lock_locks.log";
       bool locked = false;
 
@@ -1484,6 +1481,7 @@ public void TestExclusiveLockLocks()
     [Test]
     public void TestMinimalLockFails()
     {
+      Utils.InconclusiveOnMono();
       string filename = "test_minimal_lock_fails.log";
 
       FileStream fs = new(filename, FileMode.Create, FileAccess.Write, FileShare.None);
@@ -1507,6 +1505,7 @@ public void TestMinimalLockFails()
     [Test]
     public void TestMinimalLockRecovers()
     {
+      Utils.InconclusiveOnMono();
       string filename = "test_minimal_lock_recovers.log";
 
       FileStream fs = new(filename, FileMode.Create, FileAccess.Write, FileShare.None);
@@ -1530,6 +1529,7 @@ public void TestMinimalLockRecovers()
     [Test]
     public void TestMinimalLockUnlocks()
     {
+      Utils.InconclusiveOnMono();
       string filename = "test_minimal_lock_unlocks.log";
       bool locked;
 
@@ -1558,6 +1558,7 @@ public void TestMinimalLockUnlocks()
     [Test]
     public void TestInterProcessLockFails()
     {
+      Utils.InconclusiveOnMono();
       string filename = "test_interprocess_lock_fails.log";
 
       FileStream fs = new(filename, FileMode.Create, FileAccess.Write, FileShare.None);
@@ -1581,6 +1582,7 @@ public void TestInterProcessLockFails()
     [Test]
     public void TestInterProcessLockRecovers()
     {
+      Utils.InconclusiveOnMono();
       string filename = "test_interprocess_lock_recovers.log";
 
       FileStream fs = new(filename, FileMode.Create, FileAccess.Write, FileShare.None);
@@ -1604,6 +1606,7 @@ public void TestInterProcessLockRecovers()
     [Test]
     public void TestInterProcessLockUnlocks()
     {
+      Utils.InconclusiveOnMono();
       string filename = "test_interprocess_lock_unlocks.log";
       bool locked;
 
@@ -1632,6 +1635,7 @@ public void TestInterProcessLockUnlocks()
     [Test]
     public void TestInterProcessLockRoll()
     {
+      Utils.InconclusiveOnMono();
       const string filename = "test_interprocess_lock_roll.log";
 
       SilentErrorHandler sh = new();

src/log4net.Tests/Appender/SmtpPickupDirAppenderTest.cs

@@ -170,6 +170,7 @@ private static void DestroyLogger()
     [Test]
     public void TestOutputContainsSentDate()
     {
+      Utils.InconclusiveOnMono();
       SilentErrorHandler sh = new SilentErrorHandler();
       SmtpPickupDirAppender appender = CreateSmtpPickupDirAppender(sh);
       ILogger log = CreateLogger(appender);
@@ -203,6 +204,7 @@ public void TestOutputContainsSentDate()
     [Test]
     public void TestConfigurableFileExtension()
     {
+      Utils.InconclusiveOnMono();
       const string fileExtension = "eml";
       SilentErrorHandler sh = new SilentErrorHandler();
       SmtpPickupDirAppender appender = CreateSmtpPickupDirAppender(sh);
@@ -226,6 +228,7 @@ public void TestConfigurableFileExtension()
     [Test]
     public void TestDefaultFileNameIsAGuid()
     {
+      Utils.InconclusiveOnMono();
       SilentErrorHandler sh = new SilentErrorHandler();
       SmtpPickupDirAppender appender = CreateSmtpPickupDirAppender(sh);
       ILogger log = CreateLogger(appender);

src/log4net.Tests/Core/LoggingEventTest.cs

@@ -39,6 +39,7 @@ private static readonly DateTime localTime
   [Test]
   public void SerializeDeserialize_BinaryFormatter()
   {
+    Utils.InconclusiveOnMono();
     var timestamp = localTime.ToUniversalTime();
     var ev = new LoggingEvent(new LoggingEventData
     {
@@ -87,6 +88,7 @@ public void SerializeDeserialize_BinaryFormatter()
   [Test]
   public void DeserializeV2()
   {
+    Utils.InconclusiveOnMono();
     const string datPath = @"..\..\..\..\integration-testing\log4net2-SerializeEvent\SerializeV2Event.dat";
     using var stream = File.OpenRead(datPath);
     var formatter = new BinaryFormatter();

src/log4net.Tests/Utils.cs

@@ -17,15 +17,40 @@
 //
 #endregion
 
+using System;
+using NUnit.Framework;
+
 namespace log4net.Tests
 {
   /// <summary>
-  /// Summary description for Class1.
+  /// Utilities for testing
   /// </summary>
   public static class Utils
   {
+    /// <summary>
+    /// Is the mono runtime used
+    /// </summary>
+    internal static bool IsMono { get; } = Type.GetType("Mono.Runtime") is not null;
+
+    /// <summary>
+    /// Skips the current test when run under mono
+    /// </summary>
+    internal static void InconclusiveOnMono()
+    {
+      if (IsMono)
+      {
+        Assert.Inconclusive("mono has a different behaviour");
+      }
+    }
+
+    /// <summary>
+    /// Sample property key
+    /// </summary>
     internal const string PROPERTY_KEY = "prop1";
 
+    /// <summary>
+    /// Remove the <see cref="PROPERTY_KEY"/> from alle log4net contexts
+    /// </summary>
     internal static void RemovePropertyFromAllContexts()
     {
       GlobalContext.Properties.Remove(PROPERTY_KEY);