Fix infinite loop when RefCountedSharedArena's underlying Arena#close fails due to concurrent usage of segments (#15112)

Author: uschindler

lucene/CHANGES.txt

@@ -306,6 +306,9 @@ Bug Fixes
   resulted in query branches being wrongly ignored if the QueryIndex was
   built by a different JVM. (Luke Kot-Zaniewski)
 
+* GITHUB#15106: Fix infinite loop when RefCountedSharedArena's underlying
+  Arena#close fails due to concurrent usage of segments.  (Uwe Schindler)
+
 Build
 ---------------------
 * Upgrade forbiddenapis to version 3.9.  (Uwe Schindler)

lucene/core/src/java/org/apache/lucene/store/RefCountedSharedArena.java

@@ -50,7 +50,11 @@ final class RefCountedSharedArena implements Arena {
   private static final int ACQUIRE_DECREMENT = REMAINING_UNIT - 1; // 0xffff
 
   private final String segmentName;
+
+  // onClose could be called multiple times when the inner Arena's close fails with
+  // IllegalStateException
   private final Runnable onClose;
+
   private final Arena arena;
 
   // high 16 bits contain the total remaining acquires; monotonically decreasing
@@ -99,14 +103,10 @@ boolean acquire() {
 
   /** Decrements the ref count. */
   void release() {
-    int value;
     while (true) {
-      value = state.get();
+      final int value = state.get();
       final int count = value & 0xFFFF;
-      if (count == 0) {
-        throw new IllegalStateException(value == CLOSED ? "closed" : "nothing to release");
-      }
-      final int newValue = count == 1 ? CLOSED : value - 1;
+      final int newValue = count <= 1 ? CLOSED : value - 1;
       if (this.state.compareAndSet(value, newValue)) {
         if (newValue == CLOSED) {
           onClose.run();