Skip to content

Commit 2bae327

Browse files
authored
Failing workflow instead of comment on missing changelog entry (#15409)
Signed-off-by: Ankit Jain <jainankitk@apache.org>
1 parent 7ceee5d commit 2bae327

File tree

1 file changed

+2
-3
lines changed

1 file changed

+2
-3
lines changed

.github/workflows/verify-changelog-and-set-milestone.yml

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -56,9 +56,8 @@ jobs:
5656
5757
echo "Diff:"
5858
if git diff --exit-code --name-only "$BASE_COMMIT" HEAD -- "$CHANGE_LOG_FILE"; then
59-
echo "Change log file:$CHANGE_LOG_FILE does not contains an entry corresponding to changes introduced in PR. Please add a changelog entry."
60-
gh pr comment "$PR_NUMBER" --body "This PR does not have an entry in lucene/CHANGES.txt. Consider adding one. If the PR doesn't need a changelog entry, then add the skip-changelog label to it and you will stop receiving this reminder on future updates to the PR."
61-
exit 0
59+
echo "::error ::Change log file:$CHANGE_LOG_FILE does not contains an entry corresponding to changes introduced in PR. Please add a changelog entry."
60+
exit 1
6261
else
6362
echo "$CHANGE_LOG_FILE contains change log entry. Proceeding with next steps."
6463
fi

0 commit comments

Comments
 (0)