Add checkDimension check to Lucene104ScalarQuantizedVectorScorer#getRandomVectorScorer (#15359)

Author: shubhamvishu

lucene/core/src/java/org/apache/lucene/codecs/hnsw/FlatVectorsScorer.java

@@ -67,4 +67,11 @@ RandomVectorScorer getRandomVectorScorer(
   RandomVectorScorer getRandomVectorScorer(
       VectorSimilarityFunction similarityFunction, KnnVectorValues vectorValues, byte[] target)
       throws IOException;
+
+  static void checkDimensions(int queryLen, int fieldLen) {
+    if (queryLen != fieldLen) {
+      throw new IllegalArgumentException(
+          "vector query dimension: " + queryLen + " differs from field dimension: " + fieldLen);
+    }
+  }
 }

lucene/core/src/java/org/apache/lucene/codecs/lucene104/Lucene104ScalarQuantizedVectorScorer.java

@@ -39,13 +39,6 @@ public Lucene104ScalarQuantizedVectorScorer(FlatVectorsScorer nonQuantizedDelega
     this.nonQuantizedDelegate = nonQuantizedDelegate;
   }
 
-  static void checkDimensions(int queryLen, int fieldLen) {
-    if (queryLen != fieldLen) {
-      throw new IllegalArgumentException(
-          "vector query dimension: " + queryLen + " differs from field dimension: " + fieldLen);
-    }
-  }
-
   @Override
   public RandomVectorScorerSupplier getRandomVectorScorerSupplier(
       VectorSimilarityFunction similarityFunction, KnnVectorValues vectorValues)
@@ -62,7 +55,7 @@ public RandomVectorScorer getRandomVectorScorer(
       VectorSimilarityFunction similarityFunction, KnnVectorValues vectorValues, float[] target)
       throws IOException {
     if (vectorValues instanceof QuantizedByteVectorValues qv) {
-      checkDimensions(target.length, qv.dimension());
+      FlatVectorsScorer.checkDimensions(target.length, qv.dimension());
       OptimizedScalarQuantizer quantizer = qv.getQuantizer();
       byte[] targetQuantized =
           new byte
@@ -93,6 +86,7 @@ public float score(int node) throws IOException {
   public RandomVectorScorer getRandomVectorScorer(
       VectorSimilarityFunction similarityFunction, KnnVectorValues vectorValues, byte[] target)
       throws IOException {
+    FlatVectorsScorer.checkDimensions(target.length, vectorValues.dimension());
     return nonQuantizedDelegate.getRandomVectorScorer(similarityFunction, vectorValues, target);
   }
 

lucene/core/src/java/org/apache/lucene/codecs/lucene99/Lucene99ScalarQuantizedVectorScorer.java

@@ -95,6 +95,7 @@ static UpdateableRandomVectorScorer fromVectorSimilarity(
       VectorSimilarityFunction sim,
       float constMultiplier,
       QuantizedByteVectorValues values) {
+    FlatVectorsScorer.checkDimensions(values.dimension(), targetBytes.length);
     return switch (sim) {
       case EUCLIDEAN -> new Euclidean(values, constMultiplier, targetBytes);
       case COSINE, DOT_PRODUCT ->

lucene/core/src/java21/org/apache/lucene/internal/vectorization/Lucene99MemorySegmentFlatVectorsScorer.java

@@ -84,7 +84,7 @@ private RandomVectorScorerSupplier getByteScorerSupplier(
   public RandomVectorScorer getRandomVectorScorer(
       VectorSimilarityFunction similarityType, KnnVectorValues vectorValues, float[] target)
       throws IOException {
-    checkDimensions(target.length, vectorValues.dimension());
+    FlatVectorsScorer.checkDimensions(target.length, vectorValues.dimension());
     if (vectorValues instanceof FloatVectorValues fvv
         && fvv instanceof HasIndexSlice floatVectorValues
         && floatVectorValues.getSlice() != null) {
@@ -102,7 +102,7 @@ public RandomVectorScorer getRandomVectorScorer(
   public RandomVectorScorer getRandomVectorScorer(
       VectorSimilarityFunction similarityType, KnnVectorValues vectorValues, byte[] queryVector)
       throws IOException {
-    checkDimensions(queryVector.length, vectorValues.dimension());
+    FlatVectorsScorer.checkDimensions(queryVector.length, vectorValues.dimension());
     // a quantized values here is a wrapping or delegation issue
     assert !(vectorValues instanceof QuantizedByteVectorValues);
     if (vectorValues instanceof ByteVectorValues bvv
@@ -118,13 +118,6 @@ public RandomVectorScorer getRandomVectorScorer(
     return delegate.getRandomVectorScorer(similarityType, vectorValues, queryVector);
   }
 
-  static void checkDimensions(int queryLen, int fieldLen) {
-    if (queryLen != fieldLen) {
-      throw new IllegalArgumentException(
-          "vector query dimension: " + queryLen + " differs from field dimension: " + fieldLen);
-    }
-  }
-
   @Override
   public String toString() {
     return "Lucene99MemorySegmentFlatVectorsScorer()";