Upgrade to Gradle 9.1.0 (#15236)

Author: dweiss

.github/actions/prepare-for-build/action.yml

@@ -7,7 +7,7 @@ description: Creates a shared setup for other workflows
 inputs:
   java-version:
     required: false
-    default: "24"
+    default: "25"
     description: "The default JDK version to set up."
 
   java-distribution:

.github/workflows/run-checks-all.yml

@@ -29,7 +29,7 @@ jobs:
     strategy:
       matrix:
         os: [ ubuntu-latest ]
-        java: [ '24' ]
+        java: [ '25' ]
 
     runs-on: ${{ matrix.os }}
 
@@ -63,7 +63,7 @@ jobs:
       matrix:
         # Operating systems to run on.
         os: [ ubuntu-latest, windows-latest, macos-latest ]
-        java: [ '24' ]
+        java: [ '25' ]
 
     runs-on: ${{ matrix.os }}
 

.github/workflows/run-checks-gradle-upgrade.yml

@@ -32,7 +32,7 @@ jobs:
     strategy:
       matrix:
         os: [ ubuntu-latest ]
-        java-version: [ '24' ]
+        java-version: [ '25' ]
         uses-alt-java: [ true, false ]
 
     runs-on: ${{ matrix.os }}

.github/workflows/run-nightly-smoketester.yml

@@ -22,7 +22,7 @@ jobs:
     strategy:
       matrix:
         os: [ ubuntu-latest ]
-        java-version: [ '24' ]
+        java-version: [ '25' ]
 
     runs-on: ${{ matrix.os }}
 

.github/workflows/run-special-checks-sandbox.yml

@@ -20,7 +20,7 @@ jobs:
     strategy:
       matrix:
         os: [ ubuntu-latest ]
-        java: [ '24' ]
+        java: [ '25' ]
         faiss-version: [ '1.11.0' ]
 
     runs-on: ${{ matrix.os }}

README.md

@@ -40,7 +40,7 @@ comprehensive documentation, visit:
 
 ### Basic steps:
 
-1. Install [OpenJDK 24](https://jdk.java.net/archive/).
+1. Install [OpenJDK 25](https://jdk.java.net/archive/).
 2. Clone Lucene's git repository (or download the source distribution).
 3. Run gradle launcher script (`gradlew`).
 

build-tools/build-infra-shadow/build.gradle

@@ -24,6 +24,8 @@ repositories {
   gradlePluginPortal()
 }
 
+apply from: rootProject.file("build-tools/build-infra/ecj-source.gradle")
+
 // Convert a plugin dependency to a regular dependency so that we can
 // use [plugins] section in the top-level toml but declare regular
 // project dependencies here.

build-tools/build-infra/build.gradle

@@ -27,6 +27,8 @@ repositories {
   gradlePluginPortal()
 }
 
+apply from: file("ecj-source.gradle")
+
 group = "org.apache"
 
 java {

build-tools/build-infra/ecj-source.gradle

@@ -0,0 +1,45 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+// We occasionally use versions of ecj that are not yet published in Maven Central
+// and are only available in Eclipse "drops" (interim builds) (ecj jar is uploaded
+// to maven central approximately every three months). If this is the case,
+// we redirect dependency resolution to our own s3-based "maven repository" just for
+// the ecj jar.
+
+boolean useDropMirrorForEcj = true
+if (useDropMirrorForEcj) {
+  repositories {
+    exclusiveContent {
+      forRepository {
+        ivy {
+          url = 'https://s3.amazonaws.com/lucene-testdata/temp-repo/ecj/'
+          patternLayout {
+            artifact "[artifact]-[revision](.[ext])"
+            m2compatible = true
+          }
+          metadataSources {
+            it.artifact()
+          }
+        }
+      }
+      filter {
+        includeGroup "org.eclipse.jdt"
+      }
+    }
+  }
+}

build-tools/build-infra/src/main/groovy/lucene.regenerate.icu.gradle

@@ -272,18 +272,18 @@ configure(project(":lucene:analysis:common")) {
     outputs.file outputFile
 
     doFirst {
-      def execOps = objects.newInstance(ExecOperationsProvider).execOperations
-      execOps.javaexec {
-        mainClass "groovy.lang.GroovyShell"
-        classpath icuConfig, groovyConfig
+      ExecOperations execOps = objects.newInstance(ExecOperationsProvider).execOperations
+      execOps.javaexec({ JavaExecSpec spec ->
+        spec.mainClass = "groovy.lang.GroovyShell"
+        spec.classpath(icuConfig, groovyConfig)
 
-        args = [
+        spec.args([
           "--encoding",
           "UTF-8",
-          file("${resources}/GenerateUnicodeProps.groovy"),
-          outputFile
-        ]
-      }
+          file("${resources}/GenerateUnicodeProps.groovy").toString(),
+          outputFile.toString()
+        ])
+      })
     }
   }
 
@@ -313,8 +313,8 @@ configure(project(":lucene:core")) {
 
     doFirst {
       def execOps = objects.newInstance(ExecOperationsProvider).execOperations
-      execOps.javaexec {
-        mainClass "groovy.lang.GroovyShell"
+      execOps.javaexec({
+        mainClass = "groovy.lang.GroovyShell"
         classpath icuConfig, groovyConfig
 
         args = [
@@ -323,7 +323,7 @@ configure(project(":lucene:core")) {
           file("${resources}/GenerateCaseFolding.groovy"),
           outputFile
         ]
-      }
+      })
     }
   }