Skip to content

Commit 7f63410

Browse files
dungba88mikemccand
authored andcommitted
remove FST's BytesReader#reversed() (#12777)
1 parent bb479c7 commit 7f63410

File tree

8 files changed

+0
-40
lines changed

8 files changed

+0
-40
lines changed

lucene/core/src/java/org/apache/lucene/util/fst/ByteBlockPoolReverseBytesReader.java

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -58,11 +58,6 @@ public void setPosition(long pos) {
5858
this.pos = pos - posDelta;
5959
}
6060

61-
@Override
62-
public boolean reversed() {
63-
return true;
64-
}
65-
6661
public void setPosDelta(long posDelta) {
6762
this.posDelta = posDelta;
6863
}

lucene/core/src/java/org/apache/lucene/util/fst/BytesStore.java

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -434,11 +434,6 @@ public void setPosition(long pos) {
434434
nextRead = (int) (pos & blockMask);
435435
assert getPosition() == pos;
436436
}
437-
438-
@Override
439-
public boolean reversed() {
440-
return false;
441-
}
442437
};
443438
}
444439

@@ -492,11 +487,6 @@ public void setPosition(long pos) {
492487
nextRead = (int) (pos & blockMask);
493488
assert getPosition() == pos : "pos=" + pos + " getPos()=" + getPosition();
494489
}
495-
496-
@Override
497-
public boolean reversed() {
498-
return true;
499-
}
500490
};
501491
}
502492

lucene/core/src/java/org/apache/lucene/util/fst/FST.java

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1135,9 +1135,6 @@ public abstract static class BytesReader extends DataInput {
11351135

11361136
/** Set current read position. */
11371137
public abstract void setPosition(long pos);
1138-
1139-
/** Returns true if this reader uses reversed bytes under-the-hood. */
1140-
public abstract boolean reversed();
11411138
}
11421139

11431140
/**

lucene/core/src/java/org/apache/lucene/util/fst/ForwardBytesReader.java

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -53,9 +53,4 @@ public long getPosition() {
5353
public void setPosition(long pos) {
5454
this.pos = (int) pos;
5555
}
56-
57-
@Override
58-
public boolean reversed() {
59-
return false;
60-
}
6156
}

lucene/core/src/java/org/apache/lucene/util/fst/ReverseBytesReader.java

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -51,9 +51,4 @@ public long getPosition() {
5151
public void setPosition(long pos) {
5252
this.pos = (int) pos;
5353
}
54-
55-
@Override
56-
public boolean reversed() {
57-
return true;
58-
}
5954
}

lucene/core/src/java/org/apache/lucene/util/fst/ReverseRandomAccessReader.java

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -55,9 +55,4 @@ public long getPosition() {
5555
public void setPosition(long pos) {
5656
this.pos = pos;
5757
}
58-
59-
@Override
60-
public boolean reversed() {
61-
return true;
62-
}
6358
}

lucene/core/src/test/org/apache/lucene/util/fst/TestBitTableUtil.java

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -154,11 +154,6 @@ public void setPosition(long pos) {
154154
position = (int) pos;
155155
}
156156

157-
@Override
158-
public boolean reversed() {
159-
return false;
160-
}
161-
162157
@Override
163158
public byte readByte() {
164159
return bits[position++];

lucene/core/src/test/org/apache/lucene/util/fst/TestBytesStore.java

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -272,7 +272,6 @@ private void verify(BytesStore bytes, byte[] expected, int totalLength) throws E
272272
}
273273
// reversed
274274
FST.BytesReader r = bytes.getReverseBytesReader();
275-
assertTrue(r.reversed());
276275
r.setPosition(totalLength - 1);
277276
r.readBytes(actual, 0, actual.length);
278277
int start = 0;
@@ -290,7 +289,6 @@ private void verify(BytesStore bytes, byte[] expected, int totalLength) throws E
290289
System.out.println(" bulk: forward");
291290
}
292291
FST.BytesReader r = bytes.getForwardReader();
293-
assertFalse(r.reversed());
294292
r.readBytes(actual, 0, actual.length);
295293
}
296294

0 commit comments

Comments
 (0)