Move isolated-inheritdoc detection to an ast-grep rule (#14988)

Author: dweiss

build-tools/build-infra/src/main/groovy/lucene.validation.source-patterns.gradle

@@ -97,9 +97,7 @@ class ValidateSourcePatternsTask extends DefaultTask {
 
   @TaskAction
   public void check() {
-    def invalidPatterns = [
-      (~$/\Q/**\E((?:\s)|(?:\*))*\Q{@inheritDoc}\E((?:\s)|(?:\*))*\Q*/\E/$) : '{@inheritDoc} on its own is unnecessary',
-    ]
+    def invalidPatterns = []
 
     def violations = new TreeSet();
     def reportViolation = { f, name ->

gradle/validation/ast-grep/rules/java-patterns.yml

@@ -140,3 +140,12 @@ rule:
         pattern: incubator
 severity: error
 message: Module dependency on incubator APIs
+---
+# yaml-language-server: $schema=https://raw.githubusercontent.com/ast-grep/ast-grep/refs/heads/main/schemas/java_rule.json
+id: javadoc-only-inheriting-super
+language: java
+rule:
+  matches: javadoc
+  regex: "^/\\*\\*([ \r\n*])*[{]@inheritDoc[ \r\n]*[}]([ \r\n*])*\\*/$"
+severity: error
+message: "{@inheritDoc} on its own is unnecessary"

gradle/validation/ast-grep/tests/java-patterns.yml

@@ -115,3 +115,21 @@ valid:
     module org.apache.lucene.foo {
       requires org.apache.lucene.bar;
     }
+---
+id: javadoc-only-inheriting-super
+invalid:
+  - /** {@inheritDoc} */
+  - /** {@inheritDoc } */
+  - "/**\n * {@inheritDoc}\n */"
+valid:
+  - |
+    /**
+    * {@inheritDoc}
+    *
+    * And something.
+    */
+  - |
+    /**
+    * Something and...
+    * {@inheritDoc}
+    */