deps(java): bump com.google.errorprone:error_prone_core from 2.42.0 to 2.43.0 (#15407)

* deps(java): bump com.google.errorprone:error_prone_core

Bumps [com.google.errorprone:error_prone_core](https://github.com/google/error-prone) from 2.42.0 to 2.43.0.
- [Release notes](https://github.com/google/error-prone/releases)
- [Commits](google/error-prone@v2.42.0...v2.43.0)

---
updated-dependencies:
- dependency-name: com.google.errorprone:error_prone_core
  dependency-version: 2.43.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>

* Update lock file. Update check list in error prone plugin. Correct one dead null check.

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Dawid Weiss <[email protected]>

Author: dependabot[bot]

build-tools/build-infra/src/main/java/org/apache/lucene/gradle/plugins/java/CodeProfilingPlugin.java

@@ -203,7 +203,7 @@ public void apply(Project project) {
                               .getProviders()
                               .provider(
                                   () -> {
-                                    return task.getState().getFailure() == null;
+                                    return task.getState().getDidWork();
                                   }));
                 });
           });

build-tools/build-infra/src/main/java/org/apache/lucene/gradle/plugins/java/ErrorPronePlugin.java

@@ -265,7 +265,6 @@ public void apply(Project project) {
     "AlwaysThrows:OFF", // we don't use guava
     "AmbiguousMethodReference:OFF",
     "AndroidInjectionBeforeSuper:OFF", // we don't use android
-    "AndroidJdkLibsChecker:OFF", // TODO: new, not checked if applicable to Lucene
     "AnnotateFormatMethod:OFF", // we don't use this annotation
     "AnnotationMirrorToString:OFF", // TODO: new, not checked if applicable to Lucene
     "AnnotationPosition:OFF", // TODO: new, not checked if applicable to Lucene
@@ -647,6 +646,7 @@ public void apply(Project project) {
     "NonRuntimeAnnotation:ERROR",
     "NotJavadoc:WARN",
     "NullArgumentForNonNullParameter:OFF", // we don't use this annotation
+    "NullNeedsCastForVarargs:ERROR",
     "NullOptional:WARN",
     "NullTernary:ERROR",
     "NullableConstructor:OFF", // we don't use this annotation
@@ -712,6 +712,7 @@ public void apply(Project project) {
     "ReachabilityFenceUsage:WARN",
     "RectIntersectReturnValueIgnored:OFF", // we don't use android
     "RedundantControlFlow:OFF", // stylistic
+    "RedundantNullCheck:ERROR",
     "RedundantOverride:OFF", // TODO: new, not checked if applicable to Lucene
     "RedundantSetterCall:OFF", // we don't use protobuf
     "RedundantThrows:OFF", // TODO: new, not checked if applicable to Lucene

gradle/libs.versions.toml

@@ -11,7 +11,7 @@ commons-compress = "1.28.0"
 # See ecj-lint.gradle (used for more linting).
 ecj = "I20250926-1800"
 # java linting
-errorprone = "2.42.0"
+errorprone = "2.43.0"
 # markdown documentation generation
 flexmark = "0.64.8"
 # @keep This is GJF version for java source code formatting

versions.lock

@@ -34,10 +34,10 @@
       "com.google.auto.value:auto-value-annotations:1.9" : "90685606,refs=39",
       "com.google.auto:auto-common:1.2.2" : "90685606,refs=39",
       "com.google.code.findbugs:jsr305:3.0.2" : "90685606,refs=39",
-      "com.google.errorprone:error_prone_annotation:2.42.0" : "90685606,refs=39",
-      "com.google.errorprone:error_prone_annotations:2.42.0" : "90685606,refs=39",
-      "com.google.errorprone:error_prone_check_api:2.42.0" : "90685606,refs=39",
-      "com.google.errorprone:error_prone_core:2.42.0" : "90685606,refs=39",
+      "com.google.errorprone:error_prone_annotation:2.43.0" : "90685606,refs=39",
+      "com.google.errorprone:error_prone_annotations:2.43.0" : "90685606,refs=39",
+      "com.google.errorprone:error_prone_check_api:2.43.0" : "90685606,refs=39",
+      "com.google.errorprone:error_prone_core:2.43.0" : "90685606,refs=39",
       "com.google.googlejavaformat:google-java-format:1.27.0" : "90685606,refs=39",
       "com.google.guava:failureaccess:1.0.2" : "90685606,refs=39",
       "com.google.guava:guava:33.4.0-jre" : "90685606,refs=39",