test: fix some slow tests (#15323)

rmuir · web-flow · commit a8888cade78d · 2025-10-10T03:33:07.000-04:00
Especially tests that ran very slow on windows or macos
diff --git a/lucene/analysis/common/src/test/org/apache/lucene/analysis/miscellaneous/TestWordDelimiterGraphFilter.java b/lucene/analysis/common/src/test/org/apache/lucene/analysis/miscellaneous/TestWordDelimiterGraphFilter.java
@@ -1104,9 +1104,10 @@ public void testToDot() throws Exception {
 
   private String randomWDFText() {
     StringBuilder b = new StringBuilder();
-    int length = TestUtil.nextInt(random(), 1, 50);
+    Random random = random();
+    int length = TestUtil.nextInt(random, 1, 20);
     for (int i = 0; i < length; i++) {
-      int surpriseMe = random().nextInt(37);
+      int surpriseMe = random.nextInt(37);
       int lower = -1;
       int upper = -1;
       if (surpriseMe < 10) {
@@ -1130,7 +1131,7 @@ private String randomWDFText() {
       }
 
       if (lower != -1) {
-        b.append((char) TestUtil.nextInt(random(), lower, upper));
+        b.append((char) TestUtil.nextInt(random, lower, upper));
       }
     }
 
@@ -1146,7 +1147,7 @@ public void testInvalidFlag() throws Exception {
   }
 
   public void testRandomPaths() throws Exception {
-    int iters = atLeast(10);
+    int iters = atLeast(1);
     for (int iter = 0; iter < iters; iter++) {
       String text = randomWDFText();
       if (VERBOSE) {
diff --git a/lucene/core/src/java/org/apache/lucene/util/OfflineSorter.java b/lucene/core/src/java/org/apache/lucene/util/OfflineSorter.java
@@ -97,6 +97,11 @@ private BufferSize(long bytes) {
       this.bytes = (int) bytes;
     }
 
+    // internal for testing
+    static BufferSize kilobytes(long kb) {
+      return new BufferSize(kb * 1024);
+    }
+
     /** Creates a {@link BufferSize} in MB. The given values must be &gt; 0 and &lt; 2048. */
     public static BufferSize megabytes(long mb) {
       return new BufferSize(mb * MB);
diff --git a/lucene/core/src/test/org/apache/lucene/codecs/lucene103/blocktree/TestTrie.java b/lucene/core/src/test/org/apache/lucene/codecs/lucene103/blocktree/TestTrie.java
@@ -67,7 +67,7 @@ public void testVeryLongTerms() throws Exception {
   public void testOneByteTerms() throws Exception {
     // heavily test single byte terms to generate various label distribution.
     Supplier<byte[]> supplier = () -> new byte[] {(byte) random().nextInt()};
-    int round = atLeast(50);
+    int round = atLeast(5);
     for (int i = 0; i < round; i++) {
       testTrieLookup(supplier, 10);
     }
diff --git a/lucene/core/src/test/org/apache/lucene/document/TestLatLonPointDistanceFeatureQuery.java b/lucene/core/src/test/org/apache/lucene/document/TestLatLonPointDistanceFeatureQuery.java
@@ -455,7 +455,7 @@ public void testCompareSorting() throws IOException {
     LatLonDocValuesField docValue = new LatLonDocValuesField("foo", 0., 0.);
     doc.add(docValue);
 
-    int numDocs = atLeast(10000);
+    int numDocs = atLeast(2048);
     for (int i = 0; i < numDocs; ++i) {
       double lat = random().nextDouble() * 180 - 90;
       double lon = random().nextDouble() * 360 - 180;
diff --git a/lucene/core/src/test/org/apache/lucene/index/TestIndexSorting.java b/lucene/core/src/test/org/apache/lucene/index/TestIndexSorting.java
@@ -3333,7 +3333,7 @@ public void testMixRandomDocumentsWithBlocks() throws IOException {
       iwc.setIndexSort(indexSort);
       iwc.setParentField(parentField);
       RandomIndexWriter randomIndexWriter = new RandomIndexWriter(random(), dir, iwc);
-      int numDocs = random().nextInt(100, 1000);
+      int numDocs = random().nextInt(100, 300);
       for (int i = 0; i < numDocs; i++) {
         if (rarely()) {
           randomIndexWriter.deleteDocuments(new Term("id", "" + random().nextInt(0, i + 1)));
diff --git a/lucene/core/src/test/org/apache/lucene/index/TestIndexTooManyDocs.java b/lucene/core/src/test/org/apache/lucene/index/TestIndexTooManyDocs.java
@@ -43,7 +43,7 @@ public void testIndexTooManyDocs() throws IOException, InterruptedException {
     IndexWriter writer = new IndexWriter(dir, config);
     try {
       IndexWriter.setMaxDocs(numMaxDoc);
-      int numThreads = 5 + random().nextInt(5);
+      int numThreads = atLeast(2);
       Thread[] threads = new Thread[numThreads];
       CountDownLatch latch = new CountDownLatch(numThreads);
       CountDownLatch indexingDone = new CountDownLatch(numThreads - 2);
diff --git a/lucene/core/src/test/org/apache/lucene/index/TestIndexWriter.java b/lucene/core/src/test/org/apache/lucene/index/TestIndexWriter.java
@@ -1098,8 +1098,8 @@ public void testThreadInterruptDeadlock() throws Exception {
         new ThreadInterruptedException(new InterruptedException()).getCause()
             instanceof InterruptedException);
 
-    // issue 100 interrupts to child thread
-    final int numInterrupts = atLeast(100);
+    // issue 20 interrupts to child thread
+    final int numInterrupts = atLeast(20);
     int i = 0;
     while (i < numInterrupts) {
       // TODO: would be nice to also sometimes interrupt the CMS merge threads too ...
@@ -4388,9 +4388,9 @@ public void testMaxCompletedSequenceNumber() throws IOException, InterruptedExce
         SearcherManager manager = new SearcherManager(writer, new SearcherFactory())) {
       CountDownLatch start = new CountDownLatch(1);
       int numDocs =
-          TEST_NIGHTLY ? TestUtil.nextInt(random(), 100, 600) : TestUtil.nextInt(random(), 10, 60);
+          TEST_NIGHTLY ? TestUtil.nextInt(random(), 100, 600) : TestUtil.nextInt(random(), 10, 30);
       AtomicLong maxCompletedSeqID = new AtomicLong(-1);
-      Thread[] threads = new Thread[2 + random().nextInt(2)];
+      Thread[] threads = new Thread[2];
       for (int i = 0; i < threads.length; i++) {
         int idx = i;
         threads[i] =
diff --git a/lucene/core/src/test/org/apache/lucene/index/TestIndexWriterExceptions2.java b/lucene/core/src/test/org/apache/lucene/index/TestIndexWriterExceptions2.java
@@ -101,7 +101,7 @@ protected TokenStreamComponents createComponents(String fieldName) {
     conf.setMergeScheduler(new SerialMergeScheduler());
     conf.setCodec(codec);
 
-    int numDocs = atLeast(100);
+    int numDocs = atLeast(20);
 
     IndexWriter iw = new IndexWriter(dir, conf);
     try {
diff --git a/lucene/core/src/test/org/apache/lucene/index/TestIndexWriterNRTIsCurrent.java b/lucene/core/src/test/org/apache/lucene/index/TestIndexWriterNRTIsCurrent.java
@@ -43,7 +43,7 @@ public void testIsCurrentWithThreads() throws IOException, InterruptedException
     int numReaderThreads = TEST_NIGHTLY ? TestUtil.nextInt(random(), 2, 5) : 2;
     ReaderThread[] threads = new ReaderThread[numReaderThreads];
     final CountDownLatch latch = new CountDownLatch(1);
-    WriterThread writerThread = new WriterThread(holder, writer, atLeast(500), random(), latch);
+    WriterThread writerThread = new WriterThread(holder, writer, atLeast(200), random(), latch);
     for (int i = 0; i < threads.length; i++) {
       threads[i] = new ReaderThread(holder, latch);
       threads[i].start();
@@ -110,7 +110,7 @@ public void run() {
               latch.countDown();
             }
           }
-          if (random.nextBoolean()) {
+          if (random.nextInt(7) == 0) {
             writer.commit();
             final DirectoryReader newReader = DirectoryReader.openIfChanged(currentReader);
             if (newReader != null) {
diff --git a/lucene/core/src/test/org/apache/lucene/search/TestLRUQueryCache.java b/lucene/core/src/test/org/apache/lucene/search/TestLRUQueryCache.java
@@ -127,7 +127,7 @@ public IndexSearcher newSearcher(IndexReader reader, IndexReader previous)
     final SearcherManager mgr = new SearcherManager(w.w, applyDeletes, false, searcherFactory);
     final AtomicBoolean indexing = new AtomicBoolean(true);
     final AtomicReference<Throwable> error = new AtomicReference<>();
-    final int numDocs = atLeast(1000);
+    final int numDocs = atLeast(257);
     Thread[] threads = new Thread[3];
     threads[0] =
         new Thread() {
diff --git a/lucene/core/src/test/org/apache/lucene/search/TestRescoreTopNQuery.java b/lucene/core/src/test/org/apache/lucene/search/TestRescoreTopNQuery.java
@@ -170,7 +170,7 @@ public void testLateInteractionQuery() throws Exception {
     final String KNN_FIELD = "knn_vector";
     List<float[][]> corpus = new ArrayList<>();
     final int numDocs = atLeast(100);
-    final int numSegments = random().nextInt(2, 5);
+    final int numSegments = atLeast(2);
     final int dim = 8;
     final VectorSimilarityFunction vectorSimilarityFunction =
         VectorSimilarityFunction.values()[
diff --git a/lucene/core/src/test/org/apache/lucene/search/TestWANDScorer.java b/lucene/core/src/test/org/apache/lucene/search/TestWANDScorer.java
@@ -746,7 +746,7 @@ public void testRandom() throws IOException {
     // but will be called during searching
     IndexSearcher searcher = newSearcher(reader, true, true, false);
 
-    for (int iter = 0; iter < 100; ++iter) {
+    for (int iter = 0; iter < 10; ++iter) {
       int start = random().nextInt(10);
       int numClauses = random().nextInt(1 << random().nextInt(5));
       BooleanQuery.Builder builder = new BooleanQuery.Builder();
diff --git a/lucene/core/src/test/org/apache/lucene/util/TestOfflineSorter.java b/lucene/core/src/test/org/apache/lucene/util/TestOfflineSorter.java
@@ -115,7 +115,7 @@ public void testIntermediateMerges() throws Exception {
   }
 
   public void testSmallRandom() throws Exception {
-    // Sort 20 mb worth of data with 1mb buffer.
+    // Sort 10 mb worth of data with 512kb buffer.
     try (Directory dir = newFSDirectory(createTempDir())) {
       ExecutorService exec = randomExecutorServiceOrNull();
       SortInfo sortInfo =
@@ -125,12 +125,12 @@ public void testSmallRandom() throws Exception {
                   dir,
                   "foo",
                   OfflineSorter.DEFAULT_COMPARATOR,
-                  BufferSize.megabytes(1),
+                  BufferSize.kilobytes(512),
                   OfflineSorter.MAX_TEMPFILES,
                   -1,
                   exec,
                   TestUtil.nextInt(random(), 1, 4)),
-              generateRandom((int) OfflineSorter.MB * 20));
+              generateRandom((int) OfflineSorter.MB * 10));
       if (exec != null) {
         exec.shutdownNow();
       }
diff --git a/lucene/core/src/test/org/apache/lucene/util/bkd/TestBKD.java b/lucene/core/src/test/org/apache/lucene/util/bkd/TestBKD.java
@@ -1320,6 +1320,8 @@ public Relation compare(byte[] minPackedValue, byte[] maxPackedValue) {
     dir.close();
   }
 
+  // TODO: can this use less docs?
+  @Nightly
   public void test2DLongOrdsOffline() throws Exception {
     try (Directory dir = newDirectory()) {
       int numDocs = 100000;
diff --git a/lucene/facet/src/test/org/apache/lucene/facet/MultiValuesSourceTestCase.java b/lucene/facet/src/test/org/apache/lucene/facet/MultiValuesSourceTestCase.java
@@ -32,20 +32,20 @@
 import org.apache.lucene.store.Directory;
 import org.apache.lucene.tests.index.RandomIndexWriter;
 import org.apache.lucene.tests.util.LuceneTestCase;
+import org.junit.AfterClass;
+import org.junit.BeforeClass;
 
 public abstract class MultiValuesSourceTestCase extends LuceneTestCase {
-  protected Directory dir;
-  protected IndexReader reader;
-  protected IndexSearcher searcher;
-
-  @Override
-  public void setUp() throws Exception {
-    super.setUp();
+  protected static Directory dir;
+  protected static IndexReader reader;
+  protected static IndexSearcher searcher;
 
+  @BeforeClass
+  public static void beforeClass() throws Exception {
     dir = newDirectory();
     RandomIndexWriter iw = new RandomIndexWriter(random(), dir);
 
-    int numDocs = RandomNumbers.randomIntBetween(random(), 100, 1000);
+    int numDocs = RandomNumbers.randomIntBetween(random(), 100, 300);
     for (int i = 0; i < numDocs; i++) {
       Document doc = new Document();
 
@@ -95,11 +95,13 @@ public void setUp() throws Exception {
     searcher = newSearcher(reader);
   }
 
-  @Override
-  public void tearDown() throws Exception {
+  @AfterClass
+  public static void afterClass() throws Exception {
     reader.close();
     dir.close();
-    super.tearDown();
+    searcher = null;
+    reader = null;
+    dir = null;
   }
 
   protected void validateFieldBasedSource(NumericDocValues docValues, LongValues values, int maxDoc)
diff --git a/lucene/facet/src/test/org/apache/lucene/facet/TestStringValueFacetCounts.java b/lucene/facet/src/test/org/apache/lucene/facet/TestStringValueFacetCounts.java
@@ -345,7 +345,7 @@ public void testStaleState() throws Exception {
 
   public void testRandom() throws Exception {
 
-    int fullIterations = LuceneTestCase.TEST_NIGHTLY ? 20 : 3;
+    int fullIterations = LuceneTestCase.TEST_NIGHTLY ? 20 : 1;
     for (int iter = 0; iter < fullIterations; iter++) {
       Directory dir = newDirectory();
       RandomIndexWriter writer = new RandomIndexWriter(random(), dir);
diff --git a/lucene/facet/src/test/org/apache/lucene/facet/taxonomy/TestSearcherTaxonomyManager.java b/lucene/facet/src/test/org/apache/lucene/facet/taxonomy/TestSearcherTaxonomyManager.java
@@ -241,7 +241,7 @@ public void testDirectory() throws Exception {
     final AtomicBoolean stop = new AtomicBoolean();
 
     // How many unique facets to index before stopping:
-    final int ordLimit = TEST_NIGHTLY ? 100000 : 600;
+    final int ordLimit = TEST_NIGHTLY ? 100000 : 100;
 
     Thread indexer = new IndexerThread(w, config, tw, mgr, ordLimit, stop);
     indexer.start();
diff --git a/lucene/facet/src/test/org/apache/lucene/facet/taxonomy/TestTaxonomyCombined.java b/lucene/facet/src/test/org/apache/lucene/facet/taxonomy/TestTaxonomyCombined.java
@@ -750,7 +750,7 @@ public void testTaxonomyReaderRefreshRaces() throws Exception {
     final ParallelTaxonomyArrays ca2 = trBase.getParallelTaxonomyArrays();
     final int abYoungChildBase2 = ca2.children().get(abOrd);
 
-    int numRetries = atLeast(10);
+    int numRetries = atLeast(3);
     for (int retry = 0; retry < numRetries; retry++) {
       assertConsistentYoungestChild(
           abPath, abOrd, abYoungChildBase1, abYoungChildBase2, retry, numCategories);
diff --git a/lucene/facet/src/test/org/apache/lucene/facet/taxonomy/directory/TestConcurrentFacetedIndexing.java b/lucene/facet/src/test/org/apache/lucene/facet/taxonomy/directory/TestConcurrentFacetedIndexing.java
@@ -93,14 +93,14 @@ static TaxonomyWriterCache newTaxoWriterCache(int ndocs) {
   }
 
   public void testConcurrency() throws Exception {
-    final AtomicInteger numDocs = new AtomicInteger(atLeast(10000));
+    final AtomicInteger numDocs = new AtomicInteger(atLeast(1000));
     final Directory indexDir = newDirectory();
     final Directory taxoDir = newDirectory();
     final ConcurrentHashMap<String, String> values = new ConcurrentHashMap<>();
     final IndexWriter iw = new IndexWriter(indexDir, newIndexWriterConfig(null));
     final DirectoryTaxonomyWriter tw =
         new DirectoryTaxonomyWriter(taxoDir, OpenMode.CREATE, newTaxoWriterCache(numDocs.get()));
-    final Thread[] indexThreads = new Thread[atLeast(4)];
+    final Thread[] indexThreads = new Thread[atLeast(2)];
     final FacetsConfig config = new FacetsConfig();
     for (int i = 0; i < 10; i++) {
       config.setHierarchical("l1." + i, true);
diff --git a/lucene/sandbox/src/test/org/apache/lucene/sandbox/document/TestFloatPointNearestNeighbor.java b/lucene/sandbox/src/test/org/apache/lucene/sandbox/document/TestFloatPointNearestNeighbor.java
@@ -151,8 +151,8 @@ public void testNearestNeighborWithNoDocs() throws Exception {
 
   public void testNearestNeighborRandom() throws Exception {
     Directory dir;
-    int numPoints = atLeast(5000);
-    if (numPoints > 100000) {
+    int numPoints = atLeast(1000);
+    if (numPoints > 20000) {
       dir = newFSDirectory(createTempDir(getClass().getSimpleName()));
     } else {
       dir = newDirectory();
@@ -189,7 +189,7 @@ public void testNearestNeighborRandom() throws Exception {
     // can't wrap because we require Lucene60PointsFormat directly but e.g. ParallelReader wraps
     // with its own points impl:
     IndexSearcher s = newSearcher(r, false);
-    int iters = atLeast(100);
+    int iters = atLeast(10);
     for (int iter = 0; iter < iters; ++iter) {
       if (VERBOSE) {
         System.out.println("\nTEST: iter=" + iter);
diff --git a/lucene/sandbox/src/test/org/apache/lucene/sandbox/facet/TestRangeFacet.java b/lucene/sandbox/src/test/org/apache/lucene/sandbox/facet/TestRangeFacet.java
@@ -897,7 +897,7 @@ public void testRandomLongsMultiValued() throws Exception {
     Directory dir = newDirectory();
     RandomIndexWriter w = new RandomIndexWriter(random(), dir);
 
-    int numDocs = atLeast(1000);
+    int numDocs = atLeast(500);
     if (VERBOSE) {
       System.out.println("TEST: numDocs=" + numDocs);
     }
@@ -926,12 +926,12 @@ public void testRandomLongsMultiValued() throws Exception {
     IndexSearcher s = newSearcher(r, false);
     FacetsConfig config = new FacetsConfig();
 
-    int numIters = atLeast(10);
+    int numIters = atLeast(3);
     for (int iter = 0; iter < numIters; iter++) {
       if (VERBOSE) {
         System.out.println("TEST: iter=" + iter);
       }
-      int numRange = TestUtil.nextInt(random(), 1, 100);
+      int numRange = TestUtil.nextInt(random(), 1, 50);
       LongRange[] ranges = new LongRange[numRange];
       int[] expectedCounts = new int[numRange];
       long minAcceptedValue = Long.MAX_VALUE;
diff --git a/lucene/suggest/src/test/org/apache/lucene/search/spell/TestSpellChecker.java b/lucene/suggest/src/test/org/apache/lucene/search/spell/TestSpellChecker.java
@@ -444,7 +444,7 @@ public void testConcurrentAccess() throws IOException, InterruptedException {
     assertEquals(4, searchers.size());
     int num_field2 = this.numdoc();
     assertEquals(num_field2, num_field1 + 1);
-    int numThreads = 5 + random().nextInt(5);
+    int numThreads = atLeast(2);
     ExecutorService executor =
         Executors.newFixedThreadPool(numThreads, new NamedThreadFactory("testConcurrentAccess"));
     SpellCheckWorker[] workers = new SpellCheckWorker[numThreads];
@@ -453,7 +453,7 @@ public void testConcurrentAccess() throws IOException, InterruptedException {
       executor.execute(spellCheckWorker);
       workers[i] = spellCheckWorker;
     }
-    int iterations = 5 + random().nextInt(5);
+    int iterations = atLeast(3);
     for (int i = 0; i < iterations; i++) {
       Thread.sleep(100);
       // concurrently reset the spell index
diff --git a/lucene/suggest/src/test/org/apache/lucene/search/suggest/TestDocumentDictionary.java b/lucene/suggest/src/test/org/apache/lucene/search/suggest/TestDocumentDictionary.java
@@ -249,7 +249,7 @@ public void testWithDeletions() throws IOException {
     iwc.setMergePolicy(newLogMergePolicy());
     RandomIndexWriter writer = new RandomIndexWriter(random(), dir, iwc);
     Map.Entry<List<String>, Map<String, Document>> res =
-        generateIndexDocuments(atLeast(1000), false);
+        generateIndexDocuments(atLeast(200), false);
     Map<String, Document> docs = res.getValue();
     List<String> invalidDocTerms = res.getKey();
     Random rand = random();
diff --git a/lucene/test-framework/src/java/org/apache/lucene/tests/index/BaseCompoundFormatTestCase.java b/lucene/test-framework/src/java/org/apache/lucene/tests/index/BaseCompoundFormatTestCase.java
@@ -169,6 +169,8 @@ public IndexOutput createOutput(String name, IOContext context) throws IOExcepti
   }
 
   // LUCENE-5724: actually test we play nice with NRTCachingDir and massive file
+  // TODO: very slow with SimpleText
+  @Nightly
   public void testLargeCFS() throws IOException {
     final String testfile = "_123.test";
     IOContext context = IOContext.flush(new FlushInfo(0, 512 * 1024 * 1024));
diff --git a/lucene/test-framework/src/java/org/apache/lucene/tests/index/BaseDocValuesFormatTestCase.java b/lucene/test-framework/src/java/org/apache/lucene/tests/index/BaseDocValuesFormatTestCase.java
diff --git a/lucene/test-framework/src/java/org/apache/lucene/tests/index/BaseFieldInfoFormatTestCase.java b/lucene/test-framework/src/java/org/apache/lucene/tests/index/BaseFieldInfoFormatTestCase.java
diff --git a/lucene/test-framework/src/java/org/apache/lucene/tests/index/BaseIndexFileFormatTestCase.java b/lucene/test-framework/src/java/org/apache/lucene/tests/index/BaseIndexFileFormatTestCase.java
diff --git a/lucene/test-framework/src/java/org/apache/lucene/tests/index/BaseKnnVectorsFormatTestCase.java b/lucene/test-framework/src/java/org/apache/lucene/tests/index/BaseKnnVectorsFormatTestCase.java
diff --git a/lucene/test-framework/src/java/org/apache/lucene/tests/index/BasePostingsFormatTestCase.java b/lucene/test-framework/src/java/org/apache/lucene/tests/index/BasePostingsFormatTestCase.java
diff --git a/lucene/test-framework/src/java/org/apache/lucene/tests/index/LegacyBaseDocValuesFormatTestCase.java b/lucene/test-framework/src/java/org/apache/lucene/tests/index/LegacyBaseDocValuesFormatTestCase.java
diff --git a/lucene/test-framework/src/java/org/apache/lucene/tests/store/BaseDirectoryTestCase.java b/lucene/test-framework/src/java/org/apache/lucene/tests/store/BaseDirectoryTestCase.java
diff --git a/lucene/test-framework/src/test/org/apache/lucene/tests/store/TestSerializedIOCountingDirectory.java b/lucene/test-framework/src/test/org/apache/lucene/tests/store/TestSerializedIOCountingDirectory.java

Original file line number	Diff line number	Diff line change
`@@ -67,7 +67,7 @@ public void testVeryLongTerms() throws Exception {`
`67`	`67`	`public void testOneByteTerms() throws Exception {`
`68`	`68`	`// heavily test single byte terms to generate various label distribution.`
`69`	`69`	`Supplier<byte[]> supplier = () -> new byte[] {(byte) random().nextInt()};`
`70`		`- int round = atLeast(50);`
	`70`	`+ int round = atLeast(5);`
`71`	`71`	`for (int i = 0; i < round; i++) {`
`72`	`72`	`testTrieLookup(supplier, 10);`
`73`	`73`	`}`