Run the tests with assertions disabled ~25% of the time (#15325)

* Fix the code so that testing with -Ptests.asserts=false passes.

* More tests that don't work with assertions disabled.

* Pick tests.asserts randomly based on the main seed. Use assertions 75% of the time.

* Changes entry.

* Clean up duplicate assertion-verifying code.

Author: dweiss

build-tools/build-infra/src/main/java/org/apache/lucene/gradle/plugins/java/TestsAndRandomizationPlugin.java

@@ -223,7 +223,13 @@ public void apply(Project project) {
 
     Provider<Boolean> assertsOption =
         buildOptions.addBooleanOption(
-            "tests.asserts", "Enables or disables assertions mode.", true);
+            "tests.asserts",
+            "Enables or disables assertions mode.",
+            project.provider(
+                () -> {
+                  // Run with assertions for ~75% of all seeds.
+                  return new Random(buildGlobals.getProjectSeedAsLong().get()).nextInt(100) > 25;
+                }));
     optionsInheritedAsProperties.add("tests.asserts");
 
     buildOptions.addBooleanOption(

lucene/CHANGES.txt

@@ -106,6 +106,8 @@ Changes in Runtime Behavior
 
 Build
 ---------------------
+* GITHUB#15325: Run the tests with assertions disabled ~25% of the time #15325 (Dawid Weiss)
+
 * GITHUB#14804: Detect and ban wildcard imports in Java (Robert Muir, Dawid Weiss)
 
 * GITHUB#14808: Add support for validating sources using ast-grep tool rules #14808

lucene/core/src/test/org/apache/lucene/TestAssertions.java

@@ -46,13 +46,13 @@ public boolean incrementToken() {
   public void testTokenStreams() {
     new TestTokenStream1();
     new TestTokenStream2();
-    try {
-      new TestTokenStream3();
-      if (assertsAreEnabled) {
-        fail("TestTokenStream3 should fail assertion");
-      }
-    } catch (AssertionError _) {
-      // expected
+
+    if (TEST_ASSERTS_ENABLED) {
+      expectThrows(
+          AssertionError.class,
+          () -> {
+            new TestTokenStream3();
+          });
     }
   }
 }

lucene/core/src/test/org/apache/lucene/internal/hppc/TestCharHashSet.java

@@ -90,11 +90,13 @@ public void testIndexMethods() {
     MatcherAssert.assertThat(set.indexGet(set.indexOf(keyE)), is(equalTo(keyE)));
     MatcherAssert.assertThat(set.indexGet(set.indexOf(key1)), is(equalTo(key1)));
 
-    expectThrows(
-        AssertionError.class,
-        () -> {
-          set.indexGet(set.indexOf(key2));
-        });
+    if (TEST_ASSERTS_ENABLED) {
+      expectThrows(
+          AssertionError.class,
+          () -> {
+            set.indexGet(set.indexOf(key2));
+          });
+    }
 
     MatcherAssert.assertThat(set.indexReplace(set.indexOf(keyE), keyE), is(equalTo(keyE)));
     MatcherAssert.assertThat(set.indexReplace(set.indexOf(key1), key1), is(equalTo(key1)));

lucene/core/src/test/org/apache/lucene/internal/hppc/TestCharObjectHashMap.java

@@ -177,11 +177,13 @@ public void testIndexMethods() {
     assertEquals(value1, map.indexGet(map.indexOf(keyE)));
     assertEquals(value2, map.indexGet(map.indexOf(key1)));
 
-    expectThrows(
-        AssertionError.class,
-        () -> {
-          map.indexGet(map.indexOf(key2));
-        });
+    if (TEST_ASSERTS_ENABLED) {
+      expectThrows(
+          AssertionError.class,
+          () -> {
+            map.indexGet(map.indexOf(key2));
+          });
+    }
 
     assertEquals(value1, map.indexReplace(map.indexOf(keyE), value3));
     assertEquals(value2, map.indexReplace(map.indexOf(key1), value4));

lucene/core/src/test/org/apache/lucene/internal/hppc/TestIntDoubleHashMap.java

@@ -173,11 +173,13 @@ public void testIndexMethods() {
     assertEquals2(value1, map.indexGet(map.indexOf(keyE)));
     assertEquals2(value2, map.indexGet(map.indexOf(key1)));
 
-    expectThrows(
-        AssertionError.class,
-        () -> {
-          map.indexGet(map.indexOf(key2));
-        });
+    if (TEST_ASSERTS_ENABLED) {
+      expectThrows(
+          AssertionError.class,
+          () -> {
+            map.indexGet(map.indexOf(key2));
+          });
+    }
 
     assertEquals2(value1, map.indexReplace(map.indexOf(keyE), value3));
     assertEquals2(value2, map.indexReplace(map.indexOf(key1), value4));

lucene/core/src/test/org/apache/lucene/internal/hppc/TestIntFloatHashMap.java

@@ -173,11 +173,13 @@ public void testIndexMethods() {
     assertEquals2(value1, map.indexGet(map.indexOf(keyE)));
     assertEquals2(value2, map.indexGet(map.indexOf(key1)));
 
-    expectThrows(
-        AssertionError.class,
-        () -> {
-          map.indexGet(map.indexOf(key2));
-        });
+    if (TEST_ASSERTS_ENABLED) {
+      expectThrows(
+          AssertionError.class,
+          () -> {
+            map.indexGet(map.indexOf(key2));
+          });
+    }
 
     assertEquals2(value1, map.indexReplace(map.indexOf(keyE), value3));
     assertEquals2(value2, map.indexReplace(map.indexOf(key1), value4));

lucene/core/src/test/org/apache/lucene/internal/hppc/TestIntHashSet.java

@@ -90,11 +90,13 @@ public void testIndexMethods() {
     MatcherAssert.assertThat(set.indexGet(set.indexOf(keyE)), is(equalTo(keyE)));
     MatcherAssert.assertThat(set.indexGet(set.indexOf(key1)), is(equalTo(key1)));
 
-    expectThrows(
-        AssertionError.class,
-        () -> {
-          set.indexGet(set.indexOf(key2));
-        });
+    if (TEST_ASSERTS_ENABLED) {
+      expectThrows(
+          AssertionError.class,
+          () -> {
+            set.indexGet(set.indexOf(key2));
+          });
+    }
 
     MatcherAssert.assertThat(set.indexReplace(set.indexOf(keyE), keyE), is(equalTo(keyE)));
     MatcherAssert.assertThat(set.indexReplace(set.indexOf(key1), key1), is(equalTo(key1)));

lucene/core/src/test/org/apache/lucene/internal/hppc/TestIntIntHashMap.java

@@ -152,11 +152,13 @@ public void testIndexMethods() {
     assertEquals(value1, map.indexGet(map.indexOf(keyE)));
     assertEquals(value2, map.indexGet(map.indexOf(key1)));
 
-    expectThrows(
-        AssertionError.class,
-        () -> {
-          map.indexGet(map.indexOf(key2));
-        });
+    if (TEST_ASSERTS_ENABLED) {
+      expectThrows(
+          AssertionError.class,
+          () -> {
+            map.indexGet(map.indexOf(key2));
+          });
+    }
 
     assertEquals(value1, map.indexReplace(map.indexOf(keyE), value3));
     assertEquals(value2, map.indexReplace(map.indexOf(key1), value4));

lucene/core/src/test/org/apache/lucene/internal/hppc/TestIntLongHashMap.java

@@ -184,11 +184,13 @@ public void testIndexMethods() {
     assertEquals(value1, map.indexGet(map.indexOf(keyE)));
     assertEquals(value2, map.indexGet(map.indexOf(key1)));
 
-    expectThrows(
-        AssertionError.class,
-        () -> {
-          map.indexGet(map.indexOf(key2));
-        });
+    if (TEST_ASSERTS_ENABLED) {
+      expectThrows(
+          AssertionError.class,
+          () -> {
+            map.indexGet(map.indexOf(key2));
+          });
+    }
 
     assertEquals(value1, map.indexReplace(map.indexOf(keyE), value3));
     assertEquals(value2, map.indexReplace(map.indexOf(key1), value4));