Early exit while computing globalMin/Max using skipper (#15127)

jainankitk · web-flow · commit bec05a1c2c2d · 2025-08-27T21:43:27.000+05:30
---------

Signed-off-by: Ankit Jain &lt;jain.ankitk@gmail.com&gt;
diff --git a/lucene/core/src/java/org/apache/lucene/index/DocValuesSkipper.java b/lucene/core/src/java/org/apache/lucene/index/DocValuesSkipper.java
@@ -139,7 +139,8 @@ public static long globalMinValue(IndexSearcher searcher, String field) throws I
       }
       DocValuesSkipper skipper = ctx.reader().getDocValuesSkipper(field);
       if (skipper == null) {
-        minValue = Long.MIN_VALUE;
+        // minimum cannot be computed correctly since skipper is not enabled for some leaf
+        return Long.MIN_VALUE;
       } else {
         minValue = Math.min(minValue, skipper.minValue());
       }
@@ -162,7 +163,8 @@ public static long globalMaxValue(IndexSearcher searcher, String field) throws I
       }
       DocValuesSkipper skipper = ctx.reader().getDocValuesSkipper(field);
       if (skipper == null) {
-        maxValue = Long.MAX_VALUE;
+        // maximum cannot be computed correctly since skipper is not enabled for some leaf
+        return Long.MAX_VALUE;
       } else {
         maxValue = Math.max(maxValue, skipper.maxValue());
       }

Original file line number	Diff line number	Diff line change
`@@ -139,7 +139,8 @@ public static long globalMinValue(IndexSearcher searcher, String field) throws I`
`139`	`139`	`}`
`140`	`140`	`DocValuesSkipper skipper = ctx.reader().getDocValuesSkipper(field);`
`141`	`141`	`if (skipper == null) {`
`142`		`- minValue = Long.MIN_VALUE;`
	`142`	`+ // minimum cannot be computed correctly since skipper is not enabled for some leaf`
	`143`	`+ return Long.MIN_VALUE;`
`143`	`144`	`} else {`
`144`	`145`	`minValue = Math.min(minValue, skipper.minValue());`
`145`	`146`	`}`
`@@ -162,7 +163,8 @@ public static long globalMaxValue(IndexSearcher searcher, String field) throws I`
`162`	`163`	`}`
`163`	`164`	`DocValuesSkipper skipper = ctx.reader().getDocValuesSkipper(field);`
`164`	`165`	`if (skipper == null) {`
`165`		`- maxValue = Long.MAX_VALUE;`
	`166`	`+ // maximum cannot be computed correctly since skipper is not enabled for some leaf`
	`167`	`+ return Long.MAX_VALUE;`
`166`	`168`	`} else {`
`167`	`169`	`maxValue = Math.max(maxValue, skipper.maxValue());`
`168`	`170`	`}`