[Tessellator] Fix failure due to hole bridge being coplanar with polygon edge. (#15211)

The fix changes the strategy for removing co-planar points to do it once after all holes are removed 
instead of doing it for each removed hole.

Author: iverase

lucene/CHANGES.txt

@@ -173,6 +173,11 @@ Bug Fixes
 * GITHUB#14161: PointInSetQuery's constructor now throws IllegalArgumentException
   instead of UnsupportedOperationException when values are out of order. (Shubham Sharma)
 
+* GITHUB#15205: Fixes regression introduced in GITHUB#13980 where polygons might fail to tessellate
+  because the hole bridge is coplanar with the polygon vertex. The fix changes the strategy for
+  removing co-planar points to do it once after all holes are removed instead of doing it for each
+  removed hole.
+
 Other
 ---------------------
 (No changes)

lucene/core/src/java/org/apache/lucene/geo/Tessellator.java

@@ -359,8 +359,8 @@ private static Node eliminateHoles(
         throw new IllegalArgumentException("Illegal hole detected: " + polygon);
       }
     }
-    // Return a pointer to the list.
-    return outerNode;
+    // Filter co-planar nodes and return a pointer to the list.
+    return filterPoints(outerNode, null);
   }
 
   /** Finds a bridge between vertices that connects a hole with an outer ring, and links it */
@@ -387,9 +387,7 @@ private static boolean eliminateHole(
           isPointInLine(outerNode, outerNode.next, holeNode)
               || isPointInLine(holeNode, holeNode.next, outerNode);
       // Split the resulting polygon.
-      Node node = splitPolygon(outerNode, holeNode, fromPolygon);
-      // Filter the split nodes.
-      filterPoints(node, node.next);
+      splitPolygon(outerNode, holeNode, fromPolygon);
       return true;
     } else {
       return false;
@@ -431,9 +429,7 @@ private static boolean maybeMergeHoleWithSharedVertices(
     } while (next != outerNode);
     if (sharedVertex != null) {
       // Split the resulting polygon.
-      Node node = splitPolygon(sharedVertexConnection, sharedVertex, true);
-      // Filter the split nodes.
-      filterPoints(node, node.next);
+      splitPolygon(sharedVertexConnection, sharedVertex, true);
       return true;
     }
     return false;

lucene/core/src/test/org/apache/lucene/geo/TestTessellator.java

@@ -374,7 +374,7 @@ public void testComplexPolygon17() throws Exception {
     IllegalArgumentException ex =
         expectThrows(IllegalArgumentException.class, () -> Tessellator.tessellate(polygon, true));
     assertEquals(
-        "Polygon ring self-intersection at lat=40.8278688 lon=14.1990929", ex.getMessage());
+        "Polygon ring self-intersection at lat=40.8277665 lon=14.1993975", ex.getMessage());
   }
 
   public void testComplexPolygon18() throws Exception {
@@ -922,6 +922,12 @@ public void testComplexPolygon60() throws Exception {
     checkPolygon(wkt);
   }
 
+  public void testComplexPolygon61() throws Exception {
+    String geoJson = GeoTestUtil.readShape("github-15205.geojson.gz");
+    Polygon[] polygons = Polygon.fromGeoJSON(geoJson);
+    checkMultiPolygon(polygons, 1e-11);
+  }
+
   private static class TestCountingMonitor implements Tessellator.Monitor {
     private int count = 0;
     private int splitsStarted = 0;