Return MatchNoDocsQuery when IndexOrDocValuesQuery::rewrite does not match (#14700)

In a similar way to how IndexOrDocValuesQuery may rewrite to a MatchAllDocsQuery, if either of the queries rewrites to match no docs, then return a MatchNoDocsQuery.

Author: ChrisHegarty

lucene/CHANGES.txt

@@ -116,6 +116,9 @@ Optimizations
 * GITHUB#14679: Optimize exhaustive evaluation of disjunctive queries.
   (Adrien Grand)
 
+* GITHUB#14700: Return MatchNoDocsQuery when IndexOrDocValuesQuery::rewrite does not match
+  (Chris Hegarty)
+
 Bug Fixes
 ---------------------
 * GITHUB#14654: ValueSource.fromDoubleValuesSource(dvs).getSortField() would throw errors when

lucene/core/src/java/org/apache/lucene/search/IndexOrDocValuesQuery.java

@@ -117,6 +117,10 @@ public Query rewrite(IndexSearcher indexSearcher) throws IOException {
         || dvRewrite.getClass() == MatchAllDocsQuery.class) {
       return new MatchAllDocsQuery();
     }
+    if (indexRewrite.getClass() == MatchNoDocsQuery.class
+        || dvRewrite.getClass() == MatchNoDocsQuery.class) {
+      return new MatchNoDocsQuery();
+    }
     if (indexQuery != indexRewrite || dvQuery != dvRewrite) {
       return new IndexOrDocValuesQuery(indexRewrite, dvRewrite);
     }

lucene/core/src/test/org/apache/lucene/search/TestIndexOrDocValuesQuery.java

@@ -227,4 +227,39 @@ public void testQueryMatchesCount() throws Exception {
     w.close();
     dir.close();
   }
+
+  public void testQueryMatchesAllOrNone() throws Exception {
+    var config = newIndexWriterConfig().setCodec(TestUtil.getDefaultCodec());
+    try (Directory dir = newDirectory();
+        IndexWriter w = new IndexWriter(dir, config)) {
+      final int numDocs = random().nextInt(5000);
+      for (int i = 0; i < numDocs; ++i) {
+        Document doc = new Document();
+        doc.add(new LongPoint("f2", i));
+        doc.add(new SortedNumericDocValuesField("f2", i));
+        w.addDocument(doc);
+      }
+      w.forceMerge(1);
+
+      try (IndexReader reader = DirectoryReader.open(w)) {
+        IndexSearcher searcher = newSearcher(reader);
+
+        // range with all docs
+        IndexOrDocValuesQuery query =
+            new IndexOrDocValuesQuery(
+                LongPoint.newRangeQuery("f2", 0, numDocs),
+                SortedNumericDocValuesField.newSlowRangeQuery("f2", 0, numDocs));
+        QueryUtils.check(random(), query, searcher);
+        assertSame(MatchAllDocsQuery.class, query.rewrite(searcher).getClass());
+
+        // range with no docs
+        query =
+            new IndexOrDocValuesQuery(
+                LongPoint.newRangeQuery("f2", numDocs + 1, numDocs + 200),
+                SortedNumericDocValuesField.newSlowRangeQuery("f2", numDocs + 1, numDocs + 200));
+        QueryUtils.check(random(), query, searcher);
+        assertSame(MatchNoDocsQuery.class, query.rewrite(searcher).getClass());
+      }
+    }
+  }
 }