Skip to content

Commit fbc74a5

Browse files
HUSTERGSgesong.samuel
andauthored
Refactor for loop at PointRangeQuery hot path (#14991)
Co-authored-by: gesong.samuel <[email protected]>
1 parent 86d45d7 commit fbc74a5

File tree

3 files changed

+5
-3
lines changed

3 files changed

+5
-3
lines changed

lucene/CHANGES.txt

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -220,6 +220,8 @@ Optimizations
220220

221221
* GITHUB#14970: Further speed up filtering hits by score. (Adrien Grand)
222222

223+
* GITHUB#14991: Refactor for loop at PointRangeQuery hot path. (Ge Song)
224+
223225
Changes in Runtime Behavior
224226
---------------------
225227
* GITHUB#14823: Decrease TieredMergePolicy's default number of segments per

lucene/core/src/java/org/apache/lucene/search/PointRangeQuery.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -210,7 +210,7 @@ public void visit(DocIdSetIterator iterator) throws IOException {
210210

211211
@Override
212212
public void visit(IntsRef ref) {
213-
for (int i = ref.offset; i < ref.offset + ref.length; i++) {
213+
for (int i = ref.offset, to = ref.offset + ref.length; i < to; i++) {
214214
result.set(ref.ints[i]);
215215
}
216216
cost[0] += ref.length;

lucene/core/src/java/org/apache/lucene/util/DocIdSetBuilder.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -60,8 +60,8 @@ public void add(int doc) {
6060

6161
@Override
6262
public void add(IntsRef docs) {
63-
for (int i = 0; i < docs.length; i++) {
64-
bitSet.set(docs.ints[docs.offset + i]);
63+
for (int i = docs.offset, to = docs.offset + docs.length; i < to; i++) {
64+
bitSet.set(docs.ints[i]);
6565
}
6666
}
6767

0 commit comments

Comments
 (0)