Skip to content

Conversation

@gf2121
Copy link
Contributor

@gf2121 gf2121 commented Oct 25, 2023

closes #12702

Copy link
Member

@mikemccand mikemccand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @gf2121!


* GITHUB#12712: Speed up sorting postings file with an offline radix sorter in BPIndexReader. (Guo Feng)

* GITHUB#12702: Disable suffix sharing for block tree index. (Guo Feng)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe also add something more user friendly, e.g. "making writing the terms dictionary index faster and less RAM hungry, while making the index a bit (~1.X
% for the terms index file on wikipedia) bigger"?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great description! I just copied it :)

@gf2121 gf2121 merged commit c701a5d into apache:main Oct 26, 2023
@gf2121 gf2121 added this to the 9.9.0 milestone Nov 22, 2023
@mikemccand
Copy link
Member

Unfortunately, because I messed up conflict resolution on backport of #12633 (commit 2ca906d), I accidentally reverted this change! This means it did not in fact make it into 9.9 :(

I uncovered this (and will correct it) while backporting #12624 ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Optimize FST suffix sharing for block tree index

2 participants