[MSHARED-796] use java.specification.version instead of java.version

in Build-Jdk manifest entry. This will keep by default the important
information for generated bytecode reproducibility: the major version of
the JDK used. But this will remove the hard to reproduce part that does
not influence generated bytecode: the patch level

Author: hboutemy

src/main/java/org/apache/maven/archiver/MavenArchiver.java

@@ -508,7 +508,7 @@ private void handleSpecificationEntries( MavenProject project, Map<String, Strin
     private void addCustomEntries( Manifest m, Map<String, String> entries, ManifestConfiguration config )
         throws ManifestException
     {
-        addManifestAttribute( m, entries, "Build-Jdk", System.getProperty( "java.version" ) );
+        addManifestAttribute( m, entries, "Build-Jdk", System.getProperty( "java.specification.version" ) );
 
         /*
          * TODO: rethink this, it wasn't working Artifact projectArtifact = project.getArtifact(); if (

src/test/java/org/apache/maven/archiver/MavenArchiverTest.java

@@ -499,7 +499,8 @@ public void testDeprecatedCreateArchiveAPI()
         assertEquals( "0.1.1", manifest.get( Attributes.Name.IMPLEMENTATION_VERSION ) );
         assertEquals( "Apache", manifest.get( Attributes.Name.IMPLEMENTATION_VENDOR ) );
 
-        assertEquals( System.getProperty( "java.version" ), manifest.get( new Attributes.Name( "Build-Jdk" ) ) );
+        assertEquals( System.getProperty( "java.specification.version" ),
+                      manifest.get( new Attributes.Name( "Build-Jdk" ) ) );
     }
 
     @Test
@@ -554,7 +555,8 @@ public void testManifestEntries()
         assertEquals( "olivier", manifest.get( new Attributes.Name( "first-name" ) ) );
         assertEquals( "org.apache.maven.archiver", manifest.getValue( "Automatic-Module-Name" ) );
 
-        assertEquals( System.getProperty( "java.version" ), manifest.get( new Attributes.Name( "Build-Jdk" ) ) );
+        assertEquals( System.getProperty( "java.specification.version" ),
+                      manifest.get( new Attributes.Name( "Build-Jdk" ) ) );
 
         assertTrue( StringUtils.isEmpty( manifest.getValue( new Attributes.Name( "keyWithEmptyValue" ) ) ) );
         assertTrue( manifest.containsKey( new Attributes.Name( "keyWithEmptyValue" ) ) );