chore: migrate junit3/4 to junit 5 #639
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AbstractMojoTestCase based test will be migrate in a seperate PR Signed-off-by: Sandra Parsick <[email protected]>
32 tasks
|
I would like to split such PR - one update in ITs and next with unit tests updates |
|
I will split it tomorrow. |
src/test/java/org/apache/maven/plugins/checkstyle/exec/CheckstyleExecutorTest.java
Outdated
Show resolved
Hide resolved
Comment on lines
137
to
143
| // | ||
| // LegacySupport legacySupport = lookup(LegacySupport.class); | ||
| // legacySupport.setSession(newMavenSession(new MavenProjectStub())); | ||
| DefaultRepositorySystemSession repoSession = | ||
| (DefaultRepositorySystemSession) legacySupport.getRepositorySession(); | ||
| repoSession.setLocalRepositoryManager(new SimpleLocalRepositoryManagerFactory() | ||
| .newInstance(repoSession, new LocalRepository(artifactStubFactory.getWorkingDir()))); |
There was a problem hiding this comment.
Legacy staff is not used by AbstractMavenReport ...
but AbstractMavenReport needs a remote repository to resolve site skin, so it looks like more integration test
There is side effect with such old staff that test is working
I need to discover how to achieve similar effect with new way
There was a problem hiding this comment.
FYI: m-pmd-plugin has similar test code.
sparsick
force-pushed
the
junit3-migration
branch
from
fd2fe7a to
43842d9
Compare
I revert the MojoTest related changes and put in on a separate PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For migration AbstractMojoTestCase to MojoTest see PR