Use the native encoding for reading the file written by a native process (forked compiler).

Avoid too verbatim verifications of locale-sensitive compiler messages.
#327

Author: desruisseaux

src/it/MCOMPILER-346/verify.groovy

@@ -21,5 +21,14 @@ def logFile = new File( basedir, 'build.log' )
 assert logFile.exists()
 content = logFile.text
 
-assert content.contains( 'package org.jenkinsci.test.acceptance.controller does not exist' )
-assert content.contains( 'package org.jenkinsci.test.acceptance.log does not exist' )
+/*
+ * The messages expected by this test were:
+ *
+ *   - package org.jenkinsci.test.acceptance.controller does not exist
+ *   - package org.jenkinsci.test.acceptance.log does not exist
+ *
+ * But we cannot test the full messages as shown above because they may be localized.
+ * Test only the package name on the assumption that they will be present in all locales.
+ */
+assert content.contains( 'org.jenkinsci.test.acceptance.controller' )
+assert content.contains( 'org.jenkinsci.test.acceptance.log' )

src/it/mcompiler-120/verify.groovy

@@ -20,7 +20,12 @@ def logFile = new File( basedir, 'build.log' )
 assert logFile.exists()
 content = logFile.text
 
+/*
+ * The message expected by this test was "unchecked call to add(E) as a member of the raw type List".
+ * But we cannot test that message because it is locale-dependent. Check only a few keywords instead.
+ */
+assert content.contains( 'add(E)' )
+assert content.contains( 'List' ) // May be `List` or `java.util.List`.
 assert content.contains( 'COMPILATION ERROR:' )
 assert content.contains( 'CompilationFailureException' ) // In debug level logs.
 assert !content.contains( 'invalid flag' )
-assert content.contains( 'unchecked call to add(E) as a member of the raw type ' ) // List or java.util.List

src/it/mcompiler-179/verify.groovy

@@ -21,6 +21,14 @@ def logFile = new File( basedir, 'build.log' )
 assert logFile.exists()
 content = logFile.text
 
-assert content.contains( '[WARNING] unchecked call' )
+/*
+ * The message expected by this test was "[WARNING] unchecked call" (the full message
+ * is actually "unchecked call to add(E) as a member of the raw type java.util.List").
+ * But we cannot test that message because it is locale-dependent.
+ * Check only a few keywords instead.
+ */
+assert content.contains( '[WARNING]' )
+assert content.contains( 'add(E)' )
+assert content.contains( 'List' ) // May be `List` or `java.util.List`.
 assert content.contains( 'COMPILATION ERROR:' )
 assert content.contains( 'CompilationFailureException' ) // In debug level logs.

src/main/java/org/apache/maven/plugin/compiler/ForkedTool.java

@@ -164,7 +164,13 @@ final boolean run(
             builder.redirectOutput(dest);
             return start(builder, out) == 0;
         } finally {
-            out.append(Files.readString(output.toPath()));
+            /*
+             * Need to use the native encoding because it is the encoding used by the native process.
+             * This is not necessarily the default encoding of the JVM, which is "file.encoding".
+             * This property is available since Java 17.
+             */
+            String cs = System.getProperty("native.encoding");
+            out.append(Files.readString(output.toPath(), Charset.forName(cs)));
             output.delete();
         }
     }