Skip to content

Commit a830aed

Browse files
slachiewiczTeamModerne
slachiewicz
and
TeamModerne
committed
JUnit Jupiter best practices
Use this link to re-run the recipe: https://app.moderne.io/recipes/org.openrewrite.java.testing.junit.JupiterBestPractices?organizationId=YTA5ODhiOTYtNDI5OS00OGY3LTg0NjctNGZiNmI4OTY1ZjY3 Co-authored-by: Moderne <[email protected]>
1 parent 7ef0f64 commit a830aed

File tree

4 files changed

+26
-26
lines changed

4 files changed

+26
-26
lines changed

‎src/test/java/org/apache/maven/plugins/deploy/DeployFileMojoTest.java‎

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,7 @@
5858
* @author <a href="mailto:[email protected]">Allan Ramirez</a>
5959
*/
6060
@MojoTest
61-
public class DeployFileMojoTest {
61+
class DeployFileMojoTest {
6262
private static final String LOCAL_REPO = "target/local-repo";
6363

6464
@Inject
@@ -75,7 +75,7 @@ public class DeployFileMojoTest {
7575

7676
@Test
7777
@InjectMojo(goal = "deploy-file")
78-
public void testDeployTestEnvironment(DeployFileMojo mojo) {
78+
void deployTestEnvironment(DeployFileMojo mojo) {
7979
assertNotNull(mojo);
8080
}
8181

@@ -93,7 +93,7 @@ public void testDeployTestEnvironment(DeployFileMojo mojo) {
9393
@MojoParameter(name = "description", value = "POM was created from deploy:deploy-file")
9494
@MojoParameter(name = "generatePom", value = "true")
9595
@MojoParameter(name = "skip", value = "snapshots")
96-
public void testBasicDeployFile(DeployFileMojo mojo) throws Exception {
96+
void basicDeployFile(DeployFileMojo mojo) throws Exception {
9797
assertNotNull(mojo);
9898

9999
String groupId = (String) getVariableValueFromObject(mojo, "groupId");
@@ -155,7 +155,7 @@ public void testBasicDeployFile(DeployFileMojo mojo) throws Exception {
155155
@MojoParameter(name = "url", value = "file://${session.topDirectory}/target/remote-repo/deploy-file")
156156
@MojoParameter(name = "classifier", value = "bin")
157157
@MojoParameter(name = "generatePom", value = "true")
158-
public void testDeployIfClassifierIsSet(DeployFileMojo mojo) throws Exception {
158+
void deployIfClassifierIsSet(DeployFileMojo mojo) throws Exception {
159159
assertNotNull(mojo);
160160

161161
String groupId = (String) getVariableValueFromObject(mojo, "groupId");
@@ -196,7 +196,7 @@ public void testDeployIfClassifierIsSet(DeployFileMojo mojo) throws Exception {
196196
@MojoParameter(name = "repositoryId", value = "deploy-test")
197197
@MojoParameter(name = "url", value = "file://${session.topDirectory}/target/remote-repo/deploy-file")
198198
@MojoParameter(name = "generatePom", value = "true")
199-
public void testDeployIfArtifactIsNotJar(DeployFileMojo mojo) throws Exception {
199+
void deployIfArtifactIsNotJar(DeployFileMojo mojo) throws Exception {
200200
assertNotNull(mojo);
201201

202202
String groupId = (String) getVariableValueFromObject(mojo, "groupId");

‎src/test/java/org/apache/maven/plugins/deploy/DeployFileMojoUnitTest.java‎

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -32,12 +32,12 @@
3232
/**
3333
* @author <a href="[email protected]">Jerome Lacoste</a>
3434
*/
35-
public class DeployFileMojoUnitTest {
35+
class DeployFileMojoUnitTest {
3636
MockDeployFileMojo mojo;
3737
Parent parent;
3838

3939
@BeforeEach
40-
public void setUp() {
40+
void setUp() {
4141
parent = Parent.newBuilder()
4242
.groupId("parentGroup")
4343
.artifactId("parentArtifact")
@@ -61,31 +61,31 @@ protected Model readModel(Path pomFile) throws MojoException {
6161
}
6262

6363
@Test
64-
public void testProcessPomFromPomFileWithParent4() {
64+
void processPomFromPomFileWithParent4() {
6565
mojo.setPomFile(Paths.get("foo.bar"));
6666
setMojoModel(mojo, null, "artifact", "version", "packaging", parent);
6767
mojo.initProperties();
6868
checkMojoProperties("parentGroup", "artifact", "version", "packaging");
6969
}
7070

7171
@Test
72-
public void testProcessPomFromPomFileWithParent5() {
72+
void processPomFromPomFileWithParent5() {
7373
mojo.setPomFile(Paths.get("foo.bar"));
7474
setMojoModel(mojo, "group", "artifact", "version", "packaging", parent);
7575
mojo.initProperties();
7676
checkMojoProperties("group", "artifact", "version", "packaging");
7777
}
7878

7979
@Test
80-
public void testProcessPomFromPomFileWithParent6() {
80+
void processPomFromPomFileWithParent6() {
8181
mojo.setPomFile(Paths.get("foo.bar"));
8282
setMojoModel(mojo, "group", "artifact", "version", "packaging", null);
8383
mojo.initProperties();
8484
checkMojoProperties("group", "artifact", "version", "packaging");
8585
}
8686

8787
@Test
88-
public void testProcessPomFromPomFileWithOverrides() {
88+
void processPomFromPomFileWithOverrides() {
8989
mojo.setPomFile(Paths.get("foo.bar"));
9090
setMojoModel(mojo, "group", "artifact", "version", "packaging", null);
9191
mojo.setGroupId("groupO");

‎src/test/java/org/apache/maven/plugins/deploy/DeployMojoPomPackagingTest.java‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,7 @@
5959

6060
@MojoTest
6161
@ExtendWith(MockitoExtension.class)
62-
public class DeployMojoPomPackagingTest {
62+
class DeployMojoPomPackagingTest {
6363

6464
private static final String LOCAL_REPO = "/target/local-repo";
6565

@@ -82,7 +82,7 @@ public class DeployMojoPomPackagingTest {
8282
@Test
8383
@InjectMojo(goal = "deploy")
8484
@MojoParameter(name = "deployAtEnd", value = "false")
85-
public void testBasicDeployWithPackagingAsPom(DeployMojo mojo) throws Exception {
85+
void basicDeployWithPackagingAsPom(DeployMojo mojo) throws Exception {
8686
assertNotNull(mojo);
8787

8888
ArtifactDeployerRequest request = execute(mojo);

‎src/test/java/org/apache/maven/plugins/deploy/DeployMojoTest.java‎

Lines changed: 13 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -70,7 +70,7 @@
7070
*/
7171
@MojoTest
7272
@ExtendWith(MockitoExtension.class)
73-
public class DeployMojoTest {
73+
class DeployMojoTest {
7474

7575
private static final String LOCAL_REPO = "target/local-repo";
7676

@@ -92,14 +92,14 @@ public class DeployMojoTest {
9292

9393
@Test
9494
@InjectMojo(goal = "deploy")
95-
public void testDeployTestEnvironment(DeployMojo mojo) {
95+
void deployTestEnvironment(DeployMojo mojo) {
9696
assertNotNull(mojo);
9797
}
9898

9999
@Test
100100
@InjectMojo(goal = "deploy")
101101
@MojoParameter(name = "deployAtEnd", value = "false")
102-
public void testBasicDeploy(DeployMojo mojo) throws Exception {
102+
void basicDeploy(DeployMojo mojo) throws Exception {
103103
assertNotNull(mojo);
104104
Project project = (Project) getVariableValueFromObject(mojo, "project");
105105
artifactManager.setPath(
@@ -123,7 +123,7 @@ public void testBasicDeploy(DeployMojo mojo) throws Exception {
123123
@Test
124124
@InjectMojo(goal = "deploy")
125125
@MojoParameter(name = "deployAtEnd", value = "false")
126-
public void testSkippingDeploy(DeployMojo mojo) throws Exception {
126+
void skippingDeploy(DeployMojo mojo) throws Exception {
127127
assertNotNull(mojo);
128128

129129
File file = new File(getBasedir(), "target/test-classes/unit/maven-deploy-test-1.0-SNAPSHOT.jar");
@@ -142,7 +142,7 @@ public void testSkippingDeploy(DeployMojo mojo) throws Exception {
142142
@Test
143143
@InjectMojo(goal = "deploy")
144144
@MojoParameter(name = "deployAtEnd", value = "false")
145-
public void testDeployIfArtifactFileIsNull(DeployMojo mojo) throws Exception {
145+
void deployIfArtifactFileIsNull(DeployMojo mojo) throws Exception {
146146
assertNotNull(mojo);
147147

148148
Project project = (Project) getVariableValueFromObject(mojo, "project");
@@ -154,7 +154,7 @@ public void testDeployIfArtifactFileIsNull(DeployMojo mojo) throws Exception {
154154
@Test
155155
@InjectMojo(goal = "deploy")
156156
@MojoParameter(name = "deployAtEnd", value = "false")
157-
public void testDeployWithAttachedArtifacts(DeployMojo mojo) throws Exception {
157+
void deployWithAttachedArtifacts(DeployMojo mojo) throws Exception {
158158
assertNotNull(mojo);
159159
Project project = (Project) getVariableValueFromObject(mojo, "project");
160160
projectManager.attachArtifact(
@@ -182,7 +182,7 @@ public void testDeployWithAttachedArtifacts(DeployMojo mojo) throws Exception {
182182

183183
@Test
184184
@InjectMojo(goal = "deploy")
185-
public void testLegacyAltDeploymentRepositoryWithDefaultLayout(DeployMojo mojo) throws IllegalAccessException {
185+
void legacyAltDeploymentRepositoryWithDefaultLayout(DeployMojo mojo) throws Exception {
186186
setVariableValueToObject(mojo, "altDeploymentRepository", "altDeploymentRepository::default::http://localhost");
187187

188188
RemoteRepository repository = mojo.getDeploymentRepository(true);
@@ -192,7 +192,7 @@ public void testLegacyAltDeploymentRepositoryWithDefaultLayout(DeployMojo mojo)
192192

193193
@Test
194194
@InjectMojo(goal = "deploy")
195-
public void testLegacyAltDeploymentRepositoryWithLegacyLayout(DeployMojo mojo) throws IllegalAccessException {
195+
void legacyAltDeploymentRepositoryWithLegacyLayout(DeployMojo mojo) throws Exception {
196196
setVariableValueToObject(mojo, "altDeploymentRepository", "altDeploymentRepository::legacy::http://localhost");
197197

198198
MojoException e = assertThrows(
@@ -207,7 +207,7 @@ public void testLegacyAltDeploymentRepositoryWithLegacyLayout(DeployMojo mojo) t
207207

208208
@Test
209209
@InjectMojo(goal = "deploy")
210-
public void testInsaneAltDeploymentRepository(DeployMojo mojo) throws IllegalAccessException {
210+
void insaneAltDeploymentRepository(DeployMojo mojo) throws Exception {
211211
setVariableValueToObject(
212212
mojo, "altDeploymentRepository", "altDeploymentRepository::hey::wow::foo::http://localhost");
213213

@@ -223,7 +223,7 @@ public void testInsaneAltDeploymentRepository(DeployMojo mojo) throws IllegalAcc
223223

224224
@Test
225225
@InjectMojo(goal = "deploy")
226-
public void testDefaultScmSvnAltDeploymentRepository(DeployMojo mojo) throws IllegalAccessException {
226+
void defaultScmSvnAltDeploymentRepository(DeployMojo mojo) throws Exception {
227227
setVariableValueToObject(
228228
mojo, "altDeploymentRepository", "altDeploymentRepository::default::scm:svn:http://localhost");
229229

@@ -234,7 +234,7 @@ public void testDefaultScmSvnAltDeploymentRepository(DeployMojo mojo) throws Ill
234234

235235
@Test
236236
@InjectMojo(goal = "deploy")
237-
public void testLegacyScmSvnAltDeploymentRepository(DeployMojo mojo) throws IllegalAccessException {
237+
void legacyScmSvnAltDeploymentRepository(DeployMojo mojo) throws Exception {
238238
setVariableValueToObject(
239239
mojo, "altDeploymentRepository", "altDeploymentRepository::legacy::scm:svn:http://localhost");
240240

@@ -250,7 +250,7 @@ public void testLegacyScmSvnAltDeploymentRepository(DeployMojo mojo) throws Ille
250250

251251
@Test
252252
@InjectMojo(goal = "deploy")
253-
public void testAltSnapshotDeploymentRepository(DeployMojo mojo) throws IllegalAccessException {
253+
void altSnapshotDeploymentRepository(DeployMojo mojo) throws Exception {
254254
setVariableValueToObject(mojo, "altDeploymentRepository", "altReleaseDeploymentRepository::http://localhost");
255255

256256
RemoteRepository repository = mojo.getDeploymentRepository(true);
@@ -260,7 +260,7 @@ public void testAltSnapshotDeploymentRepository(DeployMojo mojo) throws IllegalA
260260

261261
@Test
262262
@InjectMojo(goal = "deploy")
263-
public void testAltReleaseDeploymentRepository(DeployMojo mojo) throws IllegalAccessException {
263+
void altReleaseDeploymentRepository(DeployMojo mojo) throws Exception {
264264
setVariableValueToObject(mojo, "altDeploymentRepository", "altReleaseDeploymentRepository::http://localhost");
265265

266266
RemoteRepository repository = mojo.getDeploymentRepository(false);

0 commit comments

Comments
 (0)