Revert "[MDEPLOY-231] - Move checksum generation from install to depl…

[michael-o]

…oy plugin"

This reverts commit 83b2d51.

Following this checklist to help us incorporate your
contribution quickly and easily:

• Make sure there is a JIRA issue filed
  for the change (usually before you start working on it). Trivial changes like typos do not
  require a JIRA issue. Your pull request should address just this issue, without
  pulling in other changes.
• Each commit in the pull request should have a meaningful subject line and body.
• Format the pull request title like [MPH-XXX] - Fixes bug in ApproximateQuantiles,
  where you replace MPH-XXX with the appropriate JIRA issue. Best practice
  is to use the JIRA issue title in the pull request title and in the first line of the
  commit message.
• Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
• Run mvn clean verify to make sure basic checks pass. A more thorough check will
  be performed on your pull request automatically.
• You have run the integration tests successfully (mvn -Prun-its clean verify).

If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.

To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.

• I hereby declare this contribution to be licenced under the Apache License Version 2.0, January 2004

• In any other case, please file an Apache Individual Contributor License Agreement.

[rfscholte]

I think the description is wrong, because MDEPLOY-231 is still valid to me. It looks like you're only restoring an IT, which is not the same.

[michael-o]

I am confused by your statement. I do not restore the IT, I am removing it. Please explain how you understand the issue is still valid.

[michael-o]

Your understanding is that the commit title should read: "Revert IT of MDEPLOY-231"?

[rfscholte]

I was a bit confused, but it is not a complete revert, just partial.
However, I think it is valid to keep this IT. It in an integration test that ensures the checksums are generated. If Artifact Resolver is being refactored or this plugin switches to a different implementation, it is good to verify the checksums will still be there.

[michael-o]

The problem with this is that it is not portable. It does not know which checksums are generated. It is assumed, but nothing else. This especially depends on the Resolver version used...

[michael-o]

See my comment: https://issues.apache.org/jira/browse/MDEPLOY-231?focusedCommentId=17253097&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-17253097

[rfscholte]

But based on the Maven version we know the default generated checksum right?

[michael-o]

But based on the Maven version we know the default generated checksum right?

Theoretically, yes. You could add this to the configuration somehow.

[slawekjaranowski]

I would to refresh this PR ...

Simply m-deploy-p is not responsible for checksum generation, so should not be tested here ...

[michael-o]

I would to refresh this PR ...

Simply m-deploy-p is not responsible for checksum generation, so should not be tested here ...

This is also my stance. Please go on.

[slawekjaranowski]

Will be done in another PR 😄

[michael-o]

Please delete this branch when your PR is done.

[jira-importer]

Resolve #494