Skip to content

Conversation

@slawekjaranowski
Copy link
Member

  • refresh plugins versions in tests
  • remove createChecksum - parameter from tests - was removed in MINSTALL-143
  • remove unneeded plugins in test
  • remove tests with checksum validation

Following this checklist to help us incorporate your
contribution quickly and easily:

  • Make sure there is a JIRA issue filed
    for the change (usually before you start working on it). Trivial changes like typos do not
    require a JIRA issue. Your pull request should address just this issue, without
    pulling in other changes.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Format the pull request title like [MDEPLOY-XXX] - Fixes bug in ApproximateQuantiles,
    where you replace MDEPLOY-XXX with the appropriate JIRA issue. Best practice
    is to use the JIRA issue title in the pull request title and in the first line of the
    commit message.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Run mvn clean verify to make sure basic checks pass. A more thorough check will
    be performed on your pull request automatically.
  • You have run the integration tests successfully (mvn -Prun-its clean verify).

If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.

To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.

Copy link
Member

@michael-o michael-o left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cleanup => Clean up (this is a verb)
IT tests => ITs (since integration tests tests is non-sense)

@slawekjaranowski slawekjaranowski changed the title [MDEPLOY-304] Cleanup IT tests [MDEPLOY-304] Clean up ITs Jan 22, 2023
- refresh plugins versions in tests
- remove createChecksum - parameter from tests - was removed in MINSTALL-143
- remove unneeded plugins in test
- remove tests with checksum validation
@slawekjaranowski
Copy link
Member Author

Jira issue, PR and commit message updated 😄

Copy link
Member

@michael-o michael-o left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice cleanup!

@slawekjaranowski slawekjaranowski merged commit 54faa43 into master Jan 22, 2023
@slawekjaranowski slawekjaranowski deleted the MDEPLOY-304 branch January 22, 2023 23:50
@jira-importer
Copy link

Resolve #580

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants