Skip to content

Commit 66067af

Browse files
committed
Fixed PR comments
1 parent b4e6c73 commit 66067af

File tree

2 files changed

+6
-6
lines changed

2 files changed

+6
-6
lines changed

doxia-site-renderer/src/main/java/org/apache/maven/doxia/siterenderer/DocumentRenderingContext.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -62,7 +62,7 @@ public class DocumentRenderingContext {
6262
/** The project's build directory, may be {@code null} rendered from a Doxia source) */
6363
private final File rootDirectory;
6464

65-
/** The site's root directory (never null), must be within below {@link #rootDirectory}, may be {@code null} rendered from a Doxia source */
65+
/** The site's root directory, must be below {@link #rootDirectory}, may be {@code null} if not rendered from a Doxia source */
6666
private final File siteRootDirectory;
6767

6868
/** optional descriptive text of the plugin which generated the output (usually Maven coordinates). Only set when document is not based on a Doxia source. */
@@ -315,7 +315,7 @@ public String getParserId() {
315315
}
316316

317317
/**
318-
* Get the relative path of the parent folder to site root.
318+
* Get the relative path of the parent directory of this document to site root.
319319
*
320320
* @return the relative path to site root
321321
*/

doxia-site-renderer/src/main/java/org/apache/maven/doxia/siterenderer/SiteRenderingContext.java

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@
2323
import java.util.Collection;
2424
import java.util.Collections;
2525
import java.util.Date;
26-
import java.util.HashSet;
26+
import java.util.LinkedHashSet;
2727
import java.util.List;
2828
import java.util.Locale;
2929
import java.util.Map;
@@ -46,15 +46,15 @@ public static class SiteDirectory {
4646
private File path;
4747
private boolean editable;
4848
private boolean skipDuplicates;
49-
private final Collection<File> editableSourceDirectories = new HashSet<>();
49+
private final Collection<File> editableSourceDirectories = new LinkedHashSet<>();
5050

5151
public SiteDirectory(File path, boolean editable) {
5252
this(path, editable, false);
5353
}
5454

5555
/**
5656
*
57-
* @param path absolute path to the site directory containing doxia sources files, expected to have a Doxia Site layout, i.e. one directory per Doxia parser module
57+
* @param path path to the site directory containing Doxia sources files, expected to have a Doxia Site layout, i.e. one directory per Doxia parser module
5858
* @param editable {@code true} if the site directory is expected to be editable
5959
* @param skipDuplicates flag indicating if duplicates in this directory should be skipped ({@code true}) or lead to an exception ({@code false})
6060
* @since 2.1
@@ -104,7 +104,7 @@ public Collection<File> getEditableSourceDirectories() {
104104
if (editableSourceDirectories.isEmpty()) {
105105
return Collections.singleton(path);
106106
} else {
107-
return editableSourceDirectories;
107+
return Collections.unmodifiableCollection(editableSourceDirectories);
108108
}
109109
}
110110
}

0 commit comments

Comments
 (0)