Remove JUnit 3 references, drop usage of TestCase

Author: slawekjaranowski

core-it-suite/src/test/java/org/apache/maven/it/MavenITmng2690MojoLoadingErrorsTest.java

@@ -64,7 +64,7 @@ public void testNoClassDefFromMojoLoad() throws IOException, VerificationExcepti
         int msg = indexOf(lines, "(?i).*required class is missing.*");
         assertTrue("User-friendly message was not found in output.", msg >= 0);
 
-        int cls = lines.get(msg).toString().replace('/', '.').indexOf("junit.framework.TestCase");
+        int cls = lines.get(msg).toString().replace('/', '.').indexOf("org.apache.commons.lang3.StringUtils");
         assertTrue("Missing class name was not found in output.", cls >= 0);
     }
 
@@ -89,7 +89,7 @@ public void testNoClassDefFromMojoConfiguration() throws IOException, Verificati
         int msg = indexOf(lines, "(?i).*required class (i|wa)s missing( during (mojo )?configuration)?.*");
         assertTrue("User-friendly message was not found in output.", msg >= 0);
 
-        int cls = lines.get(msg).toString().replace('/', '.').indexOf("junit.framework.TestCase");
+        int cls = lines.get(msg).toString().replace('/', '.').indexOf("org.apache.commons.lang3.StringUtils");
         assertTrue("Missing class name was not found in output.", cls >= 0);
     }
 

core-it-suite/src/test/java/org/apache/maven/it/MavenITmng5640LifecycleParticipantAfterSessionEnd.java

@@ -63,7 +63,7 @@ public void testBuildFailureUTFail() throws Exception {
         } catch (VerificationException e) {
             // expected, as the build will fail due to always failing UT
         }
-        verifier.verifyTextInLog("testApp(org.apache.maven.its.mng5640.FailingTest)");
+        verifier.verifyTextInLog("org.apache.maven.its.mng5640.FailingTest.testApp()");
 
         verifier.verifyFilePresent("target/afterProjectsRead.txt");
         // See https://issues.apache.org/jira/browse/MNG-5641

core-it-suite/src/test/resources/it0030/child-hierarchy/pom.xml

@@ -13,11 +13,4 @@
     <module>project1</module>
     <module>project2</module>
   </modules>
-  <dependencies>
-    <dependency>
-      <groupId>junit</groupId>
-      <artifactId>junit</artifactId>
-      <scope>test</scope>
-    </dependency>
-  </dependencies>
 </project>

core-it-suite/src/test/resources/it0030/pom.xml

@@ -13,11 +13,6 @@
   </modules>
   <dependencyManagement>
     <dependencies>
-      <dependency>
-        <groupId>junit</groupId>
-        <artifactId>junit</artifactId>
-        <version>3.8.1</version>
-      </dependency>
       <dependency>
         <groupId>org.apache.maven.its.it0030</groupId>
         <artifactId>project1</artifactId>

core-it-suite/src/test/resources/mng-0666/repo/org/apache/maven/its/it0059/test/3.8.1/test-3.8.1.jar.md5

@@ -1,5 +1,5 @@
 <project>
-  <groupId>junit</groupId>
-  <artifactId>junit</artifactId>
+  <groupId>test</groupId>
+  <artifactId>test</artifactId>
   <version>3.8.1</version>
 </project>

core-it-suite/src/test/resources/mng-0666/repo/org/apache/maven/its/it0059/test/3.8.1/test-3.8.1.jar.sha1

@@ -18,34 +18,12 @@
  */
 package com.stchome.mavenTest.it0096;
 
-import junit.framework.Test;
-import junit.framework.TestCase;
-import junit.framework.TestSuite;
-
 /**
  * Unit test for simple App.
  */
-public class AppTest extends TestCase {
-    /**
-     * Create the test case
-     *
-     * @param testName name of the test case
-     */
-    public AppTest(String testName) {
-        super(testName);
-    }
-
-    /**
-     * @return the suite of tests being tested
-     */
-    public static Test suite() {
-        return new TestSuite(AppTest.class);
-    }
-
+public class AppTest {
     /**
      * Rigourous Test :-)
      */
-    public void testApp() {
-        assertTrue(true);
-    }
+    public void testApp() {}
 }