[#620] Add support for optional attach parameter to disable artifact attachment #621
Conversation
peter277
force-pushed
the
add-attach-option
branch
from
99500d0 to
26dfd96
Compare
… attaching output artifacts when attach parameter set to false
I have added a new integration test |
|
Hi Team - just checking in to see if there’s anything I can do to help move this PR forward? Happy to make adjustments if needed. |
|
Thanks @bmarwell for the review - I have incorporated your suggested changes into the branch. |
|
|
||
| try { | ||
| File target = new File( basedir, "target" ) | ||
| if ( !target.exists() || !target.isDirectory() ) { |
There was a problem hiding this comment.
we can simply use a groovy assert
https://groovy-lang.org/semantics.html#_power_assertion
but it is not a blocker for it
|
Hi Team - just checking in to see if there’s anything else needed before this PR can be merged? Do I need to sign an individual contributor license agreement, given that the change only adds a flag? Was hoping there might be a release in the near future including this change so that I could start using it. |
3 participants
Add support for optional attach parameter to disable artifact attachment
fixes #620
Checklist
for the change (usually before you start working on it). Trivial changes like typos do not
require a GitHub issue. Your pull request should address just this issue, without
pulling in other changes.
[#<num>] - Fixes bug in ApproximateQuantiles,where you replace
#<num>with the appropriate GitHub issue. Best practiceis to use the GitHub issue title in the pull request title and in the first line of the
commit message.
mvn clean verifyto make sure basic checks pass. A more thorough check willbe performed on your pull request automatically.
mvn -Prun-its clean verify).If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.
I hereby declare this contribution to be licenced under the Apache License Version 2.0, January 2004
In any other case, please file an Apache Individual Contributor License Agreement.