Adding mvnd for linux on docker on a mac.#1285
Adding mvnd for linux on docker on a mac.#1285flyhard wants to merge 14 commits intoapache:masterfrom
Conversation
|
This needs more, look at other workflow files, like release... |
|
Should the new flow only work for v2 of mvnd? or even for 1.0? |
|
I am unsure about the changes in the homebrew-mvnd repo. I have locally tried to adapt, but I am unsure about the perl expressions needed. Can you help with those? |
|
Just keep on master (2.x) for now. |
|
Please have a look at it again to see if it works correctly now. I have this as accompanying PR: mvndaemon/homebrew-mvnd#17 |
… arm64 architecture
Co-authored-by: Guillaume Nodet <gnodet@gmail.com>
|
I have tried to incorporate your changes. Does it look ok to you now? |
build/publish-on-homebrew.sh
Outdated
| @@ -34,6 +34,8 @@ darwinArmZipUrl="https://downloads.apache.org/maven/mvnd/${VERSION}/maven-mvnd-$ | |||
| darwinArmSha256="$(curl -L --silent "${darwinArmZipUrl}.sha256")" | |||
| linuxZipUrl="https://downloads.apache.org/maven/mvnd/${VERSION}/maven-mvnd-${VERSION}-linux-amd64.zip" | |||
There was a problem hiding this comment.
maybe add the Amd prefix to keep things aligned ? similar to what we have for darwin
There was a problem hiding this comment.
I have fixed that. Please review again :-)
… SHA256 checksums
|
Is there something I need to do before this can be merged? |
|
@flyhard could you please rebase your PR against latest master? |
done |
|
|
|
Seems something is still needed here... there is a name conflict? |
|
@flyhard seems uploading of daemon logs are now conflicting... |
|
Really difficult for me to debug this since I cannot run the pipeline when I think I have fixed something |
…S does not contain the version and thus generats conflicts
|
Our env.OS variable strips the version which makes the builds generate conflicting names. I pushed a fix for that. I hope the release pipeline does not have the same issue - in line 119 it looks like we could have an issue. |
|
Can you post link to line 119? As for me that maps to irrelevant line (am looking at early-access.yml you modified). |
|
Sure: https://github.com/flyhard/maven-mvnd/blob/792635bb7e2efe6ca94d21d12d22cbb794356d61/.github/workflows/release.yaml#L119 |
…14. Also changed the name for the artifacts to upload to have the macos version so they don't collide
3 participants
I am trying to use mvnd in a devcontainer on a mac. There is no binary available to install. It is also missing from SDKMAN!