-
Notifications
You must be signed in to change notification settings - Fork 26
Open
Labels
enhancementNew feature or requestNew feature or request
Description
Proposal: Add rewrite
support for errorprone.refasterrules
I’d like to propose integrating Google’s Error Prone and its Picnic extension (demonstrated in Automating Away Bugs with Error Prone | PlatformCon 2023) to enable automated bug fixes via rewrite
rules. This would complement Checkstyle’s static analysis capabilities by addressing semantic bugs rather than stylistic issues.
Motivation
Error Prone’s refaster
/rewrite
rules can automatically:
- Fix common bug patterns (e.g.,
String.equals()
misuse) - Modernize code (e.g., JDK migration helpers)
- Enforce best practices (e.g., null-check improvements)
Real-world adoptions show tangible benefits:
- Fix #5953: [java] PoC: Add
rewrite
support forerrorprone.refasterrules
pmd/pmd#5956 - Issue #17487: Add
rewrite
support forerrorprone.refasterrules
checkstyle/checkstyle#17490 - PoC: Add
rewrite
support forerrorprone.refasterrules
kafka#20219 - PoC: Add
rewrite
support forerrorprone.refasterrules
diffplug/spotless#2576
Proposal
- Add support for
errorprone.refasterrules
-based rewrites - Implement with opt-in adoption (no breaking changes)
- Include suppression mechanisms for API constraints
Discussion Points
- Need consensus on:
- Scope of auto-fixes
- Preferred suppression strategy
- Integration approach
Next Steps
I’m happy to:
- Prepare a PoC demonstrating the value
- Collaborate on implementation strategy
- Address any concerns about compatibility
relates to:
Metadata
Metadata
Assignees
Labels
enhancementNew feature or requestNew feature or request