[MRESOURCES-310] When <filtering>true</filtering> new line is added at the end of file

[jira-importer]

michael elbaz opened MRESOURCES-310 and commented

When using <filtering>true</filtering> a new line is added at the end of the +generated+ file which it can cause bug

---

No further details from MRESOURCES-310

[jira-importer]

Michael Osipov commented

Can you give one example where it causes a bug?

[jira-importer]

michael elbaz commented

Michael Osipov for sure

<plugin>
    <groupId>org.apache.maven.plugins</groupId>
    <artifactId>maven-resources-plugin</artifactId>
    <version>3.3.1</version>
    <executions>
        <execution>
            <id>copy-resources</id>
            <phase>validate</phase>
            <goals>
                <goal>copy-resources</goal>
            </goals>
            <configuration>
                <outputDirectory>${basedir}/target/features</outputDirectory>
                <resources>
                    <resource>
                        <directory>src/main/features</directory>
                        <filtering>true</filtering>
                    </resource>
                </resources>
            </configuration>
        </execution>
    </executions>
</plugin>

<resources>
    <resource>
        <directory>src/main/resources</directory>
        <filtering>true</filtering>
    </resource>
</resources> 

So i have a simple file containing

${java.version} 

And the generated file in directory features look like this (an unwanted \n at end)

21.0.3

[jira-importer]

Michael Osipov commented

And the reader expects no line terminator, right?

[jira-importer]

michael elbaz commented

right Michael Osipov 

[jira-importer]

Michael Osipov commented

I am quite certain that the interpolator is line oriented and uses println() at the end and does not add the entire file into memory, but one needs to verify this in the source.

[jira-importer]

Michael Osipov commented

Weird: https://github.com/apache/maven-filtering/blob/b577a43086ed607adcb0417196bfa6fc382622a0/src/main/java/org/apache/maven/shared/filtering/FilteringUtils.java#L299-L324

[jira-importer]

michael elbaz commented

Yes weird we need to run this code in debug mode to see what really happen (Don't know how)

[jira-importer]

michael elbaz commented

Michael Osipov Hello the code your'e showed here is not the same as the 3.3.1 which is the current latest public avalable version (https://mvnrepository.com/artifact/org.apache.maven.plugins/maven-resources-plugin)

https://github.com/apache/maven-filtering/blob/maven-filtering-3.3.1/src/main/java/org/apache/maven/shared/filtering/FilteringUtils.java#L314

By the way it's easy to reproduce i think just by running mvn as i do thanks for the help

[jira-importer]

michael elbaz commented

any news ?

[jira-importer]

Michael Osipov commented

Same old, same old

[jira-importer]

michael elbaz commented

:) ok so no fix ?

[jira-importer]

Slawomir Jaranowski commented

PR with fix is always welcome.