Improve method

Author: gnodet

apache-maven/src/assembly/maven/bin/mvn

@@ -167,53 +167,34 @@ find_file_argument_basedir() {
 
 # concatenates all lines of a file and replaces variables
 concat_lines() {
-  if [ -f "$1" ]; then
-    # Use a temporary file to avoid subshell issues with variable substitution
-    # First, clean the file: convert CR to LF, remove empty lines and comments
-    _temp_file=$(mktemp)
-    tr '\r' '\n' < "$1" | sed -e '/^$/d' -e 's/#.*$//' > "$_temp_file"
-
-    # Read each line and perform variable substitution, then concatenate with spaces
-    _result=""
-    while IFS= read -r line || [ -n "$line" ]; do
-      if [ -n "$line" ]; then
-        # Replace variables
-        line=$(echo "$line" | sed \
-          -e "s@\${MAVEN_PROJECTBASEDIR}@$MAVEN_PROJECTBASEDIR@g" \
-          -e "s@\$MAVEN_PROJECTBASEDIR@$MAVEN_PROJECTBASEDIR@g")
-        # Escape pipe symbols that are not within quotes to prevent shell interpretation
-        processed_line=$(printf '%s' "$line" | awk '
-        {
-          result = ""
-          in_quotes = 0
-          for (i = 1; i <= length($0); i++) {
-            char = substr($0, i, 1)
-            if (char == "\"") {
-              in_quotes = !in_quotes
-              result = result char
-            } else if (char == "|" && !in_quotes) {
-              result = result "\\|"
-            } else {
-              result = result char
-            }
-          }
-          print result
-        }')
-
-        if [ -z "$_result" ]; then
-          _result="$processed_line"
-        else
-          _result="$_result $processed_line"
-        fi
-      fi
-    done < "$_temp_file"
-
-    # Clean up temporary file
-    rm -f "$_temp_file"
-
-    # Output the result
-    echo "$_result"
-  fi
+  [ -f "$1" ] || return
+  
+  tr '\r' '\n' < "$1" | sed -e '/^$/d' -e 's/#.*$//' | awk \
+    -v maven_dir="${MAVEN_PROJECTBASEDIR//\\/\\\\}" '
+    {
+      # Replace variables
+      gsub(/\$\{MAVEN_PROJECTBASEDIR\}/, maven_dir)
+      gsub(/\$MAVEN_PROJECTBASEDIR/, maven_dir)
+      
+      # Escape unquoted pipe symbols
+      result = ""
+      in_quotes = 0
+      for (i = 1; i <= length($0); i++) {
+        char = substr($0, i, 1)
+        if (char == "\"") {
+          in_quotes = !in_quotes
+        } else if (char == "|" && !in_quotes) {
+          char = "\\|"
+        }
+        result = result char
+      }
+      
+      # Accumulate lines with space separator
+      if (NR > 1) printf " "
+      printf "%s", result
+    }
+    END { print "" }
+  '
 }
 
 MAVEN_PROJECTBASEDIR="`find_maven_basedir "$@"`"