[S1161] rule: category/java/bestpractices.xml/MissingOverride

Author: Vincent Potucek

.gitignore

@@ -16,4 +16,5 @@
 .factorypath
 .vscode/
 repo/
-/*.svg
+/*.svg
+.pmd/.cache

.pmd/ruleset.xml

@@ -0,0 +1,26 @@
+<?xml version="1.0"?>
+<!--
+Licensed to the Apache Software Foundation (ASF) under one
+or more contributor license agreements.  See the NOTICE file
+distributed with this work for additional information
+regarding copyright ownership.  The ASF licenses this file
+to you under the Apache License, Version 2.0 (the
+"License"); you may not use this file except in compliance
+with the License.  You may obtain a copy of the License at
+
+  http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing,
+software distributed under the License is distributed on an
+"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+KIND, either express or implied.  See the License for the
+specific language governing permissions and limitations
+under the License.
+-->
+<ruleset name="DOD"
+         xmlns="http://pmd.sourceforge.net/ruleset/2.0.0"
+         xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+         xsi:schemaLocation="http://pmd.sourceforge.net/ruleset/2.0.0 https://pmd.sourceforge.io/ruleset_2_0_0.xsd">
+    <exclude-pattern>.*/compat/maven-compat/.*</exclude-pattern>
+    <rule ref="category/java/bestpractices.xml/MissingOverride" />
+</ruleset>

compat/maven-embedder/src/main/java/org/apache/maven/cli/ExtensionConfigurationModule.java

@@ -68,6 +68,7 @@ static class ExtensionInterpolator extends MavenTransformer {
             super(transformer);
         }
 
+        @Override
         public XmlNode transform(XmlNode node) {
             return super.transform(node);
         }

compat/maven-embedder/src/main/java/org/eclipse/sisu/plexus/PlexusXmlBeanConverter.java

@@ -80,6 +80,7 @@ public final class PlexusXmlBeanConverter implements PlexusBeanConverter {
     // Public methods
     // ----------------------------------------------------------------------
 
+    @Override
     @SuppressWarnings({"unchecked", "rawtypes"})
     public Object convert(final TypeLiteral role, final String value) {
         if (value.trim().startsWith("<")) {

impl/maven-cli/src/main/java/org/apache/maven/cling/extensions/ExtensionConfigurationModule.java

@@ -68,6 +68,7 @@ static class ExtensionInterpolator extends MavenTransformer {
             super(transformer);
         }
 
+        @Override
         public XmlNode transform(XmlNode node) {
             return super.transform(node);
         }

impl/maven-core/src/main/java/org/apache/maven/configuration/internal/EnhancedConfigurationConverter.java

@@ -33,6 +33,7 @@
  * interface.
  */
 class EnhancedConfigurationConverter extends ObjectWithFieldsConverter {
+    @Override
     protected Object fromExpression(
             final PlexusConfiguration configuration, final ExpressionEvaluator evaluator, final Class<?> type)
             throws ComponentConfigurationException {

impl/maven-core/src/main/java/org/apache/maven/session/scope/internal/SessionScope.java

@@ -46,6 +46,7 @@ public static <T> Provider<T> seededKeyProvider(Class<? extends T> clazz) {
         return SessionScope.<T>seededKeySupplier(clazz)::get;
     }
 
+    @Override
     protected boolean isTypeAnnotation(Class<? extends Annotation> annotationType) {
         return "org.apache.maven.api.di.Typed".equals(annotationType.getName())
                 || "org.eclipse.sisu.Typed".equals(annotationType.getName())

impl/maven-core/src/test/java/org/apache/maven/lifecycle/LifecycleExecutorSubModulesTest.java

@@ -60,6 +60,7 @@ class LifecycleExecutorSubModulesTest extends AbstractCoreMavenComponentTestCase
     @Inject
     private ExceptionHandler exceptionHandler;
 
+    @Override
     protected String getProjectsDirectory() {
         return "src/test/projects/lifecycle-executor";
     }

impl/maven-core/src/test/java/org/apache/maven/lifecycle/LifecycleExecutorTest.java

@@ -69,6 +69,7 @@ class LifecycleExecutorTest extends AbstractCoreMavenComponentTestCase {
     @Inject
     private MojoDescriptorCreator mojoDescriptorCreator;
 
+    @Override
     protected String getProjectsDirectory() {
         return "src/test/projects/lifecycle-executor";
     }

impl/maven-core/src/test/java/org/apache/maven/lifecycle/internal/stub/CompletionServiceStub.java

@@ -44,6 +44,7 @@ public CompletionServiceStub(boolean finishImmediately) {
         this.finishImmediately = finishImmediately;
     }
 
+    @Override
     public Future<ProjectSegment> submit(Callable<ProjectSegment> task) {
         FutureTask<ProjectSegment> projectBuildFutureTask = new FutureTask<>(task);
         projectBuildFutureTasks.add(projectBuildFutureTask);