[MNG-8717] Remove maven-plugin-plugin:addPluginArtifactMetadata from default binding

Author: slawekjaranowski

impl/maven-core/src/main/java/org/apache/maven/lifecycle/providers/packaging/MavenPluginLifecycleMappingProvider.java

@@ -38,10 +38,7 @@ public final class MavenPluginLifecycleMappingProvider extends AbstractLifecycle
                 "org.apache.maven.plugins:maven-resources-plugin:" + RESOURCES_PLUGIN_VERSION + ":testResources",
         "test-compile", "org.apache.maven.plugins:maven-compiler-plugin:" + COMPILER_PLUGIN_VERSION + ":testCompile",
         "test", "org.apache.maven.plugins:maven-surefire-plugin:" + SUREFIRE_PLUGIN_VERSION + ":test",
-        "package",
-                "org.apache.maven.plugins:maven-jar-plugin:" + JAR_PLUGIN_VERSION + ":jar,"
-                        + "org.apache.maven.plugins:maven-plugin-plugin:" + PLUGIN_PLUGIN_VERSION
-                        + ":addPluginArtifactMetadata",
+        "package", "org.apache.maven.plugins:maven-jar-plugin:" + JAR_PLUGIN_VERSION + ":jar,",
         "install", "org.apache.maven.plugins:maven-install-plugin:" + INSTALL_PLUGIN_VERSION + ":install",
         "deploy", "org.apache.maven.plugins:maven-deploy-plugin:" + DEPLOY_PLUGIN_VERSION + ":deploy"
     };

impl/maven-core/src/test/java/org/apache/maven/lifecycle/LifecycleExecutorTest.java

@@ -217,8 +217,7 @@ public void testCalculationOfBuildPlanWithMultipleExecutionsOfModello() throws E
         // [12] compiler:testCompile
         // [13] surefire:test
         // [14] jar:jar
-        // [15] plugin:addPluginArtifactMetadata
-        // [16] install:install
+        // [15] install:install
         //
 
         assertListEquals(
@@ -237,7 +236,6 @@ public void testCalculationOfBuildPlanWithMultipleExecutionsOfModello() throws E
                         "compiler:testCompile",
                         "surefire:test",
                         "jar:jar",
-                        "plugin:addPluginArtifactMetadata",
                         "install:install"),
                 executions.stream()
                         .map(execution -> execution.getMojoDescriptor().getFullGoalName())

its/core-it-suite/src/test/java/org/apache/maven/it/MavenIT0138PluginLifecycleTest.java

@@ -54,11 +54,7 @@ public void testit0138() throws Exception {
         verifier.verifyFilePresent("target/compiler-test-compile.txt");
         verifier.verifyFilePresent("target/surefire-test.txt");
         verifier.verifyFilePresent("target/jar-jar.txt");
-        verifier.verifyFilePresent("target/plugin-add-plugin-artifact-metadata.txt");
         verifier.verifyFilePresent("target/install-install.txt");
-        if (matchesVersionRange("(,2.2.0)")) {
-            verifier.verifyFilePresent("target/plugin-update-registry.txt");
-        }
         verifier.verifyFilePresent("target/deploy-deploy.txt");
         verifier.verifyErrorFreeLog();
     }