More corrections in documentation.

Author: desruisseaux

api/maven-api-core/src/main/java/org/apache/maven/api/SourceRoot.java

@@ -55,6 +55,8 @@ default Path directory() {
      * <p>
      * The default implementation returns an empty list, which means to apply a language-dependent pattern.
      * For example, for the Java language, the pattern includes all files with the {@code .java} suffix.
+     *
+     * @see java.nio.file.FileSystem#getPathMatcher(String)
      */
     default List<String> includes() {
         return List.of();

impl/maven-impl/src/main/java/org/apache/maven/impl/DefaultSourceRoot.java

@@ -153,8 +153,8 @@ public DefaultSourceRoot(final ProjectScope scope, final Language language, fina
      * @param scope scope of source code (main or test)
      * @param language language of the source code
      * @param directory directory of the source code
-     * @param includes list of patterns for the files to include, or {@code null} if unspecified
-     * @param excludes list of patterns for the files to exclude, or {@code null} if nothing to exclude
+     * @param includes patterns for the files to include, or {@code null} or empty if unspecified
+     * @param excludes patterns for the files to exclude, or {@code null} or empty if nothing to exclude
      */
     public DefaultSourceRoot(
             final ProjectScope scope,
@@ -196,7 +196,7 @@ public Path directory() {
     }
 
     /**
-     * {@return the list of patterns for the files to include}.
+     * {@return the patterns for the files to include}.
      */
     @Override
     @SuppressWarnings("ReturnOfCollectionOrArrayField") // Safe because unmodifiable
@@ -205,7 +205,7 @@ public List<String> includes() {
     }
 
     /**
-     * {@return the list of patterns for the files to exclude}.
+     * {@return the patterns for the files to exclude}.
      */
     @Override
     @SuppressWarnings("ReturnOfCollectionOrArrayField") // Safe because unmodifiable

impl/maven-impl/src/main/java/org/apache/maven/impl/PathSelector.java

@@ -30,9 +30,9 @@
 import java.util.Set;
 
 /**
- * Determines whether a path is selected according include/exclude patterns.
+ * Determines whether a path is selected according to include/exclude patterns.
  * The pathnames used for method parameters will be relative to some base directory
- * and use {@code '/'} as separator, regardless the hosting operating system.
+ * and use {@code '/'} as separator, regardless of the hosting operating system.
  *
  * <h4>Syntax</h4>
  * If a pattern contains the {@code ':'} character and the prefix before is longer than 1 character,
@@ -51,10 +51,12 @@
  * </ul>
  *
  * If above changes are not desired, put an explicit {@code "glob:"} prefix before the patterns.
- * Note that putting such prefix is recommended anyway for better performances.
+ * Note that putting such a prefix is recommended anyway for better performances.
  *
  * @author Benjamin Bentmann
  * @author Martin Desruisseaux
+ *
+ * @see java.nio.file.FileSystem#getPathMatcher(String)
  */
 public class PathSelector implements PathMatcher {
     /**
@@ -224,7 +226,7 @@ private static Collection<String> addDefaultExcludes(Collection<String> excludes
 
     /**
      * Whether the given pattern does not specify a syntax, in which case Maven syntax should be used.
-     * If the prefix has a length of 1, then it is assumed to be a Window drive letter rather than a syntax.
+     * If the prefix has a length of 1, then it is assumed to be a Windows drive letter rather than a syntax.
      *
      * @param pattern the pattern to test
      * @return whether the patter does not specify a syntax
@@ -387,7 +389,7 @@ private static PathMatcher[] matchers(final FileSystem fs, final String[] patter
      */
     @SuppressWarnings("checkstyle:MissingSwitchDefault")
     public Optional<PathMatcher> simplify() {
-        if ((excludes.length | dirIncludes.length | dirExcludes.length) == 0) {
+        if (excludes.length == 0 && dirIncludes.length == 0 && dirExcludes.length == 0) {
             switch (includes.length) {
                 case 0:
                     return Optional.empty();
@@ -413,7 +415,7 @@ public boolean matches(Path path) {
     }
 
     /**
-     * {@return whether the given file matches according one of the given matchers}.
+     * {@return whether the given file matches according to one of the given matchers}.
      */
     private static boolean isMatched(Path path, PathMatcher[] matchers) {
         for (PathMatcher matcher : matchers) {
@@ -444,7 +446,7 @@ public boolean couldHoldSelected(Path directory) {
      * Appends the elements of the given array in the given buffer.
      * This is a helper method for {@link #toString()} implementations.
      *
-     * @param buffer the buffer where to add the elements
+     * @param buffer the buffer to add the elements to
      * @param label label identifying the array of elements to add
      * @param patterns the elements to append, or {@code null} if none
      */
@@ -463,7 +465,6 @@ private static void append(StringBuilder buffer, String label, String[] patterns
 
     /**
      * {@return a string representation for logging purposes}.
-     * This string representation is reported logged when {@link Cleaner} is executed.
      */
     @Override
     public String toString() {

impl/maven-impl/src/test/java/org/apache/maven/impl/PathSelectorTest.java

@@ -32,12 +32,12 @@
 
 public class PathSelectorTest {
     /**
-     * The temporary directory where are the files to test.
+     * The temporary directory containing the files to test.
      */
     private Path directory;
 
     /**
-     * The filtered set of paths. creates by {@link #filter()}.
+     * The filtered set of paths. Created by {@link #filter()}.
      */
     private Set<Path> filtered;
 
@@ -84,7 +84,7 @@ private void filter(final String syntax) throws IOException {
     /**
      * Asserts that the filtered set of paths contains the given item.
      * If present, the path is removed from the collection of filtered files.
-     * It allows caller to verify that there is no unexpected elements remaining
+     * It allows caller to verify that there are no unexpected elements remaining
      * after all expected elements have been removed.
      *
      * @param path the path to test