[S1161] rule: category/java/bestpractices.xml/MissingOverride

Author: Vincent Potucek

.gitignore

@@ -16,4 +16,5 @@
 .factorypath
 .vscode/
 repo/
-/*.svg
+/*.svg
+.pmd/.cache

.pmd/ruleset.xml

@@ -0,0 +1,25 @@
+<?xml version="1.0"?>
+<!--
+Licensed to the Apache Software Foundation (ASF) under one
+or more contributor license agreements.  See the NOTICE file
+distributed with this work for additional information
+regarding copyright ownership.  The ASF licenses this file
+to you under the Apache License, Version 2.0 (the
+"License"); you may not use this file except in compliance
+with the License.  You may obtain a copy of the License at
+
+  http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing,
+software distributed under the License is distributed on an
+"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+KIND, either express or implied.  See the License for the
+specific language governing permissions and limitations
+under the License.
+-->
+<ruleset name="bestpractices"
+         xmlns="http://pmd.sourceforge.net/ruleset/2.0.0"
+         xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+         xsi:schemaLocation="http://pmd.sourceforge.net/ruleset/2.0.0 https://pmd.sourceforge.io/ruleset_2_0_0.xsd">
+    <rule ref="category/java/bestpractices.xml/MissingOverride" />
+</ruleset>

api/maven-api-cli/src/main/java/org/apache/maven/api/cli/mvn/MavenOptions.java

@@ -229,5 +229,6 @@ public interface MavenOptions extends Options {
      * @return a new MavenOptions instance with interpolated values
      */
     @Nonnull
+    @Override
     MavenOptions interpolate(@Nonnull UnaryOperator<String> callback);
 }

api/maven-api-cli/src/main/java/org/apache/maven/api/cli/mvnenc/EncryptOptions.java

@@ -64,5 +64,6 @@ public interface EncryptOptions extends Options {
      * @return a new EncryptOptions instance with interpolated values
      */
     @Nonnull
+    @Override
     EncryptOptions interpolate(UnaryOperator<String> callback);
 }

api/maven-api-cli/src/main/java/org/apache/maven/api/cli/mvnsh/ShellOptions.java

@@ -39,5 +39,6 @@ public interface ShellOptions extends Options {
      * @return a new EncryptOptions instance with interpolated values
      */
     @Nonnull
+    @Override
     ShellOptions interpolate(UnaryOperator<String> callback);
 }

api/maven-api-core/src/main/java/org/apache/maven/api/ExtensibleEnums.java

@@ -87,6 +87,7 @@ private static class DefaultExtensibleEnum implements ExtensibleEnum {
          *
          * @return the identifier
          */
+        @Override
         public String id() {
             return id;
         }

api/maven-api-core/src/main/java/org/apache/maven/api/Lifecycle.java

@@ -244,6 +244,7 @@ interface PhasePointer extends Pointer {
          *
          * @return the PROJECT pointer type
          */
+        @Override
         default Type type() {
             return Type.PROJECT;
         }
@@ -262,6 +263,7 @@ interface DependenciesPointer extends Pointer {
          *
          * @return the DEPENDENCIES pointer type
          */
+        @Override
         default Type type() {
             return Type.DEPENDENCIES;
         }
@@ -273,6 +275,7 @@ interface ChildrenPointer extends Pointer {
          *
          * @return the CHILDREN pointer type
          */
+        @Override
         default Type type() {
             return Type.CHILDREN;
         }

api/maven-api-core/src/main/java/org/apache/maven/api/Packaging.java

@@ -66,6 +66,7 @@ public interface Packaging extends ExtensibleEnum {
      * The packaging id.
      */
     @Nonnull
+    @Override
     String id();
 
     /**

api/maven-api-core/src/main/java/org/apache/maven/api/Type.java

@@ -134,6 +134,7 @@ public interface Type extends ExtensibleEnum {
      * @return the id of this type, never {@code null}.
      */
     @Nonnull
+    @Override
     String id();
 
     /**

api/maven-api-core/src/main/java/org/apache/maven/api/Version.java

@@ -38,5 +38,6 @@ public interface Version extends Comparable<Version> {
      * {@return the string representation of this version}
      */
     @Nonnull
+    @Override
     String toString();
 }