[S1161] rule: category/java/bestpractices.xml/MissingOverride

Author: Vincent Potucek

compat/maven-compat/src/test/java/org/apache/maven/artifact/deployer/ArtifactDeployerTest.java

@@ -46,6 +46,7 @@ class ArtifactDeployerTest extends AbstractArtifactComponentTestCase {
     @Inject
     private SessionScope sessionScope;
 
+    @Override
     protected String component() {
         return "deployer";
     }

compat/maven-compat/src/test/java/org/apache/maven/artifact/installer/ArtifactInstallerTest.java

@@ -41,6 +41,7 @@ class ArtifactInstallerTest extends AbstractArtifactComponentTestCase {
     @Inject
     private SessionScope sessionScope;
 
+    @Override
     protected String component() {
         return "installer";
     }

compat/maven-compat/src/test/java/org/apache/maven/artifact/resolver/TestFileWagon.java

@@ -35,6 +35,7 @@ public class TestFileWagon extends FileWagon {
     private TestTransferListener testTransferListener;
     private boolean insideGet;
 
+    @Override
     @Deprecated
     protected void getTransfer(Resource resource, File destination, InputStream input, boolean closeInput, int maxSize)
             throws TransferFailedException {

compat/maven-compat/src/test/java/org/apache/maven/artifact/testutils/TestFileManager.java

@@ -152,6 +152,7 @@ public String getFileContents(File file, String encoding) throws IOException {
         return FileUtils.fileRead(file, encoding);
     }
 
+    @Override
     protected void finalize() throws Throwable {
         maybeWarnAboutCleanUp();
 

compat/maven-compat/src/test/java/org/apache/maven/project/inheritance/AbstractProjectInheritanceTestCase.java

@@ -48,6 +48,7 @@ protected File projectFile(String groupId, String artifactId) {
     // The local repository for this category of tests
     // ----------------------------------------------------------------------
 
+    @Override
     protected File getLocalRepositoryPath() {
         return getTestFile("target/test-classes/inheritance-repo/" + getTestSeries());
     }

compat/maven-embedder/src/main/java/org/apache/maven/cli/ExtensionConfigurationModule.java

@@ -68,6 +68,7 @@ static class ExtensionInterpolator extends MavenTransformer {
             super(transformer);
         }
 
+        @Override
         public XmlNode transform(XmlNode node) {
             return super.transform(node);
         }

compat/maven-embedder/src/main/java/org/eclipse/sisu/plexus/PlexusXmlBeanConverter.java

@@ -80,6 +80,7 @@ public final class PlexusXmlBeanConverter implements PlexusBeanConverter {
     // Public methods
     // ----------------------------------------------------------------------
 
+    @Override
     @SuppressWarnings({"unchecked", "rawtypes"})
     public Object convert(final TypeLiteral role, final String value) {
         if (value.trim().startsWith("<")) {

impl/maven-cli/src/main/java/org/apache/maven/cling/extensions/ExtensionConfigurationModule.java

@@ -68,6 +68,7 @@ static class ExtensionInterpolator extends MavenTransformer {
             super(transformer);
         }
 
+        @Override
         public XmlNode transform(XmlNode node) {
             return super.transform(node);
         }

impl/maven-core/src/main/java/org/apache/maven/configuration/internal/EnhancedConfigurationConverter.java

@@ -33,6 +33,7 @@
  * interface.
  */
 class EnhancedConfigurationConverter extends ObjectWithFieldsConverter {
+    @Override
     protected Object fromExpression(
             final PlexusConfiguration configuration, final ExpressionEvaluator evaluator, final Class<?> type)
             throws ComponentConfigurationException {

impl/maven-core/src/main/java/org/apache/maven/session/scope/internal/SessionScope.java

@@ -46,6 +46,8 @@ public static <T> Provider<T> seededKeyProvider(Class<? extends T> clazz) {
         return SessionScope.<T>seededKeySupplier(clazz)::get;
     }
 
+    @Override
+    @Override
     protected boolean isTypeAnnotation(Class<? extends Annotation> annotationType) {
         return "org.apache.maven.api.di.Typed".equals(annotationType.getName())
                 || "org.eclipse.sisu.Typed".equals(annotationType.getName())