Mimir Cache-Purge w Pre-seed (#11315)

For this to work in Windows, we need latest 0.10.4 and also some changes/fixes in ITs. 

Changes:
* update to Mimir 0.10.4 + enable cache purge
* dropped ctor `Verifier(String basedir, boolean debug)` as `debug` was unused, instead introduced `Verifier(String basedir, boolean createDotMvn)` that auto-creates `.mvn` folder in basedir for each ITs. If IT does not want this, it must use alt method and have a Javadoc telling why.
* detached `its` parent POM from Maven parent POM, as it interferes with IT support built plugins (we have ITs that uses plugin built in core-it-support but in POM adds an IT specific dependency that in turn pulls in stub plexus-utils dependency; by having depMgt in plugin POM, due Maven 4 transitive dep mgmt, the 4th level p-u was NOT used, but a managed one was used instead)
* disabled RRF in ITs due apache/maven-resolver#1641 and parallel running of IT just exacerbates this issue

Note: due cache rename this commit when merged is at the mercy of Central (HTTP 500 and so on), so will probably need several runs to stabilize (populate caches).

Author: cstamas

.github/ci-mimir-daemon.properties

@@ -19,6 +19,5 @@
 
 # Pre-seed itself
 mimir.daemon.preSeedItself=true
-# OFF for now; Windows issues
-# mimir.file.exclusiveAccess=true
-# mimir.file.cachePurge=ON_BEGIN
+mimir.file.exclusiveAccess=true
+mimir.file.cachePurge=ON_BEGIN

.github/workflows/maven.yml

@@ -32,7 +32,7 @@ concurrency:
 permissions: {}
 
 env:
-  MIMIR_VERSION: 0.10.3
+  MIMIR_VERSION: 0.10.4
   MIMIR_BASEDIR: ~/.mimir
   MIMIR_LOCAL: ~/.mimir/local
   MAVEN_OPTS: -XX:+HeapDumpOnOutOfMemoryError -XX:HeapDumpPath=./target/java_heapdump.hprof
@@ -65,7 +65,7 @@ jobs:
         id: restore-cache
         with:
           path: ${{ env.MIMIR_LOCAL }}
-          key: mvn-${{ runner.os }}-initial
+          key: master-${{ runner.os }}-initial
 
       - name: Set up Maven
         shell: bash
@@ -156,10 +156,10 @@ jobs:
         id: restore-cache
         with:
           path: ${{ env.MIMIR_LOCAL }}
-          key: mvn-full-${{ matrix.os }}-${{ matrix.java }}
+          key: master-full-${{ matrix.os }}-${{ matrix.java }}
           restore-keys: |
-            mvn-full-${{ matrix.os }}-
-            mvn-full-
+            master-full-${{ matrix.os }}-
+            master-full-
 
       - name: Download Maven distribution
         uses: actions/download-artifact@018cc2cf5baa6db3ef3c5f8a56943fffe632ef53 # v4
@@ -246,10 +246,10 @@ jobs:
         id: restore-cache
         with:
           path: ${{ env.MIMIR_LOCAL }}
-          key: mvn-its-${{ matrix.os }}-${{ matrix.java }}
+          key: master-its-${{ matrix.os }}-${{ matrix.java }}
           restore-keys: |
-            mvn-its-${{ matrix.os }}-
-            mvn-its-
+            master-its-${{ matrix.os }}-
+            master-its-
 
       - name: Download Maven distribution
         uses: actions/download-artifact@018cc2cf5baa6db3ef3c5f8a56943fffe632ef53 # v4

impl/maven-cli/src/main/java/org/apache/maven/cling/invoker/LookupInvoker.java

@@ -323,13 +323,6 @@ protected final void createTerminal(C context) {
             context.terminal = MessageUtils.getTerminal();
             context.closeables.add(MessageUtils::systemUninstall);
             MessageUtils.registerShutdownHook(); // safety belt
-
-            // when we use embedded executor AND --raw-streams, we must ENSURE streams are properly set up
-            if (context.invokerRequest.embedded()
-                    && context.options().rawStreams().orElse(false)) {
-                // to trigger FastTerminal; with raw-streams we must do this ASAP (to have system in/out/err set up)
-                context.terminal.getName();
-            }
         } else {
             doConfigureWithTerminal(context, context.terminal);
         }
@@ -381,7 +374,15 @@ protected final void doConfigureWithTerminal(C context, Terminal terminal) {
     /**
      * Override this method to add some special handling for "raw streams" <em>enabled</em> option.
      */
-    protected void doConfigureWithTerminalWithRawStreamsEnabled(C context) {}
+    protected void doConfigureWithTerminalWithRawStreamsEnabled(C context) {
+        context.invokerRequest.stdIn().ifPresent(System::setIn);
+        context.invokerRequest
+                .stdOut()
+                .ifPresent(out -> System.setOut(out instanceof PrintStream pw ? pw : new PrintStream(out, true)));
+        context.invokerRequest
+                .stdErr()
+                .ifPresent(err -> System.setErr(err instanceof PrintStream pw ? pw : new PrintStream(err, true)));
+    }
 
     /**
      * Override this method to add some special handling for "raw streams" <em>disabled</em> option.

its/core-it-suite/pom.xml

@@ -106,6 +106,7 @@ under the License.
     <dependency>
       <groupId>org.codehaus.plexus</groupId>
       <artifactId>plexus-utils</artifactId>
+      <version>${plexusUtilsVersion}</version>
       <!-- NOTE: Use compile scope for transitivity. -->
     </dependency>
 
@@ -409,6 +410,12 @@ under the License.
           <localRepositoryPath>${preparedUserHome}/.m2/repository</localRepositoryPath>
           <extraArtifacts>
             <extraArtifact>eu.maveniverse.maven.plugins:toolbox:${toolboxVersion}:maven-plugin</extraArtifact>
+            <!--
+            Required by:
+            MavenITmng0449PluginVersionResolutionTest
+            MavenITmng0479OverrideCentralRepoTest
+            -->
+            <extraArtifact>org.apache.maven:maven-plugin-api:3.8.6</extraArtifact>
           </extraArtifacts>
         </configuration>
         <executions>

its/core-it-suite/src/test/java/org/apache/maven/it/MavenITmng5230MakeReactorWithExcludesTest.java

@@ -45,7 +45,7 @@ private void clean(Verifier verifier) throws Exception {
     public void testitMakeWithExclude() throws Exception {
         File testDir = extractResources("/mng-5230-make-reactor-with-excludes");
 
-        Verifier verifier = newVerifier(testDir.getAbsolutePath(), true);
+        Verifier verifier = newVerifier(testDir.getAbsolutePath());
         verifier.addCliArgument("-X");
         verifier.setAutoclean(false);
         clean(verifier);

its/core-it-suite/src/test/java/org/apache/maven/it/MavenITmng5669ReadPomsOnce.java

@@ -43,7 +43,7 @@ public class MavenITmng5669ReadPomsOnce extends AbstractMavenIntegrationTestCase
     public void testWithoutBuildConsumer() throws Exception {
         // prepare JavaAgent
         File testDir = extractResources("/mng-5669-read-poms-once");
-        Verifier verifier = newVerifier(testDir.getAbsolutePath(), false);
+        Verifier verifier = newVerifier(testDir.getAbsolutePath());
         Map<String, String> filterProperties = Collections.singletonMap(
                 "${javaAgentJar}",
                 verifier.getArtifactPath("org.apache.maven.its", "core-it-javaagent", "2.1-SNAPSHOT", "jar"));
@@ -78,7 +78,7 @@ public void testWithoutBuildConsumer() throws Exception {
     public void testWithBuildConsumer() throws Exception {
         // prepare JavaAgent
         File testDir = extractResources("/mng-5669-read-poms-once");
-        Verifier verifier = newVerifier(testDir.getAbsolutePath(), false);
+        Verifier verifier = newVerifier(testDir.getAbsolutePath());
         Map<String, String> filterProperties = Collections.singletonMap(
                 "${javaAgentJar}",
                 verifier.getArtifactPath("org.apache.maven.its", "core-it-javaagent", "2.1-SNAPSHOT", "jar"));

its/core-it-suite/src/test/java/org/apache/maven/it/MavenITmng5895CIFriendlyUsageWithPropertyTest.java

@@ -50,7 +50,7 @@ public MavenITmng5895CIFriendlyUsageWithPropertyTest() {
     public void testitShouldResolveTheDependenciesWithoutBuildConsumer() throws Exception {
         File testDir = extractResources("/mng-5895-ci-friendly-usage-with-property");
 
-        Verifier verifier = newVerifier(testDir.getAbsolutePath(), false);
+        Verifier verifier = newVerifier(testDir.getAbsolutePath());
         verifier.setAutoclean(false);
 
         // verifier.setLogFileName( "log-only.txt" );
@@ -67,7 +67,7 @@ public void testitShouldResolveTheDependenciesWithoutBuildConsumer() throws Exce
     public void testitShouldResolveTheDependenciesWithBuildConsumer() throws Exception {
         File testDir = extractResources("/mng-5895-ci-friendly-usage-with-property");
 
-        Verifier verifier = newVerifier(testDir.getAbsolutePath(), false);
+        Verifier verifier = newVerifier(testDir.getAbsolutePath());
         verifier.setAutoclean(false);
 
         verifier.setLogFileName("log-bc.txt");

its/core-it-suite/src/test/java/org/apache/maven/it/MavenITmng5965ParallelBuildMultipliesWorkTest.java

@@ -37,7 +37,7 @@ public class MavenITmng5965ParallelBuildMultipliesWorkTest extends AbstractMaven
     public void testItShouldOnlyRunEachTaskOnce() throws Exception {
         File testDir = extractResources("/mng-5965-parallel-build-multiplies-work");
 
-        Verifier verifier = newVerifier(testDir.getAbsolutePath(), false);
+        Verifier verifier = newVerifier(testDir.getAbsolutePath());
         verifier.setAutoclean(false);
 
         verifier.setLogFileName("log-only.txt");

its/core-it-suite/src/test/java/org/apache/maven/it/MavenITmng6057CheckReactorOrderTest.java

@@ -51,7 +51,7 @@ public MavenITmng6057CheckReactorOrderTest() {
     public void testitReactorShouldResultInExpectedOrder() throws Exception {
         File testDir = extractResources("/mng-6057-check-reactor-order");
 
-        Verifier verifier = newVerifier(testDir.getAbsolutePath(), false);
+        Verifier verifier = newVerifier(testDir.getAbsolutePath());
         verifier.setAutoclean(false);
 
         verifier.setLogFileName("log-only.txt");

its/core-it-suite/src/test/java/org/apache/maven/it/MavenITmng6065FailOnSeverityTest.java

@@ -37,7 +37,7 @@ public class MavenITmng6065FailOnSeverityTest extends AbstractMavenIntegrationTe
     public void testItShouldFailOnWarnLogMessages() throws Exception {
         File testDir = extractResources("/mng-6065-fail-on-severity");
 
-        Verifier verifier = newVerifier(testDir.getAbsolutePath(), false);
+        Verifier verifier = newVerifier(testDir.getAbsolutePath());
         verifier.setLogFileName("warn.log");
         verifier.addCliArgument("--fail-on-severity");
         verifier.addCliArgument("WARN");
@@ -60,7 +60,7 @@ public void testItShouldFailOnWarnLogMessages() throws Exception {
     public void testItShouldSucceedOnWarnLogMessagesWhenFailLevelIsError() throws Exception {
         File testDir = extractResources("/mng-6065-fail-on-severity");
 
-        Verifier verifier = newVerifier(testDir.getAbsolutePath(), false);
+        Verifier verifier = newVerifier(testDir.getAbsolutePath());
         verifier.setLogFileName("error.log");
         verifier.addCliArgument("--fail-on-severity");
         verifier.addCliArgument("ERROR");