try can use automatic resource management - current

Author: Vincent Potucek

its/core-it-support/core-it-plugins/maven-it-plugin-configuration/src/main/java/org/apache/maven/plugin/coreit/PropertiesUtil.java

@@ -47,21 +47,11 @@ public static Properties read(File inputFile) throws MojoExecutionException {
         Properties props = new Properties();
 
         if (inputFile.exists()) {
-            InputStream is = null;
-            try {
-                is = new FileInputStream(inputFile);
+            try (InputStream is = new FileInputStream(inputFile)) {
                 props.load(is);
             } catch (IOException e) {
                 throw new MojoExecutionException(
                         "Input file " + inputFile + " could not be read: " + e.getMessage(), e);
-            } finally {
-                if (is != null) {
-                    try {
-                        is.close();
-                    } catch (IOException e) {
-                        // just ignore
-                    }
-                }
             }
         }
 

its/core-it-support/core-it-plugins/maven-it-plugin-context-passing/src/main/java/org/apache/maven/plugin/coreit/CatchMojo.java

@@ -58,23 +58,11 @@ public void execute() throws MojoExecutionException {
 
         File outfile = new File(outDir, value);
 
-        Writer writer = null;
-        try {
-            writer = new FileWriter(outfile);
-
+        try (Writer writer = new FileWriter(outfile)) {
             writer.write(value);
-
             writer.flush();
         } catch (IOException e) {
             throw new MojoExecutionException("Cannot write output file: " + outfile, e);
-        } finally {
-            if (writer != null) {
-                try {
-                    writer.close();
-                } catch (IOException e) {
-                    // ignore
-                }
-            }
         }
     }
 }

its/core-it-support/core-it-plugins/maven-it-plugin-log-file/src/main/java/org/apache/maven/plugin/coreit/AbstractLogMojo.java

@@ -80,20 +80,13 @@ protected void append(Object value) throws MojoExecutionException {
         getLog().info("[MAVEN-CORE-IT-LOG]   " + value);
         try {
             file.getParentFile().mkdirs();
-            OutputStream out = new FileOutputStream(file, true);
-            try {
+            try (OutputStream out = new FileOutputStream(file, true)) {
                 BufferedWriter writer = new BufferedWriter(new OutputStreamWriter(out, encoding));
                 if (value != null) {
                     writer.write(value.toString());
                     writer.newLine();
                     writer.flush();
                 }
-            } finally {
-                try {
-                    out.close();
-                } catch (IOException e) {
-                    // just ignore, we tried our best to clean up
-                }
             }
         } catch (IOException e) {
             throw new MojoExecutionException("Failed to update log file " + logFile, e);