try can use automatic resource management

Author: Vincent Potucek

impl/maven-cli/src/main/java/org/apache/maven/cling/invoker/LookupInvoker.java

@@ -407,15 +407,7 @@ protected Consumer<String> doDetermineWriter(C context) {
         } else {
             // Given the terminal creation has been offloaded to a different thread,
             // do not pass directly the terminal writer
-            return msg -> {
-                // try (PrintWriter pw = context.terminal.writer()) {
-                //   pw.println(msg);
-                //     pw.flush(); fixme even with flush its not working, why?
-                // }
-                PrintWriter pw = context.terminal.writer();
-                pw.println(msg);
-                pw.flush();
-            };
+            return msg -> context.terminal.writer().println(msg);
         }
     }
 
@@ -446,10 +438,8 @@ protected void activateLogging(C context) throws Exception {
         }
 
         // at this point logging is set up, reply so far accumulated logs, if any and swap logger with real one
-        Logger logger =
-                new Slf4jLogger(context.loggerFactory.getLogger(getClass().getName()));
-        context.logger.drain().forEach(e -> logger.log(e.level(), e.message(), e.error()));
-        context.logger = logger;
+        context.logger = new Slf4jLogger(context.loggerFactory.getLogger(getClass().getName()));
+        context.logger.drain().forEach(e -> context.logger.log(e.level(), e.message(), e.error()));
     }
 
     protected void helpOrVersionAndMayExit(C context) throws Exception {
@@ -720,10 +710,9 @@ protected Runnable settings(C context, boolean emitSettingsWarnings, SettingsBui
         };
     }
 
-    protected void customizeSettingsRequest(C context, SettingsBuilderRequest settingsBuilderRequest)
-            throws Exception {}
+    protected abstract void customizeSettingsRequest(C context, SettingsBuilderRequest settingsBuilderRequest) throws Exception;
 
-    protected void customizeSettingsResult(C context, SettingsBuilderResult settingsBuilderResult) throws Exception {}
+    protected abstract void customizeSettingsResult(C context, SettingsBuilderResult settingsBuilderResult) throws Exception;
 
     protected boolean mayDisableInteractiveMode(C context, boolean proposedInteractive) {
         if (!context.invokerRequest.options().forceInteractive().orElse(false)) {

impl/maven-cli/src/test/java/org/apache/maven/cling/invoker/mvn/MavenInvokerTest.java

@@ -206,13 +206,11 @@ void conflictingSettings(
 </settings>""";
         Path dotMvn = cwd.resolve(".mvn");
         Files.createDirectories(dotMvn);
-        Path projectExtensions = dotMvn.resolve("settings.xml");
-        Files.writeString(projectExtensions, settingsXml);
+        Files.writeString(dotMvn.resolve("settings.xml"), settingsXml);
 
         Path userConf = userHome.resolve(".m2");
         Files.createDirectories(userConf);
-        Path userExtensions = userConf.resolve("settings.xml");
-        Files.writeString(userExtensions, settingsXml);
+        Files.writeString(userConf.resolve("settings.xml"), settingsXml);
 
         // we just execute a Mojo for downloading it only and to assert from which URL it came
         Map<String, String> logs = invoke(