fix 'StringBuilder buffer' can be replaced with 'String'

Vincent Potucek · Vincent Potucek · commit a410aa64a303 · 2025-05-31T11:54:03.000+02:00
diff --git a/impl/maven-core/src/main/java/org/apache/maven/project/MavenProject.java b/impl/maven-core/src/main/java/org/apache/maven/project/MavenProject.java
@@ -1403,9 +1403,7 @@ private void deepCopy(MavenProject project) {
     }
 
     private static String getProjectReferenceId(String groupId, String artifactId, String version) {
-        StringBuilder buffer = new StringBuilder(128);
-        buffer.append(groupId).append(':').append(artifactId).append(':').append(version);
-        return buffer.toString();
+        return groupId + ':' + artifactId + ':' + version;
     }
 
     /**

Original file line number	Diff line number	Diff line change
`@@ -1403,9 +1403,7 @@ private void deepCopy(MavenProject project) {`
`1403`	`1403`	`}`
`1404`	`1404`
`1405`	`1405`	`private static String getProjectReferenceId(String groupId, String artifactId, String version) {`
`1406`		`- StringBuilder buffer = new StringBuilder(128);`
`1407`		`- buffer.append(groupId).append(':').append(artifactId).append(':').append(version);`
`1408`		`- return buffer.toString();`
	`1406`	`+ return groupId + ':' + artifactId + ':' + version;`
`1409`	`1407`	`}`
`1410`	`1408`
`1411`	`1409`	`/**`