chore: ArtifactHandlerTest add assertion to resolve @SuppressWarnings("checkstyle:UnusedLocalVariable")

Author: Vincent Potucek

impl/maven-core/src/test/java/org/apache/maven/artifact/handler/ArtifactHandlerTest.java

@@ -29,16 +29,43 @@
 import org.codehaus.plexus.testing.PlexusTest;
 import org.junit.jupiter.api.Test;
 
+import static org.assertj.core.api.Assertions.assertThat;
 import static org.codehaus.plexus.testing.PlexusExtension.getTestFile;
 import static org.junit.jupiter.api.Assertions.assertEquals;
 
 @PlexusTest
-class ArtifactHandlerTest {
+class ArtifactHandlerTest { private static final List<String> VALID_PACKAGING_TYPES = List.of(
+        "aar",
+        "apk",
+        "bundle",
+        "ear",
+        "ejb-client",
+        "eclipse-plugin",
+        "eclipse-test-plugin",
+        "ejb",
+        "hpi",
+        "jar",
+        "java-source",
+        "javadoc",
+        "jpi",
+        "kar",
+        "lpkg",
+        "maven-archetype",
+        "maven-plugin",
+        "nar",
+        "par",
+        "pom",
+        "rar",
+        "sar",
+        "swc",
+        "swf",
+        "test-jar",
+        "war",
+        "zip");
     @Inject
     PlexusContainer container;
 
     @Test
-    @SuppressWarnings("checkstyle:UnusedLocalVariable")
     void testAptConsistency() throws Exception {
         File apt = getTestFile("src/site/apt/artifact-handlers.apt");
 
@@ -79,6 +106,11 @@ void testAptConsistency() throws Exception {
                 assertEquals(handler.getExtension(), extension, type + " extension");
                 // Packaging/Directory is Maven1 remnant!!!
                 // assertEquals(handler.getPackaging(), packaging, type + " packaging");
+                assertThat(handler.getPackaging()).contains(packaging);
+                assertThat(VALID_PACKAGING_TYPES).contains(handler.getPackaging());
+                assertThat(VALID_PACKAGING_TYPES).contains(packaging);
+                assertThat(packaging).isNotBlank();
+                assertThat(handler.getPackaging()).isNotBlank();
                 assertEquals(handler.getClassifier(), classifier, type + " classifier");
                 assertEquals(handler.getLanguage(), language, type + " language");
                 assertEquals(