Skip to content

Commit bc4b52c

Browse files
author
Vincent Potucek
committed
[S1161] Enable PMD check MissingOverride
1 parent 77ebd14 commit bc4b52c

File tree

2 files changed

+45
-7
lines changed

2 files changed

+45
-7
lines changed

.pmd/ruleset.xml

Lines changed: 27 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,27 @@
1+
<?xml version="1.0"?>
2+
<!--
3+
Licensed to the Apache Software Foundation (ASF) under one
4+
or more contributor license agreements. See the NOTICE file
5+
distributed with this work for additional information
6+
regarding copyright ownership. The ASF licenses this file
7+
to you under the Apache License, Version 2.0 (the
8+
"License"); you may not use this file except in compliance
9+
with the License. You may obtain a copy of the License at
10+
11+
http://www.apache.org/licenses/LICENSE-2.0
12+
13+
Unless required by applicable law or agreed to in writing,
14+
software distributed under the License is distributed on an
15+
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
16+
KIND, either express or implied. See the License for the
17+
specific language governing permissions and limitations
18+
under the License.
19+
-->
20+
<ruleset name="Definition of Done"
21+
xmlns="http://pmd.sourceforge.net/ruleset/2.0.0"
22+
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
23+
xsi:schemaLocation="http://pmd.sourceforge.net/ruleset/2.0.0 https://pmd.sourceforge.io/ruleset_2_0_0.xsd">
24+
<description>Programmatic approach to maintain code quality on large scale.</description>
25+
<exclude-pattern>.*/compat/maven-compat/.*</exclude-pattern>
26+
<rule ref="category/java/bestpractices.xml/MissingOverride" />
27+
</ruleset>

pom.xml

Lines changed: 18 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -798,13 +798,20 @@ under the License.</licenseText>
798798
<plugin>
799799
<groupId>org.apache.maven.plugins</groupId>
800800
<artifactId>maven-pmd-plugin</artifactId>
801-
<dependencies>
802-
<dependency>
803-
<groupId>net.sourceforge.pmd</groupId>
804-
<artifactId>pmd-core</artifactId>
805-
<version>7.14.0</version>
806-
</dependency>
807-
</dependencies>
801+
<configuration>
802+
<analysisCache>true</analysisCache>
803+
<printFailingErrors>true</printFailingErrors>
804+
<rulesets>
805+
<ruleset>.pmd/ruleset.xml</ruleset>
806+
</rulesets>
807+
</configuration>
808+
<executions>
809+
<execution>
810+
<goals>
811+
<goal>check</goal>
812+
</goals>
813+
</execution>
814+
</executions>
808815
</plugin>
809816
<plugin>
810817
<groupId>org.eclipse.sisu</groupId>
@@ -821,6 +828,10 @@ under the License.</licenseText>
821828
</plugins>
822829
</pluginManagement>
823830
<plugins>
831+
<plugin>
832+
<groupId>org.apache.maven.plugins</groupId>
833+
<artifactId>maven-pmd-plugin</artifactId>
834+
</plugin>
824835
<plugin>
825836
<groupId>io.github.olamy.maven.plugins</groupId>
826837
<artifactId>jacoco-aggregator-maven-plugin</artifactId>

0 commit comments

Comments
 (0)