use try-with-resources statement in Mojo

Vincent Potucek · Vincent Potucek · commit e1d3214dbfde · 2025-06-08T14:32:50.000+02:00
diff --git a/its/core-it-support/core-it-plugins/maven-it-plugin-active-collection/src/main/java/org/apache/maven/plugin/coreit/CheckMojo.java b/its/core-it-support/core-it-plugins/maven-it-plugin-active-collection/src/main/java/org/apache/maven/plugin/coreit/CheckMojo.java
@@ -117,21 +117,11 @@ public void execute() throws MojoExecutionException, MojoFailureException {
 
         getLog().info("[MAVEN-CORE-IT-LOG] Creating output file " + outputFile);
 
-        OutputStream out = null;
-        try {
-            outputFile.getParentFile().mkdirs();
-            out = new FileOutputStream(outputFile);
+        outputFile.getParentFile().mkdirs();
+        try (OutputStream out = new FileOutputStream(outputFile)) {
             componentProperties.store(out, "MAVEN-CORE-IT-LOG");
         } catch (IOException e) {
-            throw new MojoExecutionException("Output file could not be created: " + outputFile, e);
-        } finally {
-            if (out != null) {
-                try {
-                    out.close();
-                } catch (IOException e) {
-                    // just ignore
-                }
-            }
+            throw new MojoExecutionException(e);
         }
 
         getLog().info("[MAVEN-CORE-IT-LOG] Created output file " + outputFile);
diff --git a/its/core-it-support/core-it-plugins/maven-it-plugin-active-collection/src/main/java/org/apache/maven/plugin/coreit/CheckThreadSafetyMojo.java b/its/core-it-support/core-it-plugins/maven-it-plugin-active-collection/src/main/java/org/apache/maven/plugin/coreit/CheckThreadSafetyMojo.java
@@ -134,21 +134,11 @@ public void run() {
 
         getLog().info("[MAVEN-CORE-IT-LOG] Creating output file " + outputFile);
 
-        OutputStream out = null;
-        try {
-            outputFile.getParentFile().mkdirs();
-            out = new FileOutputStream(outputFile);
+        outputFile.getParentFile().mkdirs();
+        try (OutputStream out = new FileOutputStream(outputFile)) {
             componentProperties.store(out, "MAVEN-CORE-IT-LOG");
         } catch (IOException e) {
-            throw new MojoExecutionException("Output file could not be created: " + outputFile, e);
-        } finally {
-            if (out != null) {
-                try {
-                    out.close();
-                } catch (IOException e) {
-                    // just ignore
-                }
-            }
+            throw new MojoExecutionException(e);
         }
 
         getLog().info("[MAVEN-CORE-IT-LOG] Created output file " + outputFile);
diff --git a/its/core-it-support/core-it-plugins/maven-it-plugin-class-loader/maven-it-plugin-class-loader/src/main/java/org/apache/maven/plugin/coreit/PropertiesUtil.java b/its/core-it-support/core-it-plugins/maven-it-plugin-class-loader/maven-it-plugin-class-loader/src/main/java/org/apache/maven/plugin/coreit/PropertiesUtil.java
@@ -19,9 +19,9 @@
 package org.apache.maven.plugin.coreit;
 
 import java.io.File;
-import java.io.FileOutputStream;
 import java.io.IOException;
 import java.io.OutputStream;
+import java.nio.file.Files;
 import java.util.Properties;
 
 import org.apache.maven.plugin.MojoExecutionException;
@@ -35,21 +35,11 @@
 class PropertiesUtil {
 
     public static void write(File outputFile, Properties props) throws MojoExecutionException {
-        OutputStream out = null;
-        try {
-            outputFile.getParentFile().mkdirs();
-            out = new FileOutputStream(outputFile);
+        outputFile.getParentFile().mkdirs();
+        try (OutputStream out = Files.newOutputStream(outputFile.toPath())) {
             props.store(out, "MAVEN-CORE-IT-LOG");
         } catch (IOException e) {
-            throw new MojoExecutionException("Output file could not be created: " + outputFile, e);
-        } finally {
-            if (out != null) {
-                try {
-                    out.close();
-                } catch (IOException e) {
-                    // just ignore
-                }
-            }
+            throw new MojoExecutionException(e);
         }
     }
 }
diff --git a/its/core-it-support/core-it-plugins/maven-it-plugin-configuration/src/main/java/org/apache/maven/plugin/coreit/PropertiesUtil.java b/its/core-it-support/core-it-plugins/maven-it-plugin-configuration/src/main/java/org/apache/maven/plugin/coreit/PropertiesUtil.java
@@ -69,22 +69,11 @@ public static Properties read(File inputFile) throws MojoExecutionException {
     }
 
     public static void write(File outputFile, Properties props) throws MojoExecutionException {
-        OutputStream os = null;
-        try {
-            outputFile.getParentFile().mkdirs();
-            os = new FileOutputStream(outputFile);
+        outputFile.getParentFile().mkdirs();
+        try (OutputStream os = new FileOutputStream(outputFile)) {
             props.store(os, "MAVEN-CORE-IT-LOG");
         } catch (IOException e) {
-            throw new MojoExecutionException(
-                    "Output file " + outputFile + " could not be created: " + e.getMessage(), e);
-        } finally {
-            if (os != null) {
-                try {
-                    os.close();
-                } catch (IOException e) {
-                    // just ignore
-                }
-            }
+            throw new MojoExecutionException(e);
         }
     }
 
diff --git a/its/core-it-support/core-it-plugins/maven-it-plugin-site/src/main/java/org/apache/maven/plugin/coreit/InfoReport.java b/its/core-it-support/core-it-plugins/maven-it-plugin-site/src/main/java/org/apache/maven/plugin/coreit/InfoReport.java
@@ -96,21 +96,11 @@ public void execute() throws MojoExecutionException, MojoFailureException {
 
         getLog().info("[MAVEN-CORE-IT-LOG] Creating output file: " + outputFile);
 
-        OutputStream out = null;
-        try {
-            outputFile.getParentFile().mkdirs();
-            out = new FileOutputStream(outputFile);
+        outputFile.getParentFile().mkdirs();
+        try (OutputStream out = new FileOutputStream(outputFile)) {
             props.store(out, "MAVEN-CORE-IT-LOG");
         } catch (IOException e) {
-            throw new MojoExecutionException("Output file could not be created: " + outputFile, e);
-        } finally {
-            if (out != null) {
-                try {
-                    out.close();
-                } catch (IOException e) {
-                    // just ignore
-                }
-            }
+            throw new MojoExecutionException(e);
         }
 
         getLog().info("[MAVEN-CORE-IT-LOG] Created output file: " + outputFile);
diff --git a/its/core-it-support/core-it-plugins/maven-it-plugin-toolchain/src/main/java/org/apache/maven/plugin/coreit/CoreItMojo.java b/its/core-it-support/core-it-plugins/maven-it-plugin-toolchain/src/main/java/org/apache/maven/plugin/coreit/CoreItMojo.java
@@ -105,21 +105,11 @@ public void execute() throws MojoExecutionException {
             }
         }
 
-        OutputStream out = null;
-        try {
-            outputFile.getParentFile().mkdirs();
-            out = new FileOutputStream(outputFile);
+        outputFile.getParentFile().mkdirs();
+        try (OutputStream out = new FileOutputStream(outputFile)) {
             properties.store(out, "MAVEN-CORE-IT-LOG");
         } catch (IOException e) {
-            throw new MojoExecutionException(e.getMessage(), e);
-        } finally {
-            if (out != null) {
-                try {
-                    out.close();
-                } catch (IOException e) {
-                    // ignore
-                }
-            }
+            throw new MojoExecutionException(e);
         }
     }
 
diff --git a/its/core-it-support/core-it-plugins/maven-it-plugin-toolchain/src/main/java/org/apache/maven/plugin/coreit/FindToolMojo.java b/its/core-it-support/core-it-plugins/maven-it-plugin-toolchain/src/main/java/org/apache/maven/plugin/coreit/FindToolMojo.java
@@ -87,21 +87,11 @@ public void execute() throws MojoExecutionException {
             }
         }
 
-        OutputStream out = null;
-        try {
-            outputFile.getParentFile().mkdirs();
-            out = new FileOutputStream(outputFile);
+        outputFile.getParentFile().mkdirs();
+        try (OutputStream out = new FileOutputStream(outputFile)) {
             properties.store(out, "MAVEN-CORE-IT-LOG");
         } catch (IOException e) {
-            throw new MojoExecutionException(e.getMessage(), e);
-        } finally {
-            if (out != null) {
-                try {
-                    out.close();
-                } catch (IOException e) {
-                    // ignore
-                }
-            }
+            throw new MojoExecutionException(e);
         }
     }
 }

Original file line number	Diff line number	Diff line change
`@@ -105,21 +105,11 @@ public void execute() throws MojoExecutionException {`
`105`	`105`	`}`
`106`	`106`	`}`
`107`	`107`
`108`		`- OutputStream out = null;`
`109`		`- try {`
`110`		`- outputFile.getParentFile().mkdirs();`
`111`		`- out = new FileOutputStream(outputFile);`
	`108`	`+ outputFile.getParentFile().mkdirs();`
	`109`	`+ try (OutputStream out = new FileOutputStream(outputFile)) {`
`112`	`110`	`properties.store(out, "MAVEN-CORE-IT-LOG");`
`113`	`111`	`} catch (IOException e) {`
`114`		`- throw new MojoExecutionException(e.getMessage(), e);`
`115`		`- } finally {`
`116`		`- if (out != null) {`
`117`		`- try {`
`118`		`- out.close();`
`119`		`- } catch (IOException e) {`
`120`		`- // ignore`
`121`		`- }`
`122`		`- }`
	`112`	`+ throw new MojoExecutionException(e);`
`123`	`113`	`}`
`124`	`114`	`}`
`125`	`115`
Original file line number	Diff line number	Diff line change
`@@ -87,21 +87,11 @@ public void execute() throws MojoExecutionException {`
`87`	`87`	`}`
`88`	`88`	`}`
`89`	`89`
`90`		`- OutputStream out = null;`
`91`		`- try {`
`92`		`- outputFile.getParentFile().mkdirs();`
`93`		`- out = new FileOutputStream(outputFile);`
	`90`	`+ outputFile.getParentFile().mkdirs();`
	`91`	`+ try (OutputStream out = new FileOutputStream(outputFile)) {`
`94`	`92`	`properties.store(out, "MAVEN-CORE-IT-LOG");`
`95`	`93`	`} catch (IOException e) {`
`96`		`- throw new MojoExecutionException(e.getMessage(), e);`
`97`		`- } finally {`
`98`		`- if (out != null) {`
`99`		`- try {`
`100`		`- out.close();`
`101`		`- } catch (IOException e) {`
`102`		`- // ignore`
`103`		`- }`
`104`		`- }`
	`94`	`+ throw new MojoExecutionException(e);`
`105`	`95`	`}`
`106`	`96`	`}`
`107`	`97`	`}`