Skip to content

Commit f747693

Browse files
aschemanclaude
andcommitted
Address PR review: avoid abbreviations, use imports
- Rename 'ctx' to 'context' in DefaultProjectBuilder - Use short form 'ModelProblem' instead of FQCN in test Addresses review comments from elharo on PR #11505. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <[email protected]>
1 parent ad063bc commit f747693

File tree

2 files changed

+8
-5
lines changed

2 files changed

+8
-5
lines changed

impl/maven-core/src/main/java/org/apache/maven/project/DefaultProjectBuilder.java

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -721,12 +721,15 @@ private void initProject(MavenProject project, ModelBuilderResult result) {
721721
isModularProject);
722722

723723
// Handle main and test resources using shared method
724-
ResourceHandlingContext ctx =
724+
ResourceHandlingContext context =
725725
new ResourceHandlingContext(project, baseDir, modules, isModularProject, result);
726726
handleResourceConfiguration(
727-
ctx, project.getBuild().getDelegate().getResources(), hasMainResources, ProjectScope.MAIN);
727+
context, project.getBuild().getDelegate().getResources(), hasMainResources, ProjectScope.MAIN);
728728
handleResourceConfiguration(
729-
ctx, project.getBuild().getDelegate().getTestResources(), hasTestResources, ProjectScope.TEST);
729+
context,
730+
project.getBuild().getDelegate().getTestResources(),
731+
hasTestResources,
732+
ProjectScope.TEST);
730733
}
731734

732735
project.setActiveProfiles(

impl/maven-core/src/test/java/org/apache/maven/project/ProjectBuilderTest.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -441,8 +441,8 @@ void testModularSourcesWithExplicitResourcesIssuesWarning() throws Exception {
441441
MavenProject project = result.getProject();
442442

443443
// Verify warnings are issued for ignored legacy resources
444-
List<org.apache.maven.model.building.ModelProblem> warnings = result.getProblems().stream()
445-
.filter(p -> p.getSeverity() == org.apache.maven.model.building.ModelProblem.Severity.WARNING)
444+
List<ModelProblem> warnings = result.getProblems().stream()
445+
.filter(p -> p.getSeverity() == ModelProblem.Severity.WARNING)
446446
.filter(p -> p.getMessage().contains("Legacy") && p.getMessage().contains("ignored"))
447447
.collect(Collectors.toList());
448448

0 commit comments

Comments
 (0)