Fix false parent cycle detection with flatten-maven-plugin#11400
Merged
gnodet merged 1 commit intoapache:maven-4.0.xfrom Nov 6, 2025
Merged
Fix false parent cycle detection with flatten-maven-plugin#11400gnodet merged 1 commit intoapache:maven-4.0.xfrom
gnodet merged 1 commit intoapache:maven-4.0.xfrom
Conversation
gnodet
changed the title
…che#11399) When using flatten-maven-plugin with updatePomFile=true and parent expansion, Maven incorrectly detected a parent cycle during the install phase. The error occurred because the consumer POM builder was using Path instead of ModelSource when reading the flattened POM. This change updates the PomArtifactTransformer API to use ModelSource instead of Path. ModelSource includes the necessary context (base directory, ModelLocator) to properly resolve parent POMs and avoid false cycle detection. Changes: - Updated PomArtifactTransformer.transform() to accept ModelSource instead of Path - Modified ConsumerPomArtifactTransformer to create ModelSource with proper resolution context - Updated DefaultConsumerPomBuilder and related classes to work with ModelSource - Added integration test to verify the fix Fixes apache#11399
cstamas
approved these changes
Nov 6, 2025
gnodet
added a commit
to gnodet/maven
that referenced
this pull request
Nov 6, 2025
…che#11399) (apache#11400) When using flatten-maven-plugin with updatePomFile=true and parent expansion, Maven incorrectly detected a parent cycle during the install phase. The error occurred because the consumer POM builder was using Path instead of ModelSource when reading the flattened POM. This change updates the PomArtifactTransformer API to use ModelSource instead of Path. ModelSource includes the necessary context (base directory, ModelLocator) to properly resolve parent POMs and avoid false cycle detection. Changes: - Updated PomArtifactTransformer.transform() to accept ModelSource instead of Path - Modified ConsumerPomArtifactTransformer to create ModelSource with proper resolution context - Updated DefaultConsumerPomBuilder and related classes to work with ModelSource - Added integration test to verify the fix Fixes apache#11399 (cherry picked from commit 5ec059c) # Conflicts: # impl/maven-core/src/test/java/org/apache/maven/internal/transformation/impl/ConsumerPomArtifactTransformerTest.java
Contributor
Author
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation |
gnodet
added a commit
that referenced
this pull request
Nov 6, 2025
) (#11400) (#11403) When using flatten-maven-plugin with updatePomFile=true and parent expansion, Maven incorrectly detected a parent cycle during the install phase. The error occurred because the consumer POM builder was using Path instead of ModelSource when reading the flattened POM. This change updates the PomArtifactTransformer API to use ModelSource instead of Path. ModelSource includes the necessary context (base directory, ModelLocator) to properly resolve parent POMs and avoid false cycle detection. Changes: - Updated PomArtifactTransformer.transform() to accept ModelSource instead of Path - Modified ConsumerPomArtifactTransformer to create ModelSource with proper resolution context - Updated DefaultConsumerPomBuilder and related classes to work with ModelSource - Added integration test to verify the fix Fixes #11399 (cherry picked from commit 5ec059c)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #11399
When using
flatten-maven-pluginwithupdatePomFile=trueand<parent>expand</parent>, Maven incorrectly detected a parent cycle during the install phase. The error occurred because the consumer POM builder was usingPathinstead ofModelSourcewhen reading the flattened POM.Changes
PomArtifactTransformer.transform()to acceptModelSourceinstead ofPathConsumerPomArtifactTransformerto createModelSourcewith proper resolution context (base directory, ModelLocator)DefaultConsumerPomBuilderand related classes to work withModelSourceMavenITgh11399FlattenPluginParentCycleTestto verify the fixRoot Cause
The consumer POM builder was using
Pathinstead ofModelSourcewhen reading the flattened POM. This caused the cycle detector to incorrectly identify a cycle because it couldn't properly resolve the parent relationship context.Solution
ModelSourceincludes the necessary context (base directory, ModelLocator) to properly resolve parent POMs and avoid false cycle detection. By providing aModelSourcewith a properresolve()implementation, the parent POM can be correctly located and the cycle detection works as expected.Testing
mvn install -DskipTestsmvn test -Prun-its -Dtest=MavenITgh11399*Pull Request opened by Augment Code with guidance from the PR author