diff --git a/api/maven-api-core/src/test/java/org/apache/maven/api/MonotonicClockTest.java b/api/maven-api-core/src/test/java/org/apache/maven/api/MonotonicClockTest.java
index de561fb591a4..c77c18e2870a 100644
--- a/api/maven-api-core/src/test/java/org/apache/maven/api/MonotonicClockTest.java
+++ b/api/maven-api-core/src/test/java/org/apache/maven/api/MonotonicClockTest.java
@@ -28,69 +28,76 @@
import org.junit.jupiter.api.Nested;
import org.junit.jupiter.api.Test;
-import static org.junit.jupiter.api.Assertions.assertEquals;
-import static org.junit.jupiter.api.Assertions.assertNotNull;
-import static org.junit.jupiter.api.Assertions.assertSame;
-import static org.junit.jupiter.api.Assertions.assertTrue;
+import static org.assertj.core.api.Assertions.assertThat;
class MonotonicClockTest {
@Test
@DisplayName("MonotonicClock singleton instance should always return the same instance")
- void testSingletonInstance() {
+ void singletonInstance() {
MonotonicClock clock1 = MonotonicClock.get();
MonotonicClock clock2 = MonotonicClock.get();
- assertSame(clock1, clock2, "Multiple calls to get() should return the same instance");
+ assertThat(clock2)
+ .as("Multiple calls to get() should return the same instance")
+ .isSameAs(clock1);
}
@Test
@DisplayName("MonotonicClock should always use UTC timezone")
- void testClockTimezone() {
+ void clockTimezone() {
MonotonicClock clock = MonotonicClock.get();
- assertEquals(ZoneOffset.UTC, clock.getZone(), "Clock should use UTC timezone");
+ assertThat(clock.getZone()).as("Clock should use UTC timezone").isEqualTo(ZoneOffset.UTC);
// Verify that attempting to change timezone returns the same instance
Clock newClock = clock.withZone(ZoneId.systemDefault());
- assertSame(clock, newClock, "withZone() should return the same clock instance");
+ assertThat(newClock)
+ .as("withZone() should return the same clock instance")
+ .isSameAs(clock);
}
@Test
@DisplayName("MonotonicClock should maintain monotonic time progression")
- void testMonotonicBehavior() throws InterruptedException {
+ void monotonicBehavior() throws InterruptedException {
Instant first = MonotonicClock.now();
Thread.sleep(10); // Small delay
Instant second = MonotonicClock.now();
Thread.sleep(10); // Small delay
Instant third = MonotonicClock.now();
- assertTrue(first.isBefore(second), "Time should progress forward between measurements");
- assertTrue(second.isBefore(third), "Time should progress forward between measurements");
+ assertThat(first.isBefore(second))
+ .as("Time should progress forward between measurements")
+ .isTrue();
+ assertThat(second.isBefore(third))
+ .as("Time should progress forward between measurements")
+ .isTrue();
}
@Test
@DisplayName("MonotonicClock elapsed time should increase")
- void testElapsedTime() throws InterruptedException {
+ void elapsedTime() throws InterruptedException {
Duration initial = MonotonicClock.elapsed();
Thread.sleep(50); // Longer delay for more reliable measurement
Duration later = MonotonicClock.elapsed();
- assertTrue(later.compareTo(initial) > 0, "Elapsed time should increase");
- assertTrue(
- later.minus(initial).toMillis() >= 45,
- "Elapsed time difference should be at least 45ms (accounting for some timing variance)");
+ assertThat(later.compareTo(initial) > 0)
+ .as("Elapsed time should increase")
+ .isTrue();
+ assertThat(later.minus(initial).toMillis() >= 45)
+ .as("Elapsed time difference should be at least 45ms (accounting for some timing variance)")
+ .isTrue();
}
@Test
@DisplayName("MonotonicClock start time should remain constant")
- void testStartTime() throws InterruptedException {
+ void startTime() throws InterruptedException {
Instant start1 = MonotonicClock.start();
Thread.sleep(10);
Instant start2 = MonotonicClock.start();
- assertEquals(start1, start2, "Start time should remain constant");
- assertNotNull(start1, "Start time should not be null");
+ assertThat(start2).as("Start time should remain constant").isEqualTo(start1);
+ assertThat(start1).as("Start time should not be null").isNotNull();
}
@Nested
@@ -99,31 +106,33 @@ class TimeConsistencyTests {
@Test
@DisplayName("Current time should be after start time")
- void testCurrentTimeAfterStart() {
+ void currentTimeAfterStart() {
Instant now = MonotonicClock.now();
Instant start = MonotonicClock.start();
- assertTrue(now.isAfter(start), "Current time should be after start time");
+ assertThat(now.isAfter(start))
+ .as("Current time should be after start time")
+ .isTrue();
}
@Test
@DisplayName("Elapsed time should match time difference")
- void testElapsedTimeConsistency() {
+ void elapsedTimeConsistency() {
MonotonicClock clock = MonotonicClock.get();
Instant now = clock.instant();
Duration elapsed = clock.elapsedTime();
Duration calculated = Duration.between(clock.startInstant(), now);
// Allow for small timing differences (1ms) due to execution time between measurements
- assertTrue(
- Math.abs(elapsed.toMillis() - calculated.toMillis()) <= 1,
- "Elapsed time should match calculated duration between start and now");
+ assertThat(Math.abs(elapsed.toMillis() - calculated.toMillis()) <= 1)
+ .as("Elapsed time should match calculated duration between start and now")
+ .isTrue();
}
}
@Test
@DisplayName("MonotonicClock should handle rapid successive calls")
- void testRapidCalls() {
+ void rapidCalls() {
Instant[] instants = new Instant[1000];
for (int i = 0; i < instants.length; i++) {
instants[i] = MonotonicClock.now();
@@ -131,20 +140,22 @@ void testRapidCalls() {
// Verify monotonic behavior across all measurements
for (int i = 1; i < instants.length; i++) {
- assertTrue(
- instants[i].compareTo(instants[i - 1]) >= 0,
- "Time should never go backwards even with rapid successive calls");
+ assertThat(instants[i].compareTo(instants[i - 1]) >= 0)
+ .as("Time should never go backwards even with rapid successive calls")
+ .isTrue();
}
}
@Test
@DisplayName("MonotonicClock should maintain reasonable alignment with system time")
- void testSystemTimeAlignment() {
+ void systemTimeAlignment() {
Instant monotonic = MonotonicClock.now();
Instant system = Instant.now();
// The difference should be relatively small (allow for 1 second max)
Duration difference = Duration.between(monotonic, system).abs();
- assertTrue(difference.getSeconds() <= 1, "Monotonic time should be reasonably aligned with system time");
+ assertThat(difference.getSeconds() <= 1)
+ .as("Monotonic time should be reasonably aligned with system time")
+ .isTrue();
}
}
diff --git a/api/maven-api-core/src/test/java/org/apache/maven/api/services/RequestImplementationTest.java b/api/maven-api-core/src/test/java/org/apache/maven/api/services/RequestImplementationTest.java
index eef64a138888..f45cb2fcdec1 100644
--- a/api/maven-api-core/src/test/java/org/apache/maven/api/services/RequestImplementationTest.java
+++ b/api/maven-api-core/src/test/java/org/apache/maven/api/services/RequestImplementationTest.java
@@ -27,15 +27,13 @@
import org.apache.maven.api.Session;
import org.junit.jupiter.api.Test;
-import static org.junit.jupiter.api.Assertions.assertEquals;
-import static org.junit.jupiter.api.Assertions.assertNotEquals;
-import static org.junit.jupiter.api.Assertions.assertTrue;
+import static org.assertj.core.api.Assertions.assertThat;
import static org.mockito.Mockito.mock;
class RequestImplementationTest {
@Test
- void testArtifactResolverRequestEquality() {
+ void artifactResolverRequestEquality() {
Session session = mock(Session.class);
ArtifactCoordinates coords1 = mock(ArtifactCoordinates.class);
ArtifactCoordinates coords2 = mock(ArtifactCoordinates.class);
@@ -63,30 +61,30 @@ void testArtifactResolverRequestEquality() {
.build();
// Test equals and hashCode
- assertEquals(request1, request2);
- assertEquals(request1.hashCode(), request2.hashCode());
- assertNotEquals(request1, request3);
+ assertThat(request2).isEqualTo(request1);
+ assertThat(request2.hashCode()).isEqualTo(request1.hashCode());
+ assertThat(request3).isNotEqualTo(request1);
// Test toString
String toString = request1.toString();
- assertTrue(toString.contains("coordinates="));
- assertTrue(toString.contains("repositories="));
+ assertThat(toString.contains("coordinates=")).isTrue();
+ assertThat(toString.contains("repositories=")).isTrue();
}
@Test
- void testRequestTraceIntegration() {
+ void requestTraceIntegration() {
Session session = mock(Session.class);
RequestTrace trace = new RequestTrace("test-context", null, "test-data");
ArtifactInstallerRequest request =
ArtifactInstallerRequest.builder().session(session).trace(trace).build();
- assertEquals(trace, request.getTrace());
- assertEquals(session, request.getSession());
+ assertThat(request.getTrace()).isEqualTo(trace);
+ assertThat(request.getSession()).isEqualTo(session);
}
@Test
- void testDependencyResolverRequestEquality() {
+ void dependencyResolverRequestEquality() {
Session session = mock(Session.class);
DependencyResolverRequest.DependencyResolverRequestBuilder builder = DependencyResolverRequest.builder();
@@ -105,12 +103,12 @@ void testDependencyResolverRequestEquality() {
.pathScope(PathScope.MAIN_COMPILE)
.build();
- assertEquals(request1, request2);
- assertEquals(request1.hashCode(), request2.hashCode());
- assertNotEquals(request1, request3);
+ assertThat(request2).isEqualTo(request1);
+ assertThat(request2.hashCode()).isEqualTo(request1.hashCode());
+ assertThat(request3).isNotEqualTo(request1);
String toString = request1.toString();
- assertTrue(toString.contains("requestType="));
- assertTrue(toString.contains("pathScope="));
+ assertThat(toString.contains("requestType=")).isTrue();
+ assertThat(toString.contains("pathScope=")).isTrue();
}
}
diff --git a/api/maven-api-core/src/test/java/org/apache/maven/api/services/RequestTraceTest.java b/api/maven-api-core/src/test/java/org/apache/maven/api/services/RequestTraceTest.java
index 78534f9ae5f5..142b8a74e80c 100644
--- a/api/maven-api-core/src/test/java/org/apache/maven/api/services/RequestTraceTest.java
+++ b/api/maven-api-core/src/test/java/org/apache/maven/api/services/RequestTraceTest.java
@@ -20,68 +20,66 @@
import org.junit.jupiter.api.Test;
-import static org.junit.jupiter.api.Assertions.assertEquals;
-import static org.junit.jupiter.api.Assertions.assertNull;
-import static org.junit.jupiter.api.Assertions.assertSame;
+import static org.assertj.core.api.Assertions.assertThat;
class RequestTraceTest {
@Test
- void testRequestTraceCreation() {
+ void requestTraceCreation() {
RequestTrace parentTrace = new RequestTrace("parent-context", null, "parent-data");
RequestTrace childTrace = new RequestTrace("child-context", parentTrace, "child-data");
- assertEquals("parent-context", parentTrace.context());
- assertNull(parentTrace.parent());
- assertEquals("parent-data", parentTrace.data());
+ assertThat(parentTrace.context()).isEqualTo("parent-context");
+ assertThat(parentTrace.parent()).isNull();
+ assertThat(parentTrace.data()).isEqualTo("parent-data");
- assertEquals("child-context", childTrace.context());
- assertSame(parentTrace, childTrace.parent());
- assertEquals("child-data", childTrace.data());
+ assertThat(childTrace.context()).isEqualTo("child-context");
+ assertThat(childTrace.parent()).isSameAs(parentTrace);
+ assertThat(childTrace.data()).isEqualTo("child-data");
}
@Test
- void testRequestTraceWithParentContextInheritance() {
+ void requestTraceWithParentContextInheritance() {
RequestTrace parentTrace = new RequestTrace("parent-context", null, "parent-data");
RequestTrace childTrace = new RequestTrace(parentTrace, "child-data");
- assertEquals("parent-context", parentTrace.context());
- assertEquals("parent-context", childTrace.context());
- assertEquals("child-data", childTrace.data());
+ assertThat(parentTrace.context()).isEqualTo("parent-context");
+ assertThat(childTrace.context()).isEqualTo("parent-context");
+ assertThat(childTrace.data()).isEqualTo("child-data");
}
@Test
- void testPredefinedContexts() {
- assertEquals("plugin", RequestTrace.CONTEXT_PLUGIN);
- assertEquals("project", RequestTrace.CONTEXT_PROJECT);
- assertEquals("bootstrap", RequestTrace.CONTEXT_BOOTSTRAP);
+ void predefinedContexts() {
+ assertThat(RequestTrace.CONTEXT_PLUGIN).isEqualTo("plugin");
+ assertThat(RequestTrace.CONTEXT_PROJECT).isEqualTo("project");
+ assertThat(RequestTrace.CONTEXT_BOOTSTRAP).isEqualTo("bootstrap");
}
@Test
- void testNullValues() {
+ void nullValues() {
RequestTrace trace = new RequestTrace(null, null, null);
- assertNull(trace.context());
- assertNull(trace.parent());
- assertNull(trace.data());
+ assertThat(trace.context()).isNull();
+ assertThat(trace.parent()).isNull();
+ assertThat(trace.data()).isNull();
}
@Test
- void testChainedTraces() {
+ void chainedTraces() {
RequestTrace root = new RequestTrace("root", null, "root-data");
RequestTrace level1 = new RequestTrace("level1", root, "level1-data");
RequestTrace level2 = new RequestTrace("level2", level1, "level2-data");
RequestTrace level3 = new RequestTrace(level2, "level3-data");
// Verify the chain
- assertNull(root.parent());
- assertEquals(root, level1.parent());
- assertEquals(level1, level2.parent());
- assertEquals(level2, level3.parent());
+ assertThat(root.parent()).isNull();
+ assertThat(level1.parent()).isEqualTo(root);
+ assertThat(level2.parent()).isEqualTo(level1);
+ assertThat(level3.parent()).isEqualTo(level2);
// Verify context inheritance
- assertEquals("root", root.context());
- assertEquals("level1", level1.context());
- assertEquals("level2", level2.context());
- assertEquals("level2", level3.context()); // Inherited from parent
+ assertThat(root.context()).isEqualTo("root");
+ assertThat(level1.context()).isEqualTo("level1");
+ assertThat(level2.context()).isEqualTo("level2");
+ assertThat(level3.context()).isEqualTo("level2"); // Inherited from parent
}
}
diff --git a/api/maven-api-core/src/test/java/org/apache/maven/api/services/SourcesTest.java b/api/maven-api-core/src/test/java/org/apache/maven/api/services/SourcesTest.java
index f9abbe66d28b..ff0dc711ebb2 100644
--- a/api/maven-api-core/src/test/java/org/apache/maven/api/services/SourcesTest.java
+++ b/api/maven-api-core/src/test/java/org/apache/maven/api/services/SourcesTest.java
@@ -27,11 +27,8 @@
import org.junit.jupiter.api.Test;
import org.junit.jupiter.api.io.TempDir;
-import static org.junit.jupiter.api.Assertions.assertEquals;
-import static org.junit.jupiter.api.Assertions.assertInstanceOf;
-import static org.junit.jupiter.api.Assertions.assertNotNull;
-import static org.junit.jupiter.api.Assertions.assertNull;
-import static org.junit.jupiter.api.Assertions.assertThrows;
+import static org.assertj.core.api.Assertions.assertThat;
+import static org.assertj.core.api.AssertionsForClassTypes.assertThatExceptionOfType;
import static org.mockito.Mockito.any;
import static org.mockito.Mockito.mock;
import static org.mockito.Mockito.never;
@@ -43,53 +40,53 @@ class SourcesTest {
Path tempDir;
@Test
- void testFromPath() {
+ void fromPath() {
Path path = Paths.get("/tmp");
Source source = Sources.fromPath(path);
- assertNotNull(source);
- assertInstanceOf(Sources.PathSource.class, source);
- assertEquals(path.normalize(), source.getPath());
+ assertThat(source).isNotNull();
+ assertThat(source).isInstanceOf(Sources.PathSource.class);
+ assertThat(source.getPath()).isEqualTo(path.normalize());
}
@Test
- void testBuildSource() {
+ void buildSource() {
Path path = Paths.get("/tmp");
ModelSource source = Sources.buildSource(path);
- assertNotNull(source);
- assertInstanceOf(Sources.BuildPathSource.class, source);
- assertEquals(path.normalize(), source.getPath());
+ assertThat(source).isNotNull();
+ assertThat(source).isInstanceOf(Sources.BuildPathSource.class);
+ assertThat(source.getPath()).isEqualTo(path.normalize());
}
@Test
- void testResolvedSource() {
+ void resolvedSource() {
Path path = Paths.get("/tmp");
String location = "custom-location";
ModelSource source = Sources.resolvedSource(path, location);
- assertNotNull(source);
- assertInstanceOf(Sources.ResolvedPathSource.class, source);
- assertNull(source.getPath());
- assertEquals(location, source.getLocation());
+ assertThat(source).isNotNull();
+ assertThat(source).isInstanceOf(Sources.ResolvedPathSource.class);
+ assertThat(source.getPath()).isNull();
+ assertThat(source.getLocation()).isEqualTo(location);
}
@Test
- void testPathSourceFunctionality() {
+ void pathSourceFunctionality() {
// Test basic source functionality
Path path = Paths.get("/tmp");
Sources.PathSource source = (Sources.PathSource) Sources.fromPath(path);
- assertEquals(path.normalize(), source.getPath());
- assertEquals(path.toString(), source.getLocation());
+ assertThat(source.getPath()).isEqualTo(path.normalize());
+ assertThat(source.getLocation()).isEqualTo(path.toString());
Source resolved = source.resolve("subdir");
- assertNotNull(resolved);
- assertEquals(path.resolve("subdir").normalize(), resolved.getPath());
+ assertThat(resolved).isNotNull();
+ assertThat(resolved.getPath()).isEqualTo(path.resolve("subdir").normalize());
}
@Test
- void testBuildPathSourceFunctionality() {
+ void buildPathSourceFunctionality() {
// Test build source functionality
Path basePath = Paths.get("/tmp");
ModelSource.ModelLocator locator = mock(ModelSource.ModelLocator.class);
@@ -99,31 +96,31 @@ void testBuildPathSourceFunctionality() {
Sources.BuildPathSource source = (Sources.BuildPathSource) Sources.buildSource(basePath);
ModelSource resolved = source.resolve(locator, "subproject");
- assertNotNull(resolved);
- assertInstanceOf(Sources.BuildPathSource.class, resolved);
- assertEquals(resolvedPath, resolved.getPath());
+ assertThat(resolved).isNotNull();
+ assertThat(resolved).isInstanceOf(Sources.BuildPathSource.class);
+ assertThat(resolved.getPath()).isEqualTo(resolvedPath);
verify(locator).locateExistingPom(any(Path.class));
}
@Test
- void testResolvedPathSourceFunctionality() {
+ void resolvedPathSourceFunctionality() {
// Test resolved source functionality
Path path = Paths.get("/tmp");
String location = "custom-location";
Sources.ResolvedPathSource source = (Sources.ResolvedPathSource) Sources.resolvedSource(path, location);
- assertNull(source.getPath());
- assertEquals(location, source.getLocation());
- assertNull(source.resolve("subdir"));
+ assertThat(source.getPath()).isNull();
+ assertThat(source.getLocation()).isEqualTo(location);
+ assertThat(source.resolve("subdir")).isNull();
ModelSource.ModelLocator locator = mock(ModelSource.ModelLocator.class);
- assertNull(source.resolve(locator, "subproject"));
+ assertThat(source.resolve(locator, "subproject")).isNull();
verify(locator, never()).locateExistingPom(any(Path.class));
}
@Test
- void testStreamReading() throws IOException {
+ void streamReading() throws IOException {
// Test stream reading functionality
Path testFile = tempDir.resolve("test.txt");
String content = "test content";
@@ -132,14 +129,15 @@ void testStreamReading() throws IOException {
Source source = Sources.fromPath(testFile);
try (InputStream inputStream = source.openStream()) {
String readContent = new String(inputStream.readAllBytes());
- assertEquals(content, readContent);
+ assertThat(readContent).isEqualTo(content);
}
}
@Test
- void testNullHandling() {
- assertThrows(NullPointerException.class, () -> Sources.fromPath(null));
- assertThrows(NullPointerException.class, () -> Sources.buildSource(null));
- assertThrows(NullPointerException.class, () -> Sources.resolvedSource(null, "location"));
+ void nullHandling() {
+ assertThatExceptionOfType(NullPointerException.class).isThrownBy(() -> Sources.fromPath(null));
+ assertThatExceptionOfType(NullPointerException.class).isThrownBy(() -> Sources.buildSource(null));
+ assertThatExceptionOfType(NullPointerException.class)
+ .isThrownBy(() -> Sources.resolvedSource(null, "location"));
}
}
diff --git a/api/maven-api-plugin/pom.xml b/api/maven-api-plugin/pom.xml
index 37ed030feaf2..aa4874eed563 100644
--- a/api/maven-api-plugin/pom.xml
+++ b/api/maven-api-plugin/pom.xml
@@ -45,6 +45,11 @@ under the License.
junit-jupiter-api
test
+
+ org.assertj
+ assertj-core
+ test
+
diff --git a/api/maven-api-plugin/src/test/java/org/apache/maven/api/plugin/descriptor/another/ExtendedPluginDescriptorTest.java b/api/maven-api-plugin/src/test/java/org/apache/maven/api/plugin/descriptor/another/ExtendedPluginDescriptorTest.java
index c6b5e9ad67be..d107b03709ca 100644
--- a/api/maven-api-plugin/src/test/java/org/apache/maven/api/plugin/descriptor/another/ExtendedPluginDescriptorTest.java
+++ b/api/maven-api-plugin/src/test/java/org/apache/maven/api/plugin/descriptor/another/ExtendedPluginDescriptorTest.java
@@ -21,7 +21,7 @@
import org.apache.maven.api.plugin.descriptor.PluginDescriptor;
import org.junit.jupiter.api.Test;
-import static org.junit.jupiter.api.Assertions.assertEquals;
+import static org.assertj.core.api.Assertions.assertThat;
/**
* Verifies that subclasses from generated model classes are possible.
@@ -63,7 +63,7 @@ public ExtendedPluginDescriptor build() {
}
@Test
- void testExtendedPluginDescriptor() {
+ void extendedPluginDescriptor() {
ExtendedPluginDescriptor.Builder builder = new ExtendedPluginDescriptor.Builder();
// make sure to call the subclasses' builder methods first, otherwise fluent API would not work
builder.additionalField("additional")
@@ -71,7 +71,7 @@ void testExtendedPluginDescriptor() {
.artifactId("maven-plugin-api")
.version("1.0.0");
ExtendedPluginDescriptor descriptor = builder.build();
- assertEquals("additional", descriptor.getAdditionalField());
- assertEquals("org.apache.maven", descriptor.getGroupId());
+ assertThat(descriptor.getAdditionalField()).isEqualTo("additional");
+ assertThat(descriptor.getGroupId()).isEqualTo("org.apache.maven");
}
}
diff --git a/api/maven-api-settings/pom.xml b/api/maven-api-settings/pom.xml
index df4242455509..b01c29de961e 100644
--- a/api/maven-api-settings/pom.xml
+++ b/api/maven-api-settings/pom.xml
@@ -46,6 +46,11 @@ under the License.
junit-jupiter-api
test
+
+ org.assertj
+ assertj-core
+ test
+
diff --git a/api/maven-api-settings/src/test/java/org/apache/maven/api/settings/SettingsTest.java b/api/maven-api-settings/src/test/java/org/apache/maven/api/settings/SettingsTest.java
index b78630752ad6..3d9932e59d7d 100644
--- a/api/maven-api-settings/src/test/java/org/apache/maven/api/settings/SettingsTest.java
+++ b/api/maven-api-settings/src/test/java/org/apache/maven/api/settings/SettingsTest.java
@@ -20,22 +20,21 @@
import org.junit.jupiter.api.Test;
-import static org.junit.jupiter.api.Assertions.assertEquals;
-import static org.junit.jupiter.api.Assertions.assertNull;
+import static org.assertj.core.api.Assertions.assertThat;
class SettingsTest {
@Test
- void testSetLocalRepository() {
+ void setLocalRepository() {
Settings s = Settings.newInstance();
s = s.withLocalRepository("xxx");
- assertEquals("xxx", s.getLocalRepository());
+ assertThat(s.getLocalRepository()).isEqualTo("xxx");
s = s.withLocalRepository("yyy");
- assertEquals("yyy", s.getLocalRepository());
+ assertThat(s.getLocalRepository()).isEqualTo("yyy");
s = s.withLocalRepository(null);
- assertNull(s.getLocalRepository());
+ assertThat(s.getLocalRepository()).isNull();
}
}
diff --git a/compat/maven-artifact/src/test/java/org/apache/maven/artifact/ArtifactUtilsTest.java b/compat/maven-artifact/src/test/java/org/apache/maven/artifact/ArtifactUtilsTest.java
index 740bdee4100b..d6375dba1ae9 100644
--- a/compat/maven-artifact/src/test/java/org/apache/maven/artifact/ArtifactUtilsTest.java
+++ b/compat/maven-artifact/src/test/java/org/apache/maven/artifact/ArtifactUtilsTest.java
@@ -25,10 +25,7 @@
import org.apache.maven.artifact.versioning.VersionRange;
import org.junit.jupiter.api.Test;
-import static org.junit.jupiter.api.Assertions.assertEquals;
-import static org.junit.jupiter.api.Assertions.assertFalse;
-import static org.junit.jupiter.api.Assertions.assertNotNull;
-import static org.junit.jupiter.api.Assertions.assertTrue;
+import static org.assertj.core.api.Assertions.assertThat;
/**
* Tests {@link ArtifactUtils}.
@@ -41,29 +38,29 @@ private Artifact newArtifact(String aid) {
}
@Test
- void testIsSnapshot() {
- assertFalse(ArtifactUtils.isSnapshot(null));
- assertFalse(ArtifactUtils.isSnapshot(""));
- assertFalse(ArtifactUtils.isSnapshot("1.2.3"));
- assertTrue(ArtifactUtils.isSnapshot("1.2.3-SNAPSHOT"));
- assertTrue(ArtifactUtils.isSnapshot("1.2.3-snapshot"));
- assertTrue(ArtifactUtils.isSnapshot("1.2.3-20090413.094722-2"));
- assertFalse(ArtifactUtils.isSnapshot("1.2.3-20090413X094722-2"));
+ void isSnapshot() {
+ assertThat(ArtifactUtils.isSnapshot(null)).isFalse();
+ assertThat(ArtifactUtils.isSnapshot("")).isFalse();
+ assertThat(ArtifactUtils.isSnapshot("1.2.3")).isFalse();
+ assertThat(ArtifactUtils.isSnapshot("1.2.3-SNAPSHOT")).isTrue();
+ assertThat(ArtifactUtils.isSnapshot("1.2.3-snapshot")).isTrue();
+ assertThat(ArtifactUtils.isSnapshot("1.2.3-20090413.094722-2")).isTrue();
+ assertThat(ArtifactUtils.isSnapshot("1.2.3-20090413X094722-2")).isFalse();
}
@Test
- void testToSnapshotVersion() {
- assertEquals("1.2.3", ArtifactUtils.toSnapshotVersion("1.2.3"));
- assertEquals("1.2.3-SNAPSHOT", ArtifactUtils.toSnapshotVersion("1.2.3-SNAPSHOT"));
- assertEquals("1.2.3-SNAPSHOT", ArtifactUtils.toSnapshotVersion("1.2.3-20090413.094722-2"));
- assertEquals("1.2.3-20090413X094722-2", ArtifactUtils.toSnapshotVersion("1.2.3-20090413X094722-2"));
+ void toSnapshotVersion() {
+ assertThat(ArtifactUtils.toSnapshotVersion("1.2.3")).isEqualTo("1.2.3");
+ assertThat(ArtifactUtils.toSnapshotVersion("1.2.3-SNAPSHOT")).isEqualTo("1.2.3-SNAPSHOT");
+ assertThat(ArtifactUtils.toSnapshotVersion("1.2.3-20090413.094722-2")).isEqualTo("1.2.3-SNAPSHOT");
+ assertThat(ArtifactUtils.toSnapshotVersion("1.2.3-20090413X094722-2")).isEqualTo("1.2.3-20090413X094722-2");
}
/**
* Tests that the ordering of the map resembles the ordering of the input collection of artifacts.
*/
@Test
- void testArtifactMapByVersionlessIdOrdering() throws Exception {
+ void artifactMapByVersionlessIdOrdering() throws Exception {
List list = new ArrayList<>();
list.add(newArtifact("b"));
list.add(newArtifact("a"));
@@ -72,7 +69,7 @@ void testArtifactMapByVersionlessIdOrdering() throws Exception {
list.add(newArtifact("d"));
Map map = ArtifactUtils.artifactMapByVersionlessId(list);
- assertNotNull(map);
- assertEquals(list, new ArrayList<>(map.values()));
+ assertThat(map).isNotNull();
+ assertThat(new ArrayList<>(map.values())).isEqualTo(list);
}
}
diff --git a/compat/maven-artifact/src/test/java/org/apache/maven/artifact/DefaultArtifactTest.java b/compat/maven-artifact/src/test/java/org/apache/maven/artifact/DefaultArtifactTest.java
index 74fcd5fb93a8..5ce42335b1f2 100644
--- a/compat/maven-artifact/src/test/java/org/apache/maven/artifact/DefaultArtifactTest.java
+++ b/compat/maven-artifact/src/test/java/org/apache/maven/artifact/DefaultArtifactTest.java
@@ -28,10 +28,8 @@
import org.junit.jupiter.params.provider.Arguments;
import org.junit.jupiter.params.provider.MethodSource;
-import static org.junit.jupiter.api.Assertions.assertEquals;
-import static org.junit.jupiter.api.Assertions.assertNull;
-import static org.junit.jupiter.api.Assertions.assertThrows;
-import static org.junit.jupiter.api.Assertions.assertTrue;
+import static org.assertj.core.api.Assertions.assertThat;
+import static org.assertj.core.api.AssertionsForClassTypes.assertThatExceptionOfType;
class DefaultArtifactTest {
@@ -66,111 +64,105 @@ void setUp() throws Exception {
}
@Test
- void testGetVersionReturnsResolvedVersionOnSnapshot() {
- assertEquals(snapshotResolvedVersion, snapshotArtifact.getVersion());
+ void getVersionReturnsResolvedVersionOnSnapshot() {
+ assertThat(snapshotArtifact.getVersion()).isEqualTo(snapshotResolvedVersion);
// this is FOUL!
// snapshotArtifact.isSnapshot();
- assertEquals(snapshotSpecVersion, snapshotArtifact.getBaseVersion());
+ assertThat(snapshotArtifact.getBaseVersion()).isEqualTo(snapshotSpecVersion);
}
@Test
- void testGetDependencyConflictId() {
- assertEquals(groupId + ":" + artifactId + ":" + type + ":" + classifier, artifact.getDependencyConflictId());
+ void getDependencyConflictId() {
+ assertThat(artifact.getDependencyConflictId()).isEqualTo(groupId + ":" + artifactId + ":" + type + ":" + classifier);
}
@Test
- void testGetDependencyConflictIdNullGroupId() {
+ void getDependencyConflictIdNullGroupId() {
artifact.setGroupId(null);
- assertEquals(null + ":" + artifactId + ":" + type + ":" + classifier, artifact.getDependencyConflictId());
+ assertThat(artifact.getDependencyConflictId()).isEqualTo(null + ":" + artifactId + ":" + type + ":" + classifier);
}
@Test
- void testGetDependencyConflictIdNullClassifier() {
+ void getDependencyConflictIdNullClassifier() {
artifact = new DefaultArtifact(groupId, artifactId, versionRange, scope, type, null, artifactHandler);
- assertEquals(groupId + ":" + artifactId + ":" + type, artifact.getDependencyConflictId());
+ assertThat(artifact.getDependencyConflictId()).isEqualTo(groupId + ":" + artifactId + ":" + type);
}
@Test
- void testGetDependencyConflictIdNullScope() {
+ void getDependencyConflictIdNullScope() {
artifact.setScope(null);
- assertEquals(groupId + ":" + artifactId + ":" + type + ":" + classifier, artifact.getDependencyConflictId());
+ assertThat(artifact.getDependencyConflictId()).isEqualTo(groupId + ":" + artifactId + ":" + type + ":" + classifier);
}
@Test
void testToString() {
- assertEquals(
- groupId + ":" + artifactId + ":" + type + ":" + classifier + ":" + version + ":" + scope,
- artifact.toString());
+ assertThat(artifact.toString()).isEqualTo(groupId + ":" + artifactId + ":" + type + ":" + classifier + ":" + version + ":" + scope);
}
@Test
- void testToStringNullGroupId() {
+ void toStringNullGroupId() {
artifact.setGroupId(null);
- assertEquals(artifactId + ":" + type + ":" + classifier + ":" + version + ":" + scope, artifact.toString());
+ assertThat(artifact.toString()).isEqualTo(artifactId + ":" + type + ":" + classifier + ":" + version + ":" + scope);
}
@Test
- void testToStringNullClassifier() {
+ void toStringNullClassifier() {
artifact = new DefaultArtifact(groupId, artifactId, versionRange, scope, type, null, artifactHandler);
- assertEquals(groupId + ":" + artifactId + ":" + type + ":" + version + ":" + scope, artifact.toString());
+ assertThat(artifact.toString()).isEqualTo(groupId + ":" + artifactId + ":" + type + ":" + version + ":" + scope);
}
@Test
- void testToStringNullScope() {
+ void toStringNullScope() {
artifact.setScope(null);
- assertEquals(groupId + ":" + artifactId + ":" + type + ":" + classifier + ":" + version, artifact.toString());
+ assertThat(artifact.toString()).isEqualTo(groupId + ":" + artifactId + ":" + type + ":" + classifier + ":" + version);
}
@Test
- void testComparisonByVersion() {
+ void comparisonByVersion() {
Artifact artifact1 = new DefaultArtifact(
groupId, artifactId, VersionRange.createFromVersion("5.0"), scope, type, classifier, artifactHandler);
Artifact artifact2 = new DefaultArtifact(
groupId, artifactId, VersionRange.createFromVersion("12.0"), scope, type, classifier, artifactHandler);
- assertTrue(artifact1.compareTo(artifact2) < 0);
- assertTrue(artifact2.compareTo(artifact1) > 0);
+ assertThat(artifact1.compareTo(artifact2) < 0).isTrue();
+ assertThat(artifact2.compareTo(artifact1) > 0).isTrue();
Artifact artifact = new DefaultArtifact(
groupId, artifactId, VersionRange.createFromVersion("5.0"), scope, type, classifier, artifactHandler);
- assertTrue(artifact.compareTo(artifact1) == 0);
- assertTrue(artifact1.compareTo(artifact) == 0);
+ assertThat(artifact.compareTo(artifact1)).isEqualTo(0);
+ assertThat(artifact1.compareTo(artifact)).isEqualTo(0);
}
@Test
- void testNonResolvedVersionRangeConsistentlyYieldsNullVersions() throws Exception {
+ void nonResolvedVersionRangeConsistentlyYieldsNullVersions() throws Exception {
VersionRange vr = VersionRange.createFromVersionSpec("[1.0,2.0)");
artifact = new DefaultArtifact(groupId, artifactId, vr, scope, type, null, artifactHandler);
- assertNull(artifact.getVersion());
- assertNull(artifact.getBaseVersion());
+ assertThat(artifact.getVersion()).isNull();
+ assertThat(artifact.getBaseVersion()).isNull();
}
@Test
- void testMNG7780() throws Exception {
+ void mng7780() throws Exception {
VersionRange vr = VersionRange.createFromVersionSpec("[1.0,2.0)");
artifact = new DefaultArtifact(groupId, artifactId, vr, scope, type, null, artifactHandler);
- assertNull(artifact.getVersion());
- assertNull(artifact.getBaseVersion());
+ assertThat(artifact.getVersion()).isNull();
+ assertThat(artifact.getBaseVersion()).isNull();
DefaultArtifact nullVersionArtifact =
new DefaultArtifact(groupId, artifactId, vr, scope, type, null, artifactHandler);
- assertEquals(artifact, nullVersionArtifact);
+ assertThat(nullVersionArtifact).isEqualTo(artifact);
}
@ParameterizedTest
@MethodSource("invalidMavenCoordinates")
- void testIllegalCoordinatesInConstructor(String groupId, String artifactId, String version) {
- assertThrows(
- InvalidArtifactRTException.class,
- () -> new DefaultArtifact(
- groupId, artifactId, version, scope, type, classifier, artifactHandler, false));
+ void illegalCoordinatesInConstructor(String groupId, String artifactId, String version) {
+ assertThatExceptionOfType(InvalidArtifactRTException.class).isThrownBy(() -> new DefaultArtifact(
+ groupId, artifactId, version, scope, type, classifier, artifactHandler, false));
if (version == null) {
- assertThrows(
- InvalidArtifactRTException.class,
- () -> new DefaultArtifact(
- groupId, artifactId, (VersionRange) null, scope, type, classifier, artifactHandler, false));
+ assertThatExceptionOfType(InvalidArtifactRTException.class).isThrownBy(() -> new DefaultArtifact(
+ groupId, artifactId, (VersionRange) null, scope, type, classifier, artifactHandler, false));
}
}
diff --git a/compat/maven-artifact/src/test/java/org/apache/maven/artifact/versioning/ComparableVersionIT.java b/compat/maven-artifact/src/test/java/org/apache/maven/artifact/versioning/ComparableVersionIT.java
index a78591dafd76..929953c3147f 100644
--- a/compat/maven-artifact/src/test/java/org/apache/maven/artifact/versioning/ComparableVersionIT.java
+++ b/compat/maven-artifact/src/test/java/org/apache/maven/artifact/versioning/ComparableVersionIT.java
@@ -30,7 +30,7 @@
import org.junit.jupiter.api.Test;
-import static org.junit.jupiter.api.Assertions.assertEquals;
+import static org.assertj.core.api.Assertions.assertThat;
class ComparableVersionIT {
@@ -52,7 +52,7 @@ public FileVisitResult visitFile(Path file, BasicFileAttributes attrs) throws IO
});
try {
- assertEquals(0, p.waitFor(), "Unexpected exit code");
+ assertThat(p.waitFor()).as("Unexpected exit code").isEqualTo(0);
} catch (InterruptedException e) {
throw new InterruptedIOException(e.toString());
}
diff --git a/compat/maven-artifact/src/test/java/org/apache/maven/artifact/versioning/ComparableVersionTest.java b/compat/maven-artifact/src/test/java/org/apache/maven/artifact/versioning/ComparableVersionTest.java
index 11561aa16689..a8b2812ea1d4 100644
--- a/compat/maven-artifact/src/test/java/org/apache/maven/artifact/versioning/ComparableVersionTest.java
+++ b/compat/maven-artifact/src/test/java/org/apache/maven/artifact/versioning/ComparableVersionTest.java
@@ -22,8 +22,7 @@
import org.junit.jupiter.api.Test;
-import static org.junit.jupiter.api.Assertions.assertEquals;
-import static org.junit.jupiter.api.Assertions.assertTrue;
+import static org.assertj.core.api.Assertions.assertThat;
/**
* Test ComparableVersion.
@@ -35,10 +34,7 @@ private ComparableVersion newComparable(String version) {
String canonical = ret.getCanonical();
String parsedCanonical = new ComparableVersion(canonical).getCanonical();
- assertEquals(
- canonical,
- parsedCanonical,
- "canonical( " + version + " ) = " + canonical + " -> canonical: " + parsedCanonical);
+ assertThat(parsedCanonical).as("canonical( " + version + " ) = " + canonical + " -> canonical: " + parsedCanonical).isEqualTo(canonical);
return ret;
}
@@ -83,8 +79,8 @@ private void checkVersionsOrder(String[] versions) {
Comparable low = c[i - 1];
for (int j = i; j < versions.length; j++) {
Comparable high = c[j];
- assertTrue(low.compareTo(high) < 0, "expected " + low + " < " + high);
- assertTrue(high.compareTo(low) > 0, "expected " + high + " > " + low);
+ assertThat(low.compareTo(high) < 0).as("expected " + low + " < " + high).isTrue();
+ assertThat(high.compareTo(low) > 0).as("expected " + high + " > " + low).isTrue();
}
}
}
@@ -92,18 +88,18 @@ private void checkVersionsOrder(String[] versions) {
private void checkVersionsEqual(String v1, String v2) {
Comparable c1 = newComparable(v1);
Comparable c2 = newComparable(v2);
- assertEquals(0, c1.compareTo(c2), "expected " + v1 + " == " + v2);
- assertEquals(0, c2.compareTo(c1), "expected " + v2 + " == " + v1);
- assertEquals(c1.hashCode(), c2.hashCode(), "expected same hashcode for " + v1 + " and " + v2);
- assertEquals(c1, c2, "expected " + v1 + ".equals( " + v2 + " )");
- assertEquals(c2, c1, "expected " + v2 + ".equals( " + v1 + " )");
+ assertThat(c1.compareTo(c2)).as("expected " + v1 + " == " + v2).isEqualTo(0);
+ assertThat(c2.compareTo(c1)).as("expected " + v2 + " == " + v1).isEqualTo(0);
+ assertThat(c2.hashCode()).as("expected same hashcode for " + v1 + " and " + v2).isEqualTo(c1.hashCode());
+ assertThat(c2).as("expected " + v1 + ".equals( " + v2 + " )").isEqualTo(c1);
+ assertThat(c1).as("expected " + v2 + ".equals( " + v1 + " )").isEqualTo(c2);
}
private void checkVersionsHaveSameOrder(String v1, String v2) {
ComparableVersion c1 = new ComparableVersion(v1);
ComparableVersion c2 = new ComparableVersion(v2);
- assertEquals(0, c1.compareTo(c2), "expected " + v1 + " == " + v2);
- assertEquals(0, c2.compareTo(c1), "expected " + v2 + " == " + v1);
+ assertThat(c1.compareTo(c2)).as("expected " + v1 + " == " + v2).isEqualTo(0);
+ assertThat(c2.compareTo(c1)).as("expected " + v2 + " == " + v1).isEqualTo(0);
}
private void checkVersionsArrayEqual(String[] array) {
@@ -118,22 +114,22 @@ private void checkVersionsArrayEqual(String[] array) {
private void checkVersionsOrder(String v1, String v2) {
Comparable c1 = newComparable(v1);
Comparable c2 = newComparable(v2);
- assertTrue(c1.compareTo(c2) < 0, "expected " + v1 + " < " + v2);
- assertTrue(c2.compareTo(c1) > 0, "expected " + v2 + " > " + v1);
+ assertThat(c1.compareTo(c2) < 0).as("expected " + v1 + " < " + v2).isTrue();
+ assertThat(c2.compareTo(c1) > 0).as("expected " + v2 + " > " + v1).isTrue();
}
@Test
- void testVersionsQualifier() {
+ void versionsQualifier() {
checkVersionsOrder(VERSIONS_QUALIFIER);
}
@Test
- void testVersionsNumber() {
+ void versionsNumber() {
checkVersionsOrder(VERSIONS_NUMBER);
}
@Test
- void testVersionsEqual() {
+ void versionsEqual() {
newComparable("1.0-alpha");
checkVersionsEqual("1", "1");
checkVersionsEqual("1", "1.0");
@@ -173,7 +169,7 @@ void testVersionsEqual() {
}
@Test
- void testVersionsHaveSameOrderButAreNotEqual() {
+ void versionsHaveSameOrderButAreNotEqual() {
checkVersionsHaveSameOrder("1ga", "1");
checkVersionsHaveSameOrder("1release", "1");
checkVersionsHaveSameOrder("1final", "1");
@@ -188,7 +184,7 @@ void testVersionsHaveSameOrderButAreNotEqual() {
}
@Test
- void testVersionComparing() {
+ void versionComparing() {
checkVersionsOrder("1", "2");
checkVersionsOrder("1.5", "2");
checkVersionsOrder("1", "2.5");
@@ -219,30 +215,30 @@ void testVersionComparing() {
}
@Test
- void testLeadingZeroes() {
+ void leadingZeroes() {
checkVersionsOrder("0.7", "2");
checkVersionsOrder("0.2", "1.0.7");
}
@Test
- void testDigitGreaterThanNonAscii() {
+ void digitGreaterThanNonAscii() {
ComparableVersion c1 = new ComparableVersion("1");
ComparableVersion c2 = new ComparableVersion("é");
- assertTrue(c1.compareTo(c2) > 0, "expected " + "1" + " > " + "\uD835\uDFE4");
- assertTrue(c2.compareTo(c1) < 0, "expected " + "\uD835\uDFE4" + " < " + "1");
+ assertThat(c1.compareTo(c2) > 0).as("expected " + "1" + " > " + "\uD835\uDFE4").isTrue();
+ assertThat(c2.compareTo(c1) < 0).as("expected " + "\uD835\uDFE4" + " < " + "1").isTrue();
}
@Test
- void testDigitGreaterThanNonBmpCharacters() {
+ void digitGreaterThanNonBmpCharacters() {
ComparableVersion c1 = new ComparableVersion("1");
// MATHEMATICAL SANS-SERIF DIGIT TWO
ComparableVersion c2 = new ComparableVersion("\uD835\uDFE4");
- assertTrue(c1.compareTo(c2) > 0, "expected " + "1" + " > " + "\uD835\uDFE4");
- assertTrue(c2.compareTo(c1) < 0, "expected " + "\uD835\uDFE4" + " < " + "1");
+ assertThat(c1.compareTo(c2) > 0).as("expected " + "1" + " > " + "\uD835\uDFE4").isTrue();
+ assertThat(c2.compareTo(c1) < 0).as("expected " + "\uD835\uDFE4" + " < " + "1").isTrue();
}
@Test
- void testGetCanonical() {
+ void getCanonical() {
// MNG-7700
newComparable("0.x");
newComparable("0-x");
@@ -250,73 +246,73 @@ void testGetCanonical() {
newComparable("0-1");
ComparableVersion version = new ComparableVersion("0.x");
- assertEquals("x", version.getCanonical());
+ assertThat(version.getCanonical()).isEqualTo("x");
ComparableVersion version2 = new ComparableVersion("0.2");
- assertEquals("0.2", version2.getCanonical());
+ assertThat(version2.getCanonical()).isEqualTo("0.2");
}
@Test
- void testLexicographicASCIISortOrder() { // Required by Semver 1.0
+ void lexicographicASCIISortOrder() { // Required by Semver 1.0
ComparableVersion lower = new ComparableVersion("1.0.0-alpha1");
ComparableVersion upper = new ComparableVersion("1.0.0-ALPHA1");
// Lower case is equal to upper case. This is *NOT* what Semver 1.0
// specifies. Here we are explicitly deviating from Semver 1.0.
- assertTrue(upper.compareTo(lower) == 0, "expected 1.0.0-ALPHA1 == 1.0.0-alpha1");
- assertTrue(lower.compareTo(upper) == 0, "expected 1.0.0-alpha1 == 1.0.0-ALPHA1");
+ assertThat(upper.compareTo(lower)).as("expected 1.0.0-ALPHA1 == 1.0.0-alpha1").isEqualTo(0);
+ assertThat(lower.compareTo(upper)).as("expected 1.0.0-alpha1 == 1.0.0-ALPHA1").isEqualTo(0);
}
@Test
- void testCompareLowerCaseToUpperCaseASCII() {
+ void compareLowerCaseToUpperCaseASCII() {
ComparableVersion lower = new ComparableVersion("1.a");
ComparableVersion upper = new ComparableVersion("1.A");
// Lower case is equal to upper case
- assertTrue(upper.compareTo(lower) == 0, "expected 1.A == 1.a");
- assertTrue(lower.compareTo(upper) == 0, "expected 1.a == 1.A");
+ assertThat(upper.compareTo(lower)).as("expected 1.A == 1.a").isEqualTo(0);
+ assertThat(lower.compareTo(upper)).as("expected 1.a == 1.A").isEqualTo(0);
}
@Test
- void testCompareLowerCaseToUpperCaseNonASCII() {
+ void compareLowerCaseToUpperCaseNonASCII() {
ComparableVersion lower = new ComparableVersion("1.é");
ComparableVersion upper = new ComparableVersion("1.É");
// Lower case is equal to upper case
- assertTrue(upper.compareTo(lower) == 0, "expected 1.É < 1.é");
- assertTrue(lower.compareTo(upper) == 0, "expected 1.é > 1.É");
+ assertThat(upper.compareTo(lower)).as("expected 1.É < 1.é").isEqualTo(0);
+ assertThat(lower.compareTo(upper)).as("expected 1.é > 1.É").isEqualTo(0);
}
@Test
- void testCompareDigitToLetter() {
+ void compareDigitToLetter() {
ComparableVersion seven = new ComparableVersion("7");
ComparableVersion capitalJ = new ComparableVersion("J");
ComparableVersion lowerCaseC = new ComparableVersion("c");
// Digits are greater than letters
- assertTrue(seven.compareTo(capitalJ) > 0, "expected 7 > J");
- assertTrue(capitalJ.compareTo(seven) < 0, "expected J < 1");
- assertTrue(seven.compareTo(lowerCaseC) > 0, "expected 7 > c");
- assertTrue(lowerCaseC.compareTo(seven) < 0, "expected c < 7");
+ assertThat(seven.compareTo(capitalJ) > 0).as("expected 7 > J").isTrue();
+ assertThat(capitalJ.compareTo(seven) < 0).as("expected J < 1").isTrue();
+ assertThat(seven.compareTo(lowerCaseC) > 0).as("expected 7 > c").isTrue();
+ assertThat(lowerCaseC.compareTo(seven) < 0).as("expected c < 7").isTrue();
}
@Test
- void testNonAsciiDigits() { // These should not be treated as digits.
+ void nonAsciiDigits() { // These should not be treated as digits.
ComparableVersion asciiOne = new ComparableVersion("1");
ComparableVersion arabicEight = new ComparableVersion("\u0668");
ComparableVersion asciiNine = new ComparableVersion("9");
- assertTrue(asciiOne.compareTo(arabicEight) > 0, "expected " + "1" + " > " + "\u0668");
- assertTrue(arabicEight.compareTo(asciiOne) < 0, "expected " + "\u0668" + " < " + "1");
- assertTrue(asciiNine.compareTo(arabicEight) > 0, "expected " + "9" + " > " + "\u0668");
- assertTrue(arabicEight.compareTo(asciiNine) < 0, "expected " + "\u0668" + " < " + "9");
+ assertThat(asciiOne.compareTo(arabicEight) > 0).as("expected " + "1" + " > " + "\u0668").isTrue();
+ assertThat(arabicEight.compareTo(asciiOne) < 0).as("expected " + "\u0668" + " < " + "1").isTrue();
+ assertThat(asciiNine.compareTo(arabicEight) > 0).as("expected " + "9" + " > " + "\u0668").isTrue();
+ assertThat(arabicEight.compareTo(asciiNine) < 0).as("expected " + "\u0668" + " < " + "9").isTrue();
}
@Test
- void testLexicographicOrder() {
+ void lexicographicOrder() {
ComparableVersion aardvark = new ComparableVersion("aardvark");
ComparableVersion zebra = new ComparableVersion("zebra");
- assertTrue(zebra.compareTo(aardvark) > 0);
- assertTrue(aardvark.compareTo(zebra) < 0);
+ assertThat(zebra.compareTo(aardvark) > 0).isTrue();
+ assertThat(aardvark.compareTo(zebra) < 0).isTrue();
// Greek zebra
ComparableVersion greek = new ComparableVersion("ζέβρα");
- assertTrue(greek.compareTo(zebra) > 0);
- assertTrue(zebra.compareTo(greek) < 0);
+ assertThat(greek.compareTo(zebra) > 0).isTrue();
+ assertThat(zebra.compareTo(greek) < 0).isTrue();
}
/**
@@ -327,7 +323,7 @@ void testLexicographicOrder() {
* 226100
*/
@Test
- void testMng5568() {
+ void mng5568() {
String a = "6.1.0";
String b = "6.1.0rc3";
String c = "6.1H.5-beta"; // this is the unusual version string, with 'H' in the middle
@@ -341,7 +337,7 @@ void testMng5568() {
* Test MNG-6572 optimization.
*/
@Test
- void testMng6572() {
+ void mng6572() {
String a = "20190126.230843"; // resembles a SNAPSHOT
String b = "1234567890.12345"; // 10 digit number
String c = "123456789012345.1H.5-beta"; // 15 digit number
@@ -360,7 +356,7 @@ void testMng6572() {
* (related to MNG-6572 optimization)
*/
@Test
- void testVersionEqualWithLeadingZeroes() {
+ void versionEqualWithLeadingZeroes() {
// versions with string lengths from 1 to 19
String[] arr = new String[] {
"0000000000000000001",
@@ -392,7 +388,7 @@ void testVersionEqualWithLeadingZeroes() {
* (related to MNG-6572 optimization)
*/
@Test
- void testVersionZeroEqualWithLeadingZeroes() {
+ void versionZeroEqualWithLeadingZeroes() {
// versions with string lengths from 1 to 19
String[] arr = new String[] {
"0000000000000000000",
@@ -424,7 +420,7 @@ void testVersionZeroEqualWithLeadingZeroes() {
* for qualifiers that start with "-0.", which was showing A == C and B == C but A < B.
*/
@Test
- void testMng6964() {
+ void mng6964() {
String a = "1-0.alpha";
String b = "1-0.beta";
String c = "1";
@@ -435,7 +431,7 @@ void testMng6964() {
}
@Test
- void testLocaleIndependent() {
+ void localeIndependent() {
Locale orig = Locale.getDefault();
Locale[] locales = {Locale.ENGLISH, new Locale("tr"), Locale.getDefault()};
try {
@@ -449,13 +445,13 @@ void testLocaleIndependent() {
}
@Test
- void testReuse() {
+ void reuse() {
ComparableVersion c1 = new ComparableVersion("1");
c1.parseVersion("2");
Comparable> c2 = newComparable("2");
- assertEquals(c1, c2, "reused instance should be equivalent to new instance");
+ assertThat(c2).as("reused instance should be equivalent to new instance").isEqualTo(c1);
}
/**
@@ -464,7 +460,7 @@ void testReuse() {
* 1.0.0.X1 < 1.0.0-X2 for any string X
*/
@Test
- void testMng7644() {
+ void mng7644() {
for (String x : new String[] {"abc", "alpha", "a", "beta", "b", "def", "milestone", "m", "RC"}) {
// 1.0.0.X1 < 1.0.0-X2 for any string x
checkVersionsOrder("1.0.0." + x + "1", "1.0.0-" + x + "2");
@@ -476,13 +472,13 @@ void testMng7644() {
}
@Test
- public void testMng7714() {
+ void mng7714() {
ComparableVersion f = new ComparableVersion("1.0.final-redhat");
ComparableVersion sp1 = new ComparableVersion("1.0-sp1-redhat");
ComparableVersion sp2 = new ComparableVersion("1.0-sp-1-redhat");
ComparableVersion sp3 = new ComparableVersion("1.0-sp.1-redhat");
- assertTrue(f.compareTo(sp1) < 0, "expected " + f + " < " + sp1);
- assertTrue(f.compareTo(sp2) < 0, "expected " + f + " < " + sp2);
- assertTrue(f.compareTo(sp3) < 0, "expected " + f + " < " + sp3);
+ assertThat(f.compareTo(sp1) < 0).as("expected " + f + " < " + sp1).isTrue();
+ assertThat(f.compareTo(sp2) < 0).as("expected " + f + " < " + sp2).isTrue();
+ assertThat(f.compareTo(sp3) < 0).as("expected " + f + " < " + sp3).isTrue();
}
}
diff --git a/compat/maven-artifact/src/test/java/org/apache/maven/artifact/versioning/DefaultArtifactVersionTest.java b/compat/maven-artifact/src/test/java/org/apache/maven/artifact/versioning/DefaultArtifactVersionTest.java
index 370b0f0c5cc3..7ed25d03bfe4 100644
--- a/compat/maven-artifact/src/test/java/org/apache/maven/artifact/versioning/DefaultArtifactVersionTest.java
+++ b/compat/maven-artifact/src/test/java/org/apache/maven/artifact/versioning/DefaultArtifactVersionTest.java
@@ -20,9 +20,7 @@
import org.junit.jupiter.api.Test;
-import static org.junit.jupiter.api.Assertions.assertEquals;
-import static org.junit.jupiter.api.Assertions.assertFalse;
-import static org.junit.jupiter.api.Assertions.assertTrue;
+import static org.assertj.core.api.Assertions.assertThat;
/**
* Test DefaultArtifactVersion.
@@ -39,16 +37,16 @@ private void checkVersionParsing(
String parsed = "'" + version + "' parsed as ('" + artifactVersion.getMajorVersion() + "', '"
+ artifactVersion.getMinorVersion() + "', '" + artifactVersion.getIncrementalVersion() + "', '"
+ artifactVersion.getBuildNumber() + "', '" + artifactVersion.getQualifier() + "'), ";
- assertEquals(major, artifactVersion.getMajorVersion(), parsed + "check major version");
- assertEquals(minor, artifactVersion.getMinorVersion(), parsed + "check minor version");
- assertEquals(incremental, artifactVersion.getIncrementalVersion(), parsed + "check incremental version");
- assertEquals(buildnumber, artifactVersion.getBuildNumber(), parsed + "check build number");
- assertEquals(qualifier, artifactVersion.getQualifier(), parsed + "check qualifier");
- assertEquals(version, artifactVersion.toString(), "check " + version + " string value");
+ assertThat(artifactVersion.getMajorVersion()).as(parsed + "check major version").isEqualTo(major);
+ assertThat(artifactVersion.getMinorVersion()).as(parsed + "check minor version").isEqualTo(minor);
+ assertThat(artifactVersion.getIncrementalVersion()).as(parsed + "check incremental version").isEqualTo(incremental);
+ assertThat(artifactVersion.getBuildNumber()).as(parsed + "check build number").isEqualTo(buildnumber);
+ assertThat(artifactVersion.getQualifier()).as(parsed + "check qualifier").isEqualTo(qualifier);
+ assertThat(artifactVersion.toString()).as("check " + version + " string value").isEqualTo(version);
}
@Test
- void testVersionParsing() {
+ void versionParsing() {
checkVersionParsing("1", 1, 0, 0, 0, null);
checkVersionParsing("1.2", 1, 2, 0, 0, null);
checkVersionParsing("1.2.3", 1, 2, 3, 0, null);
@@ -85,7 +83,7 @@ void testVersionParsing() {
}
@Test
- void testVersionComparing() {
+ void versionComparing() {
assertVersionEqual("1", "1");
assertVersionOlder("1", "2");
assertVersionOlder("1.5", "2");
@@ -132,7 +130,7 @@ void testVersionComparing() {
}
@Test
- void testVersionSnapshotComparing() {
+ void versionSnapshotComparing() {
assertVersionEqual("1-SNAPSHOT", "1-SNAPSHOT");
assertVersionOlder("1-SNAPSHOT", "2-SNAPSHOT");
assertVersionOlder("1.5-SNAPSHOT", "2-SNAPSHOT");
@@ -166,7 +164,7 @@ void testVersionSnapshotComparing() {
}
@Test
- void testSnapshotVsReleases() {
+ void snapshotVsReleases() {
assertVersionOlder("1.0-RC1", "1.0-SNAPSHOT");
assertVersionOlder("1.0-rc1", "1.0-SNAPSHOT");
assertVersionOlder("1.0-rc-1", "1.0-SNAPSHOT");
@@ -176,35 +174,27 @@ void testSnapshotVsReleases() {
void testHashCode() {
ArtifactVersion v1 = newArtifactVersion("1");
ArtifactVersion v2 = newArtifactVersion("1.0");
- assertTrue(v1.equals(v2));
- assertEquals(v1.hashCode(), v2.hashCode());
+ assertThat(v2).isEqualTo(v1);
+ assertThat(v2.hashCode()).isEqualTo(v1.hashCode());
}
@Test
- void testEqualsNullSafe() {
- assertFalse(newArtifactVersion("1").equals(null));
+ void equalsNullSafe() {
+ assertThat(newArtifactVersion("1")).isNotEqualTo(null);
}
@Test
- void testEqualsTypeSafe() {
- assertFalse(newArtifactVersion("1").equals("non-an-artifact-version-instance"));
+ void equalsTypeSafe() {
+ assertThat(newArtifactVersion("1")).isNotEqualTo("non-an-artifact-version-instance");
}
private void assertVersionOlder(String left, String right) {
- assertTrue(
- newArtifactVersion(left).compareTo(newArtifactVersion(right)) < 0,
- left + " should be older than " + right);
- assertTrue(
- newArtifactVersion(right).compareTo(newArtifactVersion(left)) > 0,
- right + " should be newer than " + left);
+ assertThat(newArtifactVersion(left).compareTo(newArtifactVersion(right)) < 0).as(left + " should be older than " + right).isTrue();
+ assertThat(newArtifactVersion(right).compareTo(newArtifactVersion(left)) > 0).as(right + " should be newer than " + left).isTrue();
}
private void assertVersionEqual(String left, String right) {
- assertTrue(
- newArtifactVersion(left).compareTo(newArtifactVersion(right)) == 0,
- left + " should be equal to " + right);
- assertTrue(
- newArtifactVersion(right).compareTo(newArtifactVersion(left)) == 0,
- right + " should be equal to " + left);
+ assertThat(newArtifactVersion(left).compareTo(newArtifactVersion(right))).as(left + " should be equal to " + right).isEqualTo(0);
+ assertThat(newArtifactVersion(right).compareTo(newArtifactVersion(left))).as(right + " should be equal to " + left).isEqualTo(0);
}
}
diff --git a/compat/maven-artifact/src/test/java/org/apache/maven/artifact/versioning/VersionRangeTest.java b/compat/maven-artifact/src/test/java/org/apache/maven/artifact/versioning/VersionRangeTest.java
index 8ccf5bcca4f2..49886fcecbdd 100644
--- a/compat/maven-artifact/src/test/java/org/apache/maven/artifact/versioning/VersionRangeTest.java
+++ b/compat/maven-artifact/src/test/java/org/apache/maven/artifact/versioning/VersionRangeTest.java
@@ -23,12 +23,8 @@
import org.apache.maven.artifact.Artifact;
import org.junit.jupiter.api.Test;
-import static org.junit.jupiter.api.Assertions.assertEquals;
-import static org.junit.jupiter.api.Assertions.assertFalse;
-import static org.junit.jupiter.api.Assertions.assertNull;
-import static org.junit.jupiter.api.Assertions.assertSame;
-import static org.junit.jupiter.api.Assertions.assertThrows;
-import static org.junit.jupiter.api.Assertions.assertTrue;
+import static org.assertj.core.api.Assertions.assertThat;
+import static org.assertj.core.api.AssertionsForClassTypes.assertThatExceptionOfType;
/**
* Tests version range construction.
@@ -52,118 +48,118 @@ class VersionRangeTest {
private static final String CHECK_SELECTED_VERSION = "check selected version";
@Test
- void testRange() throws InvalidVersionSpecificationException, OverConstrainedVersionException {
+ void range() throws InvalidVersionSpecificationException, OverConstrainedVersionException {
Artifact artifact = null;
VersionRange range = VersionRange.createFromVersionSpec("(,1.0]");
List restrictions = range.getRestrictions();
- assertEquals(1, restrictions.size(), CHECK_NUM_RESTRICTIONS);
+ assertThat(restrictions.size()).as(CHECK_NUM_RESTRICTIONS).isEqualTo(1);
Restriction restriction = restrictions.get(0);
- assertNull(restriction.getLowerBound(), CHECK_LOWER_BOUND);
- assertFalse(restriction.isLowerBoundInclusive(), CHECK_LOWER_BOUND_INCLUSIVE);
- assertEquals("1.0", restriction.getUpperBound().toString(), CHECK_UPPER_BOUND);
- assertTrue(restriction.isUpperBoundInclusive(), CHECK_UPPER_BOUND_INCLUSIVE);
- assertNull(range.getRecommendedVersion(), CHECK_VERSION_RECOMMENDATION);
- assertFalse(range.isSelectedVersionKnown(artifact), CHECK_SELECTED_VERSION_KNOWN);
- assertNull(range.getSelectedVersion(artifact), CHECK_SELECTED_VERSION);
+ assertThat(restriction.getLowerBound()).as(CHECK_LOWER_BOUND).isNull();
+ assertThat(restriction.isLowerBoundInclusive()).as(CHECK_LOWER_BOUND_INCLUSIVE).isFalse();
+ assertThat(restriction.getUpperBound().toString()).as(CHECK_UPPER_BOUND).isEqualTo("1.0");
+ assertThat(restriction.isUpperBoundInclusive()).as(CHECK_UPPER_BOUND_INCLUSIVE).isTrue();
+ assertThat(range.getRecommendedVersion()).as(CHECK_VERSION_RECOMMENDATION).isNull();
+ assertThat(range.isSelectedVersionKnown(artifact)).as(CHECK_SELECTED_VERSION_KNOWN).isFalse();
+ assertThat(range.getSelectedVersion(artifact)).as(CHECK_SELECTED_VERSION).isNull();
range = VersionRange.createFromVersionSpec("1.0");
- assertEquals("1.0", range.getRecommendedVersion().toString(), CHECK_VERSION_RECOMMENDATION);
+ assertThat(range.getRecommendedVersion().toString()).as(CHECK_VERSION_RECOMMENDATION).isEqualTo("1.0");
restrictions = range.getRestrictions();
- assertEquals(1, restrictions.size(), CHECK_NUM_RESTRICTIONS);
+ assertThat(restrictions.size()).as(CHECK_NUM_RESTRICTIONS).isEqualTo(1);
restriction = restrictions.get(0);
- assertNull(restriction.getLowerBound(), CHECK_LOWER_BOUND);
- assertFalse(restriction.isLowerBoundInclusive(), CHECK_LOWER_BOUND_INCLUSIVE);
- assertNull(restriction.getUpperBound(), CHECK_UPPER_BOUND);
- assertFalse(restriction.isUpperBoundInclusive(), CHECK_UPPER_BOUND_INCLUSIVE);
- assertTrue(range.isSelectedVersionKnown(artifact), CHECK_SELECTED_VERSION_KNOWN);
- assertEquals("1.0", range.getSelectedVersion(artifact).toString(), CHECK_SELECTED_VERSION);
+ assertThat(restriction.getLowerBound()).as(CHECK_LOWER_BOUND).isNull();
+ assertThat(restriction.isLowerBoundInclusive()).as(CHECK_LOWER_BOUND_INCLUSIVE).isFalse();
+ assertThat(restriction.getUpperBound()).as(CHECK_UPPER_BOUND).isNull();
+ assertThat(restriction.isUpperBoundInclusive()).as(CHECK_UPPER_BOUND_INCLUSIVE).isFalse();
+ assertThat(range.isSelectedVersionKnown(artifact)).as(CHECK_SELECTED_VERSION_KNOWN).isTrue();
+ assertThat(range.getSelectedVersion(artifact).toString()).as(CHECK_SELECTED_VERSION).isEqualTo("1.0");
range = VersionRange.createFromVersionSpec("[1.0]");
restrictions = range.getRestrictions();
- assertEquals(1, restrictions.size(), CHECK_NUM_RESTRICTIONS);
+ assertThat(restrictions.size()).as(CHECK_NUM_RESTRICTIONS).isEqualTo(1);
restriction = restrictions.get(0);
- assertEquals("1.0", restriction.getLowerBound().toString(), CHECK_LOWER_BOUND);
- assertTrue(restriction.isLowerBoundInclusive(), CHECK_LOWER_BOUND_INCLUSIVE);
- assertEquals("1.0", restriction.getUpperBound().toString(), CHECK_UPPER_BOUND);
- assertTrue(restriction.isUpperBoundInclusive(), CHECK_UPPER_BOUND_INCLUSIVE);
- assertNull(range.getRecommendedVersion(), CHECK_VERSION_RECOMMENDATION);
- assertFalse(range.isSelectedVersionKnown(artifact), CHECK_SELECTED_VERSION_KNOWN);
- assertNull(range.getSelectedVersion(artifact), CHECK_SELECTED_VERSION);
+ assertThat(restriction.getLowerBound().toString()).as(CHECK_LOWER_BOUND).isEqualTo("1.0");
+ assertThat(restriction.isLowerBoundInclusive()).as(CHECK_LOWER_BOUND_INCLUSIVE).isTrue();
+ assertThat(restriction.getUpperBound().toString()).as(CHECK_UPPER_BOUND).isEqualTo("1.0");
+ assertThat(restriction.isUpperBoundInclusive()).as(CHECK_UPPER_BOUND_INCLUSIVE).isTrue();
+ assertThat(range.getRecommendedVersion()).as(CHECK_VERSION_RECOMMENDATION).isNull();
+ assertThat(range.isSelectedVersionKnown(artifact)).as(CHECK_SELECTED_VERSION_KNOWN).isFalse();
+ assertThat(range.getSelectedVersion(artifact)).as(CHECK_SELECTED_VERSION).isNull();
range = VersionRange.createFromVersionSpec("[1.2,1.3]");
restrictions = range.getRestrictions();
- assertEquals(1, restrictions.size(), CHECK_NUM_RESTRICTIONS);
+ assertThat(restrictions.size()).as(CHECK_NUM_RESTRICTIONS).isEqualTo(1);
restriction = restrictions.get(0);
- assertEquals("1.2", restriction.getLowerBound().toString(), CHECK_LOWER_BOUND);
- assertTrue(restriction.isLowerBoundInclusive(), CHECK_LOWER_BOUND_INCLUSIVE);
- assertEquals("1.3", restriction.getUpperBound().toString(), CHECK_UPPER_BOUND);
- assertTrue(restriction.isUpperBoundInclusive(), CHECK_UPPER_BOUND_INCLUSIVE);
- assertNull(range.getRecommendedVersion(), CHECK_VERSION_RECOMMENDATION);
- assertFalse(range.isSelectedVersionKnown(artifact), CHECK_SELECTED_VERSION_KNOWN);
- assertNull(range.getSelectedVersion(artifact), CHECK_SELECTED_VERSION);
+ assertThat(restriction.getLowerBound().toString()).as(CHECK_LOWER_BOUND).isEqualTo("1.2");
+ assertThat(restriction.isLowerBoundInclusive()).as(CHECK_LOWER_BOUND_INCLUSIVE).isTrue();
+ assertThat(restriction.getUpperBound().toString()).as(CHECK_UPPER_BOUND).isEqualTo("1.3");
+ assertThat(restriction.isUpperBoundInclusive()).as(CHECK_UPPER_BOUND_INCLUSIVE).isTrue();
+ assertThat(range.getRecommendedVersion()).as(CHECK_VERSION_RECOMMENDATION).isNull();
+ assertThat(range.isSelectedVersionKnown(artifact)).as(CHECK_SELECTED_VERSION_KNOWN).isFalse();
+ assertThat(range.getSelectedVersion(artifact)).as(CHECK_SELECTED_VERSION).isNull();
range = VersionRange.createFromVersionSpec("[1.0,2.0)");
restrictions = range.getRestrictions();
- assertEquals(1, restrictions.size(), CHECK_NUM_RESTRICTIONS);
+ assertThat(restrictions.size()).as(CHECK_NUM_RESTRICTIONS).isEqualTo(1);
restriction = restrictions.get(0);
- assertEquals("1.0", restriction.getLowerBound().toString(), CHECK_LOWER_BOUND);
- assertTrue(restriction.isLowerBoundInclusive(), CHECK_LOWER_BOUND_INCLUSIVE);
- assertEquals("2.0", restriction.getUpperBound().toString(), CHECK_UPPER_BOUND);
- assertFalse(restriction.isUpperBoundInclusive(), CHECK_UPPER_BOUND_INCLUSIVE);
- assertNull(range.getRecommendedVersion(), CHECK_VERSION_RECOMMENDATION);
- assertFalse(range.isSelectedVersionKnown(artifact), CHECK_SELECTED_VERSION_KNOWN);
- assertNull(range.getSelectedVersion(artifact), CHECK_SELECTED_VERSION);
+ assertThat(restriction.getLowerBound().toString()).as(CHECK_LOWER_BOUND).isEqualTo("1.0");
+ assertThat(restriction.isLowerBoundInclusive()).as(CHECK_LOWER_BOUND_INCLUSIVE).isTrue();
+ assertThat(restriction.getUpperBound().toString()).as(CHECK_UPPER_BOUND).isEqualTo("2.0");
+ assertThat(restriction.isUpperBoundInclusive()).as(CHECK_UPPER_BOUND_INCLUSIVE).isFalse();
+ assertThat(range.getRecommendedVersion()).as(CHECK_VERSION_RECOMMENDATION).isNull();
+ assertThat(range.isSelectedVersionKnown(artifact)).as(CHECK_SELECTED_VERSION_KNOWN).isFalse();
+ assertThat(range.getSelectedVersion(artifact)).as(CHECK_SELECTED_VERSION).isNull();
range = VersionRange.createFromVersionSpec("[1.5,)");
restrictions = range.getRestrictions();
- assertEquals(1, restrictions.size(), CHECK_NUM_RESTRICTIONS);
+ assertThat(restrictions.size()).as(CHECK_NUM_RESTRICTIONS).isEqualTo(1);
restriction = restrictions.get(0);
- assertEquals("1.5", restriction.getLowerBound().toString(), CHECK_LOWER_BOUND);
- assertTrue(restriction.isLowerBoundInclusive(), CHECK_LOWER_BOUND_INCLUSIVE);
- assertNull(restriction.getUpperBound(), CHECK_UPPER_BOUND);
- assertFalse(restriction.isUpperBoundInclusive(), CHECK_UPPER_BOUND_INCLUSIVE);
- assertNull(range.getRecommendedVersion(), CHECK_VERSION_RECOMMENDATION);
- assertFalse(range.isSelectedVersionKnown(artifact), CHECK_SELECTED_VERSION_KNOWN);
- assertNull(range.getSelectedVersion(artifact), CHECK_SELECTED_VERSION);
+ assertThat(restriction.getLowerBound().toString()).as(CHECK_LOWER_BOUND).isEqualTo("1.5");
+ assertThat(restriction.isLowerBoundInclusive()).as(CHECK_LOWER_BOUND_INCLUSIVE).isTrue();
+ assertThat(restriction.getUpperBound()).as(CHECK_UPPER_BOUND).isNull();
+ assertThat(restriction.isUpperBoundInclusive()).as(CHECK_UPPER_BOUND_INCLUSIVE).isFalse();
+ assertThat(range.getRecommendedVersion()).as(CHECK_VERSION_RECOMMENDATION).isNull();
+ assertThat(range.isSelectedVersionKnown(artifact)).as(CHECK_SELECTED_VERSION_KNOWN).isFalse();
+ assertThat(range.getSelectedVersion(artifact)).as(CHECK_SELECTED_VERSION).isNull();
range = VersionRange.createFromVersionSpec("(,1.0],[1.2,)");
restrictions = range.getRestrictions();
- assertEquals(2, restrictions.size(), CHECK_NUM_RESTRICTIONS);
+ assertThat(restrictions.size()).as(CHECK_NUM_RESTRICTIONS).isEqualTo(2);
restriction = restrictions.get(0);
- assertNull(restriction.getLowerBound(), CHECK_LOWER_BOUND);
- assertFalse(restriction.isLowerBoundInclusive(), CHECK_LOWER_BOUND_INCLUSIVE);
- assertEquals("1.0", restriction.getUpperBound().toString(), CHECK_UPPER_BOUND);
- assertTrue(restriction.isUpperBoundInclusive(), CHECK_UPPER_BOUND_INCLUSIVE);
- assertNull(range.getRecommendedVersion(), CHECK_VERSION_RECOMMENDATION);
+ assertThat(restriction.getLowerBound()).as(CHECK_LOWER_BOUND).isNull();
+ assertThat(restriction.isLowerBoundInclusive()).as(CHECK_LOWER_BOUND_INCLUSIVE).isFalse();
+ assertThat(restriction.getUpperBound().toString()).as(CHECK_UPPER_BOUND).isEqualTo("1.0");
+ assertThat(restriction.isUpperBoundInclusive()).as(CHECK_UPPER_BOUND_INCLUSIVE).isTrue();
+ assertThat(range.getRecommendedVersion()).as(CHECK_VERSION_RECOMMENDATION).isNull();
restriction = restrictions.get(1);
- assertEquals("1.2", restriction.getLowerBound().toString(), CHECK_LOWER_BOUND);
- assertTrue(restriction.isLowerBoundInclusive(), CHECK_LOWER_BOUND_INCLUSIVE);
- assertNull(restriction.getUpperBound(), CHECK_UPPER_BOUND);
- assertFalse(restriction.isUpperBoundInclusive(), CHECK_UPPER_BOUND_INCLUSIVE);
- assertNull(range.getRecommendedVersion(), CHECK_VERSION_RECOMMENDATION);
- assertFalse(range.isSelectedVersionKnown(artifact), CHECK_SELECTED_VERSION_KNOWN);
- assertNull(range.getSelectedVersion(artifact), CHECK_SELECTED_VERSION);
+ assertThat(restriction.getLowerBound().toString()).as(CHECK_LOWER_BOUND).isEqualTo("1.2");
+ assertThat(restriction.isLowerBoundInclusive()).as(CHECK_LOWER_BOUND_INCLUSIVE).isTrue();
+ assertThat(restriction.getUpperBound()).as(CHECK_UPPER_BOUND).isNull();
+ assertThat(restriction.isUpperBoundInclusive()).as(CHECK_UPPER_BOUND_INCLUSIVE).isFalse();
+ assertThat(range.getRecommendedVersion()).as(CHECK_VERSION_RECOMMENDATION).isNull();
+ assertThat(range.isSelectedVersionKnown(artifact)).as(CHECK_SELECTED_VERSION_KNOWN).isFalse();
+ assertThat(range.getSelectedVersion(artifact)).as(CHECK_SELECTED_VERSION).isNull();
range = VersionRange.createFromVersionSpec("[1.0,)");
- assertFalse(range.containsVersion(new DefaultArtifactVersion("1.0-SNAPSHOT")));
+ assertThat(range.containsVersion(new DefaultArtifactVersion("1.0-SNAPSHOT"))).isFalse();
range = VersionRange.createFromVersionSpec("[1.0,1.1-SNAPSHOT]");
- assertTrue(range.containsVersion(new DefaultArtifactVersion("1.1-SNAPSHOT")));
+ assertThat(range.containsVersion(new DefaultArtifactVersion("1.1-SNAPSHOT"))).isTrue();
range = VersionRange.createFromVersionSpec("[5.0.9.0,5.0.10.0)");
- assertTrue(range.containsVersion(new DefaultArtifactVersion("5.0.9.0")));
+ assertThat(range.containsVersion(new DefaultArtifactVersion("5.0.9.0"))).isTrue();
}
@Test
- void testSameUpperAndLowerBoundRoundtrip() throws InvalidVersionSpecificationException {
+ void sameUpperAndLowerBoundRoundtrip() throws InvalidVersionSpecificationException {
VersionRange range = VersionRange.createFromVersionSpec("[1.0]");
VersionRange range2 = VersionRange.createFromVersionSpec(range.toString());
- assertEquals(range, range2);
+ assertThat(range2).isEqualTo(range);
}
@Test
- void testInvalidRanges() {
+ void invalidRanges() {
checkInvalidRange("(1.0)");
checkInvalidRange("[1.0)");
checkInvalidRange("(1.0]");
@@ -182,535 +178,532 @@ void testInvalidRanges() {
@Test
@SuppressWarnings("checkstyle:MethodLength")
- void testIntersections() throws InvalidVersionSpecificationException {
+ void intersections() throws InvalidVersionSpecificationException {
VersionRange range1 = VersionRange.createFromVersionSpec("1.0");
VersionRange range2 = VersionRange.createFromVersionSpec("1.1");
VersionRange mergedRange = range1.restrict(range2);
// TODO current policy is to retain the original version - is this correct, do we need strategies or is that
// handled elsewhere?
// assertEquals( "1.1", mergedRange.getRecommendedVersion().toString(), CHECK_VERSION_RECOMMENDATION );
- assertEquals("1.0", mergedRange.getRecommendedVersion().toString(), CHECK_VERSION_RECOMMENDATION);
+ assertThat(mergedRange.getRecommendedVersion().toString()).as(CHECK_VERSION_RECOMMENDATION).isEqualTo("1.0");
List restrictions = mergedRange.getRestrictions();
- assertEquals(1, restrictions.size(), CHECK_NUM_RESTRICTIONS);
+ assertThat(restrictions.size()).as(CHECK_NUM_RESTRICTIONS).isEqualTo(1);
Restriction restriction = restrictions.get(0);
- assertNull(restriction.getLowerBound(), CHECK_LOWER_BOUND);
- assertFalse(restriction.isLowerBoundInclusive(), CHECK_LOWER_BOUND_INCLUSIVE);
- assertNull(restriction.getUpperBound(), CHECK_UPPER_BOUND);
- assertFalse(restriction.isUpperBoundInclusive(), CHECK_UPPER_BOUND_INCLUSIVE);
+ assertThat(restriction.getLowerBound()).as(CHECK_LOWER_BOUND).isNull();
+ assertThat(restriction.isLowerBoundInclusive()).as(CHECK_LOWER_BOUND_INCLUSIVE).isFalse();
+ assertThat(restriction.getUpperBound()).as(CHECK_UPPER_BOUND).isNull();
+ assertThat(restriction.isUpperBoundInclusive()).as(CHECK_UPPER_BOUND_INCLUSIVE).isFalse();
mergedRange = range2.restrict(range1);
- assertEquals("1.1", mergedRange.getRecommendedVersion().toString(), CHECK_VERSION_RECOMMENDATION);
+ assertThat(mergedRange.getRecommendedVersion().toString()).as(CHECK_VERSION_RECOMMENDATION).isEqualTo("1.1");
restrictions = mergedRange.getRestrictions();
- assertEquals(1, restrictions.size(), CHECK_NUM_RESTRICTIONS);
+ assertThat(restrictions.size()).as(CHECK_NUM_RESTRICTIONS).isEqualTo(1);
restriction = restrictions.get(0);
- assertNull(restriction.getLowerBound(), CHECK_LOWER_BOUND);
- assertFalse(restriction.isLowerBoundInclusive(), CHECK_LOWER_BOUND_INCLUSIVE);
- assertNull(restriction.getUpperBound(), CHECK_UPPER_BOUND);
- assertFalse(restriction.isUpperBoundInclusive(), CHECK_UPPER_BOUND_INCLUSIVE);
+ assertThat(restriction.getLowerBound()).as(CHECK_LOWER_BOUND).isNull();
+ assertThat(restriction.isLowerBoundInclusive()).as(CHECK_LOWER_BOUND_INCLUSIVE).isFalse();
+ assertThat(restriction.getUpperBound()).as(CHECK_UPPER_BOUND).isNull();
+ assertThat(restriction.isUpperBoundInclusive()).as(CHECK_UPPER_BOUND_INCLUSIVE).isFalse();
// TODO test reversed restrictions on all below
range1 = VersionRange.createFromVersionSpec("[1.0,)");
range2 = VersionRange.createFromVersionSpec("1.1");
mergedRange = range1.restrict(range2);
- assertEquals("1.1", mergedRange.getRecommendedVersion().toString(), CHECK_VERSION_RECOMMENDATION);
+ assertThat(mergedRange.getRecommendedVersion().toString()).as(CHECK_VERSION_RECOMMENDATION).isEqualTo("1.1");
restrictions = mergedRange.getRestrictions();
- assertEquals(1, restrictions.size(), CHECK_NUM_RESTRICTIONS);
+ assertThat(restrictions.size()).as(CHECK_NUM_RESTRICTIONS).isEqualTo(1);
restriction = restrictions.get(0);
- assertEquals("1.0", restriction.getLowerBound().toString(), CHECK_LOWER_BOUND);
- assertTrue(restriction.isLowerBoundInclusive(), CHECK_LOWER_BOUND_INCLUSIVE);
- assertNull(restriction.getUpperBound(), CHECK_UPPER_BOUND);
- assertFalse(restriction.isUpperBoundInclusive(), CHECK_UPPER_BOUND_INCLUSIVE);
+ assertThat(restriction.getLowerBound().toString()).as(CHECK_LOWER_BOUND).isEqualTo("1.0");
+ assertThat(restriction.isLowerBoundInclusive()).as(CHECK_LOWER_BOUND_INCLUSIVE).isTrue();
+ assertThat(restriction.getUpperBound()).as(CHECK_UPPER_BOUND).isNull();
+ assertThat(restriction.isUpperBoundInclusive()).as(CHECK_UPPER_BOUND_INCLUSIVE).isFalse();
range1 = VersionRange.createFromVersionSpec("[1.1,)");
range2 = VersionRange.createFromVersionSpec("1.1");
mergedRange = range1.restrict(range2);
- assertEquals("1.1", mergedRange.getRecommendedVersion().toString(), CHECK_VERSION_RECOMMENDATION);
+ assertThat(mergedRange.getRecommendedVersion().toString()).as(CHECK_VERSION_RECOMMENDATION).isEqualTo("1.1");
restrictions = mergedRange.getRestrictions();
- assertEquals(1, restrictions.size(), CHECK_NUM_RESTRICTIONS);
+ assertThat(restrictions.size()).as(CHECK_NUM_RESTRICTIONS).isEqualTo(1);
restriction = restrictions.get(0);
- assertEquals("1.1", restriction.getLowerBound().toString(), CHECK_LOWER_BOUND);
- assertTrue(restriction.isLowerBoundInclusive(), CHECK_LOWER_BOUND_INCLUSIVE);
- assertNull(restriction.getUpperBound(), CHECK_UPPER_BOUND);
- assertFalse(restriction.isUpperBoundInclusive(), CHECK_UPPER_BOUND_INCLUSIVE);
+ assertThat(restriction.getLowerBound().toString()).as(CHECK_LOWER_BOUND).isEqualTo("1.1");
+ assertThat(restriction.isLowerBoundInclusive()).as(CHECK_LOWER_BOUND_INCLUSIVE).isTrue();
+ assertThat(restriction.getUpperBound()).as(CHECK_UPPER_BOUND).isNull();
+ assertThat(restriction.isUpperBoundInclusive()).as(CHECK_UPPER_BOUND_INCLUSIVE).isFalse();
range1 = VersionRange.createFromVersionSpec("[1.1]");
range2 = VersionRange.createFromVersionSpec("1.1");
mergedRange = range1.restrict(range2);
- assertEquals("1.1", mergedRange.getRecommendedVersion().toString(), CHECK_VERSION_RECOMMENDATION);
+ assertThat(mergedRange.getRecommendedVersion().toString()).as(CHECK_VERSION_RECOMMENDATION).isEqualTo("1.1");
restrictions = mergedRange.getRestrictions();
- assertEquals(1, restrictions.size(), CHECK_NUM_RESTRICTIONS);
+ assertThat(restrictions.size()).as(CHECK_NUM_RESTRICTIONS).isEqualTo(1);
restriction = restrictions.get(0);
- assertEquals("1.1", restriction.getLowerBound().toString(), CHECK_LOWER_BOUND);
- assertTrue(restriction.isLowerBoundInclusive(), CHECK_LOWER_BOUND_INCLUSIVE);
- assertEquals("1.1", restriction.getLowerBound().toString(), CHECK_UPPER_BOUND);
- assertTrue(restriction.isUpperBoundInclusive(), CHECK_UPPER_BOUND_INCLUSIVE);
+ assertThat(restriction.getLowerBound().toString()).as(CHECK_LOWER_BOUND).isEqualTo("1.1");
+ assertThat(restriction.isLowerBoundInclusive()).as(CHECK_LOWER_BOUND_INCLUSIVE).isTrue();
+ assertThat(restriction.getLowerBound().toString()).as(CHECK_UPPER_BOUND).isEqualTo("1.1");
+ assertThat(restriction.isUpperBoundInclusive()).as(CHECK_UPPER_BOUND_INCLUSIVE).isTrue();
range1 = VersionRange.createFromVersionSpec("(1.1,)");
range2 = VersionRange.createFromVersionSpec("1.1");
mergedRange = range1.restrict(range2);
- assertNull(mergedRange.getRecommendedVersion(), CHECK_VERSION_RECOMMENDATION);
+ assertThat(mergedRange.getRecommendedVersion()).as(CHECK_VERSION_RECOMMENDATION).isNull();
restrictions = mergedRange.getRestrictions();
- assertEquals(1, restrictions.size(), CHECK_NUM_RESTRICTIONS);
+ assertThat(restrictions.size()).as(CHECK_NUM_RESTRICTIONS).isEqualTo(1);
restriction = restrictions.get(0);
- assertEquals("1.1", restriction.getLowerBound().toString(), CHECK_LOWER_BOUND);
- assertFalse(restriction.isLowerBoundInclusive(), CHECK_LOWER_BOUND_INCLUSIVE);
- assertNull(restriction.getUpperBound(), CHECK_UPPER_BOUND);
- assertFalse(restriction.isUpperBoundInclusive(), CHECK_UPPER_BOUND_INCLUSIVE);
+ assertThat(restriction.getLowerBound().toString()).as(CHECK_LOWER_BOUND).isEqualTo("1.1");
+ assertThat(restriction.isLowerBoundInclusive()).as(CHECK_LOWER_BOUND_INCLUSIVE).isFalse();
+ assertThat(restriction.getUpperBound()).as(CHECK_UPPER_BOUND).isNull();
+ assertThat(restriction.isUpperBoundInclusive()).as(CHECK_UPPER_BOUND_INCLUSIVE).isFalse();
range1 = VersionRange.createFromVersionSpec("[1.2,)");
range2 = VersionRange.createFromVersionSpec("1.1");
mergedRange = range1.restrict(range2);
- assertNull(mergedRange.getRecommendedVersion(), CHECK_VERSION_RECOMMENDATION);
+ assertThat(mergedRange.getRecommendedVersion()).as(CHECK_VERSION_RECOMMENDATION).isNull();
restrictions = mergedRange.getRestrictions();
- assertEquals(1, restrictions.size(), CHECK_NUM_RESTRICTIONS);
+ assertThat(restrictions.size()).as(CHECK_NUM_RESTRICTIONS).isEqualTo(1);
restriction = restrictions.get(0);
- assertEquals("1.2", restriction.getLowerBound().toString(), CHECK_LOWER_BOUND);
- assertTrue(restriction.isLowerBoundInclusive(), CHECK_LOWER_BOUND_INCLUSIVE);
- assertNull(restriction.getUpperBound(), CHECK_UPPER_BOUND);
- assertFalse(restriction.isUpperBoundInclusive(), CHECK_UPPER_BOUND_INCLUSIVE);
+ assertThat(restriction.getLowerBound().toString()).as(CHECK_LOWER_BOUND).isEqualTo("1.2");
+ assertThat(restriction.isLowerBoundInclusive()).as(CHECK_LOWER_BOUND_INCLUSIVE).isTrue();
+ assertThat(restriction.getUpperBound()).as(CHECK_UPPER_BOUND).isNull();
+ assertThat(restriction.isUpperBoundInclusive()).as(CHECK_UPPER_BOUND_INCLUSIVE).isFalse();
range1 = VersionRange.createFromVersionSpec("(,1.2]");
range2 = VersionRange.createFromVersionSpec("1.1");
mergedRange = range1.restrict(range2);
- assertEquals("1.1", mergedRange.getRecommendedVersion().toString(), CHECK_VERSION_RECOMMENDATION);
+ assertThat(mergedRange.getRecommendedVersion().toString()).as(CHECK_VERSION_RECOMMENDATION).isEqualTo("1.1");
restrictions = mergedRange.getRestrictions();
- assertEquals(1, restrictions.size(), CHECK_NUM_RESTRICTIONS);
+ assertThat(restrictions.size()).as(CHECK_NUM_RESTRICTIONS).isEqualTo(1);
restriction = restrictions.get(0);
- assertNull(restriction.getLowerBound(), CHECK_LOWER_BOUND);
- assertFalse(restriction.isLowerBoundInclusive(), CHECK_LOWER_BOUND_INCLUSIVE);
- assertEquals("1.2", restriction.getUpperBound().toString(), CHECK_UPPER_BOUND);
- assertTrue(restriction.isUpperBoundInclusive(), CHECK_UPPER_BOUND_INCLUSIVE);
+ assertThat(restriction.getLowerBound()).as(CHECK_LOWER_BOUND).isNull();
+ assertThat(restriction.isLowerBoundInclusive()).as(CHECK_LOWER_BOUND_INCLUSIVE).isFalse();
+ assertThat(restriction.getUpperBound().toString()).as(CHECK_UPPER_BOUND).isEqualTo("1.2");
+ assertThat(restriction.isUpperBoundInclusive()).as(CHECK_UPPER_BOUND_INCLUSIVE).isTrue();
range1 = VersionRange.createFromVersionSpec("(,1.1]");
range2 = VersionRange.createFromVersionSpec("1.1");
mergedRange = range1.restrict(range2);
- assertEquals("1.1", mergedRange.getRecommendedVersion().toString(), CHECK_VERSION_RECOMMENDATION);
+ assertThat(mergedRange.getRecommendedVersion().toString()).as(CHECK_VERSION_RECOMMENDATION).isEqualTo("1.1");
restrictions = mergedRange.getRestrictions();
- assertEquals(1, restrictions.size(), CHECK_NUM_RESTRICTIONS);
+ assertThat(restrictions.size()).as(CHECK_NUM_RESTRICTIONS).isEqualTo(1);
restriction = restrictions.get(0);
- assertNull(restriction.getLowerBound(), CHECK_LOWER_BOUND);
- assertFalse(restriction.isLowerBoundInclusive(), CHECK_LOWER_BOUND_INCLUSIVE);
- assertEquals("1.1", restriction.getUpperBound().toString(), CHECK_UPPER_BOUND);
- assertTrue(restriction.isUpperBoundInclusive(), CHECK_UPPER_BOUND_INCLUSIVE);
+ assertThat(restriction.getLowerBound()).as(CHECK_LOWER_BOUND).isNull();
+ assertThat(restriction.isLowerBoundInclusive()).as(CHECK_LOWER_BOUND_INCLUSIVE).isFalse();
+ assertThat(restriction.getUpperBound().toString()).as(CHECK_UPPER_BOUND).isEqualTo("1.1");
+ assertThat(restriction.isUpperBoundInclusive()).as(CHECK_UPPER_BOUND_INCLUSIVE).isTrue();
range1 = VersionRange.createFromVersionSpec("(,1.1)");
range2 = VersionRange.createFromVersionSpec("1.1");
mergedRange = range1.restrict(range2);
- assertNull(mergedRange.getRecommendedVersion(), CHECK_VERSION_RECOMMENDATION);
+ assertThat(mergedRange.getRecommendedVersion()).as(CHECK_VERSION_RECOMMENDATION).isNull();
restrictions = mergedRange.getRestrictions();
- assertEquals(1, restrictions.size(), CHECK_NUM_RESTRICTIONS);
+ assertThat(restrictions.size()).as(CHECK_NUM_RESTRICTIONS).isEqualTo(1);
restriction = restrictions.get(0);
- assertNull(restriction.getLowerBound(), CHECK_LOWER_BOUND);
- assertFalse(restriction.isLowerBoundInclusive(), CHECK_LOWER_BOUND_INCLUSIVE);
- assertEquals("1.1", restriction.getUpperBound().toString(), CHECK_UPPER_BOUND);
- assertFalse(restriction.isUpperBoundInclusive(), CHECK_UPPER_BOUND_INCLUSIVE);
+ assertThat(restriction.getLowerBound()).as(CHECK_LOWER_BOUND).isNull();
+ assertThat(restriction.isLowerBoundInclusive()).as(CHECK_LOWER_BOUND_INCLUSIVE).isFalse();
+ assertThat(restriction.getUpperBound().toString()).as(CHECK_UPPER_BOUND).isEqualTo("1.1");
+ assertThat(restriction.isUpperBoundInclusive()).as(CHECK_UPPER_BOUND_INCLUSIVE).isFalse();
range1 = VersionRange.createFromVersionSpec("(,1.0]");
range2 = VersionRange.createFromVersionSpec("1.1");
mergedRange = range1.restrict(range2);
- assertNull(mergedRange.getRecommendedVersion(), CHECK_VERSION_RECOMMENDATION);
+ assertThat(mergedRange.getRecommendedVersion()).as(CHECK_VERSION_RECOMMENDATION).isNull();
restrictions = mergedRange.getRestrictions();
- assertEquals(1, restrictions.size(), CHECK_NUM_RESTRICTIONS);
+ assertThat(restrictions.size()).as(CHECK_NUM_RESTRICTIONS).isEqualTo(1);
restriction = restrictions.get(0);
- assertNull(restriction.getLowerBound(), CHECK_LOWER_BOUND);
- assertFalse(restriction.isLowerBoundInclusive(), CHECK_LOWER_BOUND_INCLUSIVE);
- assertEquals("1.0", restriction.getUpperBound().toString(), CHECK_UPPER_BOUND);
- assertTrue(restriction.isUpperBoundInclusive(), CHECK_UPPER_BOUND_INCLUSIVE);
+ assertThat(restriction.getLowerBound()).as(CHECK_LOWER_BOUND).isNull();
+ assertThat(restriction.isLowerBoundInclusive()).as(CHECK_LOWER_BOUND_INCLUSIVE).isFalse();
+ assertThat(restriction.getUpperBound().toString()).as(CHECK_UPPER_BOUND).isEqualTo("1.0");
+ assertThat(restriction.isUpperBoundInclusive()).as(CHECK_UPPER_BOUND_INCLUSIVE).isTrue();
range1 = VersionRange.createFromVersionSpec("(,1.0], [1.1,)");
range2 = VersionRange.createFromVersionSpec("1.2");
mergedRange = range1.restrict(range2);
- assertEquals("1.2", mergedRange.getRecommendedVersion().toString(), CHECK_VERSION_RECOMMENDATION);
+ assertThat(mergedRange.getRecommendedVersion().toString()).as(CHECK_VERSION_RECOMMENDATION).isEqualTo("1.2");
restrictions = mergedRange.getRestrictions();
- assertEquals(2, restrictions.size(), CHECK_NUM_RESTRICTIONS);
+ assertThat(restrictions.size()).as(CHECK_NUM_RESTRICTIONS).isEqualTo(2);
restriction = restrictions.get(0);
- assertNull(restriction.getLowerBound(), CHECK_LOWER_BOUND);
- assertFalse(restriction.isLowerBoundInclusive(), CHECK_LOWER_BOUND_INCLUSIVE);
- assertEquals("1.0", restriction.getUpperBound().toString(), CHECK_UPPER_BOUND);
- assertTrue(restriction.isUpperBoundInclusive(), CHECK_UPPER_BOUND_INCLUSIVE);
+ assertThat(restriction.getLowerBound()).as(CHECK_LOWER_BOUND).isNull();
+ assertThat(restriction.isLowerBoundInclusive()).as(CHECK_LOWER_BOUND_INCLUSIVE).isFalse();
+ assertThat(restriction.getUpperBound().toString()).as(CHECK_UPPER_BOUND).isEqualTo("1.0");
+ assertThat(restriction.isUpperBoundInclusive()).as(CHECK_UPPER_BOUND_INCLUSIVE).isTrue();
restriction = restrictions.get(1);
- assertEquals("1.1", restriction.getLowerBound().toString(), CHECK_LOWER_BOUND);
- assertTrue(restriction.isLowerBoundInclusive(), CHECK_LOWER_BOUND_INCLUSIVE);
- assertNull(restriction.getUpperBound(), CHECK_UPPER_BOUND);
- assertFalse(restriction.isUpperBoundInclusive(), CHECK_UPPER_BOUND_INCLUSIVE);
+ assertThat(restriction.getLowerBound().toString()).as(CHECK_LOWER_BOUND).isEqualTo("1.1");
+ assertThat(restriction.isLowerBoundInclusive()).as(CHECK_LOWER_BOUND_INCLUSIVE).isTrue();
+ assertThat(restriction.getUpperBound()).as(CHECK_UPPER_BOUND).isNull();
+ assertThat(restriction.isUpperBoundInclusive()).as(CHECK_UPPER_BOUND_INCLUSIVE).isFalse();
range1 = VersionRange.createFromVersionSpec("(,1.0], [1.1,)");
range2 = VersionRange.createFromVersionSpec("1.0.5");
mergedRange = range1.restrict(range2);
- assertNull(mergedRange.getRecommendedVersion(), CHECK_VERSION_RECOMMENDATION);
+ assertThat(mergedRange.getRecommendedVersion()).as(CHECK_VERSION_RECOMMENDATION).isNull();
restrictions = mergedRange.getRestrictions();
- assertEquals(2, restrictions.size(), CHECK_NUM_RESTRICTIONS);
+ assertThat(restrictions.size()).as(CHECK_NUM_RESTRICTIONS).isEqualTo(2);
restriction = restrictions.get(0);
- assertNull(restriction.getLowerBound(), CHECK_LOWER_BOUND);
- assertFalse(restriction.isLowerBoundInclusive(), CHECK_LOWER_BOUND_INCLUSIVE);
- assertEquals("1.0", restriction.getUpperBound().toString(), CHECK_UPPER_BOUND);
- assertTrue(restriction.isUpperBoundInclusive(), CHECK_UPPER_BOUND_INCLUSIVE);
+ assertThat(restriction.getLowerBound()).as(CHECK_LOWER_BOUND).isNull();
+ assertThat(restriction.isLowerBoundInclusive()).as(CHECK_LOWER_BOUND_INCLUSIVE).isFalse();
+ assertThat(restriction.getUpperBound().toString()).as(CHECK_UPPER_BOUND).isEqualTo("1.0");
+ assertThat(restriction.isUpperBoundInclusive()).as(CHECK_UPPER_BOUND_INCLUSIVE).isTrue();
restriction = restrictions.get(1);
- assertEquals("1.1", restriction.getLowerBound().toString(), CHECK_LOWER_BOUND);
- assertTrue(restriction.isLowerBoundInclusive(), CHECK_LOWER_BOUND_INCLUSIVE);
- assertNull(restriction.getUpperBound(), CHECK_UPPER_BOUND);
- assertFalse(restriction.isUpperBoundInclusive(), CHECK_UPPER_BOUND_INCLUSIVE);
+ assertThat(restriction.getLowerBound().toString()).as(CHECK_LOWER_BOUND).isEqualTo("1.1");
+ assertThat(restriction.isLowerBoundInclusive()).as(CHECK_LOWER_BOUND_INCLUSIVE).isTrue();
+ assertThat(restriction.getUpperBound()).as(CHECK_UPPER_BOUND).isNull();
+ assertThat(restriction.isUpperBoundInclusive()).as(CHECK_UPPER_BOUND_INCLUSIVE).isFalse();
range1 = VersionRange.createFromVersionSpec("(,1.1), (1.1,)");
range2 = VersionRange.createFromVersionSpec("1.1");
mergedRange = range1.restrict(range2);
- assertNull(mergedRange.getRecommendedVersion(), CHECK_VERSION_RECOMMENDATION);
+ assertThat(mergedRange.getRecommendedVersion()).as(CHECK_VERSION_RECOMMENDATION).isNull();
restrictions = mergedRange.getRestrictions();
- assertEquals(2, restrictions.size(), CHECK_NUM_RESTRICTIONS);
+ assertThat(restrictions.size()).as(CHECK_NUM_RESTRICTIONS).isEqualTo(2);
restriction = restrictions.get(0);
- assertNull(restriction.getLowerBound(), CHECK_LOWER_BOUND);
- assertFalse(restriction.isLowerBoundInclusive(), CHECK_LOWER_BOUND_INCLUSIVE);
- assertEquals("1.1", restriction.getUpperBound().toString(), CHECK_UPPER_BOUND);
- assertFalse(restriction.isUpperBoundInclusive(), CHECK_UPPER_BOUND_INCLUSIVE);
+ assertThat(restriction.getLowerBound()).as(CHECK_LOWER_BOUND).isNull();
+ assertThat(restriction.isLowerBoundInclusive()).as(CHECK_LOWER_BOUND_INCLUSIVE).isFalse();
+ assertThat(restriction.getUpperBound().toString()).as(CHECK_UPPER_BOUND).isEqualTo("1.1");
+ assertThat(restriction.isUpperBoundInclusive()).as(CHECK_UPPER_BOUND_INCLUSIVE).isFalse();
restriction = restrictions.get(1);
- assertEquals("1.1", restriction.getLowerBound().toString(), CHECK_LOWER_BOUND);
- assertFalse(restriction.isLowerBoundInclusive(), CHECK_LOWER_BOUND_INCLUSIVE);
- assertNull(restriction.getUpperBound(), CHECK_UPPER_BOUND);
- assertFalse(restriction.isUpperBoundInclusive(), CHECK_UPPER_BOUND_INCLUSIVE);
+ assertThat(restriction.getLowerBound().toString()).as(CHECK_LOWER_BOUND).isEqualTo("1.1");
+ assertThat(restriction.isLowerBoundInclusive()).as(CHECK_LOWER_BOUND_INCLUSIVE).isFalse();
+ assertThat(restriction.getUpperBound()).as(CHECK_UPPER_BOUND).isNull();
+ assertThat(restriction.isUpperBoundInclusive()).as(CHECK_UPPER_BOUND_INCLUSIVE).isFalse();
range1 = VersionRange.createFromVersionSpec("[1.1,1.3]");
range2 = VersionRange.createFromVersionSpec("(1.1,)");
mergedRange = range1.restrict(range2);
- assertNull(mergedRange.getRecommendedVersion(), CHECK_VERSION_RECOMMENDATION);
+ assertThat(mergedRange.getRecommendedVersion()).as(CHECK_VERSION_RECOMMENDATION).isNull();
restrictions = mergedRange.getRestrictions();
- assertEquals(1, restrictions.size(), CHECK_NUM_RESTRICTIONS);
+ assertThat(restrictions.size()).as(CHECK_NUM_RESTRICTIONS).isEqualTo(1);
restriction = restrictions.get(0);
- assertEquals("1.1", restriction.getLowerBound().toString(), CHECK_LOWER_BOUND);
- assertFalse(restriction.isLowerBoundInclusive(), CHECK_LOWER_BOUND_INCLUSIVE);
- assertEquals("1.3", restriction.getUpperBound().toString(), CHECK_UPPER_BOUND);
- assertTrue(restriction.isUpperBoundInclusive(), CHECK_UPPER_BOUND_INCLUSIVE);
+ assertThat(restriction.getLowerBound().toString()).as(CHECK_LOWER_BOUND).isEqualTo("1.1");
+ assertThat(restriction.isLowerBoundInclusive()).as(CHECK_LOWER_BOUND_INCLUSIVE).isFalse();
+ assertThat(restriction.getUpperBound().toString()).as(CHECK_UPPER_BOUND).isEqualTo("1.3");
+ assertThat(restriction.isUpperBoundInclusive()).as(CHECK_UPPER_BOUND_INCLUSIVE).isTrue();
range1 = VersionRange.createFromVersionSpec("(,1.3)");
range2 = VersionRange.createFromVersionSpec("[1.2,1.3]");
mergedRange = range1.restrict(range2);
- assertNull(mergedRange.getRecommendedVersion(), CHECK_VERSION_RECOMMENDATION);
+ assertThat(mergedRange.getRecommendedVersion()).as(CHECK_VERSION_RECOMMENDATION).isNull();
restrictions = mergedRange.getRestrictions();
- assertEquals(1, restrictions.size(), CHECK_NUM_RESTRICTIONS);
+ assertThat(restrictions.size()).as(CHECK_NUM_RESTRICTIONS).isEqualTo(1);
restriction = restrictions.get(0);
- assertEquals("1.2", restriction.getLowerBound().toString(), CHECK_LOWER_BOUND);
- assertTrue(restriction.isLowerBoundInclusive(), CHECK_LOWER_BOUND_INCLUSIVE);
- assertEquals("1.3", restriction.getUpperBound().toString(), CHECK_UPPER_BOUND);
- assertFalse(restriction.isUpperBoundInclusive(), CHECK_UPPER_BOUND_INCLUSIVE);
+ assertThat(restriction.getLowerBound().toString()).as(CHECK_LOWER_BOUND).isEqualTo("1.2");
+ assertThat(restriction.isLowerBoundInclusive()).as(CHECK_LOWER_BOUND_INCLUSIVE).isTrue();
+ assertThat(restriction.getUpperBound().toString()).as(CHECK_UPPER_BOUND).isEqualTo("1.3");
+ assertThat(restriction.isUpperBoundInclusive()).as(CHECK_UPPER_BOUND_INCLUSIVE).isFalse();
range1 = VersionRange.createFromVersionSpec("[1.1,1.3]");
range2 = VersionRange.createFromVersionSpec("[1.2,)");
mergedRange = range1.restrict(range2);
- assertNull(mergedRange.getRecommendedVersion(), CHECK_VERSION_RECOMMENDATION);
+ assertThat(mergedRange.getRecommendedVersion()).as(CHECK_VERSION_RECOMMENDATION).isNull();
restrictions = mergedRange.getRestrictions();
- assertEquals(1, restrictions.size(), CHECK_NUM_RESTRICTIONS);
+ assertThat(restrictions.size()).as(CHECK_NUM_RESTRICTIONS).isEqualTo(1);
restriction = restrictions.get(0);
- assertEquals("1.2", restriction.getLowerBound().toString(), CHECK_LOWER_BOUND);
- assertTrue(restriction.isLowerBoundInclusive(), CHECK_LOWER_BOUND_INCLUSIVE);
- assertEquals("1.3", restriction.getUpperBound().toString(), CHECK_UPPER_BOUND);
- assertTrue(restriction.isUpperBoundInclusive(), CHECK_UPPER_BOUND_INCLUSIVE);
+ assertThat(restriction.getLowerBound().toString()).as(CHECK_LOWER_BOUND).isEqualTo("1.2");
+ assertThat(restriction.isLowerBoundInclusive()).as(CHECK_LOWER_BOUND_INCLUSIVE).isTrue();
+ assertThat(restriction.getUpperBound().toString()).as(CHECK_UPPER_BOUND).isEqualTo("1.3");
+ assertThat(restriction.isUpperBoundInclusive()).as(CHECK_UPPER_BOUND_INCLUSIVE).isTrue();
range1 = VersionRange.createFromVersionSpec("(,1.3]");
range2 = VersionRange.createFromVersionSpec("[1.2,1.4]");
mergedRange = range1.restrict(range2);
- assertNull(mergedRange.getRecommendedVersion(), CHECK_VERSION_RECOMMENDATION);
+ assertThat(mergedRange.getRecommendedVersion()).as(CHECK_VERSION_RECOMMENDATION).isNull();
restrictions = mergedRange.getRestrictions();
- assertEquals(1, restrictions.size(), CHECK_NUM_RESTRICTIONS);
+ assertThat(restrictions.size()).as(CHECK_NUM_RESTRICTIONS).isEqualTo(1);
restriction = restrictions.get(0);
- assertEquals("1.2", restriction.getLowerBound().toString(), CHECK_LOWER_BOUND);
- assertTrue(restriction.isLowerBoundInclusive(), CHECK_LOWER_BOUND_INCLUSIVE);
- assertEquals("1.3", restriction.getUpperBound().toString(), CHECK_UPPER_BOUND);
- assertTrue(restriction.isUpperBoundInclusive(), CHECK_UPPER_BOUND_INCLUSIVE);
+ assertThat(restriction.getLowerBound().toString()).as(CHECK_LOWER_BOUND).isEqualTo("1.2");
+ assertThat(restriction.isLowerBoundInclusive()).as(CHECK_LOWER_BOUND_INCLUSIVE).isTrue();
+ assertThat(restriction.getUpperBound().toString()).as(CHECK_UPPER_BOUND).isEqualTo("1.3");
+ assertThat(restriction.isUpperBoundInclusive()).as(CHECK_UPPER_BOUND_INCLUSIVE).isTrue();
range1 = VersionRange.createFromVersionSpec("(1.2,1.3]");
range2 = VersionRange.createFromVersionSpec("[1.1,1.4]");
mergedRange = range1.restrict(range2);
- assertNull(mergedRange.getRecommendedVersion(), CHECK_VERSION_RECOMMENDATION);
+ assertThat(mergedRange.getRecommendedVersion()).as(CHECK_VERSION_RECOMMENDATION).isNull();
restrictions = mergedRange.getRestrictions();
- assertEquals(1, restrictions.size(), CHECK_NUM_RESTRICTIONS);
+ assertThat(restrictions.size()).as(CHECK_NUM_RESTRICTIONS).isEqualTo(1);
restriction = restrictions.get(0);
- assertEquals("1.2", restriction.getLowerBound().toString(), CHECK_LOWER_BOUND);
- assertFalse(restriction.isLowerBoundInclusive(), CHECK_LOWER_BOUND_INCLUSIVE);
- assertEquals("1.3", restriction.getUpperBound().toString(), CHECK_UPPER_BOUND);
- assertTrue(restriction.isUpperBoundInclusive(), CHECK_UPPER_BOUND_INCLUSIVE);
+ assertThat(restriction.getLowerBound().toString()).as(CHECK_LOWER_BOUND).isEqualTo("1.2");
+ assertThat(restriction.isLowerBoundInclusive()).as(CHECK_LOWER_BOUND_INCLUSIVE).isFalse();
+ assertThat(restriction.getUpperBound().toString()).as(CHECK_UPPER_BOUND).isEqualTo("1.3");
+ assertThat(restriction.isUpperBoundInclusive()).as(CHECK_UPPER_BOUND_INCLUSIVE).isTrue();
range1 = VersionRange.createFromVersionSpec("(1.2,1.3)");
range2 = VersionRange.createFromVersionSpec("[1.1,1.4]");
mergedRange = range1.restrict(range2);
- assertNull(mergedRange.getRecommendedVersion(), CHECK_VERSION_RECOMMENDATION);
+ assertThat(mergedRange.getRecommendedVersion()).as(CHECK_VERSION_RECOMMENDATION).isNull();
restrictions = mergedRange.getRestrictions();
- assertEquals(1, restrictions.size(), CHECK_NUM_RESTRICTIONS);
+ assertThat(restrictions.size()).as(CHECK_NUM_RESTRICTIONS).isEqualTo(1);
restriction = restrictions.get(0);
- assertEquals("1.2", restriction.getLowerBound().toString(), CHECK_LOWER_BOUND);
- assertFalse(restriction.isLowerBoundInclusive(), CHECK_LOWER_BOUND_INCLUSIVE);
- assertEquals("1.3", restriction.getUpperBound().toString(), CHECK_UPPER_BOUND);
- assertFalse(restriction.isUpperBoundInclusive(), CHECK_UPPER_BOUND_INCLUSIVE);
+ assertThat(restriction.getLowerBound().toString()).as(CHECK_LOWER_BOUND).isEqualTo("1.2");
+ assertThat(restriction.isLowerBoundInclusive()).as(CHECK_LOWER_BOUND_INCLUSIVE).isFalse();
+ assertThat(restriction.getUpperBound().toString()).as(CHECK_UPPER_BOUND).isEqualTo("1.3");
+ assertThat(restriction.isUpperBoundInclusive()).as(CHECK_UPPER_BOUND_INCLUSIVE).isFalse();
range1 = VersionRange.createFromVersionSpec("[1.2,1.3)");
range2 = VersionRange.createFromVersionSpec("[1.1,1.4]");
mergedRange = range1.restrict(range2);
- assertNull(mergedRange.getRecommendedVersion(), CHECK_VERSION_RECOMMENDATION);
+ assertThat(mergedRange.getRecommendedVersion()).as(CHECK_VERSION_RECOMMENDATION).isNull();
restrictions = mergedRange.getRestrictions();
- assertEquals(1, restrictions.size(), CHECK_NUM_RESTRICTIONS);
+ assertThat(restrictions.size()).as(CHECK_NUM_RESTRICTIONS).isEqualTo(1);
restriction = restrictions.get(0);
- assertEquals("1.2", restriction.getLowerBound().toString(), CHECK_LOWER_BOUND);
- assertTrue(restriction.isLowerBoundInclusive(), CHECK_LOWER_BOUND_INCLUSIVE);
- assertEquals("1.3", restriction.getUpperBound().toString(), CHECK_UPPER_BOUND);
- assertFalse(restriction.isUpperBoundInclusive(), CHECK_UPPER_BOUND_INCLUSIVE);
+ assertThat(restriction.getLowerBound().toString()).as(CHECK_LOWER_BOUND).isEqualTo("1.2");
+ assertThat(restriction.isLowerBoundInclusive()).as(CHECK_LOWER_BOUND_INCLUSIVE).isTrue();
+ assertThat(restriction.getUpperBound().toString()).as(CHECK_UPPER_BOUND).isEqualTo("1.3");
+ assertThat(restriction.isUpperBoundInclusive()).as(CHECK_UPPER_BOUND_INCLUSIVE).isFalse();
range1 = VersionRange.createFromVersionSpec("[1.0,1.1]");
range2 = VersionRange.createFromVersionSpec("[1.1,1.4]");
mergedRange = range1.restrict(range2);
- assertNull(mergedRange.getRecommendedVersion(), CHECK_VERSION_RECOMMENDATION);
+ assertThat(mergedRange.getRecommendedVersion()).as(CHECK_VERSION_RECOMMENDATION).isNull();
restrictions = mergedRange.getRestrictions();
- assertEquals(1, restrictions.size(), CHECK_NUM_RESTRICTIONS);
+ assertThat(restrictions.size()).as(CHECK_NUM_RESTRICTIONS).isEqualTo(1);
restriction = restrictions.get(0);
- assertEquals("1.1", restriction.getLowerBound().toString(), CHECK_LOWER_BOUND);
- assertTrue(restriction.isLowerBoundInclusive(), CHECK_LOWER_BOUND_INCLUSIVE);
- assertEquals("1.1", restriction.getUpperBound().toString(), CHECK_UPPER_BOUND);
- assertTrue(restriction.isUpperBoundInclusive(), CHECK_UPPER_BOUND_INCLUSIVE);
+ assertThat(restriction.getLowerBound().toString()).as(CHECK_LOWER_BOUND).isEqualTo("1.1");
+ assertThat(restriction.isLowerBoundInclusive()).as(CHECK_LOWER_BOUND_INCLUSIVE).isTrue();
+ assertThat(restriction.getUpperBound().toString()).as(CHECK_UPPER_BOUND).isEqualTo("1.1");
+ assertThat(restriction.isUpperBoundInclusive()).as(CHECK_UPPER_BOUND_INCLUSIVE).isTrue();
range1 = VersionRange.createFromVersionSpec("[1.0,1.1)");
range2 = VersionRange.createFromVersionSpec("[1.1,1.4]");
mergedRange = range1.restrict(range2);
- assertNull(mergedRange.getRecommendedVersion(), CHECK_VERSION_RECOMMENDATION);
+ assertThat(mergedRange.getRecommendedVersion()).as(CHECK_VERSION_RECOMMENDATION).isNull();
restrictions = mergedRange.getRestrictions();
- assertEquals(0, restrictions.size(), CHECK_NUM_RESTRICTIONS);
+ assertThat(restrictions.size()).as(CHECK_NUM_RESTRICTIONS).isEqualTo(0);
range1 = VersionRange.createFromVersionSpec("[1.0,1.2],[1.3,1.5]");
range2 = VersionRange.createFromVersionSpec("[1.1]");
mergedRange = range1.restrict(range2);
- assertNull(mergedRange.getRecommendedVersion(), CHECK_VERSION_RECOMMENDATION);
+ assertThat(mergedRange.getRecommendedVersion()).as(CHECK_VERSION_RECOMMENDATION).isNull();
restrictions = mergedRange.getRestrictions();
- assertEquals(1, restrictions.size(), CHECK_NUM_RESTRICTIONS);
+ assertThat(restrictions.size()).as(CHECK_NUM_RESTRICTIONS).isEqualTo(1);
restriction = restrictions.get(0);
- assertEquals("1.1", restriction.getLowerBound().toString(), CHECK_LOWER_BOUND);
- assertTrue(restriction.isLowerBoundInclusive(), CHECK_LOWER_BOUND_INCLUSIVE);
- assertEquals("1.1", restriction.getUpperBound().toString(), CHECK_UPPER_BOUND);
- assertTrue(restriction.isUpperBoundInclusive(), CHECK_UPPER_BOUND_INCLUSIVE);
+ assertThat(restriction.getLowerBound().toString()).as(CHECK_LOWER_BOUND).isEqualTo("1.1");
+ assertThat(restriction.isLowerBoundInclusive()).as(CHECK_LOWER_BOUND_INCLUSIVE).isTrue();
+ assertThat(restriction.getUpperBound().toString()).as(CHECK_UPPER_BOUND).isEqualTo("1.1");
+ assertThat(restriction.isUpperBoundInclusive()).as(CHECK_UPPER_BOUND_INCLUSIVE).isTrue();
range1 = VersionRange.createFromVersionSpec("[1.0,1.2],[1.3,1.5]");
range2 = VersionRange.createFromVersionSpec("[1.4]");
mergedRange = range1.restrict(range2);
- assertNull(mergedRange.getRecommendedVersion(), CHECK_VERSION_RECOMMENDATION);
+ assertThat(mergedRange.getRecommendedVersion()).as(CHECK_VERSION_RECOMMENDATION).isNull();
restrictions = mergedRange.getRestrictions();
- assertEquals(1, restrictions.size(), CHECK_NUM_RESTRICTIONS);
+ assertThat(restrictions.size()).as(CHECK_NUM_RESTRICTIONS).isEqualTo(1);
restriction = restrictions.get(0);
- assertEquals("1.4", restriction.getLowerBound().toString(), CHECK_LOWER_BOUND);
- assertTrue(restriction.isLowerBoundInclusive(), CHECK_LOWER_BOUND_INCLUSIVE);
- assertEquals("1.4", restriction.getUpperBound().toString(), CHECK_UPPER_BOUND);
- assertTrue(restriction.isUpperBoundInclusive(), CHECK_UPPER_BOUND_INCLUSIVE);
+ assertThat(restriction.getLowerBound().toString()).as(CHECK_LOWER_BOUND).isEqualTo("1.4");
+ assertThat(restriction.isLowerBoundInclusive()).as(CHECK_LOWER_BOUND_INCLUSIVE).isTrue();
+ assertThat(restriction.getUpperBound().toString()).as(CHECK_UPPER_BOUND).isEqualTo("1.4");
+ assertThat(restriction.isUpperBoundInclusive()).as(CHECK_UPPER_BOUND_INCLUSIVE).isTrue();
range1 = VersionRange.createFromVersionSpec("[1.0,1.2],[1.3,1.5]");
range2 = VersionRange.createFromVersionSpec("[1.1,1.4]");
mergedRange = range1.restrict(range2);
- assertNull(mergedRange.getRecommendedVersion(), CHECK_VERSION_RECOMMENDATION);
+ assertThat(mergedRange.getRecommendedVersion()).as(CHECK_VERSION_RECOMMENDATION).isNull();
restrictions = mergedRange.getRestrictions();
- assertEquals(2, restrictions.size(), CHECK_NUM_RESTRICTIONS);
+ assertThat(restrictions.size()).as(CHECK_NUM_RESTRICTIONS).isEqualTo(2);
restriction = restrictions.get(0);
- assertEquals("1.1", restriction.getLowerBound().toString(), CHECK_LOWER_BOUND);
- assertTrue(restriction.isLowerBoundInclusive(), CHECK_LOWER_BOUND_INCLUSIVE);
- assertEquals("1.2", restriction.getUpperBound().toString(), CHECK_UPPER_BOUND);
- assertTrue(restriction.isUpperBoundInclusive(), CHECK_UPPER_BOUND_INCLUSIVE);
+ assertThat(restriction.getLowerBound().toString()).as(CHECK_LOWER_BOUND).isEqualTo("1.1");
+ assertThat(restriction.isLowerBoundInclusive()).as(CHECK_LOWER_BOUND_INCLUSIVE).isTrue();
+ assertThat(restriction.getUpperBound().toString()).as(CHECK_UPPER_BOUND).isEqualTo("1.2");
+ assertThat(restriction.isUpperBoundInclusive()).as(CHECK_UPPER_BOUND_INCLUSIVE).isTrue();
restriction = restrictions.get(1);
- assertEquals("1.3", restriction.getLowerBound().toString(), CHECK_LOWER_BOUND);
- assertTrue(restriction.isLowerBoundInclusive(), CHECK_LOWER_BOUND_INCLUSIVE);
- assertEquals("1.4", restriction.getUpperBound().toString(), CHECK_UPPER_BOUND);
- assertTrue(restriction.isUpperBoundInclusive(), CHECK_UPPER_BOUND_INCLUSIVE);
+ assertThat(restriction.getLowerBound().toString()).as(CHECK_LOWER_BOUND).isEqualTo("1.3");
+ assertThat(restriction.isLowerBoundInclusive()).as(CHECK_LOWER_BOUND_INCLUSIVE).isTrue();
+ assertThat(restriction.getUpperBound().toString()).as(CHECK_UPPER_BOUND).isEqualTo("1.4");
+ assertThat(restriction.isUpperBoundInclusive()).as(CHECK_UPPER_BOUND_INCLUSIVE).isTrue();
range1 = VersionRange.createFromVersionSpec("[1.0,1.2),(1.3,1.5]");
range2 = VersionRange.createFromVersionSpec("[1.1,1.4]");
mergedRange = range1.restrict(range2);
- assertNull(mergedRange.getRecommendedVersion(), CHECK_VERSION_RECOMMENDATION);
+ assertThat(mergedRange.getRecommendedVersion()).as(CHECK_VERSION_RECOMMENDATION).isNull();
restrictions = mergedRange.getRestrictions();
- assertEquals(2, restrictions.size(), CHECK_NUM_RESTRICTIONS);
+ assertThat(restrictions.size()).as(CHECK_NUM_RESTRICTIONS).isEqualTo(2);
restriction = restrictions.get(0);
- assertEquals("1.1", restriction.getLowerBound().toString(), CHECK_LOWER_BOUND);
- assertTrue(restriction.isLowerBoundInclusive(), CHECK_LOWER_BOUND_INCLUSIVE);
- assertEquals("1.2", restriction.getUpperBound().toString(), CHECK_UPPER_BOUND);
- assertFalse(restriction.isUpperBoundInclusive(), CHECK_UPPER_BOUND_INCLUSIVE);
+ assertThat(restriction.getLowerBound().toString()).as(CHECK_LOWER_BOUND).isEqualTo("1.1");
+ assertThat(restriction.isLowerBoundInclusive()).as(CHECK_LOWER_BOUND_INCLUSIVE).isTrue();
+ assertThat(restriction.getUpperBound().toString()).as(CHECK_UPPER_BOUND).isEqualTo("1.2");
+ assertThat(restriction.isUpperBoundInclusive()).as(CHECK_UPPER_BOUND_INCLUSIVE).isFalse();
restriction = restrictions.get(1);
- assertEquals("1.3", restriction.getLowerBound().toString(), CHECK_LOWER_BOUND);
- assertFalse(restriction.isLowerBoundInclusive(), CHECK_LOWER_BOUND_INCLUSIVE);
- assertEquals("1.4", restriction.getUpperBound().toString(), CHECK_UPPER_BOUND);
- assertTrue(restriction.isUpperBoundInclusive(), CHECK_UPPER_BOUND_INCLUSIVE);
+ assertThat(restriction.getLowerBound().toString()).as(CHECK_LOWER_BOUND).isEqualTo("1.3");
+ assertThat(restriction.isLowerBoundInclusive()).as(CHECK_LOWER_BOUND_INCLUSIVE).isFalse();
+ assertThat(restriction.getUpperBound().toString()).as(CHECK_UPPER_BOUND).isEqualTo("1.4");
+ assertThat(restriction.isUpperBoundInclusive()).as(CHECK_UPPER_BOUND_INCLUSIVE).isTrue();
range1 = VersionRange.createFromVersionSpec("[1.0,1.2],[1.3,1.5]");
range2 = VersionRange.createFromVersionSpec("(1.1,1.4)");
mergedRange = range1.restrict(range2);
- assertNull(mergedRange.getRecommendedVersion(), CHECK_VERSION_RECOMMENDATION);
+ assertThat(mergedRange.getRecommendedVersion()).as(CHECK_VERSION_RECOMMENDATION).isNull();
restrictions = mergedRange.getRestrictions();
- assertEquals(2, restrictions.size(), CHECK_NUM_RESTRICTIONS);
+ assertThat(restrictions.size()).as(CHECK_NUM_RESTRICTIONS).isEqualTo(2);
restriction = restrictions.get(0);
- assertEquals("1.1", restriction.getLowerBound().toString(), CHECK_LOWER_BOUND);
- assertFalse(restriction.isLowerBoundInclusive(), CHECK_LOWER_BOUND_INCLUSIVE);
- assertEquals("1.2", restriction.getUpperBound().toString(), CHECK_UPPER_BOUND);
- assertTrue(restriction.isUpperBoundInclusive(), CHECK_UPPER_BOUND_INCLUSIVE);
+ assertThat(restriction.getLowerBound().toString()).as(CHECK_LOWER_BOUND).isEqualTo("1.1");
+ assertThat(restriction.isLowerBoundInclusive()).as(CHECK_LOWER_BOUND_INCLUSIVE).isFalse();
+ assertThat(restriction.getUpperBound().toString()).as(CHECK_UPPER_BOUND).isEqualTo("1.2");
+ assertThat(restriction.isUpperBoundInclusive()).as(CHECK_UPPER_BOUND_INCLUSIVE).isTrue();
restriction = restrictions.get(1);
- assertEquals("1.3", restriction.getLowerBound().toString(), CHECK_LOWER_BOUND);
- assertTrue(restriction.isLowerBoundInclusive(), CHECK_LOWER_BOUND_INCLUSIVE);
- assertEquals("1.4", restriction.getUpperBound().toString(), CHECK_UPPER_BOUND);
- assertFalse(restriction.isUpperBoundInclusive(), CHECK_UPPER_BOUND_INCLUSIVE);
+ assertThat(restriction.getLowerBound().toString()).as(CHECK_LOWER_BOUND).isEqualTo("1.3");
+ assertThat(restriction.isLowerBoundInclusive()).as(CHECK_LOWER_BOUND_INCLUSIVE).isTrue();
+ assertThat(restriction.getUpperBound().toString()).as(CHECK_UPPER_BOUND).isEqualTo("1.4");
+ assertThat(restriction.isUpperBoundInclusive()).as(CHECK_UPPER_BOUND_INCLUSIVE).isFalse();
range1 = VersionRange.createFromVersionSpec("[1.0,1.2),(1.3,1.5]");
range2 = VersionRange.createFromVersionSpec("(1.1,1.4)");
mergedRange = range1.restrict(range2);
- assertNull(mergedRange.getRecommendedVersion(), CHECK_VERSION_RECOMMENDATION);
+ assertThat(mergedRange.getRecommendedVersion()).as(CHECK_VERSION_RECOMMENDATION).isNull();
restrictions = mergedRange.getRestrictions();
- assertEquals(2, restrictions.size(), CHECK_NUM_RESTRICTIONS);
+ assertThat(restrictions.size()).as(CHECK_NUM_RESTRICTIONS).isEqualTo(2);
restriction = restrictions.get(0);
- assertEquals("1.1", restriction.getLowerBound().toString(), CHECK_LOWER_BOUND);
- assertFalse(restriction.isLowerBoundInclusive(), CHECK_LOWER_BOUND_INCLUSIVE);
- assertEquals("1.2", restriction.getUpperBound().toString(), CHECK_UPPER_BOUND);
- assertFalse(restriction.isUpperBoundInclusive(), CHECK_UPPER_BOUND_INCLUSIVE);
+ assertThat(restriction.getLowerBound().toString()).as(CHECK_LOWER_BOUND).isEqualTo("1.1");
+ assertThat(restriction.isLowerBoundInclusive()).as(CHECK_LOWER_BOUND_INCLUSIVE).isFalse();
+ assertThat(restriction.getUpperBound().toString()).as(CHECK_UPPER_BOUND).isEqualTo("1.2");
+ assertThat(restriction.isUpperBoundInclusive()).as(CHECK_UPPER_BOUND_INCLUSIVE).isFalse();
restriction = restrictions.get(1);
- assertEquals("1.3", restriction.getLowerBound().toString(), CHECK_LOWER_BOUND);
- assertFalse(restriction.isLowerBoundInclusive(), CHECK_LOWER_BOUND_INCLUSIVE);
- assertEquals("1.4", restriction.getUpperBound().toString(), CHECK_UPPER_BOUND);
- assertFalse(restriction.isUpperBoundInclusive(), CHECK_UPPER_BOUND_INCLUSIVE);
+ assertThat(restriction.getLowerBound().toString()).as(CHECK_LOWER_BOUND).isEqualTo("1.3");
+ assertThat(restriction.isLowerBoundInclusive()).as(CHECK_LOWER_BOUND_INCLUSIVE).isFalse();
+ assertThat(restriction.getUpperBound().toString()).as(CHECK_UPPER_BOUND).isEqualTo("1.4");
+ assertThat(restriction.isUpperBoundInclusive()).as(CHECK_UPPER_BOUND_INCLUSIVE).isFalse();
range1 = VersionRange.createFromVersionSpec("(,1.1),(1.4,)");
range2 = VersionRange.createFromVersionSpec("[1.1,1.4]");
mergedRange = range1.restrict(range2);
- assertNull(mergedRange.getRecommendedVersion(), CHECK_VERSION_RECOMMENDATION);
+ assertThat(mergedRange.getRecommendedVersion()).as(CHECK_VERSION_RECOMMENDATION).isNull();
restrictions = mergedRange.getRestrictions();
- assertEquals(0, restrictions.size(), CHECK_NUM_RESTRICTIONS);
+ assertThat(restrictions.size()).as(CHECK_NUM_RESTRICTIONS).isEqualTo(0);
range1 = VersionRange.createFromVersionSpec("(,1.1],[1.4,)");
range2 = VersionRange.createFromVersionSpec("(1.1,1.4)");
mergedRange = range1.restrict(range2);
- assertNull(mergedRange.getRecommendedVersion(), CHECK_VERSION_RECOMMENDATION);
+ assertThat(mergedRange.getRecommendedVersion()).as(CHECK_VERSION_RECOMMENDATION).isNull();
restrictions = mergedRange.getRestrictions();
- assertEquals(0, restrictions.size(), CHECK_NUM_RESTRICTIONS);
+ assertThat(restrictions.size()).as(CHECK_NUM_RESTRICTIONS).isEqualTo(0);
range1 = VersionRange.createFromVersionSpec("[,1.1],[1.4,]");
range2 = VersionRange.createFromVersionSpec("[1.2,1.3]");
mergedRange = range1.restrict(range2);
- assertNull(mergedRange.getRecommendedVersion(), CHECK_VERSION_RECOMMENDATION);
+ assertThat(mergedRange.getRecommendedVersion()).as(CHECK_VERSION_RECOMMENDATION).isNull();
restrictions = mergedRange.getRestrictions();
- assertEquals(0, restrictions.size(), CHECK_NUM_RESTRICTIONS);
+ assertThat(restrictions.size()).as(CHECK_NUM_RESTRICTIONS).isEqualTo(0);
range1 = VersionRange.createFromVersionSpec("[1.0,1.2],[1.3,1.5]");
range2 = VersionRange.createFromVersionSpec("[1.1,1.4],[1.6,]");
mergedRange = range1.restrict(range2);
- assertNull(mergedRange.getRecommendedVersion(), CHECK_VERSION_RECOMMENDATION);
+ assertThat(mergedRange.getRecommendedVersion()).as(CHECK_VERSION_RECOMMENDATION).isNull();
restrictions = mergedRange.getRestrictions();
- assertEquals(2, restrictions.size(), CHECK_NUM_RESTRICTIONS);
+ assertThat(restrictions.size()).as(CHECK_NUM_RESTRICTIONS).isEqualTo(2);
restriction = restrictions.get(0);
- assertEquals("1.1", restriction.getLowerBound().toString(), CHECK_LOWER_BOUND);
- assertTrue(restriction.isLowerBoundInclusive(), CHECK_LOWER_BOUND_INCLUSIVE);
- assertEquals("1.2", restriction.getUpperBound().toString(), CHECK_UPPER_BOUND);
- assertTrue(restriction.isUpperBoundInclusive(), CHECK_UPPER_BOUND_INCLUSIVE);
+ assertThat(restriction.getLowerBound().toString()).as(CHECK_LOWER_BOUND).isEqualTo("1.1");
+ assertThat(restriction.isLowerBoundInclusive()).as(CHECK_LOWER_BOUND_INCLUSIVE).isTrue();
+ assertThat(restriction.getUpperBound().toString()).as(CHECK_UPPER_BOUND).isEqualTo("1.2");
+ assertThat(restriction.isUpperBoundInclusive()).as(CHECK_UPPER_BOUND_INCLUSIVE).isTrue();
restriction = restrictions.get(1);
- assertEquals("1.3", restriction.getLowerBound().toString(), CHECK_LOWER_BOUND);
- assertTrue(restriction.isLowerBoundInclusive(), CHECK_LOWER_BOUND_INCLUSIVE);
- assertEquals("1.4", restriction.getUpperBound().toString(), CHECK_UPPER_BOUND);
- assertTrue(restriction.isUpperBoundInclusive(), CHECK_UPPER_BOUND_INCLUSIVE);
+ assertThat(restriction.getLowerBound().toString()).as(CHECK_LOWER_BOUND).isEqualTo("1.3");
+ assertThat(restriction.isLowerBoundInclusive()).as(CHECK_LOWER_BOUND_INCLUSIVE).isTrue();
+ assertThat(restriction.getUpperBound().toString()).as(CHECK_UPPER_BOUND).isEqualTo("1.4");
+ assertThat(restriction.isUpperBoundInclusive()).as(CHECK_UPPER_BOUND_INCLUSIVE).isTrue();
range1 = VersionRange.createFromVersionSpec("[1.0,1.2],[1.3,1.5]");
range2 = VersionRange.createFromVersionSpec("[1.1,1.4],[1.5,]");
mergedRange = range1.restrict(range2);
- assertNull(mergedRange.getRecommendedVersion(), CHECK_VERSION_RECOMMENDATION);
+ assertThat(mergedRange.getRecommendedVersion()).as(CHECK_VERSION_RECOMMENDATION).isNull();
restrictions = mergedRange.getRestrictions();
- assertEquals(3, restrictions.size(), CHECK_NUM_RESTRICTIONS);
+ assertThat(restrictions.size()).as(CHECK_NUM_RESTRICTIONS).isEqualTo(3);
restriction = restrictions.get(0);
- assertEquals("1.1", restriction.getLowerBound().toString(), CHECK_LOWER_BOUND);
- assertTrue(restriction.isLowerBoundInclusive(), CHECK_LOWER_BOUND_INCLUSIVE);
- assertEquals("1.2", restriction.getUpperBound().toString(), CHECK_UPPER_BOUND);
- assertTrue(restriction.isUpperBoundInclusive(), CHECK_UPPER_BOUND_INCLUSIVE);
+ assertThat(restriction.getLowerBound().toString()).as(CHECK_LOWER_BOUND).isEqualTo("1.1");
+ assertThat(restriction.isLowerBoundInclusive()).as(CHECK_LOWER_BOUND_INCLUSIVE).isTrue();
+ assertThat(restriction.getUpperBound().toString()).as(CHECK_UPPER_BOUND).isEqualTo("1.2");
+ assertThat(restriction.isUpperBoundInclusive()).as(CHECK_UPPER_BOUND_INCLUSIVE).isTrue();
restriction = restrictions.get(1);
- assertEquals("1.3", restriction.getLowerBound().toString(), CHECK_LOWER_BOUND);
- assertTrue(restriction.isLowerBoundInclusive(), CHECK_LOWER_BOUND_INCLUSIVE);
- assertEquals("1.4", restriction.getUpperBound().toString(), CHECK_UPPER_BOUND);
- assertTrue(restriction.isUpperBoundInclusive(), CHECK_UPPER_BOUND_INCLUSIVE);
+ assertThat(restriction.getLowerBound().toString()).as(CHECK_LOWER_BOUND).isEqualTo("1.3");
+ assertThat(restriction.isLowerBoundInclusive()).as(CHECK_LOWER_BOUND_INCLUSIVE).isTrue();
+ assertThat(restriction.getUpperBound().toString()).as(CHECK_UPPER_BOUND).isEqualTo("1.4");
+ assertThat(restriction.isUpperBoundInclusive()).as(CHECK_UPPER_BOUND_INCLUSIVE).isTrue();
restriction = restrictions.get(2);
- assertEquals("1.5", restriction.getLowerBound().toString(), CHECK_LOWER_BOUND);
- assertTrue(restriction.isLowerBoundInclusive(), CHECK_LOWER_BOUND_INCLUSIVE);
- assertEquals("1.5", restriction.getUpperBound().toString(), CHECK_UPPER_BOUND);
- assertTrue(restriction.isUpperBoundInclusive(), CHECK_UPPER_BOUND_INCLUSIVE);
+ assertThat(restriction.getLowerBound().toString()).as(CHECK_LOWER_BOUND).isEqualTo("1.5");
+ assertThat(restriction.isLowerBoundInclusive()).as(CHECK_LOWER_BOUND_INCLUSIVE).isTrue();
+ assertThat(restriction.getUpperBound().toString()).as(CHECK_UPPER_BOUND).isEqualTo("1.5");
+ assertThat(restriction.isUpperBoundInclusive()).as(CHECK_UPPER_BOUND_INCLUSIVE).isTrue();
range1 = VersionRange.createFromVersionSpec("[1.0,1.2],[1.3,1.7]");
range2 = VersionRange.createFromVersionSpec("[1.1,1.4],[1.5,1.6]");
mergedRange = range1.restrict(range2);
- assertNull(mergedRange.getRecommendedVersion(), CHECK_VERSION_RECOMMENDATION);
+ assertThat(mergedRange.getRecommendedVersion()).as(CHECK_VERSION_RECOMMENDATION).isNull();
restrictions = mergedRange.getRestrictions();
- assertEquals(3, restrictions.size(), CHECK_NUM_RESTRICTIONS);
+ assertThat(restrictions.size()).as(CHECK_NUM_RESTRICTIONS).isEqualTo(3);
restriction = restrictions.get(0);
- assertEquals("1.1", restriction.getLowerBound().toString(), CHECK_LOWER_BOUND);
- assertTrue(restriction.isLowerBoundInclusive(), CHECK_LOWER_BOUND_INCLUSIVE);
- assertEquals("1.2", restriction.getUpperBound().toString(), CHECK_UPPER_BOUND);
- assertTrue(restriction.isUpperBoundInclusive(), CHECK_UPPER_BOUND_INCLUSIVE);
+ assertThat(restriction.getLowerBound().toString()).as(CHECK_LOWER_BOUND).isEqualTo("1.1");
+ assertThat(restriction.isLowerBoundInclusive()).as(CHECK_LOWER_BOUND_INCLUSIVE).isTrue();
+ assertThat(restriction.getUpperBound().toString()).as(CHECK_UPPER_BOUND).isEqualTo("1.2");
+ assertThat(restriction.isUpperBoundInclusive()).as(CHECK_UPPER_BOUND_INCLUSIVE).isTrue();
restriction = restrictions.get(1);
- assertEquals("1.3", restriction.getLowerBound().toString(), CHECK_LOWER_BOUND);
- assertTrue(restriction.isLowerBoundInclusive(), CHECK_LOWER_BOUND_INCLUSIVE);
- assertEquals("1.4", restriction.getUpperBound().toString(), CHECK_UPPER_BOUND);
- assertTrue(restriction.isUpperBoundInclusive(), CHECK_UPPER_BOUND_INCLUSIVE);
+ assertThat(restriction.getLowerBound().toString()).as(CHECK_LOWER_BOUND).isEqualTo("1.3");
+ assertThat(restriction.isLowerBoundInclusive()).as(CHECK_LOWER_BOUND_INCLUSIVE).isTrue();
+ assertThat(restriction.getUpperBound().toString()).as(CHECK_UPPER_BOUND).isEqualTo("1.4");
+ assertThat(restriction.isUpperBoundInclusive()).as(CHECK_UPPER_BOUND_INCLUSIVE).isTrue();
restriction = restrictions.get(2);
- assertEquals("1.5", restriction.getLowerBound().toString(), CHECK_LOWER_BOUND);
- assertTrue(restriction.isLowerBoundInclusive(), CHECK_LOWER_BOUND_INCLUSIVE);
- assertEquals("1.6", restriction.getUpperBound().toString(), CHECK_UPPER_BOUND);
- assertTrue(restriction.isUpperBoundInclusive(), CHECK_UPPER_BOUND_INCLUSIVE);
+ assertThat(restriction.getLowerBound().toString()).as(CHECK_LOWER_BOUND).isEqualTo("1.5");
+ assertThat(restriction.isLowerBoundInclusive()).as(CHECK_LOWER_BOUND_INCLUSIVE).isTrue();
+ assertThat(restriction.getUpperBound().toString()).as(CHECK_UPPER_BOUND).isEqualTo("1.6");
+ assertThat(restriction.isUpperBoundInclusive()).as(CHECK_UPPER_BOUND_INCLUSIVE).isTrue();
// test restricting empty sets
range1 = VersionRange.createFromVersionSpec("[,1.1],[1.4,]");
range2 = VersionRange.createFromVersionSpec("[1.2,1.3]");
range1 = range1.restrict(range2);
mergedRange = range1.restrict(range2);
- assertNull(mergedRange.getRecommendedVersion(), CHECK_VERSION_RECOMMENDATION);
+ assertThat(mergedRange.getRecommendedVersion()).as(CHECK_VERSION_RECOMMENDATION).isNull();
restrictions = mergedRange.getRestrictions();
- assertEquals(0, restrictions.size(), CHECK_NUM_RESTRICTIONS);
+ assertThat(restrictions.size()).as(CHECK_NUM_RESTRICTIONS).isEqualTo(0);
range1 = VersionRange.createFromVersionSpec("[,1.1],[1.4,]");
range2 = VersionRange.createFromVersionSpec("[1.2,1.3]");
range2 = range1.restrict(range2);
mergedRange = range1.restrict(range2);
- assertNull(mergedRange.getRecommendedVersion(), CHECK_VERSION_RECOMMENDATION);
+ assertThat(mergedRange.getRecommendedVersion()).as(CHECK_VERSION_RECOMMENDATION).isNull();
restrictions = mergedRange.getRestrictions();
- assertEquals(0, restrictions.size(), CHECK_NUM_RESTRICTIONS);
+ assertThat(restrictions.size()).as(CHECK_NUM_RESTRICTIONS).isEqualTo(0);
}
@Test
- void testReleaseRangeBoundsContainsSnapshots() throws InvalidVersionSpecificationException {
+ void releaseRangeBoundsContainsSnapshots() throws InvalidVersionSpecificationException {
VersionRange range = VersionRange.createFromVersionSpec("[1.0,1.2]");
- assertTrue(range.containsVersion(new DefaultArtifactVersion("1.1-SNAPSHOT")));
- assertTrue(range.containsVersion(new DefaultArtifactVersion("1.2-SNAPSHOT")));
- assertFalse(range.containsVersion(new DefaultArtifactVersion("1.0-SNAPSHOT")));
+ assertThat(range.containsVersion(new DefaultArtifactVersion("1.1-SNAPSHOT"))).isTrue();
+ assertThat(range.containsVersion(new DefaultArtifactVersion("1.2-SNAPSHOT"))).isTrue();
+ assertThat(range.containsVersion(new DefaultArtifactVersion("1.0-SNAPSHOT"))).isFalse();
}
@Test
- void testSnapshotRangeBoundsCanContainSnapshots() throws InvalidVersionSpecificationException {
+ void snapshotRangeBoundsCanContainSnapshots() throws InvalidVersionSpecificationException {
VersionRange range = VersionRange.createFromVersionSpec("[1.0,1.2-SNAPSHOT]");
- assertTrue(range.containsVersion(new DefaultArtifactVersion("1.1-SNAPSHOT")));
- assertTrue(range.containsVersion(new DefaultArtifactVersion("1.2-SNAPSHOT")));
+ assertThat(range.containsVersion(new DefaultArtifactVersion("1.1-SNAPSHOT"))).isTrue();
+ assertThat(range.containsVersion(new DefaultArtifactVersion("1.2-SNAPSHOT"))).isTrue();
range = VersionRange.createFromVersionSpec("[1.0-SNAPSHOT,1.2]");
- assertTrue(range.containsVersion(new DefaultArtifactVersion("1.0-SNAPSHOT")));
- assertTrue(range.containsVersion(new DefaultArtifactVersion("1.1-SNAPSHOT")));
+ assertThat(range.containsVersion(new DefaultArtifactVersion("1.0-SNAPSHOT"))).isTrue();
+ assertThat(range.containsVersion(new DefaultArtifactVersion("1.1-SNAPSHOT"))).isTrue();
}
@Test
- void testSnapshotSoftVersionCanContainSnapshot() throws InvalidVersionSpecificationException {
+ void snapshotSoftVersionCanContainSnapshot() throws InvalidVersionSpecificationException {
VersionRange range = VersionRange.createFromVersionSpec("1.0-SNAPSHOT");
- assertTrue(range.containsVersion(new DefaultArtifactVersion("1.0-SNAPSHOT")));
+ assertThat(range.containsVersion(new DefaultArtifactVersion("1.0-SNAPSHOT"))).isTrue();
}
private void checkInvalidRange(String version) {
- assertThrows(
- InvalidVersionSpecificationException.class,
- () -> VersionRange.createFromVersionSpec(version),
- "Version " + version + " should have failed to construct");
+ assertThatExceptionOfType(InvalidVersionSpecificationException.class).as("Version " + version + " should have failed to construct").isThrownBy(() -> VersionRange.createFromVersionSpec(version));
}
@Test
- void testContains() throws InvalidVersionSpecificationException {
+ void contains() throws InvalidVersionSpecificationException {
ArtifactVersion actualVersion = new DefaultArtifactVersion("2.0.5");
- assertTrue(enforceVersion("2.0.5", actualVersion));
- assertTrue(enforceVersion("2.0.4", actualVersion));
- assertTrue(enforceVersion("[2.0.5]", actualVersion));
- assertFalse(enforceVersion("[2.0.6,)", actualVersion));
- assertFalse(enforceVersion("[2.0.6]", actualVersion));
- assertTrue(enforceVersion("[2.0,2.1]", actualVersion));
- assertFalse(enforceVersion("[2.0,2.0.3]", actualVersion));
- assertTrue(enforceVersion("[2.0,2.0.5]", actualVersion));
- assertFalse(enforceVersion("[2.0,2.0.5)", actualVersion));
+ assertThat(enforceVersion("2.0.5", actualVersion)).isTrue();
+ assertThat(enforceVersion("2.0.4", actualVersion)).isTrue();
+ assertThat(enforceVersion("[2.0.5]", actualVersion)).isTrue();
+ assertThat(enforceVersion("[2.0.6,)", actualVersion)).isFalse();
+ assertThat(enforceVersion("[2.0.6]", actualVersion)).isFalse();
+ assertThat(enforceVersion("[2.0,2.1]", actualVersion)).isTrue();
+ assertThat(enforceVersion("[2.0,2.0.3]", actualVersion)).isFalse();
+ assertThat(enforceVersion("[2.0,2.0.5]", actualVersion)).isTrue();
+ assertThat(enforceVersion("[2.0,2.0.5)", actualVersion)).isFalse();
}
public boolean enforceVersion(String requiredVersionRange, ArtifactVersion actualVersion)
@@ -721,22 +714,20 @@ public boolean enforceVersion(String requiredVersionRange, ArtifactVersion actua
}
@Test
- void testCache() throws InvalidVersionSpecificationException {
+ void cache() throws InvalidVersionSpecificationException {
VersionRange range = VersionRange.createFromVersionSpec("[1.0,1.2]");
- assertSame(range, VersionRange.createFromVersionSpec("[1.0,1.2]")); // same instance from spec cache
+ assertThat(VersionRange.createFromVersionSpec("[1.0,1.2]")).isSameAs(range); // same instance from spec cache
VersionRange spec = VersionRange.createFromVersionSpec("1.0");
- assertSame(spec, VersionRange.createFromVersionSpec("1.0")); // same instance from spec cache
+ assertThat(VersionRange.createFromVersionSpec("1.0")).isSameAs(spec); // same instance from spec cache
List restrictions = spec.getRestrictions();
- assertEquals(1, restrictions.size(), CHECK_NUM_RESTRICTIONS);
+ assertThat(restrictions.size()).as(CHECK_NUM_RESTRICTIONS).isEqualTo(1);
VersionRange version = VersionRange.createFromVersion("1.0");
- assertSame(version, VersionRange.createFromVersion("1.0")); // same instance from version cache
+ assertThat(VersionRange.createFromVersion("1.0")).isSameAs(version); // same instance from version cache
restrictions = version.getRestrictions();
- assertEquals(0, restrictions.size(), CHECK_NUM_RESTRICTIONS);
+ assertThat(restrictions.size()).as(CHECK_NUM_RESTRICTIONS).isEqualTo(0);
- assertFalse(
- spec.equals(version),
- "check !VersionRange.createFromVersionSpec(x).equals(VersionRange.createFromVersion(x))");
+ assertThat(version).as("check !VersionRange.createFromVersionSpec(x).equals(VersionRange.createFromVersion(x))").isNotEqualTo(spec);
}
}
diff --git a/compat/maven-builder-support/src/test/java/org/apache/maven/building/DefaultProblemCollectorTest.java b/compat/maven-builder-support/src/test/java/org/apache/maven/building/DefaultProblemCollectorTest.java
index 4ff6750e5ad0..895a8b3b8ada 100644
--- a/compat/maven-builder-support/src/test/java/org/apache/maven/building/DefaultProblemCollectorTest.java
+++ b/compat/maven-builder-support/src/test/java/org/apache/maven/building/DefaultProblemCollectorTest.java
@@ -21,42 +21,40 @@
import org.apache.maven.building.Problem.Severity;
import org.junit.jupiter.api.Test;
-import static org.junit.jupiter.api.Assertions.assertEquals;
-import static org.junit.jupiter.api.Assertions.assertNotNull;
-import static org.junit.jupiter.api.Assertions.assertNull;
+import static org.assertj.core.api.Assertions.assertThat;
class DefaultProblemCollectorTest {
@Test
- void testGetProblems() {
+ void getProblems() {
DefaultProblemCollector collector = new DefaultProblemCollector(null);
- assertNotNull(collector.getProblems());
- assertEquals(0, collector.getProblems().size());
+ assertThat(collector.getProblems()).isNotNull();
+ assertThat(collector.getProblems().size()).isEqualTo(0);
collector.add(null, "MESSAGE1", -1, -1, null);
Exception e2 = new Exception();
collector.add(Severity.WARNING, null, 42, 127, e2);
- assertEquals(2, collector.getProblems().size());
+ assertThat(collector.getProblems().size()).isEqualTo(2);
Problem p1 = collector.getProblems().get(0);
- assertEquals(Severity.ERROR, p1.getSeverity());
- assertEquals("MESSAGE1", p1.getMessage());
- assertEquals(-1, p1.getLineNumber());
- assertEquals(-1, p1.getColumnNumber());
- assertNull(p1.getException());
+ assertThat(p1.getSeverity()).isEqualTo(Severity.ERROR);
+ assertThat(p1.getMessage()).isEqualTo("MESSAGE1");
+ assertThat(p1.getLineNumber()).isEqualTo(-1);
+ assertThat(p1.getColumnNumber()).isEqualTo(-1);
+ assertThat(p1.getException()).isNull();
Problem p2 = collector.getProblems().get(1);
- assertEquals(Severity.WARNING, p2.getSeverity());
- assertEquals("", p2.getMessage());
- assertEquals(42, p2.getLineNumber());
- assertEquals(127, p2.getColumnNumber());
- assertEquals(e2, p2.getException());
+ assertThat(p2.getSeverity()).isEqualTo(Severity.WARNING);
+ assertThat(p2.getMessage()).isEqualTo("");
+ assertThat(p2.getLineNumber()).isEqualTo(42);
+ assertThat(p2.getColumnNumber()).isEqualTo(127);
+ assertThat(p2.getException()).isEqualTo(e2);
}
@Test
- void testSetSource() {
+ void setSource() {
DefaultProblemCollector collector = new DefaultProblemCollector(null);
collector.add(null, "PROBLEM1", -1, -1, null);
@@ -67,8 +65,8 @@ void testSetSource() {
collector.setSource("SOURCE_PROBLEM3");
collector.add(null, "PROBLEM3", -1, -1, null);
- assertEquals("", collector.getProblems().get(0).getSource());
- assertEquals("SOURCE_PROBLEM2", collector.getProblems().get(1).getSource());
- assertEquals("SOURCE_PROBLEM3", collector.getProblems().get(2).getSource());
+ assertThat(collector.getProblems().get(0).getSource()).isEqualTo("");
+ assertThat(collector.getProblems().get(1).getSource()).isEqualTo("SOURCE_PROBLEM2");
+ assertThat(collector.getProblems().get(2).getSource()).isEqualTo("SOURCE_PROBLEM3");
}
}
diff --git a/compat/maven-builder-support/src/test/java/org/apache/maven/building/DefaultProblemTest.java b/compat/maven-builder-support/src/test/java/org/apache/maven/building/DefaultProblemTest.java
index 3bd8a9aa9ec0..95b5bd2df269 100644
--- a/compat/maven-builder-support/src/test/java/org/apache/maven/building/DefaultProblemTest.java
+++ b/compat/maven-builder-support/src/test/java/org/apache/maven/building/DefaultProblemTest.java
@@ -21,108 +21,106 @@
import org.apache.maven.building.Problem.Severity;
import org.junit.jupiter.api.Test;
-import static org.junit.jupiter.api.Assertions.assertEquals;
-import static org.junit.jupiter.api.Assertions.assertNull;
-import static org.junit.jupiter.api.Assertions.assertSame;
+import static org.assertj.core.api.Assertions.assertThat;
class DefaultProblemTest {
@Test
- void testGetSeverity() {
+ void getSeverity() {
DefaultProblem problem = new DefaultProblem(null, null, null, -1, -1, null);
- assertEquals(Severity.ERROR, problem.getSeverity());
+ assertThat(problem.getSeverity()).isEqualTo(Severity.ERROR);
problem = new DefaultProblem(null, Severity.FATAL, null, -1, -1, null);
- assertEquals(Severity.FATAL, problem.getSeverity());
+ assertThat(problem.getSeverity()).isEqualTo(Severity.FATAL);
problem = new DefaultProblem(null, Severity.ERROR, null, -1, -1, null);
- assertEquals(Severity.ERROR, problem.getSeverity());
+ assertThat(problem.getSeverity()).isEqualTo(Severity.ERROR);
problem = new DefaultProblem(null, Severity.WARNING, null, -1, -1, null);
- assertEquals(Severity.WARNING, problem.getSeverity());
+ assertThat(problem.getSeverity()).isEqualTo(Severity.WARNING);
}
@Test
- void testGetLineNumber() {
+ void getLineNumber() {
DefaultProblem problem = new DefaultProblem(null, null, null, -1, -1, null);
- assertEquals(-1, problem.getLineNumber());
+ assertThat(problem.getLineNumber()).isEqualTo(-1);
problem = new DefaultProblem(null, null, null, 42, -1, null);
- assertEquals(42, problem.getLineNumber());
+ assertThat(problem.getLineNumber()).isEqualTo(42);
problem = new DefaultProblem(null, null, null, Integer.MAX_VALUE, -1, null);
- assertEquals(Integer.MAX_VALUE, problem.getLineNumber());
+ assertThat(problem.getLineNumber()).isEqualTo(Integer.MAX_VALUE);
// this case is not specified, might also return -1
problem = new DefaultProblem(null, null, null, Integer.MIN_VALUE, -1, null);
- assertEquals(Integer.MIN_VALUE, problem.getLineNumber());
+ assertThat(problem.getLineNumber()).isEqualTo(Integer.MIN_VALUE);
}
@Test
- void testGetColumnNumber() {
+ void getColumnNumber() {
DefaultProblem problem = new DefaultProblem(null, null, null, -1, -1, null);
- assertEquals(-1, problem.getColumnNumber());
+ assertThat(problem.getColumnNumber()).isEqualTo(-1);
problem = new DefaultProblem(null, null, null, -1, 42, null);
- assertEquals(42, problem.getColumnNumber());
+ assertThat(problem.getColumnNumber()).isEqualTo(42);
problem = new DefaultProblem(null, null, null, -1, Integer.MAX_VALUE, null);
- assertEquals(Integer.MAX_VALUE, problem.getColumnNumber());
+ assertThat(problem.getColumnNumber()).isEqualTo(Integer.MAX_VALUE);
// this case is not specified, might also return -1
problem = new DefaultProblem(null, null, null, -1, Integer.MIN_VALUE, null);
- assertEquals(Integer.MIN_VALUE, problem.getColumnNumber());
+ assertThat(problem.getColumnNumber()).isEqualTo(Integer.MIN_VALUE);
}
@Test
- void testGetException() {
+ void getException() {
DefaultProblem problem = new DefaultProblem(null, null, null, -1, -1, null);
- assertNull(problem.getException());
+ assertThat(problem.getException()).isNull();
Exception e = new Exception();
problem = new DefaultProblem(null, null, null, -1, -1, e);
- assertSame(e, problem.getException());
+ assertThat(problem.getException()).isSameAs(e);
}
@Test
- void testGetSource() {
+ void getSource() {
DefaultProblem problem = new DefaultProblem(null, null, null, -1, -1, null);
- assertEquals("", problem.getSource());
+ assertThat(problem.getSource()).isEqualTo("");
problem = new DefaultProblem(null, null, "", -1, -1, null);
- assertEquals("", problem.getSource());
+ assertThat(problem.getSource()).isEqualTo("");
problem = new DefaultProblem(null, null, "SOURCE", -1, -1, null);
- assertEquals("SOURCE", problem.getSource());
+ assertThat(problem.getSource()).isEqualTo("SOURCE");
}
@Test
- void testGetLocation() {
+ void getLocation() {
DefaultProblem problem = new DefaultProblem(null, null, null, -1, -1, null);
- assertEquals("", problem.getLocation());
+ assertThat(problem.getLocation()).isEqualTo("");
problem = new DefaultProblem(null, null, "SOURCE", -1, -1, null);
- assertEquals("SOURCE", problem.getLocation());
+ assertThat(problem.getLocation()).isEqualTo("SOURCE");
problem = new DefaultProblem(null, null, null, 42, -1, null);
- assertEquals("line 42", problem.getLocation());
+ assertThat(problem.getLocation()).isEqualTo("line 42");
problem = new DefaultProblem(null, null, null, -1, 127, null);
- assertEquals("column 127", problem.getLocation());
+ assertThat(problem.getLocation()).isEqualTo("column 127");
problem = new DefaultProblem(null, null, "SOURCE", 42, 127, null);
- assertEquals("SOURCE, line 42, column 127", problem.getLocation());
+ assertThat(problem.getLocation()).isEqualTo("SOURCE, line 42, column 127");
}
@Test
- void testGetMessage() {
+ void getMessage() {
DefaultProblem problem = new DefaultProblem("MESSAGE", null, null, -1, -1, null);
- assertEquals("MESSAGE", problem.getMessage());
+ assertThat(problem.getMessage()).isEqualTo("MESSAGE");
problem = new DefaultProblem(null, null, null, -1, -1, new Exception());
- assertEquals("", problem.getMessage());
+ assertThat(problem.getMessage()).isEqualTo("");
problem = new DefaultProblem(null, null, null, -1, -1, new Exception("EXCEPTION MESSAGE"));
- assertEquals("EXCEPTION MESSAGE", problem.getMessage());
+ assertThat(problem.getMessage()).isEqualTo("EXCEPTION MESSAGE");
}
}
diff --git a/compat/maven-builder-support/src/test/java/org/apache/maven/building/FileSourceTest.java b/compat/maven-builder-support/src/test/java/org/apache/maven/building/FileSourceTest.java
index 33dd09373548..af7985ddff1e 100644
--- a/compat/maven-builder-support/src/test/java/org/apache/maven/building/FileSourceTest.java
+++ b/compat/maven-builder-support/src/test/java/org/apache/maven/building/FileSourceTest.java
@@ -24,43 +24,40 @@
import org.junit.jupiter.api.Test;
-import static org.junit.jupiter.api.Assertions.assertEquals;
-import static org.junit.jupiter.api.Assertions.assertThrows;
+import static org.assertj.core.api.Assertions.assertThat;
+import static org.assertj.core.api.AssertionsForClassTypes.assertThatExceptionOfType;
class FileSourceTest {
@Test
- void testFileSource() {
- NullPointerException e = assertThrows(
- NullPointerException.class,
- () -> new FileSource((File) null),
- "Should fail, since you must specify a file");
- assertEquals("file cannot be null", e.getMessage());
+ void fileSource() {
+ NullPointerException e = assertThatExceptionOfType(NullPointerException.class).as("Should fail, since you must specify a file").isThrownBy(() -> new FileSource((File) null)).actual();
+ assertThat(e.getMessage()).isEqualTo("file cannot be null");
}
@Test
- void testGetInputStream() throws Exception {
+ void getInputStream() throws Exception {
File txtFile = new File("target/test-classes/source.txt");
FileSource source = new FileSource(txtFile);
try (InputStream is = source.getInputStream();
Scanner scanner = new Scanner(is)) {
- assertEquals("Hello World!", scanner.nextLine());
+ assertThat(scanner.nextLine()).isEqualTo("Hello World!");
}
}
@Test
- void testGetLocation() {
+ void getLocation() {
File txtFile = new File("target/test-classes/source.txt");
FileSource source = new FileSource(txtFile);
- assertEquals(txtFile.getAbsolutePath(), source.getLocation());
+ assertThat(source.getLocation()).isEqualTo(txtFile.getAbsolutePath());
}
@Test
- void testGetFile() {
+ void getFile() {
File txtFile = new File("target/test-classes/source.txt");
FileSource source = new FileSource(txtFile);
- assertEquals(txtFile.getAbsoluteFile(), source.getFile());
+ assertThat(source.getFile()).isEqualTo(txtFile.getAbsoluteFile());
}
}
diff --git a/compat/maven-builder-support/src/test/java/org/apache/maven/building/ProblemCollectorFactoryTest.java b/compat/maven-builder-support/src/test/java/org/apache/maven/building/ProblemCollectorFactoryTest.java
index 6705992befc5..1c3714c0caba 100644
--- a/compat/maven-builder-support/src/test/java/org/apache/maven/building/ProblemCollectorFactoryTest.java
+++ b/compat/maven-builder-support/src/test/java/org/apache/maven/building/ProblemCollectorFactoryTest.java
@@ -22,20 +22,20 @@
import org.junit.jupiter.api.Test;
-import static org.junit.jupiter.api.Assertions.assertEquals;
+import static org.assertj.core.api.Assertions.assertThat;
import static org.junit.jupiter.api.Assertions.assertNotSame;
class ProblemCollectorFactoryTest {
@Test
- void testNewInstance() {
+ void newInstance() {
ProblemCollector collector1 = ProblemCollectorFactory.newInstance(null);
Problem problem = new DefaultProblem("MESSAGE1", null, null, -1, -1, null);
ProblemCollector collector2 = ProblemCollectorFactory.newInstance(Collections.singletonList(problem));
assertNotSame(collector1, collector2);
- assertEquals(0, collector1.getProblems().size());
- assertEquals(1, collector2.getProblems().size());
+ assertThat(collector1.getProblems().size()).isEqualTo(0);
+ assertThat(collector2.getProblems().size()).isEqualTo(1);
}
}
diff --git a/compat/maven-builder-support/src/test/java/org/apache/maven/building/StringSourceTest.java b/compat/maven-builder-support/src/test/java/org/apache/maven/building/StringSourceTest.java
index 8bd2a41587f0..7ebf5c37810b 100644
--- a/compat/maven-builder-support/src/test/java/org/apache/maven/building/StringSourceTest.java
+++ b/compat/maven-builder-support/src/test/java/org/apache/maven/building/StringSourceTest.java
@@ -23,34 +23,34 @@
import org.junit.jupiter.api.Test;
-import static org.junit.jupiter.api.Assertions.assertEquals;
+import static org.assertj.core.api.Assertions.assertThat;
class StringSourceTest {
@Test
- void testGetInputStream() throws Exception {
+ void getInputStream() throws Exception {
StringSource source = new StringSource("Hello World!");
try (InputStream is = source.getInputStream();
Scanner scanner = new Scanner(is)) {
- assertEquals("Hello World!", scanner.nextLine());
+ assertThat(scanner.nextLine()).isEqualTo("Hello World!");
}
}
@Test
- void testGetLocation() {
+ void getLocation() {
StringSource source = new StringSource("Hello World!");
- assertEquals("(memory)", source.getLocation());
+ assertThat(source.getLocation()).isEqualTo("(memory)");
source = new StringSource("Hello World!", "LOCATION");
- assertEquals("LOCATION", source.getLocation());
+ assertThat(source.getLocation()).isEqualTo("LOCATION");
}
@Test
- void testGetContent() {
+ void getContent() {
StringSource source = new StringSource(null);
- assertEquals("", source.getContent());
+ assertThat(source.getContent()).isEqualTo("");
source = new StringSource("Hello World!", "LOCATION");
- assertEquals("Hello World!", source.getContent());
+ assertThat(source.getContent()).isEqualTo("Hello World!");
}
}
diff --git a/compat/maven-builder-support/src/test/java/org/apache/maven/building/UrlSourceTest.java b/compat/maven-builder-support/src/test/java/org/apache/maven/building/UrlSourceTest.java
index 216c5d7c72a4..c9f802561e98 100644
--- a/compat/maven-builder-support/src/test/java/org/apache/maven/building/UrlSourceTest.java
+++ b/compat/maven-builder-support/src/test/java/org/apache/maven/building/UrlSourceTest.java
@@ -25,32 +25,31 @@
import org.junit.jupiter.api.Test;
-import static org.junit.jupiter.api.Assertions.assertEquals;
-import static org.junit.jupiter.api.Assertions.assertThrows;
+import static org.assertj.core.api.Assertions.assertThat;
+import static org.assertj.core.api.AssertionsForClassTypes.assertThatExceptionOfType;
class UrlSourceTest {
@Test
- void testUrlSource() {
- NullPointerException e = assertThrows(
- NullPointerException.class, () -> new UrlSource(null), "Should fail, since you must specify a url");
- assertEquals("url cannot be null", e.getMessage());
+ void urlSource() {
+ NullPointerException e = assertThatExceptionOfType(NullPointerException.class).as("Should fail, since you must specify a url").isThrownBy(() -> new UrlSource(null)).actual();
+ assertThat(e.getMessage()).isEqualTo("url cannot be null");
}
@Test
- void testGetInputStream() throws Exception {
+ void getInputStream() throws Exception {
URL txtFile = new File("target/test-classes/source.txt").toURI().toURL();
UrlSource source = new UrlSource(txtFile);
try (InputStream is = source.getInputStream();
Scanner scanner = new Scanner(is)) {
- assertEquals("Hello World!", scanner.nextLine());
+ assertThat(scanner.nextLine()).isEqualTo("Hello World!");
}
}
@Test
- void testGetLocation() throws Exception {
+ void getLocation() throws Exception {
URL txtFile = new File("target/test-classes/source.txt").toURI().toURL();
UrlSource source = new UrlSource(txtFile);
- assertEquals(txtFile.toExternalForm(), source.getLocation());
+ assertThat(source.getLocation()).isEqualTo(txtFile.toExternalForm());
}
}
diff --git a/compat/maven-compat/src/test/java/org/apache/maven/ProjectDependenciesResolverTest.java b/compat/maven-compat/src/test/java/org/apache/maven/ProjectDependenciesResolverTest.java
index 5cc242c09648..25fba367dcb7 100644
--- a/compat/maven-compat/src/test/java/org/apache/maven/ProjectDependenciesResolverTest.java
+++ b/compat/maven-compat/src/test/java/org/apache/maven/ProjectDependenciesResolverTest.java
@@ -31,10 +31,10 @@
import org.apache.maven.project.MavenProject;
import org.junit.jupiter.api.Test;
+import static org.assertj.core.api.Assertions.assertThat;
import static org.codehaus.plexus.testing.PlexusExtension.getBasedir;
import static org.hamcrest.MatcherAssert.assertThat;
import static org.hamcrest.Matchers.endsWith;
-import static org.junit.jupiter.api.Assertions.assertEquals;
@Deprecated
class ProjectDependenciesResolverTest extends AbstractCoreMavenComponentTestCase {
@@ -46,7 +46,7 @@ protected String getProjectsDirectory() {
}
@Test
- void testSystemScopeDependencies() throws Exception {
+ void systemScopeDependencies() throws Exception {
MavenSession session = createMavenSession(null);
MavenProject project = session.getCurrentProject();
@@ -60,11 +60,11 @@ void testSystemScopeDependencies() throws Exception {
Set artifactDependencies =
resolver.resolve(project, Collections.singleton(Artifact.SCOPE_COMPILE), session);
- assertEquals(1, artifactDependencies.size());
+ assertThat(artifactDependencies.size()).isEqualTo(1);
}
@Test
- void testSystemScopeDependencyIsPresentInTheCompileClasspathElements() throws Exception {
+ void systemScopeDependencyIsPresentInTheCompileClasspathElements() throws Exception {
File pom = getProject("it0063");
Properties eps = new Properties();
@@ -76,11 +76,11 @@ void testSystemScopeDependencyIsPresentInTheCompileClasspathElements() throws Ex
project.setArtifacts(resolver.resolve(project, Collections.singleton(Artifact.SCOPE_COMPILE), session));
List elements = project.getCompileClasspathElements();
- assertEquals(2, elements.size());
+ assertThat(elements.size()).isEqualTo(2);
@SuppressWarnings("deprecation")
List artifacts = project.getCompileArtifacts();
- assertEquals(1, artifacts.size());
+ assertThat(artifacts.size()).isEqualTo(1);
assertThat(artifacts.get(0).getFile().getName(), endsWith("tools.jar"));
}
}
diff --git a/compat/maven-compat/src/test/java/org/apache/maven/artifact/AbstractArtifactComponentTestCase.java b/compat/maven-compat/src/test/java/org/apache/maven/artifact/AbstractArtifactComponentTestCase.java
index 14f394c0c1cd..2e914638d244 100644
--- a/compat/maven-compat/src/test/java/org/apache/maven/artifact/AbstractArtifactComponentTestCase.java
+++ b/compat/maven-compat/src/test/java/org/apache/maven/artifact/AbstractArtifactComponentTestCase.java
@@ -75,9 +75,8 @@
import org.eclipse.aether.util.repository.SimpleArtifactDescriptorPolicy;
import org.junit.jupiter.api.BeforeEach;
+import static org.assertj.core.api.Assertions.assertThat;
import static org.codehaus.plexus.testing.PlexusExtension.getBasedir;
-import static org.junit.jupiter.api.Assertions.assertFalse;
-import static org.junit.jupiter.api.Assertions.assertTrue;
/**
*/
@@ -176,7 +175,7 @@ protected void assertRemoteArtifactPresent(Artifact artifact) throws Exception {
File file = new File(remoteRepo.getBasedir(), path);
- assertTrue(file.exists(), "Remote artifact " + file + " should be present.");
+ assertThat(file.exists()).as("Remote artifact " + file + " should be present.").isTrue();
}
protected void assertLocalArtifactPresent(Artifact artifact) throws Exception {
@@ -186,7 +185,7 @@ protected void assertLocalArtifactPresent(Artifact artifact) throws Exception {
File file = new File(localRepo.getBasedir(), path);
- assertTrue(file.exists(), "Local artifact " + file + " should be present.");
+ assertThat(file.exists()).as("Local artifact " + file + " should be present.").isTrue();
}
protected void assertRemoteArtifactNotPresent(Artifact artifact) throws Exception {
@@ -196,7 +195,7 @@ protected void assertRemoteArtifactNotPresent(Artifact artifact) throws Exceptio
File file = new File(remoteRepo.getBasedir(), path);
- assertFalse(file.exists(), "Remote artifact " + file + " should not be present.");
+ assertThat(file.exists()).as("Remote artifact " + file + " should not be present.").isFalse();
}
protected void assertLocalArtifactNotPresent(Artifact artifact) throws Exception {
@@ -206,7 +205,7 @@ protected void assertLocalArtifactNotPresent(Artifact artifact) throws Exception
File file = new File(localRepo.getBasedir(), path);
- assertFalse(file.exists(), "Local artifact " + file + " should not be present.");
+ assertThat(file.exists()).as("Local artifact " + file + " should not be present.").isFalse();
}
// ----------------------------------------------------------------------
diff --git a/compat/maven-compat/src/test/java/org/apache/maven/artifact/deployer/ArtifactDeployerTest.java b/compat/maven-compat/src/test/java/org/apache/maven/artifact/deployer/ArtifactDeployerTest.java
index 0435e1195252..d15ee8ea1c8b 100644
--- a/compat/maven-compat/src/test/java/org/apache/maven/artifact/deployer/ArtifactDeployerTest.java
+++ b/compat/maven-compat/src/test/java/org/apache/maven/artifact/deployer/ArtifactDeployerTest.java
@@ -31,9 +31,8 @@
import org.apache.maven.session.scope.internal.SessionScope;
import org.junit.jupiter.api.Test;
+import static org.assertj.core.api.Assertions.assertThat;
import static org.codehaus.plexus.testing.PlexusExtension.getBasedir;
-import static org.junit.jupiter.api.Assertions.assertEquals;
-import static org.junit.jupiter.api.Assertions.assertTrue;
import static org.mockito.Mockito.mock;
/**
@@ -51,7 +50,7 @@ protected String component() {
}
@Test
- void testArtifactInstallation() throws Exception {
+ void artifactInstallation() throws Exception {
sessionScope.enter();
try {
sessionScope.seed(MavenSession.class, mock(MavenSession.class));
@@ -61,14 +60,14 @@ void testArtifactInstallation() throws Exception {
Artifact artifact = createArtifact("artifact", "1.0");
File file = new File(artifactBasedir, "artifact-1.0.jar");
- assertEquals("dummy", new String(Files.readAllBytes(file.toPath()), StandardCharsets.UTF_8).trim());
+ assertThat(new String(Files.readAllBytes(file.toPath()), StandardCharsets.UTF_8).trim()).isEqualTo("dummy");
artifactDeployer.deploy(file, artifact, remoteRepository(), localRepository());
ArtifactRepository remoteRepository = remoteRepository();
File deployedFile = new File(remoteRepository.getBasedir(), remoteRepository.pathOf(artifact));
- assertTrue(deployedFile.exists());
- assertEquals("dummy", new String(Files.readAllBytes(deployedFile.toPath()), StandardCharsets.UTF_8).trim());
+ assertThat(deployedFile.exists()).isTrue();
+ assertThat(new String(Files.readAllBytes(deployedFile.toPath()), StandardCharsets.UTF_8).trim()).isEqualTo("dummy");
} finally {
sessionScope.exit();
}
diff --git a/compat/maven-compat/src/test/java/org/apache/maven/artifact/factory/DefaultArtifactFactoryTest.java b/compat/maven-compat/src/test/java/org/apache/maven/artifact/factory/DefaultArtifactFactoryTest.java
index 634e7f7462ef..5078879087db 100644
--- a/compat/maven-compat/src/test/java/org/apache/maven/artifact/factory/DefaultArtifactFactoryTest.java
+++ b/compat/maven-compat/src/test/java/org/apache/maven/artifact/factory/DefaultArtifactFactoryTest.java
@@ -25,7 +25,7 @@
import org.codehaus.plexus.testing.PlexusTest;
import org.junit.jupiter.api.Test;
-import static org.junit.jupiter.api.Assertions.assertEquals;
+import static org.assertj.core.api.Assertions.assertThat;
@PlexusTest
@Deprecated
@@ -35,7 +35,7 @@ class DefaultArtifactFactoryTest {
ArtifactFactory factory;
@Test
- void testPropagationOfSystemScopeRegardlessOfInheritedScope() {
+ void propagationOfSystemScopeRegardlessOfInheritedScope() {
Artifact artifact = factory.createDependencyArtifact(
"test-grp", "test-artifact", VersionRange.createFromVersion("1.0"), "type", null, "system", "provided");
Artifact artifact2 = factory.createDependencyArtifact(
@@ -61,10 +61,10 @@ void testPropagationOfSystemScopeRegardlessOfInheritedScope() {
Artifact artifact5 = factory.createDependencyArtifact(
"test-grp", "test-artifact-5", VersionRange.createFromVersion("1.0"), "type", null, "system", "system");
- assertEquals("system", artifact.getScope());
- assertEquals("system", artifact2.getScope());
- assertEquals("system", artifact3.getScope());
- assertEquals("system", artifact4.getScope());
- assertEquals("system", artifact5.getScope());
+ assertThat(artifact.getScope()).isEqualTo("system");
+ assertThat(artifact2.getScope()).isEqualTo("system");
+ assertThat(artifact3.getScope()).isEqualTo("system");
+ assertThat(artifact4.getScope()).isEqualTo("system");
+ assertThat(artifact5.getScope()).isEqualTo("system");
}
}
diff --git a/compat/maven-compat/src/test/java/org/apache/maven/artifact/installer/ArtifactInstallerTest.java b/compat/maven-compat/src/test/java/org/apache/maven/artifact/installer/ArtifactInstallerTest.java
index 0d24d73bcbc1..06313ccd1059 100644
--- a/compat/maven-compat/src/test/java/org/apache/maven/artifact/installer/ArtifactInstallerTest.java
+++ b/compat/maven-compat/src/test/java/org/apache/maven/artifact/installer/ArtifactInstallerTest.java
@@ -46,7 +46,7 @@ protected String component() {
}
@Test
- void testArtifactInstallation() throws Exception {
+ void artifactInstallation() throws Exception {
sessionScope.enter();
try {
sessionScope.seed(MavenSession.class, mock(MavenSession.class));
diff --git a/compat/maven-compat/src/test/java/org/apache/maven/artifact/repository/MavenArtifactRepositoryTest.java b/compat/maven-compat/src/test/java/org/apache/maven/artifact/repository/MavenArtifactRepositoryTest.java
index f529ae822ba4..2a44a0c961cb 100644
--- a/compat/maven-compat/src/test/java/org/apache/maven/artifact/repository/MavenArtifactRepositoryTest.java
+++ b/compat/maven-compat/src/test/java/org/apache/maven/artifact/repository/MavenArtifactRepositoryTest.java
@@ -20,8 +20,7 @@
import org.junit.jupiter.api.Test;
-import static org.junit.jupiter.api.Assertions.assertFalse;
-import static org.junit.jupiter.api.Assertions.assertTrue;
+import static org.assertj.core.api.Assertions.assertThat;
@Deprecated
class MavenArtifactRepositoryTest {
@@ -39,18 +38,18 @@ public String getId() {
}
@Test
- void testHashCodeEquals() {
+ void hashCodeEquals() {
MavenArtifactRepositorySubclass r1 = new MavenArtifactRepositorySubclass("foo");
MavenArtifactRepositorySubclass r2 = new MavenArtifactRepositorySubclass("foo");
MavenArtifactRepositorySubclass r3 = new MavenArtifactRepositorySubclass("bar");
- assertTrue(r1.hashCode() == r2.hashCode());
- assertFalse(r1.hashCode() == r3.hashCode());
+ assertThat(r2.hashCode()).isEqualTo(r1.hashCode());
+ assertThat(r1.hashCode() == r3.hashCode()).isFalse();
- assertTrue(r1.equals(r2));
- assertTrue(r2.equals(r1));
+ assertThat(r2).isEqualTo(r1);
+ assertThat(r1).isEqualTo(r2);
- assertFalse(r1.equals(r3));
- assertFalse(r3.equals(r1));
+ assertThat(r3).isNotEqualTo(r1);
+ assertThat(r1).isNotEqualTo(r3);
}
}
diff --git a/compat/maven-compat/src/test/java/org/apache/maven/artifact/resolver/ArtifactResolutionExceptionTest.java b/compat/maven-compat/src/test/java/org/apache/maven/artifact/resolver/ArtifactResolutionExceptionTest.java
index 385660370138..64bf2ba841d0 100644
--- a/compat/maven-compat/src/test/java/org/apache/maven/artifact/resolver/ArtifactResolutionExceptionTest.java
+++ b/compat/maven-compat/src/test/java/org/apache/maven/artifact/resolver/ArtifactResolutionExceptionTest.java
@@ -23,7 +23,7 @@
import org.junit.jupiter.api.Test;
-import static org.junit.jupiter.api.Assertions.assertEquals;
+import static org.assertj.core.api.Assertions.assertThat;
/**
* Test the artifact resolution exception message
@@ -33,7 +33,7 @@ class ArtifactResolutionExceptionTest {
private static final String LS = System.lineSeparator();
@Test
- void testMissingArtifactMessageFormat() {
+ void missingArtifactMessageFormat() {
String message = "Missing artifact";
String indentation = " ";
String groupId = "aGroupId";
@@ -54,6 +54,6 @@ void testMissingArtifactMessageFormat() {
+ LS + " \t2) dependency2" + LS + LS;
String actual = AbstractArtifactResolutionException.constructMissingArtifactMessage(
message, indentation, groupId, artifactId, version, type, classifier, downloadUrl, path);
- assertEquals(expected, actual);
+ assertThat(actual).isEqualTo(expected);
}
}
diff --git a/compat/maven-compat/src/test/java/org/apache/maven/artifact/resolver/ArtifactResolverTest.java b/compat/maven-compat/src/test/java/org/apache/maven/artifact/resolver/ArtifactResolverTest.java
index 30ade70a919b..8aa0fcfbd036 100644
--- a/compat/maven-compat/src/test/java/org/apache/maven/artifact/resolver/ArtifactResolverTest.java
+++ b/compat/maven-compat/src/test/java/org/apache/maven/artifact/resolver/ArtifactResolverTest.java
@@ -39,9 +39,8 @@
import org.junit.jupiter.api.BeforeEach;
import org.junit.jupiter.api.Test;
-import static org.junit.jupiter.api.Assertions.assertEquals;
-import static org.junit.jupiter.api.Assertions.assertThrows;
-import static org.junit.jupiter.api.Assertions.assertTrue;
+import static org.assertj.core.api.Assertions.assertThat;
+import static org.assertj.core.api.AssertionsForClassTypes.assertThatExceptionOfType;
// It would be cool if there was a hook that I could use to set up a test environment.
// I want to set up a local/remote repositories for testing but I don't want to have
@@ -79,7 +78,7 @@ protected String component() {
}
@Test
- void testResolutionOfASingleArtifactWhereTheArtifactIsPresentInTheLocalRepository() throws Exception {
+ void resolutionOfASingleArtifactWhereTheArtifactIsPresentInTheLocalRepository() throws Exception {
Artifact a = createLocalArtifact("a", "1.0");
artifactResolver.resolve(a, remoteRepositories(), localRepository());
@@ -88,7 +87,7 @@ void testResolutionOfASingleArtifactWhereTheArtifactIsPresentInTheLocalRepositor
}
@Test
- void testResolutionOfASingleArtifactWhereTheArtifactIsNotPresentLocallyAndMustBeRetrievedFromTheRemoteRepository()
+ void resolutionOfASingleArtifactWhereTheArtifactIsNotPresentLocallyAndMustBeRetrievedFromTheRemoteRepository()
throws Exception {
Artifact b = createRemoteArtifact("b", "1.0-SNAPSHOT");
deleteLocalArtifact(b);
@@ -103,7 +102,7 @@ protected Artifact createArtifact(String groupId, String artifactId, String vers
}
@Test
- void testTransitiveResolutionWhereAllArtifactsArePresentInTheLocalRepository() throws Exception {
+ void transitiveResolutionWhereAllArtifactsArePresentInTheLocalRepository() throws Exception {
Artifact g = createLocalArtifact("g", "1.0");
Artifact h = createLocalArtifact("h", "1.0");
@@ -113,11 +112,11 @@ void testTransitiveResolutionWhereAllArtifactsArePresentInTheLocalRepository() t
printErrors(result);
- assertEquals(2, result.getArtifacts().size());
+ assertThat(result.getArtifacts().size()).isEqualTo(2);
- assertTrue(result.getArtifacts().contains(g));
+ assertThat(result.getArtifacts().contains(g)).isTrue();
- assertTrue(result.getArtifacts().contains(h));
+ assertThat(result.getArtifacts().contains(h)).isTrue();
assertLocalArtifactPresent(g);
@@ -126,7 +125,7 @@ void testTransitiveResolutionWhereAllArtifactsArePresentInTheLocalRepository() t
@Test
void
- testTransitiveResolutionWhereAllArtifactsAreNotPresentInTheLocalRepositoryAndMustBeRetrievedFromTheRemoteRepository()
+ transitiveResolutionWhereAllArtifactsAreNotPresentInTheLocalRepositoryAndMustBeRetrievedFromTheRemoteRepository()
throws Exception {
Artifact i = createRemoteArtifact("i", "1.0-SNAPSHOT");
deleteLocalArtifact(i);
@@ -139,11 +138,11 @@ void testTransitiveResolutionWhereAllArtifactsArePresentInTheLocalRepository() t
printErrors(result);
- assertEquals(2, result.getArtifacts().size());
+ assertThat(result.getArtifacts().size()).isEqualTo(2);
- assertTrue(result.getArtifacts().contains(i));
+ assertThat(result.getArtifacts().contains(i)).isTrue();
- assertTrue(result.getArtifacts().contains(j));
+ assertThat(result.getArtifacts().contains(j)).isTrue();
assertLocalArtifactPresent(i);
@@ -151,17 +150,14 @@ void testTransitiveResolutionWhereAllArtifactsArePresentInTheLocalRepository() t
}
@Test
- void testResolutionFailureWhenArtifactNotPresentInRemoteRepository() throws Exception {
+ void resolutionFailureWhenArtifactNotPresentInRemoteRepository() throws Exception {
Artifact k = createArtifact("k", "1.0");
- assertThrows(
- ArtifactNotFoundException.class,
- () -> artifactResolver.resolve(k, remoteRepositories(), localRepository()),
- "Resolution succeeded when it should have failed");
+ assertThatExceptionOfType(ArtifactNotFoundException.class).as("Resolution succeeded when it should have failed").isThrownBy(() -> artifactResolver.resolve(k, remoteRepositories(), localRepository()));
}
@Test
- void testResolutionOfAnArtifactWhereOneRemoteRepositoryIsBadButOneIsGood() throws Exception {
+ void resolutionOfAnArtifactWhereOneRemoteRepositoryIsBadButOneIsGood() throws Exception {
Artifact l = createRemoteArtifact("l", "1.0-SNAPSHOT");
deleteLocalArtifact(l);
@@ -175,19 +171,19 @@ void testResolutionOfAnArtifactWhereOneRemoteRepositoryIsBadButOneIsGood() throw
}
@Test
- public void testReadRepoFromModel() throws Exception {
+ void readRepoFromModel() throws Exception {
Artifact artifact = createArtifact(TestMavenWorkspaceReader.ARTIFACT_ID, TestMavenWorkspaceReader.VERSION);
ArtifactMetadataSource source = getContainer().lookup(ArtifactMetadataSource.class, "maven");
ResolutionGroup group = source.retrieve(artifact, localRepository(), new ArrayList<>());
List repositories = group.getResolutionRepositories();
- assertEquals(1, repositories.size(), "There should be one repository!");
+ assertThat(repositories.size()).as("There should be one repository!").isEqualTo(1);
ArtifactRepository repository = repositories.get(0);
- assertEquals(TestMavenWorkspaceReader.REPO_ID, repository.getId());
- assertEquals(TestMavenWorkspaceReader.REPO_URL, repository.getUrl());
+ assertThat(repository.getId()).isEqualTo(TestMavenWorkspaceReader.REPO_ID);
+ assertThat(repository.getUrl()).isEqualTo(TestMavenWorkspaceReader.REPO_URL);
}
@Test
- void testTransitiveResolutionOrder() throws Exception {
+ void transitiveResolutionOrder() throws Exception {
Artifact m = createLocalArtifact("m", "1.0");
Artifact n = createLocalArtifact("n", "1.0");
@@ -241,8 +237,8 @@ public List retrieveAvailableVersions(MetadataResolutionRequest
printErrors(result);
Iterator i = result.getArtifacts().iterator();
- assertEquals(n, i.next(), "n should be first");
- assertEquals(m, i.next(), "m should be second");
+ assertThat(i.next()).as("n should be first").isEqualTo(n);
+ assertThat(i.next()).as("m should be second").isEqualTo(m);
// inverse order
set = new LinkedHashSet<>();
@@ -255,8 +251,8 @@ public List retrieveAvailableVersions(MetadataResolutionRequest
printErrors(result);
i = result.getArtifacts().iterator();
- assertEquals(m, i.next(), "m should be first");
- assertEquals(n, i.next(), "n should be second");
+ assertThat(i.next()).as("m should be first").isEqualTo(m);
+ assertThat(i.next()).as("n should be second").isEqualTo(n);
}
private void printErrors(ArtifactResolutionResult result) {
diff --git a/compat/maven-compat/src/test/java/org/apache/maven/artifact/resolver/DefaultArtifactResolverTest.java b/compat/maven-compat/src/test/java/org/apache/maven/artifact/resolver/DefaultArtifactResolverTest.java
index a523b0d356af..0aeca49c728c 100644
--- a/compat/maven-compat/src/test/java/org/apache/maven/artifact/resolver/DefaultArtifactResolverTest.java
+++ b/compat/maven-compat/src/test/java/org/apache/maven/artifact/resolver/DefaultArtifactResolverTest.java
@@ -27,8 +27,7 @@
import org.junit.jupiter.api.BeforeEach;
import org.junit.jupiter.api.Test;
-import static org.junit.jupiter.api.Assertions.assertNotNull;
-import static org.junit.jupiter.api.Assertions.assertTrue;
+import static org.assertj.core.api.Assertions.assertThat;
@Deprecated
class DefaultArtifactResolverTest extends AbstractArtifactComponentTestCase {
@@ -50,7 +49,7 @@ protected String component() {
}
@Test
- void testMNG4738() throws Exception {
+ void mng4738() throws Exception {
Artifact g = createLocalArtifact("g", "1.0");
createLocalArtifact("h", "1.0");
artifactResolver.resolveTransitively(
@@ -81,16 +80,16 @@ void testMNG4738() throws Exception {
for (Thread active : ts) {
String name = active.getName();
boolean daemon = active.isDaemon();
- assertTrue(daemon, name + " is no daemon Thread.");
+ assertThat(daemon).as(name + " is no daemon Thread.").isTrue();
}
}
- assertTrue(seen, "Could not find ThreadGroup: " + DefaultArtifactResolver.DaemonThreadCreator.THREADGROUP_NAME);
+ assertThat(seen).as("Could not find ThreadGroup: " + DefaultArtifactResolver.DaemonThreadCreator.THREADGROUP_NAME).isTrue();
}
@Test
- void testLookup() throws Exception {
+ void lookup() throws Exception {
ArtifactResolver resolver = getContainer().lookup(ArtifactResolver.class, "default");
- assertNotNull(resolver);
+ assertThat(resolver).isNotNull();
}
}
diff --git a/compat/maven-compat/src/test/java/org/apache/maven/artifact/resolver/filter/AndArtifactFilterTest.java b/compat/maven-compat/src/test/java/org/apache/maven/artifact/resolver/filter/AndArtifactFilterTest.java
index fe0343c857cb..45a3cc385fa9 100644
--- a/compat/maven-compat/src/test/java/org/apache/maven/artifact/resolver/filter/AndArtifactFilterTest.java
+++ b/compat/maven-compat/src/test/java/org/apache/maven/artifact/resolver/filter/AndArtifactFilterTest.java
@@ -22,9 +22,7 @@
import org.junit.jupiter.api.Test;
-import static org.junit.jupiter.api.Assertions.assertEquals;
-import static org.junit.jupiter.api.Assertions.assertFalse;
-import static org.junit.jupiter.api.Assertions.assertTrue;
+import static org.assertj.core.api.Assertions.assertThat;
/**
* Tests {@link AndArtifactFilter}.
@@ -37,16 +35,16 @@ private ArtifactFilter newSubFilter() {
}
@Test
- void testEquals() {
+ void equals() {
AndArtifactFilter filter1 = new AndArtifactFilter();
AndArtifactFilter filter2 = new AndArtifactFilter(Arrays.asList(newSubFilter()));
- assertFalse(filter1.equals(null));
- assertTrue(filter1.equals(filter1));
- assertEquals(filter1.hashCode(), filter1.hashCode());
+ assertThat(filter1).isNotEqualTo(null);
+ assertThat(filter1).isEqualTo(filter1);
+ assertThat(filter1.hashCode()).isEqualTo(filter1.hashCode());
- assertFalse(filter1.equals(filter2));
- assertFalse(filter2.equals(filter1));
+ assertThat(filter2).isNotEqualTo(filter1);
+ assertThat(filter1).isNotEqualTo(filter2);
}
}
diff --git a/compat/maven-compat/src/test/java/org/apache/maven/artifact/resolver/filter/FilterHashEqualsTest.java b/compat/maven-compat/src/test/java/org/apache/maven/artifact/resolver/filter/FilterHashEqualsTest.java
index 53a26db4ea12..36de5d10459c 100644
--- a/compat/maven-compat/src/test/java/org/apache/maven/artifact/resolver/filter/FilterHashEqualsTest.java
+++ b/compat/maven-compat/src/test/java/org/apache/maven/artifact/resolver/filter/FilterHashEqualsTest.java
@@ -23,26 +23,26 @@
import org.junit.jupiter.api.Test;
-import static org.junit.jupiter.api.Assertions.assertTrue;
+import static org.assertj.core.api.Assertions.assertThat;
/**
*/
class FilterHashEqualsTest {
@Test
- void testIncludesExcludesArtifactFilter() {
+ void includesExcludesArtifactFilter() {
List patterns = Arrays.asList("c", "d", "e");
IncludesArtifactFilter f1 = new IncludesArtifactFilter(patterns);
IncludesArtifactFilter f2 = new IncludesArtifactFilter(patterns);
- assertTrue(f1.equals(f2));
- assertTrue(f2.equals(f1));
- assertTrue(f1.hashCode() == f2.hashCode());
+ assertThat(f2).isEqualTo(f1);
+ assertThat(f1).isEqualTo(f2);
+ assertThat(f2.hashCode()).isEqualTo(f1.hashCode());
IncludesArtifactFilter f3 = new IncludesArtifactFilter(Arrays.asList("d", "c", "e"));
- assertTrue(f1.equals(f3));
- assertTrue(f1.hashCode() == f3.hashCode());
+ assertThat(f3).isEqualTo(f1);
+ assertThat(f3.hashCode()).isEqualTo(f1.hashCode());
}
}
diff --git a/compat/maven-compat/src/test/java/org/apache/maven/artifact/resolver/filter/OrArtifactFilterTest.java b/compat/maven-compat/src/test/java/org/apache/maven/artifact/resolver/filter/OrArtifactFilterTest.java
index 6c8cda6802bc..62b8f58c2d96 100644
--- a/compat/maven-compat/src/test/java/org/apache/maven/artifact/resolver/filter/OrArtifactFilterTest.java
+++ b/compat/maven-compat/src/test/java/org/apache/maven/artifact/resolver/filter/OrArtifactFilterTest.java
@@ -22,9 +22,7 @@
import org.junit.jupiter.api.Test;
-import static org.junit.jupiter.api.Assertions.assertEquals;
-import static org.junit.jupiter.api.Assertions.assertFalse;
-import static org.junit.jupiter.api.Assertions.assertTrue;
+import static org.assertj.core.api.Assertions.assertThat;
/**
* Tests {@link OrArtifactFilter}.
@@ -38,16 +36,16 @@ private ArtifactFilter newSubFilter() {
}
@Test
- void testEquals() {
+ void equals() {
OrArtifactFilter filter1 = new OrArtifactFilter();
OrArtifactFilter filter2 = new OrArtifactFilter(Arrays.asList(newSubFilter()));
- assertFalse(filter1.equals(null));
- assertTrue(filter1.equals(filter1));
- assertEquals(filter1.hashCode(), filter1.hashCode());
+ assertThat(filter1).isNotEqualTo(null);
+ assertThat(filter1).isEqualTo(filter1);
+ assertThat(filter1.hashCode()).isEqualTo(filter1.hashCode());
- assertFalse(filter1.equals(filter2));
- assertFalse(filter2.equals(filter1));
+ assertThat(filter2).isNotEqualTo(filter1);
+ assertThat(filter1).isNotEqualTo(filter2);
}
}
diff --git a/compat/maven-compat/src/test/java/org/apache/maven/artifact/resolver/filter/ScopeArtifactFilterTest.java b/compat/maven-compat/src/test/java/org/apache/maven/artifact/resolver/filter/ScopeArtifactFilterTest.java
index 0addbe8023bd..19b20768723b 100644
--- a/compat/maven-compat/src/test/java/org/apache/maven/artifact/resolver/filter/ScopeArtifactFilterTest.java
+++ b/compat/maven-compat/src/test/java/org/apache/maven/artifact/resolver/filter/ScopeArtifactFilterTest.java
@@ -22,8 +22,7 @@
import org.apache.maven.artifact.DefaultArtifact;
import org.junit.jupiter.api.Test;
-import static org.junit.jupiter.api.Assertions.assertFalse;
-import static org.junit.jupiter.api.Assertions.assertTrue;
+import static org.assertj.core.api.Assertions.assertThat;
/**
* Tests {@link ScopeArtifactFilter}.
@@ -36,57 +35,57 @@ private Artifact newArtifact(String scope) {
}
@Test
- void testIncludeCompile() {
+ void includeCompile() {
ScopeArtifactFilter filter = new ScopeArtifactFilter(Artifact.SCOPE_COMPILE);
- assertTrue(filter.include(newArtifact(Artifact.SCOPE_COMPILE)));
- assertTrue(filter.include(newArtifact(Artifact.SCOPE_SYSTEM)));
- assertTrue(filter.include(newArtifact(Artifact.SCOPE_PROVIDED)));
- assertFalse(filter.include(newArtifact(Artifact.SCOPE_RUNTIME)));
- assertFalse(filter.include(newArtifact(Artifact.SCOPE_TEST)));
+ assertThat(filter.include(newArtifact(Artifact.SCOPE_COMPILE))).isTrue();
+ assertThat(filter.include(newArtifact(Artifact.SCOPE_SYSTEM))).isTrue();
+ assertThat(filter.include(newArtifact(Artifact.SCOPE_PROVIDED))).isTrue();
+ assertThat(filter.include(newArtifact(Artifact.SCOPE_RUNTIME))).isFalse();
+ assertThat(filter.include(newArtifact(Artifact.SCOPE_TEST))).isFalse();
}
@Test
- void testIncludeCompilePlusRuntime() {
+ void includeCompilePlusRuntime() {
ScopeArtifactFilter filter = new ScopeArtifactFilter(Artifact.SCOPE_COMPILE_PLUS_RUNTIME);
- assertTrue(filter.include(newArtifact(Artifact.SCOPE_COMPILE)));
- assertTrue(filter.include(newArtifact(Artifact.SCOPE_SYSTEM)));
- assertTrue(filter.include(newArtifact(Artifact.SCOPE_PROVIDED)));
- assertTrue(filter.include(newArtifact(Artifact.SCOPE_RUNTIME)));
- assertFalse(filter.include(newArtifact(Artifact.SCOPE_TEST)));
+ assertThat(filter.include(newArtifact(Artifact.SCOPE_COMPILE))).isTrue();
+ assertThat(filter.include(newArtifact(Artifact.SCOPE_SYSTEM))).isTrue();
+ assertThat(filter.include(newArtifact(Artifact.SCOPE_PROVIDED))).isTrue();
+ assertThat(filter.include(newArtifact(Artifact.SCOPE_RUNTIME))).isTrue();
+ assertThat(filter.include(newArtifact(Artifact.SCOPE_TEST))).isFalse();
}
@Test
- void testIncludeRuntime() {
+ void includeRuntime() {
ScopeArtifactFilter filter = new ScopeArtifactFilter(Artifact.SCOPE_RUNTIME);
- assertTrue(filter.include(newArtifact(Artifact.SCOPE_COMPILE)));
- assertFalse(filter.include(newArtifact(Artifact.SCOPE_SYSTEM)));
- assertFalse(filter.include(newArtifact(Artifact.SCOPE_PROVIDED)));
- assertTrue(filter.include(newArtifact(Artifact.SCOPE_RUNTIME)));
- assertFalse(filter.include(newArtifact(Artifact.SCOPE_TEST)));
+ assertThat(filter.include(newArtifact(Artifact.SCOPE_COMPILE))).isTrue();
+ assertThat(filter.include(newArtifact(Artifact.SCOPE_SYSTEM))).isFalse();
+ assertThat(filter.include(newArtifact(Artifact.SCOPE_PROVIDED))).isFalse();
+ assertThat(filter.include(newArtifact(Artifact.SCOPE_RUNTIME))).isTrue();
+ assertThat(filter.include(newArtifact(Artifact.SCOPE_TEST))).isFalse();
}
@Test
- void testIncludeRuntimePlusSystem() {
+ void includeRuntimePlusSystem() {
ScopeArtifactFilter filter = new ScopeArtifactFilter(Artifact.SCOPE_RUNTIME_PLUS_SYSTEM);
- assertTrue(filter.include(newArtifact(Artifact.SCOPE_COMPILE)));
- assertTrue(filter.include(newArtifact(Artifact.SCOPE_SYSTEM)));
- assertFalse(filter.include(newArtifact(Artifact.SCOPE_PROVIDED)));
- assertTrue(filter.include(newArtifact(Artifact.SCOPE_RUNTIME)));
- assertFalse(filter.include(newArtifact(Artifact.SCOPE_TEST)));
+ assertThat(filter.include(newArtifact(Artifact.SCOPE_COMPILE))).isTrue();
+ assertThat(filter.include(newArtifact(Artifact.SCOPE_SYSTEM))).isTrue();
+ assertThat(filter.include(newArtifact(Artifact.SCOPE_PROVIDED))).isFalse();
+ assertThat(filter.include(newArtifact(Artifact.SCOPE_RUNTIME))).isTrue();
+ assertThat(filter.include(newArtifact(Artifact.SCOPE_TEST))).isFalse();
}
@Test
- void testIncludeTest() {
+ void includeTest() {
ScopeArtifactFilter filter = new ScopeArtifactFilter(Artifact.SCOPE_TEST);
- assertTrue(filter.include(newArtifact(Artifact.SCOPE_COMPILE)));
- assertTrue(filter.include(newArtifact(Artifact.SCOPE_SYSTEM)));
- assertTrue(filter.include(newArtifact(Artifact.SCOPE_PROVIDED)));
- assertTrue(filter.include(newArtifact(Artifact.SCOPE_RUNTIME)));
- assertTrue(filter.include(newArtifact(Artifact.SCOPE_TEST)));
+ assertThat(filter.include(newArtifact(Artifact.SCOPE_COMPILE))).isTrue();
+ assertThat(filter.include(newArtifact(Artifact.SCOPE_SYSTEM))).isTrue();
+ assertThat(filter.include(newArtifact(Artifact.SCOPE_PROVIDED))).isTrue();
+ assertThat(filter.include(newArtifact(Artifact.SCOPE_RUNTIME))).isTrue();
+ assertThat(filter.include(newArtifact(Artifact.SCOPE_TEST))).isTrue();
}
}
diff --git a/compat/maven-compat/src/test/java/org/apache/maven/artifact/testutils/TestFileManager.java b/compat/maven-compat/src/test/java/org/apache/maven/artifact/testutils/TestFileManager.java
index 47372855ca2d..a953d30c3d8c 100644
--- a/compat/maven-compat/src/test/java/org/apache/maven/artifact/testutils/TestFileManager.java
+++ b/compat/maven-compat/src/test/java/org/apache/maven/artifact/testutils/TestFileManager.java
@@ -26,9 +26,7 @@
import org.codehaus.plexus.util.FileUtils;
-import static org.junit.jupiter.api.Assertions.assertEquals;
-import static org.junit.jupiter.api.Assertions.assertFalse;
-import static org.junit.jupiter.api.Assertions.assertTrue;
+import static org.assertj.core.api.Assertions.assertThat;
@Deprecated
public class TestFileManager {
@@ -120,9 +118,9 @@ public void assertFileExistence(File dir, String filename, boolean shouldExist)
File file = new File(dir, filename);
if (shouldExist) {
- assertTrue(file.exists());
+ assertThat(file.exists()).isTrue();
} else {
- assertFalse(file.exists());
+ assertThat(file.exists()).isFalse();
}
}
@@ -133,7 +131,7 @@ public void assertFileContents(File dir, String filename, String contentsTest, S
String contents = FileUtils.fileRead(file, encoding);
- assertEquals(contentsTest, contents);
+ assertThat(contents).isEqualTo(contentsTest);
}
public File createFile(File dir, String filename, String contents, String encoding) throws IOException {
diff --git a/compat/maven-compat/src/test/java/org/apache/maven/artifact/transform/TransformationManagerTest.java b/compat/maven-compat/src/test/java/org/apache/maven/artifact/transform/TransformationManagerTest.java
index 4e76243abe66..a3eeced5f419 100644
--- a/compat/maven-compat/src/test/java/org/apache/maven/artifact/transform/TransformationManagerTest.java
+++ b/compat/maven-compat/src/test/java/org/apache/maven/artifact/transform/TransformationManagerTest.java
@@ -30,8 +30,7 @@
import org.codehaus.plexus.testing.PlexusTest;
import org.junit.jupiter.api.Test;
-import static org.junit.jupiter.api.Assertions.assertEquals;
-import static org.junit.jupiter.api.Assertions.assertTrue;
+import static org.assertj.core.api.Assertions.assertThat;
@PlexusTest
@Deprecated
@@ -40,21 +39,15 @@ class TransformationManagerTest {
ArtifactTransformationManager tm;
@Test
- void testTransformationManager() {
+ void transformationManager() {
List tms = tm.getArtifactTransformations();
- assertEquals(3, tms.size());
+ assertThat(tms.size()).isEqualTo(3);
- assertTrue(
- tms.get(0) instanceof ReleaseArtifactTransformation,
- "We expected the release transformation and got " + tms.get(0));
+ assertThat((tms.get(0) instanceof ReleaseArtifactTransformation)).as("We expected the release transformation and got " + tms.get(0)).isTrue();
- assertTrue(
- tms.get(1) instanceof LatestArtifactTransformation,
- "We expected the latest transformation and got " + tms.get(1));
+ assertThat((tms.get(1) instanceof LatestArtifactTransformation)).as("We expected the latest transformation and got " + tms.get(1)).isTrue();
- assertTrue(
- tms.get(2) instanceof SnapshotTransformation,
- "We expected the snapshot transformation and got " + tms.get(2));
+ assertThat((tms.get(2) instanceof SnapshotTransformation)).as("We expected the snapshot transformation and got " + tms.get(2)).isTrue();
}
}
diff --git a/compat/maven-compat/src/test/java/org/apache/maven/profiles/manager/DefaultProfileManagerTest.java b/compat/maven-compat/src/test/java/org/apache/maven/profiles/manager/DefaultProfileManagerTest.java
index d0d798b7e007..327adfbf2460 100644
--- a/compat/maven-compat/src/test/java/org/apache/maven/profiles/manager/DefaultProfileManagerTest.java
+++ b/compat/maven-compat/src/test/java/org/apache/maven/profiles/manager/DefaultProfileManagerTest.java
@@ -32,8 +32,7 @@
import org.codehaus.plexus.testing.PlexusTest;
import org.junit.jupiter.api.Test;
-import static org.junit.jupiter.api.Assertions.assertEquals;
-import static org.junit.jupiter.api.Assertions.assertNotNull;
+import static org.assertj.core.api.Assertions.assertThat;
@PlexusTest
@Deprecated
@@ -47,7 +46,7 @@ protected PlexusContainer getContainer() {
}
@Test
- void testShouldActivateDefaultProfile() throws Exception {
+ void shouldActivateDefaultProfile() throws Exception {
Profile notActivated = new Profile();
notActivated.setId("notActivated");
@@ -75,13 +74,13 @@ void testShouldActivateDefaultProfile() throws Exception {
List active = profileManager.getActiveProfiles();
- assertNotNull(active);
- assertEquals(1, active.size());
- assertEquals("defaultActivated", ((Profile) active.get(0)).getId());
+ assertThat(active).isNotNull();
+ assertThat(active.size()).isEqualTo(1);
+ assertThat(((Profile) active.get(0)).getId()).isEqualTo("defaultActivated");
}
@Test
- void testShouldNotActivateDefaultProfile() throws Exception {
+ void shouldNotActivateDefaultProfile() throws Exception {
Profile syspropActivated = new Profile();
syspropActivated.setId("syspropActivated");
@@ -112,13 +111,13 @@ void testShouldNotActivateDefaultProfile() throws Exception {
List active = profileManager.getActiveProfiles();
- assertNotNull(active);
- assertEquals(1, active.size());
- assertEquals("syspropActivated", ((Profile) active.get(0)).getId());
+ assertThat(active).isNotNull();
+ assertThat(active.size()).isEqualTo(1);
+ assertThat(((Profile) active.get(0)).getId()).isEqualTo("syspropActivated");
}
@Test
- void testShouldNotActivateReversalOfPresentSystemProperty() throws Exception {
+ void shouldNotActivateReversalOfPresentSystemProperty() throws Exception {
Profile syspropActivated = new Profile();
syspropActivated.setId("syspropActivated");
@@ -139,12 +138,12 @@ void testShouldNotActivateReversalOfPresentSystemProperty() throws Exception {
List active = profileManager.getActiveProfiles();
- assertNotNull(active);
- assertEquals(0, active.size());
+ assertThat(active).isNotNull();
+ assertThat(active.size()).isEqualTo(0);
}
@Test
- void testShouldOverrideAndActivateInactiveProfile() throws Exception {
+ void shouldOverrideAndActivateInactiveProfile() throws Exception {
Profile syspropActivated = new Profile();
syspropActivated.setId("syspropActivated");
@@ -167,13 +166,13 @@ void testShouldOverrideAndActivateInactiveProfile() throws Exception {
List active = profileManager.getActiveProfiles();
- assertNotNull(active);
- assertEquals(1, active.size());
- assertEquals("syspropActivated", ((Profile) active.get(0)).getId());
+ assertThat(active).isNotNull();
+ assertThat(active.size()).isEqualTo(1);
+ assertThat(((Profile) active.get(0)).getId()).isEqualTo("syspropActivated");
}
@Test
- void testShouldOverrideAndDeactivateActiveProfile() throws Exception {
+ void shouldOverrideAndDeactivateActiveProfile() throws Exception {
Profile syspropActivated = new Profile();
syspropActivated.setId("syspropActivated");
@@ -196,7 +195,7 @@ void testShouldOverrideAndDeactivateActiveProfile() throws Exception {
List active = profileManager.getActiveProfiles();
- assertNotNull(active);
- assertEquals(0, active.size());
+ assertThat(active).isNotNull();
+ assertThat(active.size()).isEqualTo(0);
}
}
diff --git a/compat/maven-compat/src/test/java/org/apache/maven/project/AbstractMavenProjectTestCase.java b/compat/maven-compat/src/test/java/org/apache/maven/project/AbstractMavenProjectTestCase.java
index 56f62cf65dc5..f5e3502bab95 100644
--- a/compat/maven-compat/src/test/java/org/apache/maven/project/AbstractMavenProjectTestCase.java
+++ b/compat/maven-compat/src/test/java/org/apache/maven/project/AbstractMavenProjectTestCase.java
@@ -47,7 +47,7 @@
import org.eclipse.aether.DefaultRepositorySystemSession;
import org.junit.jupiter.api.BeforeEach;
-import static org.junit.jupiter.api.Assertions.fail;
+import static org.assertj.core.api.Assertions.fail;
/**
*/
diff --git a/compat/maven-compat/src/test/java/org/apache/maven/project/ProjectClasspathTestType.java b/compat/maven-compat/src/test/java/org/apache/maven/project/ProjectClasspathTestType.java
index 24af8e7dfdc6..0c297c25c83e 100644
--- a/compat/maven-compat/src/test/java/org/apache/maven/project/ProjectClasspathTestType.java
+++ b/compat/maven-compat/src/test/java/org/apache/maven/project/ProjectClasspathTestType.java
@@ -28,9 +28,7 @@
import org.junit.jupiter.api.BeforeEach;
import org.junit.jupiter.api.Test;
-import static org.junit.jupiter.api.Assertions.assertEquals;
-import static org.junit.jupiter.api.Assertions.assertNotNull;
-import static org.junit.jupiter.api.Assertions.assertNull;
+import static org.assertj.core.api.Assertions.assertThat;
@Deprecated
class ProjectClasspathTestType extends AbstractMavenProjectTestCase {
@@ -52,14 +50,14 @@ public void setUp() throws Exception {
}
@Test
- void testProjectClasspath() throws Exception {
+ void projectClasspath() throws Exception {
File f = getFileForClasspathResource(DIR + "project-with-scoped-dependencies.xml");
MavenProject project = getProjectWithDependencies(f);
Artifact artifact;
- assertNotNull(project, "Test project can't be null!");
+ assertThat(project).as("Test project can't be null!").isNotNull();
checkArtifactIdScope(project, "provided", "provided");
checkArtifactIdScope(project, "test", "test");
@@ -69,59 +67,59 @@ void testProjectClasspath() throws Exception {
// check all transitive deps of a test dependency are test, except test and provided which is skipped
artifact = getArtifact(project, "maven-test-test", "scope-provided");
- assertNull(artifact, "Check no provided dependencies are transitive");
+ assertThat(artifact).as("Check no provided dependencies are transitive").isNull();
artifact = getArtifact(project, "maven-test-test", "scope-test");
- assertNull(artifact, "Check no test dependencies are transitive");
+ assertThat(artifact).as("Check no test dependencies are transitive").isNull();
artifact = getArtifact(project, "maven-test-test", "scope-compile");
- assertNotNull(artifact);
+ assertThat(artifact).isNotNull();
System.out.println("a = " + artifact);
System.out.println("b = " + artifact.getScope());
- assertEquals("test", artifact.getScope(), "Check scope");
+ assertThat(artifact.getScope()).as("Check scope").isEqualTo("test");
artifact = getArtifact(project, "maven-test-test", "scope-default");
- assertEquals("test", artifact.getScope(), "Check scope");
+ assertThat(artifact.getScope()).as("Check scope").isEqualTo("test");
artifact = getArtifact(project, "maven-test-test", "scope-runtime");
- assertEquals("test", artifact.getScope(), "Check scope");
+ assertThat(artifact.getScope()).as("Check scope").isEqualTo("test");
// check all transitive deps of a provided dependency are provided scope, except for test
checkGroupIdScope(project, "provided", "maven-test-provided");
artifact = getArtifact(project, "maven-test-provided", "scope-runtime");
- assertEquals("provided", artifact.getScope(), "Check scope");
+ assertThat(artifact.getScope()).as("Check scope").isEqualTo("provided");
// check all transitive deps of a runtime dependency are runtime scope, except for test
checkGroupIdScope(project, "runtime", "maven-test-runtime");
artifact = getArtifact(project, "maven-test-runtime", "scope-runtime");
- assertEquals("runtime", artifact.getScope(), "Check scope");
+ assertThat(artifact.getScope()).as("Check scope").isEqualTo("runtime");
// check all transitive deps of a compile dependency are compile scope, except for runtime and test
checkGroupIdScope(project, "compile", "maven-test-compile");
artifact = getArtifact(project, "maven-test-compile", "scope-runtime");
- assertEquals("runtime", artifact.getScope(), "Check scope");
+ assertThat(artifact.getScope()).as("Check scope").isEqualTo("runtime");
// check all transitive deps of a default dependency are compile scope, except for runtime and test
checkGroupIdScope(project, "compile", "maven-test-default");
artifact = getArtifact(project, "maven-test-default", "scope-runtime");
- assertEquals("runtime", artifact.getScope(), "Check scope");
+ assertThat(artifact.getScope()).as("Check scope").isEqualTo("runtime");
}
private void checkGroupIdScope(MavenProject project, String scopeValue, String groupId) {
Artifact artifact;
artifact = getArtifact(project, groupId, "scope-compile");
- assertEquals(scopeValue, artifact.getScope(), "Check scope");
+ assertThat(artifact.getScope()).as("Check scope").isEqualTo(scopeValue);
artifact = getArtifact(project, groupId, "scope-test");
- assertNull(artifact, "Check test dependency is not transitive");
+ assertThat(artifact).as("Check test dependency is not transitive").isNull();
artifact = getArtifact(project, groupId, "scope-provided");
- assertNull(artifact, "Check provided dependency is not transitive");
+ assertThat(artifact).as("Check provided dependency is not transitive").isNull();
artifact = getArtifact(project, groupId, "scope-default");
- assertEquals(scopeValue, artifact.getScope(), "Check scope");
+ assertThat(artifact.getScope()).as("Check scope").isEqualTo(scopeValue);
}
private void checkArtifactIdScope(MavenProject project, String scope, String scopeValue) {
String artifactId = "scope-" + scope;
Artifact artifact = getArtifact(project, "maven-test", artifactId);
- assertNotNull(artifact);
- assertEquals(scopeValue, artifact.getScope(), "Check scope");
+ assertThat(artifact).isNotNull();
+ assertThat(artifact.getScope()).as("Check scope").isEqualTo(scopeValue);
}
private Artifact getArtifact(MavenProject project, String groupId, String artifactId) {
diff --git a/compat/maven-compat/src/test/java/org/apache/maven/project/artifact/DefaultMavenMetadataCacheTest.java b/compat/maven-compat/src/test/java/org/apache/maven/project/artifact/DefaultMavenMetadataCacheTest.java
index 20938963639a..c3081e5280b0 100644
--- a/compat/maven-compat/src/test/java/org/apache/maven/project/artifact/DefaultMavenMetadataCacheTest.java
+++ b/compat/maven-compat/src/test/java/org/apache/maven/project/artifact/DefaultMavenMetadataCacheTest.java
@@ -30,7 +30,7 @@
import org.junit.jupiter.api.BeforeEach;
import org.junit.jupiter.api.Test;
-import static org.junit.jupiter.api.Assertions.assertEquals;
+import static org.assertj.core.api.Assertions.assertThat;
import static org.junit.jupiter.api.Assertions.assertNotSame;
/**
@@ -45,7 +45,7 @@ void setUp() {
}
@Test
- void testCacheKey() throws Exception {
+ void cacheKey() throws Exception {
Artifact a1 = repositorySystem.createArtifact("testGroup", "testArtifact", "1.2.3", "jar");
@SuppressWarnings("deprecation")
ArtifactRepository lr1 = new DelegatingLocalArtifactRepository(repositorySystem.createDefaultLocalRepository());
@@ -68,6 +68,6 @@ void testCacheKey() throws Exception {
DefaultMavenMetadataCache.CacheKey k2 =
new DefaultMavenMetadataCache.CacheKey(a2, false, lr2, Collections.singletonList(rr2));
- assertEquals(k1.hashCode(), k2.hashCode());
+ assertThat(k2.hashCode()).isEqualTo(k1.hashCode());
}
}
diff --git a/compat/maven-compat/src/test/java/org/apache/maven/project/inheritance/t00/ProjectInheritanceTest.java b/compat/maven-compat/src/test/java/org/apache/maven/project/inheritance/t00/ProjectInheritanceTest.java
index 88f0ddcc3581..e25ab9c419ce 100644
--- a/compat/maven-compat/src/test/java/org/apache/maven/project/inheritance/t00/ProjectInheritanceTest.java
+++ b/compat/maven-compat/src/test/java/org/apache/maven/project/inheritance/t00/ProjectInheritanceTest.java
@@ -22,7 +22,7 @@
import org.apache.maven.project.inheritance.AbstractProjectInheritanceTestCase;
import org.junit.jupiter.api.Test;
-import static org.junit.jupiter.api.Assertions.assertEquals;
+import static org.assertj.core.api.Assertions.assertThat;
/**
* A test which demonstrates maven's recursive inheritance where
@@ -51,41 +51,41 @@ class ProjectInheritanceTest extends AbstractProjectInheritanceTestCase {
// ----------------------------------------------------------------------
@Test
- void testProjectInheritance() throws Exception {
+ void projectInheritance() throws Exception {
MavenProject p4 = getProject(projectFile("p4"));
- assertEquals("p4", p4.getName());
+ assertThat(p4.getName()).isEqualTo("p4");
// ----------------------------------------------------------------------
// Value inherited from p3
// ----------------------------------------------------------------------
- assertEquals("2000", p4.getInceptionYear());
+ assertThat(p4.getInceptionYear()).isEqualTo("2000");
// ----------------------------------------------------------------------
// Value taken from p2
// ----------------------------------------------------------------------
- assertEquals("mailing-list", p4.getMailingLists().get(0).getName());
+ assertThat(p4.getMailingLists().get(0).getName()).isEqualTo("mailing-list");
// ----------------------------------------------------------------------
// Value taken from p1
// ----------------------------------------------------------------------
- assertEquals("scm-url/p2/p3/p4", p4.getScm().getUrl());
+ assertThat(p4.getScm().getUrl()).isEqualTo("scm-url/p2/p3/p4");
// ----------------------------------------------------------------------
// Value taken from p4
// ----------------------------------------------------------------------
- assertEquals("Codehaus", p4.getOrganization().getName());
+ assertThat(p4.getOrganization().getName()).isEqualTo("Codehaus");
// ----------------------------------------------------------------------
// Value taken from super model
// ----------------------------------------------------------------------
- assertEquals("4.0.0", p4.getModelVersion());
+ assertThat(p4.getModelVersion()).isEqualTo("4.0.0");
- assertEquals("4.0.0", p4.getModelVersion());
+ assertThat(p4.getModelVersion()).isEqualTo("4.0.0");
}
}
diff --git a/compat/maven-compat/src/test/java/org/apache/maven/project/inheritance/t01/ProjectInheritanceTest.java b/compat/maven-compat/src/test/java/org/apache/maven/project/inheritance/t01/ProjectInheritanceTest.java
index 8e5368718bc8..2312ae5faeb6 100644
--- a/compat/maven-compat/src/test/java/org/apache/maven/project/inheritance/t01/ProjectInheritanceTest.java
+++ b/compat/maven-compat/src/test/java/org/apache/maven/project/inheritance/t01/ProjectInheritanceTest.java
@@ -22,7 +22,7 @@
import org.apache.maven.project.inheritance.AbstractProjectInheritanceTestCase;
import org.junit.jupiter.api.Test;
-import static org.junit.jupiter.api.Assertions.assertEquals;
+import static org.assertj.core.api.Assertions.assertThat;
/**
* A test which demonstrates maven's recursive inheritance where
@@ -48,14 +48,14 @@ class ProjectInheritanceTest extends AbstractProjectInheritanceTestCase {
// ----------------------------------------------------------------------
@Test
- void testProjectInheritance() throws Exception {
+ void projectInheritance() throws Exception {
// ----------------------------------------------------------------------
// Check p0 value for org name
// ----------------------------------------------------------------------
MavenProject p0 = getProject(projectFile("maven.t01", "p0"));
- assertEquals("p0-org", p0.getOrganization().getName());
+ assertThat(p0.getOrganization().getName()).isEqualTo("p0-org");
// ----------------------------------------------------------------------
// Check p1 value for org name
@@ -63,7 +63,7 @@ void testProjectInheritance() throws Exception {
MavenProject p1 = getProject(projectFile("maven.t01", "p1"));
- assertEquals("p1-org", p1.getOrganization().getName());
+ assertThat(p1.getOrganization().getName()).isEqualTo("p1-org");
// ----------------------------------------------------------------------
// Check p2 value for org name
@@ -71,7 +71,7 @@ void testProjectInheritance() throws Exception {
MavenProject p2 = getProject(projectFile("maven.t01", "p2"));
- assertEquals("p2-org", p2.getOrganization().getName());
+ assertThat(p2.getOrganization().getName()).isEqualTo("p2-org");
// ----------------------------------------------------------------------
// Check p2 value for org name
@@ -79,7 +79,7 @@ void testProjectInheritance() throws Exception {
MavenProject p3 = getProject(projectFile("maven.t01", "p3"));
- assertEquals("p3-org", p3.getOrganization().getName());
+ assertThat(p3.getOrganization().getName()).isEqualTo("p3-org");
// ----------------------------------------------------------------------
// Check p4 value for org name
@@ -87,6 +87,6 @@ void testProjectInheritance() throws Exception {
MavenProject p4 = getProject(projectFile("maven.t01", "p4"));
- assertEquals("p4-org", p4.getOrganization().getName());
+ assertThat(p4.getOrganization().getName()).isEqualTo("p4-org");
}
}
diff --git a/compat/maven-compat/src/test/java/org/apache/maven/project/inheritance/t02/ProjectInheritanceTest.java b/compat/maven-compat/src/test/java/org/apache/maven/project/inheritance/t02/ProjectInheritanceTest.java
index b277dad26d7f..346ec706fa7e 100644
--- a/compat/maven-compat/src/test/java/org/apache/maven/project/inheritance/t02/ProjectInheritanceTest.java
+++ b/compat/maven-compat/src/test/java/org/apache/maven/project/inheritance/t02/ProjectInheritanceTest.java
@@ -32,9 +32,7 @@
import org.junit.jupiter.api.condition.DisabledOnOs;
import org.junit.jupiter.api.condition.OS;
-import static org.junit.jupiter.api.Assertions.assertEquals;
-import static org.junit.jupiter.api.Assertions.assertNotNull;
-import static org.junit.jupiter.api.Assertions.assertTrue;
+import static org.assertj.core.api.Assertions.assertThat;
/**
* A test which demonstrates maven's recursive inheritance where
@@ -65,7 +63,7 @@ class ProjectInheritanceTest extends AbstractProjectInheritanceTestCase {
@Test
@DisabledOnOs(OS.WINDOWS) // need to investigate why it fails on windows
- void testProjectInheritance() throws Exception {
+ void projectInheritance() throws Exception {
File localRepo = getLocalRepositoryPath();
System.out.println("Local repository is at: " + localRepo.getAbsolutePath());
@@ -87,37 +85,37 @@ void testProjectInheritance() throws Exception {
MavenProject project4 = getProject(pom4);
MavenProject project5 = getProject(pom5);
- assertEquals("p4", project4.getName());
+ assertThat(project4.getName()).isEqualTo("p4");
// ----------------------------------------------------------------------
// Value inherited from p3
// ----------------------------------------------------------------------
- assertEquals("2000", project4.getInceptionYear());
+ assertThat(project4.getInceptionYear()).isEqualTo("2000");
// ----------------------------------------------------------------------
// Value taken from p2
// ----------------------------------------------------------------------
- assertEquals("mailing-list", project4.getMailingLists().get(0).getName());
+ assertThat(project4.getMailingLists().get(0).getName()).isEqualTo("mailing-list");
// ----------------------------------------------------------------------
// Value taken from p1
// ----------------------------------------------------------------------
- assertEquals("scm-url/p2/p3/p4", project4.getScm().getUrl());
+ assertThat(project4.getScm().getUrl()).isEqualTo("scm-url/p2/p3/p4");
// ----------------------------------------------------------------------
// Value taken from p4
// ----------------------------------------------------------------------
- assertEquals("Codehaus", project4.getOrganization().getName());
+ assertThat(project4.getOrganization().getName()).isEqualTo("Codehaus");
// ----------------------------------------------------------------------
// Value taken from super model
// ----------------------------------------------------------------------
- assertEquals("4.0.0", project4.getModelVersion());
+ assertThat(project4.getModelVersion()).isEqualTo("4.0.0");
Build build = project4.getBuild();
List plugins = build.getPlugins();
@@ -139,7 +137,7 @@ void testProjectInheritance() throws Exception {
for (Plugin plugin : plugins) {
String pluginArtifactId = plugin.getArtifactId();
- assertTrue(validPluginCounts.containsKey(pluginArtifactId), "Illegal plugin found: " + pluginArtifactId);
+ assertThat(validPluginCounts.containsKey(pluginArtifactId)).as("Illegal plugin found: " + pluginArtifactId).isTrue();
if (pluginArtifactId.equals(testPluginArtifactId)) {
testPlugin = plugin;
@@ -147,17 +145,17 @@ void testProjectInheritance() throws Exception {
Integer count = validPluginCounts.get(pluginArtifactId);
- assertEquals(0, (int) count, "Multiple copies of plugin: " + pluginArtifactId + " found in POM.");
+ assertThat((int) count).as("Multiple copies of plugin: " + pluginArtifactId + " found in POM.").isEqualTo(0);
count = count + 1;
validPluginCounts.put(pluginArtifactId, count);
}
- assertNotNull(testPlugin);
+ assertThat(testPlugin).isNotNull();
List executions = testPlugin.getExecutions();
- assertEquals(1, executions.size());
+ assertThat(executions.size()).isEqualTo(1);
}
}
diff --git a/compat/maven-compat/src/test/java/org/apache/maven/project/inheritance/t03/ProjectInheritanceTest.java b/compat/maven-compat/src/test/java/org/apache/maven/project/inheritance/t03/ProjectInheritanceTest.java
index 9ff8e4ac8bcb..4cff0737c0f7 100644
--- a/compat/maven-compat/src/test/java/org/apache/maven/project/inheritance/t03/ProjectInheritanceTest.java
+++ b/compat/maven-compat/src/test/java/org/apache/maven/project/inheritance/t03/ProjectInheritanceTest.java
@@ -24,7 +24,7 @@
import org.apache.maven.project.inheritance.AbstractProjectInheritanceTestCase;
import org.junit.jupiter.api.Test;
-import static org.junit.jupiter.api.Assertions.assertEquals;
+import static org.assertj.core.api.Assertions.assertThat;
/**
* A test which demonstrates maven's recursive inheritance where
@@ -51,7 +51,7 @@ class ProjectInheritanceTest extends AbstractProjectInheritanceTestCase {
// ----------------------------------------------------------------------
@Test
- void testProjectInheritance() throws Exception {
+ void projectInheritance() throws Exception {
File localRepo = getLocalRepositoryPath();
File pom0 = new File(localRepo, "p0/pom.xml");
@@ -63,6 +63,6 @@ void testProjectInheritance() throws Exception {
MavenProject project0 = getProject(pom0);
MavenProject project1 = getProject(pom1);
- assertEquals(pom0Basedir, project1.getParent().getBasedir());
+ assertThat(project1.getParent().getBasedir()).isEqualTo(pom0Basedir);
}
}
diff --git a/compat/maven-compat/src/test/java/org/apache/maven/project/inheritance/t04/ProjectInheritanceTest.java b/compat/maven-compat/src/test/java/org/apache/maven/project/inheritance/t04/ProjectInheritanceTest.java
index e6ffa7cf23ae..56f49445f7bf 100644
--- a/compat/maven-compat/src/test/java/org/apache/maven/project/inheritance/t04/ProjectInheritanceTest.java
+++ b/compat/maven-compat/src/test/java/org/apache/maven/project/inheritance/t04/ProjectInheritanceTest.java
@@ -26,9 +26,7 @@
import org.apache.maven.project.inheritance.AbstractProjectInheritanceTestCase;
import org.junit.jupiter.api.Test;
-import static org.junit.jupiter.api.Assertions.assertEquals;
-import static org.junit.jupiter.api.Assertions.assertNotNull;
-import static org.junit.jupiter.api.Assertions.assertTrue;
+import static org.assertj.core.api.Assertions.assertThat;
/**
* Verifies the version of a dependency listed in a parent's
@@ -55,7 +53,7 @@ class ProjectInheritanceTest extends AbstractProjectInheritanceTestCase {
// ----------------------------------------------------------------------
@Test
- void testDependencyManagementOverridesTransitiveDependencyVersion() throws Exception {
+ void dependencyManagementOverridesTransitiveDependencyVersion() throws Exception {
File localRepo = getLocalRepositoryPath();
File pom0 = new File(localRepo, "p0/pom.xml");
File pom0Basedir = pom0.getParentFile();
@@ -65,18 +63,17 @@ void testDependencyManagementOverridesTransitiveDependencyVersion() throws Excep
MavenProject project0 = getProjectWithDependencies(pom0);
MavenProject project1 = getProjectWithDependencies(pom1);
- assertEquals(pom0Basedir, project1.getParent().getBasedir());
+ assertThat(project1.getParent().getBasedir()).isEqualTo(pom0Basedir);
Set set = project1.getArtifacts();
- assertNotNull(set, "No artifacts");
- assertTrue(set.size() > 0, "No Artifacts");
- assertTrue(set.size() == 3, "Set size should be 3, is " + set.size());
+ assertThat(set).as("No artifacts").isNotNull();
+ assertThat(set.size() > 0).as("No Artifacts").isTrue();
+ assertThat(set.size()).as("Set size should be 3, is " + set.size()).isEqualTo(3);
for (Object aSet : set) {
Artifact artifact = (Artifact) aSet;
System.out.println("Artifact: " + artifact.getDependencyConflictId() + " " + artifact.getVersion()
+ " Optional=" + (artifact.isOptional() ? "true" : "false"));
- assertTrue(
- artifact.getVersion().equals("1.0"), "Incorrect version for " + artifact.getDependencyConflictId());
+ assertThat(artifact.getVersion()).as("Incorrect version for " + artifact.getDependencyConflictId()).isEqualTo("1.0");
}
}
}
diff --git a/compat/maven-compat/src/test/java/org/apache/maven/project/inheritance/t05/ProjectInheritanceTest.java b/compat/maven-compat/src/test/java/org/apache/maven/project/inheritance/t05/ProjectInheritanceTest.java
index a0d610d21043..fae5eeec1326 100644
--- a/compat/maven-compat/src/test/java/org/apache/maven/project/inheritance/t05/ProjectInheritanceTest.java
+++ b/compat/maven-compat/src/test/java/org/apache/maven/project/inheritance/t05/ProjectInheritanceTest.java
@@ -26,9 +26,7 @@
import org.apache.maven.project.inheritance.AbstractProjectInheritanceTestCase;
import org.junit.jupiter.api.Test;
-import static org.junit.jupiter.api.Assertions.assertEquals;
-import static org.junit.jupiter.api.Assertions.assertNotNull;
-import static org.junit.jupiter.api.Assertions.assertTrue;
+import static org.assertj.core.api.Assertions.assertThat;
/**
* A test which demonstrates maven's dependency management
@@ -49,7 +47,7 @@ class ProjectInheritanceTest extends AbstractProjectInheritanceTestCase {
// ----------------------------------------------------------------------
@Test
- void testDependencyManagement() throws Exception {
+ void dependencyManagement() throws Exception {
File localRepo = getLocalRepositoryPath();
File pom0 = new File(localRepo, "p0/pom.xml");
@@ -61,17 +59,16 @@ void testDependencyManagement() throws Exception {
MavenProject project0 = getProjectWithDependencies(pom0);
MavenProject project1 = getProjectWithDependencies(pom1);
- assertEquals(pom0Basedir, project1.getParent().getBasedir());
+ assertThat(project1.getParent().getBasedir()).isEqualTo(pom0Basedir);
Set set = project1.getArtifacts();
- assertNotNull(set, "No artifacts");
- assertTrue(set.size() > 0, "No Artifacts");
+ assertThat(set).as("No artifacts").isNotNull();
+ assertThat(set.size() > 0).as("No Artifacts").isTrue();
for (Object aSet : set) {
Artifact artifact = (Artifact) aSet;
System.out.println("Artifact: " + artifact.getDependencyConflictId() + " " + artifact.getVersion()
+ " Scope: " + artifact.getScope());
- assertTrue(
- artifact.getVersion().equals("1.0"), "Incorrect version for " + artifact.getDependencyConflictId());
+ assertThat(artifact.getVersion()).as("Incorrect version for " + artifact.getDependencyConflictId()).isEqualTo("1.0");
}
}
}
diff --git a/compat/maven-compat/src/test/java/org/apache/maven/project/inheritance/t06/ProjectInheritanceTest.java b/compat/maven-compat/src/test/java/org/apache/maven/project/inheritance/t06/ProjectInheritanceTest.java
index 43a666040f1f..6f1e568b9c8a 100644
--- a/compat/maven-compat/src/test/java/org/apache/maven/project/inheritance/t06/ProjectInheritanceTest.java
+++ b/compat/maven-compat/src/test/java/org/apache/maven/project/inheritance/t06/ProjectInheritanceTest.java
@@ -27,9 +27,7 @@
import org.apache.maven.project.inheritance.AbstractProjectInheritanceTestCase;
import org.junit.jupiter.api.Test;
-import static org.junit.jupiter.api.Assertions.assertEquals;
-import static org.junit.jupiter.api.Assertions.assertNotNull;
-import static org.junit.jupiter.api.Assertions.assertTrue;
+import static org.assertj.core.api.Assertions.assertThat;
/**
* A test which demonstrates maven's dependency management
@@ -50,7 +48,7 @@ class ProjectInheritanceTest extends AbstractProjectInheritanceTestCase {
// ----------------------------------------------------------------------
@Test
- void testDependencyManagement() throws Exception {
+ void dependencyManagement() throws Exception {
File localRepo = getLocalRepositoryPath();
File pom0 = new File(localRepo, "p0/pom.xml");
@@ -62,19 +60,18 @@ void testDependencyManagement() throws Exception {
MavenProject project0 = getProjectWithDependencies(pom0);
MavenProject project1 = getProjectWithDependencies(pom1);
- assertEquals(pom0Basedir, project1.getParent().getBasedir());
+ assertThat(project1.getParent().getBasedir()).isEqualTo(pom0Basedir);
Set set = project1.getArtifacts();
- assertNotNull(set, "No artifacts");
- assertTrue(set.size() > 0, "No Artifacts");
+ assertThat(set).as("No artifacts").isNotNull();
+ assertThat(set.size() > 0).as("No Artifacts").isTrue();
Iterator iter = set.iterator();
- assertTrue(set.size() == 4, "Set size should be 4, is " + set.size());
+ assertThat(set.size()).as("Set size should be 4, is " + set.size()).isEqualTo(4);
while (iter.hasNext()) {
Artifact artifact = (Artifact) iter.next();
System.out.println("Artifact: " + artifact.getDependencyConflictId() + " " + artifact.getVersion()
+ " Optional=" + (artifact.isOptional() ? "true" : "false"));
- assertTrue(
- artifact.getVersion().equals("1.0"), "Incorrect version for " + artifact.getDependencyConflictId());
+ assertThat(artifact.getVersion()).as("Incorrect version for " + artifact.getDependencyConflictId()).isEqualTo("1.0");
}
}
}
diff --git a/compat/maven-compat/src/test/java/org/apache/maven/project/inheritance/t07/ProjectInheritanceTest.java b/compat/maven-compat/src/test/java/org/apache/maven/project/inheritance/t07/ProjectInheritanceTest.java
index 45ff8791fd81..7653adf86c33 100644
--- a/compat/maven-compat/src/test/java/org/apache/maven/project/inheritance/t07/ProjectInheritanceTest.java
+++ b/compat/maven-compat/src/test/java/org/apache/maven/project/inheritance/t07/ProjectInheritanceTest.java
@@ -26,10 +26,7 @@
import org.apache.maven.project.inheritance.AbstractProjectInheritanceTestCase;
import org.junit.jupiter.api.Test;
-import static org.junit.jupiter.api.Assertions.assertEquals;
-import static org.junit.jupiter.api.Assertions.assertFalse;
-import static org.junit.jupiter.api.Assertions.assertNotNull;
-import static org.junit.jupiter.api.Assertions.assertTrue;
+import static org.assertj.core.api.Assertions.assertThat;
/**
* A test which demonstrates maven's dependency management
@@ -50,7 +47,7 @@ class ProjectInheritanceTest extends AbstractProjectInheritanceTestCase {
// ----------------------------------------------------------------------
@Test
- void testDependencyManagement() throws Exception {
+ void dependencyManagement() throws Exception {
File localRepo = getLocalRepositoryPath();
File pom0 = new File(localRepo, "p0/pom.xml");
@@ -61,20 +58,19 @@ void testDependencyManagement() throws Exception {
// load everything...
MavenProject project1 = getProjectWithDependencies(pom1);
- assertEquals(pom0Basedir, project1.getParent().getBasedir());
+ assertThat(project1.getParent().getBasedir()).isEqualTo(pom0Basedir);
System.out.println("Project " + project1.getId() + " " + project1);
Set set = project1.getArtifacts();
- assertNotNull(set, "No artifacts");
- assertTrue(set.size() > 0, "No Artifacts");
- assertTrue(set.size() == 3, "Set size should be 3, is " + set.size());
+ assertThat(set).as("No artifacts").isNotNull();
+ assertThat(set.size() > 0).as("No Artifacts").isTrue();
+ assertThat(set.size()).as("Set size should be 3, is " + set.size()).isEqualTo(3);
for (Object aSet : set) {
Artifact artifact = (Artifact) aSet;
- assertFalse(artifact.getArtifactId().equals("t07-d"));
+ assertThat(artifact.getArtifactId()).isNotEqualTo("t07-d");
System.out.println("Artifact: " + artifact.getDependencyConflictId() + " " + artifact.getVersion()
+ " Optional=" + (artifact.isOptional() ? "true" : "false"));
- assertTrue(
- artifact.getVersion().equals("1.0"), "Incorrect version for " + artifact.getDependencyConflictId());
+ assertThat(artifact.getVersion()).as("Incorrect version for " + artifact.getDependencyConflictId()).isEqualTo("1.0");
}
}
}
diff --git a/compat/maven-compat/src/test/java/org/apache/maven/project/inheritance/t08/ProjectInheritanceTest.java b/compat/maven-compat/src/test/java/org/apache/maven/project/inheritance/t08/ProjectInheritanceTest.java
index 5158f52e29de..fc3e776b51e8 100644
--- a/compat/maven-compat/src/test/java/org/apache/maven/project/inheritance/t08/ProjectInheritanceTest.java
+++ b/compat/maven-compat/src/test/java/org/apache/maven/project/inheritance/t08/ProjectInheritanceTest.java
@@ -27,9 +27,7 @@
import org.apache.maven.project.inheritance.AbstractProjectInheritanceTestCase;
import org.junit.jupiter.api.Test;
-import static org.junit.jupiter.api.Assertions.assertEquals;
-import static org.junit.jupiter.api.Assertions.assertNotNull;
-import static org.junit.jupiter.api.Assertions.assertTrue;
+import static org.assertj.core.api.Assertions.assertThat;
/**
* A test which demonstrates maven's dependency management
@@ -50,7 +48,7 @@ class ProjectInheritanceTest extends AbstractProjectInheritanceTestCase {
// ----------------------------------------------------------------------
@Test
- void testDependencyManagement() throws Exception {
+ void dependencyManagement() throws Exception {
File localRepo = getLocalRepositoryPath();
File pom0 = new File(localRepo, "p0/pom.xml");
@@ -62,20 +60,19 @@ void testDependencyManagement() throws Exception {
MavenProject project0 = getProjectWithDependencies(pom0);
MavenProject project1 = getProjectWithDependencies(pom1);
- assertEquals(pom0Basedir, project1.getParent().getBasedir());
+ assertThat(project1.getParent().getBasedir()).isEqualTo(pom0Basedir);
System.out.println("Project " + project1.getId() + " " + project1);
Set set = project1.getArtifacts();
- assertNotNull(set, "No artifacts");
- assertTrue(set.size() > 0, "No Artifacts");
+ assertThat(set).as("No artifacts").isNotNull();
+ assertThat(set.size() > 0).as("No Artifacts").isTrue();
Iterator iter = set.iterator();
- assertTrue(set.size() == 4, "Set size should be 4, is " + set.size());
+ assertThat(set.size()).as("Set size should be 4, is " + set.size()).isEqualTo(4);
while (iter.hasNext()) {
Artifact artifact = (Artifact) iter.next();
System.out.println("Artifact: " + artifact.getDependencyConflictId() + " " + artifact.getVersion()
+ " Optional=" + (artifact.isOptional() ? "true" : "false"));
- assertTrue(
- artifact.getVersion().equals("1.0"), "Incorrect version for " + artifact.getDependencyConflictId());
+ assertThat(artifact.getVersion()).as("Incorrect version for " + artifact.getDependencyConflictId()).isEqualTo("1.0");
}
}
}
diff --git a/compat/maven-compat/src/test/java/org/apache/maven/project/inheritance/t09/ProjectInheritanceTest.java b/compat/maven-compat/src/test/java/org/apache/maven/project/inheritance/t09/ProjectInheritanceTest.java
index 149b7b04e161..0d639ee4c711 100644
--- a/compat/maven-compat/src/test/java/org/apache/maven/project/inheritance/t09/ProjectInheritanceTest.java
+++ b/compat/maven-compat/src/test/java/org/apache/maven/project/inheritance/t09/ProjectInheritanceTest.java
@@ -25,10 +25,7 @@
import org.apache.maven.project.inheritance.AbstractProjectInheritanceTestCase;
import org.junit.jupiter.api.Test;
-import static org.junit.jupiter.api.Assertions.assertEquals;
-import static org.junit.jupiter.api.Assertions.assertFalse;
-import static org.junit.jupiter.api.Assertions.assertNotNull;
-import static org.junit.jupiter.api.Assertions.assertTrue;
+import static org.assertj.core.api.Assertions.assertThat;
/**
* Verifies exclusions listed in dependencyManagement are valid for
@@ -62,7 +59,7 @@ class ProjectInheritanceTest extends AbstractProjectInheritanceTestCase {
* a & b only.
*/
@Test
- void testDependencyManagementExclusionsExcludeTransitively() throws Exception {
+ void dependencyManagementExclusionsExcludeTransitively() throws Exception {
File localRepo = getLocalRepositoryPath();
File pom0 = new File(localRepo, "p0/pom.xml");
@@ -73,17 +70,17 @@ void testDependencyManagementExclusionsExcludeTransitively() throws Exception {
MavenProject project0 = getProjectWithDependencies(pom0);
MavenProject project1 = getProjectWithDependencies(pom1);
- assertNotNull(project1.getParent(), "Parent is null");
- assertEquals(pom0Basedir, project1.getParent().getBasedir());
+ assertThat(project1.getParent()).as("Parent is null").isNotNull();
+ assertThat(project1.getParent().getBasedir()).isEqualTo(pom0Basedir);
Map map = project1.getArtifactMap();
- assertNotNull(map, "No artifacts");
- assertTrue(map.size() > 0, "No Artifacts");
- assertTrue(map.size() == 2, "Set size should be 2, is " + map.size());
+ assertThat(map).as("No artifacts").isNotNull();
+ assertThat(map.size() > 0).as("No Artifacts").isTrue();
+ assertThat(map.size()).as("Set size should be 2, is " + map.size()).isEqualTo(2);
- assertTrue(map.containsKey("maven-test:t09-a"), "maven-test:t09-a is not in the project");
- assertTrue(map.containsKey("maven-test:t09-b"), "maven-test:t09-b is not in the project");
- assertFalse(map.containsKey("maven-test:t09-c"), "maven-test:t09-c is in the project");
+ assertThat(map.containsKey("maven-test:t09-a")).as("maven-test:t09-a is not in the project").isTrue();
+ assertThat(map.containsKey("maven-test:t09-b")).as("maven-test:t09-b is not in the project").isTrue();
+ assertThat(map.containsKey("maven-test:t09-c")).as("maven-test:t09-c is in the project").isFalse();
}
/**
@@ -97,7 +94,7 @@ void testDependencyManagementExclusionsExcludeTransitively() throws Exception {
* @throws Exception
*/
@Test
- void testDependencyManagementExclusionDoesNotOverrideGloballyForTransitives() throws Exception {
+ void dependencyManagementExclusionDoesNotOverrideGloballyForTransitives() throws Exception {
File localRepo = getLocalRepositoryPath();
File pom0 = new File(localRepo, "p0/pom.xml");
@@ -108,15 +105,15 @@ void testDependencyManagementExclusionDoesNotOverrideGloballyForTransitives() th
MavenProject project0 = getProjectWithDependencies(pom0);
MavenProject project2 = getProjectWithDependencies(pom2);
- assertEquals(pom0Basedir, project2.getParent().getBasedir());
+ assertThat(project2.getParent().getBasedir()).isEqualTo(pom0Basedir);
Map map = project2.getArtifactMap();
- assertNotNull(map, "No artifacts");
- assertTrue(map.size() > 0, "No Artifacts");
- assertTrue(map.size() == 4, "Set size should be 4, is " + map.size());
+ assertThat(map).as("No artifacts").isNotNull();
+ assertThat(map.size() > 0).as("No Artifacts").isTrue();
+ assertThat(map.size()).as("Set size should be 4, is " + map.size()).isEqualTo(4);
- assertTrue(map.containsKey("maven-test:t09-a"), "maven-test:t09-a is not in the project");
- assertTrue(map.containsKey("maven-test:t09-b"), "maven-test:t09-b is not in the project");
- assertTrue(map.containsKey("maven-test:t09-c"), "maven-test:t09-c is not in the project");
- assertTrue(map.containsKey("maven-test:t09-d"), "maven-test:t09-d is not in the project");
+ assertThat(map.containsKey("maven-test:t09-a")).as("maven-test:t09-a is not in the project").isTrue();
+ assertThat(map.containsKey("maven-test:t09-b")).as("maven-test:t09-b is not in the project").isTrue();
+ assertThat(map.containsKey("maven-test:t09-c")).as("maven-test:t09-c is not in the project").isTrue();
+ assertThat(map.containsKey("maven-test:t09-d")).as("maven-test:t09-d is not in the project").isTrue();
}
}
diff --git a/compat/maven-compat/src/test/java/org/apache/maven/project/inheritance/t10/ProjectInheritanceTest.java b/compat/maven-compat/src/test/java/org/apache/maven/project/inheritance/t10/ProjectInheritanceTest.java
index e9004e01133a..cf654982fad2 100644
--- a/compat/maven-compat/src/test/java/org/apache/maven/project/inheritance/t10/ProjectInheritanceTest.java
+++ b/compat/maven-compat/src/test/java/org/apache/maven/project/inheritance/t10/ProjectInheritanceTest.java
@@ -26,9 +26,7 @@
import org.apache.maven.project.inheritance.AbstractProjectInheritanceTestCase;
import org.junit.jupiter.api.Test;
-import static org.junit.jupiter.api.Assertions.assertEquals;
-import static org.junit.jupiter.api.Assertions.assertNotNull;
-import static org.junit.jupiter.api.Assertions.assertTrue;
+import static org.assertj.core.api.Assertions.assertThat;
/**
* Verifies scope inheritance of direct and transitive dependencies.
@@ -56,7 +54,7 @@ class ProjectInheritanceTest extends AbstractProjectInheritanceTestCase {
// ----------------------------------------------------------------------
@Test
- void testDependencyManagementOverridesTransitiveDependencyVersion() throws Exception {
+ void dependencyManagementOverridesTransitiveDependencyVersion() throws Exception {
File localRepo = getLocalRepositoryPath();
File pom0 = new File(localRepo, "p0/pom.xml");
@@ -67,29 +65,29 @@ void testDependencyManagementOverridesTransitiveDependencyVersion() throws Excep
MavenProject project0 = getProjectWithDependencies(pom0);
MavenProject project1 = getProjectWithDependencies(pom1);
- assertEquals(pom0Basedir, project1.getParent().getBasedir());
+ assertThat(project1.getParent().getBasedir()).isEqualTo(pom0Basedir);
System.out.println("Project " + project1.getId() + " " + project1);
Map map = project1.getArtifactMap();
- assertNotNull(map, "No artifacts");
- assertTrue(map.size() > 0, "No Artifacts");
- assertTrue(map.size() == 3, "Set size should be 3, is " + map.size());
+ assertThat(map).as("No artifacts").isNotNull();
+ assertThat(map.size() > 0).as("No Artifacts").isTrue();
+ assertThat(map.size()).as("Set size should be 3, is " + map.size()).isEqualTo(3);
Artifact a = (Artifact) map.get("maven-test:t10-a");
Artifact b = (Artifact) map.get("maven-test:t10-b");
Artifact c = (Artifact) map.get("maven-test:t10-c");
- assertNotNull(a);
- assertNotNull(b);
- assertNotNull(c);
+ assertThat(a).isNotNull();
+ assertThat(b).isNotNull();
+ assertThat(c).isNotNull();
// inherited from depMgmt
System.out.println(a.getScope());
- assertTrue(a.getScope().equals("test"), "Incorrect scope for " + a.getDependencyConflictId());
+ assertThat(a.getScope()).as("Incorrect scope for " + a.getDependencyConflictId()).isEqualTo("test");
// transitive dep, overridden b depMgmt
- assertTrue(b.getScope().equals("runtime"), "Incorrect scope for " + b.getDependencyConflictId());
+ assertThat(b.getScope()).as("Incorrect scope for " + b.getDependencyConflictId()).isEqualTo("runtime");
// direct dep, overrides depMgmt
- assertTrue(c.getScope().equals("runtime"), "Incorrect scope for " + c.getDependencyConflictId());
+ assertThat(c.getScope()).as("Incorrect scope for " + c.getDependencyConflictId()).isEqualTo("runtime");
}
}
diff --git a/compat/maven-compat/src/test/java/org/apache/maven/project/inheritance/t11/ProjectInheritanceTest.java b/compat/maven-compat/src/test/java/org/apache/maven/project/inheritance/t11/ProjectInheritanceTest.java
index 9b0a188c5666..5cd460f65b93 100644
--- a/compat/maven-compat/src/test/java/org/apache/maven/project/inheritance/t11/ProjectInheritanceTest.java
+++ b/compat/maven-compat/src/test/java/org/apache/maven/project/inheritance/t11/ProjectInheritanceTest.java
@@ -24,8 +24,7 @@
import org.apache.maven.project.inheritance.AbstractProjectInheritanceTestCase;
import org.junit.jupiter.api.Test;
-import static org.junit.jupiter.api.Assertions.assertEquals;
-import static org.junit.jupiter.api.Assertions.assertNull;
+import static org.assertj.core.api.Assertions.assertThat;
/**
* Verifies scope of root project is preserved regardless of parent dependency management.
@@ -47,7 +46,7 @@ class ProjectInheritanceTest extends AbstractProjectInheritanceTestCase {
// ----------------------------------------------------------------------
@Test
- void testDependencyManagementDoesNotOverrideScopeOfCurrentArtifact() throws Exception {
+ void dependencyManagementDoesNotOverrideScopeOfCurrentArtifact() throws Exception {
File localRepo = getLocalRepositoryPath();
File pom0 = new File(localRepo, "p0/pom.xml");
@@ -58,9 +57,7 @@ void testDependencyManagementDoesNotOverrideScopeOfCurrentArtifact() throws Exce
MavenProject project0 = getProjectWithDependencies(pom0);
MavenProject project1 = getProjectWithDependencies(pom1);
- assertEquals(pom0Basedir, project1.getParent().getBasedir());
- assertNull(
- project1.getArtifact().getScope(),
- "dependencyManagement has overwritten the scope of the currently building child project");
+ assertThat(project1.getParent().getBasedir()).isEqualTo(pom0Basedir);
+ assertThat(project1.getArtifact().getScope()).as("dependencyManagement has overwritten the scope of the currently building child project").isNull();
}
}
diff --git a/compat/maven-compat/src/test/java/org/apache/maven/project/inheritance/t12/ProjectInheritanceTest.java b/compat/maven-compat/src/test/java/org/apache/maven/project/inheritance/t12/ProjectInheritanceTest.java
index 0a30d34ffa28..b024f7b473b0 100644
--- a/compat/maven-compat/src/test/java/org/apache/maven/project/inheritance/t12/ProjectInheritanceTest.java
+++ b/compat/maven-compat/src/test/java/org/apache/maven/project/inheritance/t12/ProjectInheritanceTest.java
@@ -26,8 +26,7 @@
import org.apache.maven.project.inheritance.AbstractProjectInheritanceTestCase;
import org.junit.jupiter.api.Test;
-import static org.junit.jupiter.api.Assertions.assertNotNull;
-import static org.junit.jupiter.api.Assertions.assertNull;
+import static org.assertj.core.api.Assertions.assertThat;
/**
* Verifies that plugin execution sections in the parent POM that have
@@ -48,7 +47,7 @@ class ProjectInheritanceTest extends AbstractProjectInheritanceTestCase {
// ----------------------------------------------------------------------
@Test
- void testFalsePluginExecutionInheritValue() throws Exception {
+ void falsePluginExecutionInheritValue() throws Exception {
File localRepo = getLocalRepositoryPath();
File pom0 = new File(localRepo, "p0/pom.xml");
@@ -61,11 +60,9 @@ void testFalsePluginExecutionInheritValue() throws Exception {
Map pluginMap = project1.getBuild().getPluginsAsMap();
Plugin compilerPlugin = (Plugin) pluginMap.get("org.apache.maven.plugins:maven-compiler-plugin");
- assertNotNull(compilerPlugin);
+ assertThat(compilerPlugin).isNotNull();
Map executionMap = compilerPlugin.getExecutionsAsMap();
- assertNull(
- executionMap.get("test"),
- "Plugin execution: 'test' should NOT exist in the compiler plugin specification for the child project!");
+ assertThat(executionMap.get("test")).as("Plugin execution: 'test' should NOT exist in the compiler plugin specification for the child project!").isNull();
}
}
diff --git a/compat/maven-compat/src/test/java/org/apache/maven/project/inheritance/t12scm/ProjectInheritanceTest.java b/compat/maven-compat/src/test/java/org/apache/maven/project/inheritance/t12scm/ProjectInheritanceTest.java
index 61c0c1fb0fac..716c045cfaa6 100644
--- a/compat/maven-compat/src/test/java/org/apache/maven/project/inheritance/t12scm/ProjectInheritanceTest.java
+++ b/compat/maven-compat/src/test/java/org/apache/maven/project/inheritance/t12scm/ProjectInheritanceTest.java
@@ -24,7 +24,7 @@
import org.apache.maven.project.inheritance.AbstractProjectInheritanceTestCase;
import org.junit.jupiter.api.Test;
-import static org.junit.jupiter.api.Assertions.assertEquals;
+import static org.assertj.core.api.Assertions.assertThat;
/**
* Verifies SCM inheritance uses modules statement from parent.
@@ -43,7 +43,7 @@ class ProjectInheritanceTest extends AbstractProjectInheritanceTestCase {
// ----------------------------------------------------------------------
@Test
- void testScmInfoCalculatedCorrectlyOnParentAndChildRead() throws Exception {
+ void scmInfoCalculatedCorrectlyOnParentAndChildRead() throws Exception {
File localRepo = getLocalRepositoryPath();
File pom0 = new File(localRepo, "p0/pom.xml");
@@ -54,14 +54,13 @@ void testScmInfoCalculatedCorrectlyOnParentAndChildRead() throws Exception {
MavenProject project0 = getProject(pom0);
MavenProject project1 = getProject(pom1);
- assertEquals(project1.getScm().getUrl(), project0.getScm().getUrl() + "/modules/p1");
- assertEquals(project1.getScm().getConnection(), project0.getScm().getConnection() + "/modules/p1");
- assertEquals(
- project1.getScm().getDeveloperConnection(), project0.getScm().getDeveloperConnection() + "/modules/p1");
+ assertThat(project0.getScm().getUrl() + "/modules/p1").isEqualTo(project1.getScm().getUrl());
+ assertThat(project0.getScm().getConnection() + "/modules/p1").isEqualTo(project1.getScm().getConnection());
+ assertThat(project0.getScm().getDeveloperConnection() + "/modules/p1").isEqualTo(project1.getScm().getDeveloperConnection());
}
@Test
- void testScmInfoCalculatedCorrectlyOnChildOnlyRead() throws Exception {
+ void scmInfoCalculatedCorrectlyOnChildOnlyRead() throws Exception {
File localRepo = getLocalRepositoryPath();
File pom1 = new File(localRepo, "p0/modules/p1/pom.xml");
@@ -69,8 +68,8 @@ void testScmInfoCalculatedCorrectlyOnChildOnlyRead() throws Exception {
// load the child project, which inherits from p0...
MavenProject project1 = getProject(pom1);
- assertEquals("http://host/viewer?path=/p0/modules/p1", project1.getScm().getUrl());
- assertEquals("scm:svn:http://host/p0/modules/p1", project1.getScm().getConnection());
- assertEquals("scm:svn:https://host/p0/modules/p1", project1.getScm().getDeveloperConnection());
+ assertThat(project1.getScm().getUrl()).isEqualTo("http://host/viewer?path=/p0/modules/p1");
+ assertThat(project1.getScm().getConnection()).isEqualTo("scm:svn:http://host/p0/modules/p1");
+ assertThat(project1.getScm().getDeveloperConnection()).isEqualTo("scm:svn:https://host/p0/modules/p1");
}
}
diff --git a/compat/maven-compat/src/test/java/org/apache/maven/project/path/DefaultPathTranslatorTest.java b/compat/maven-compat/src/test/java/org/apache/maven/project/path/DefaultPathTranslatorTest.java
index d194a78e9c71..c6cad472c8fe 100644
--- a/compat/maven-compat/src/test/java/org/apache/maven/project/path/DefaultPathTranslatorTest.java
+++ b/compat/maven-compat/src/test/java/org/apache/maven/project/path/DefaultPathTranslatorTest.java
@@ -22,35 +22,35 @@
import org.junit.jupiter.api.Test;
-import static org.junit.jupiter.api.Assertions.assertEquals;
+import static org.assertj.core.api.Assertions.assertThat;
@Deprecated
class DefaultPathTranslatorTest {
@Test
- void testAlignToBasedirWhereBasedirExpressionIsTheCompleteValue() {
+ void alignToBasedirWhereBasedirExpressionIsTheCompleteValue() {
File basedir = new File(System.getProperty("java.io.tmpdir"), "test").getAbsoluteFile();
String aligned = new DefaultPathTranslator().alignToBaseDirectory("${basedir}", basedir);
- assertEquals(basedir.getAbsolutePath(), aligned);
+ assertThat(aligned).isEqualTo(basedir.getAbsolutePath());
}
@Test
- void testAlignToBasedirWhereBasedirExpressionIsTheValuePrefix() {
+ void alignToBasedirWhereBasedirExpressionIsTheValuePrefix() {
File basedir = new File(System.getProperty("java.io.tmpdir"), "test").getAbsoluteFile();
String aligned = new DefaultPathTranslator().alignToBaseDirectory("${basedir}/dir", basedir);
- assertEquals(new File(basedir, "dir").getAbsolutePath(), aligned);
+ assertThat(aligned).isEqualTo(new File(basedir, "dir").getAbsolutePath());
}
@Test
- void testUnalignToBasedirWherePathEqualsBasedir() {
+ void unalignToBasedirWherePathEqualsBasedir() {
File basedir = new File(System.getProperty("java.io.tmpdir"), "test").getAbsoluteFile();
String unaligned = new DefaultPathTranslator().unalignFromBaseDirectory(basedir.getAbsolutePath(), basedir);
- assertEquals(".", unaligned);
+ assertThat(unaligned).isEqualTo(".");
}
}
diff --git a/compat/maven-compat/src/test/java/org/apache/maven/repository/DefaultMirrorSelectorTest.java b/compat/maven-compat/src/test/java/org/apache/maven/repository/DefaultMirrorSelectorTest.java
index 2d2a2631806b..7e43f5579753 100644
--- a/compat/maven-compat/src/test/java/org/apache/maven/repository/DefaultMirrorSelectorTest.java
+++ b/compat/maven-compat/src/test/java/org/apache/maven/repository/DefaultMirrorSelectorTest.java
@@ -22,14 +22,14 @@
import org.apache.maven.artifact.repository.DefaultArtifactRepository;
import org.junit.jupiter.api.Test;
-import static org.junit.jupiter.api.Assertions.assertFalse;
+import static org.assertj.core.api.Assertions.assertThat;
@Deprecated
class DefaultMirrorSelectorTest {
@Test
- void testMirrorWithMirrorOfPatternContainingANegationIsNotSelected() {
+ void mirrorWithMirrorOfPatternContainingANegationIsNotSelected() {
ArtifactRepository repository = new DefaultArtifactRepository("snapshots.repo", "http://whatever", null);
String pattern = "external:*, !snapshots.repo";
- assertFalse(DefaultMirrorSelector.matchPattern(repository, pattern));
+ assertThat(DefaultMirrorSelector.matchPattern(repository, pattern)).isFalse();
}
}
diff --git a/compat/maven-compat/src/test/java/org/apache/maven/repository/LegacyRepositorySystemTest.java b/compat/maven-compat/src/test/java/org/apache/maven/repository/LegacyRepositorySystemTest.java
index 8f9709a175c0..7d23690c5b34 100644
--- a/compat/maven-compat/src/test/java/org/apache/maven/repository/LegacyRepositorySystemTest.java
+++ b/compat/maven-compat/src/test/java/org/apache/maven/repository/LegacyRepositorySystemTest.java
@@ -68,10 +68,8 @@
import org.junit.jupiter.api.BeforeEach;
import org.junit.jupiter.api.Test;
+import static org.assertj.core.api.Assertions.assertThat;
import static org.codehaus.plexus.testing.PlexusExtension.getBasedir;
-import static org.junit.jupiter.api.Assertions.assertEquals;
-import static org.junit.jupiter.api.Assertions.assertFalse;
-import static org.junit.jupiter.api.Assertions.assertTrue;
/**
* Tests {@link LegacyRepositorySystem}.
@@ -116,7 +114,7 @@ protected ArtifactRepository getLocalRepository() throws Exception {
}
@Test
- void testThatASystemScopedDependencyIsNotResolvedFromRepositories() throws Exception {
+ void thatASystemScopedDependencyIsNotResolvedFromRepositories() throws Exception {
//
// We should get a whole slew of dependencies resolving this artifact transitively
//
@@ -178,14 +176,14 @@ public void setPath(ProducedArtifact artifact, Path path) {
ArtifactResolutionResult result = repositorySystem.resolve(request);
resolutionErrorHandler.throwErrors(request, result);
- assertEquals(2, result.getArtifacts().size());
+ assertThat(result.getArtifacts().size()).isEqualTo(2);
//
// System scoped version which should
//
d.setScope(Artifact.SCOPE_SYSTEM);
File file = new File(getBasedir(), "src/test/repository-system/maven-core-2.1.0.jar");
- assertTrue(file.exists());
+ assertThat(file.exists()).isTrue();
d.setSystemPath(file.getCanonicalPath());
artifact = repositorySystem.createDependencyArtifact(d);
@@ -202,13 +200,13 @@ public void setPath(ProducedArtifact artifact, Path path) {
result = repositorySystem.resolve(request);
resolutionErrorHandler.throwErrors(request, result);
- assertEquals(1, result.getArtifacts().size());
+ assertThat(result.getArtifacts().size()).isEqualTo(1);
//
// Put in a bogus file to make sure missing files cause the resolution to fail.
//
file = new File(getBasedir(), "src/test/repository-system/maven-monkey-2.1.0.jar");
- assertFalse(file.exists());
+ assertThat(file.exists()).isFalse();
d.setSystemPath(file.getCanonicalPath());
artifact = repositorySystem.createDependencyArtifact(d);
@@ -226,24 +224,24 @@ public void setPath(ProducedArtifact artifact, Path path) {
result = repositorySystem.resolve(request);
resolutionErrorHandler.throwErrors(request, result);
} catch (Exception e) {
- assertTrue(result.hasMissingArtifacts());
+ assertThat(result.hasMissingArtifacts()).isTrue();
}
}
@Test
- void testLocalRepositoryBasedir() throws Exception {
+ void localRepositoryBasedir() throws Exception {
File localRepoDir = new File("").getAbsoluteFile();
ArtifactRepository localRepo = repositorySystem.createLocalRepository(localRepoDir);
String basedir = localRepo.getBasedir();
- assertFalse(basedir.endsWith("/"));
- assertFalse(basedir.endsWith("\\"));
+ assertThat(basedir.endsWith("/")).isFalse();
+ assertThat(basedir.endsWith("\\")).isFalse();
- assertEquals(localRepoDir, new File(basedir));
+ assertThat(new File(basedir)).isEqualTo(localRepoDir);
- assertEquals(localRepoDir.getPath(), basedir);
+ assertThat(basedir).isEqualTo(localRepoDir.getPath());
}
@Inject
diff --git a/compat/maven-compat/src/test/java/org/apache/maven/repository/MirrorProcessorTest.java b/compat/maven-compat/src/test/java/org/apache/maven/repository/MirrorProcessorTest.java
index 34c859807cb0..2a42618491e0 100644
--- a/compat/maven-compat/src/test/java/org/apache/maven/repository/MirrorProcessorTest.java
+++ b/compat/maven-compat/src/test/java/org/apache/maven/repository/MirrorProcessorTest.java
@@ -30,10 +30,7 @@
import org.codehaus.plexus.testing.PlexusTest;
import org.junit.jupiter.api.Test;
-import static org.junit.jupiter.api.Assertions.assertFalse;
-import static org.junit.jupiter.api.Assertions.assertNull;
-import static org.junit.jupiter.api.Assertions.assertSame;
-import static org.junit.jupiter.api.Assertions.assertTrue;
+import static org.assertj.core.api.Assertions.assertThat;
@PlexusTest
@Deprecated
@@ -45,58 +42,58 @@ class MirrorProcessorTest {
private ArtifactRepositoryFactory repositorySystem;
@Test
- void testExternalURL() {
- assertTrue(DefaultMirrorSelector.isExternalRepo(getRepo("foo", "http://somehost")));
- assertTrue(DefaultMirrorSelector.isExternalRepo(getRepo("foo", "http://somehost:9090/somepath")));
- assertTrue(DefaultMirrorSelector.isExternalRepo(getRepo("foo", "ftp://somehost")));
- assertTrue(DefaultMirrorSelector.isExternalRepo(getRepo("foo", "http://192.168.101.1")));
- assertTrue(DefaultMirrorSelector.isExternalRepo(getRepo("foo", "http://")));
+ void externalURL() {
+ assertThat(DefaultMirrorSelector.isExternalRepo(getRepo("foo", "http://somehost"))).isTrue();
+ assertThat(DefaultMirrorSelector.isExternalRepo(getRepo("foo", "http://somehost:9090/somepath"))).isTrue();
+ assertThat(DefaultMirrorSelector.isExternalRepo(getRepo("foo", "ftp://somehost"))).isTrue();
+ assertThat(DefaultMirrorSelector.isExternalRepo(getRepo("foo", "http://192.168.101.1"))).isTrue();
+ assertThat(DefaultMirrorSelector.isExternalRepo(getRepo("foo", "http://"))).isTrue();
// these are local
- assertFalse(DefaultMirrorSelector.isExternalRepo(getRepo("foo", "http://localhost:8080")));
- assertFalse(DefaultMirrorSelector.isExternalRepo(getRepo("foo", "http://127.0.0.1:9090")));
- assertFalse(DefaultMirrorSelector.isExternalRepo(getRepo("foo", "file://localhost/somepath")));
- assertFalse(DefaultMirrorSelector.isExternalRepo(getRepo("foo", "file://localhost/D:/somepath")));
- assertFalse(DefaultMirrorSelector.isExternalRepo(getRepo("foo", "http://localhost")));
- assertFalse(DefaultMirrorSelector.isExternalRepo(getRepo("foo", "http://127.0.0.1")));
- assertFalse(DefaultMirrorSelector.isExternalRepo(getRepo("foo", "file:///somepath")));
- assertFalse(DefaultMirrorSelector.isExternalRepo(getRepo("foo", "file://D:/somepath")));
+ assertThat(DefaultMirrorSelector.isExternalRepo(getRepo("foo", "http://localhost:8080"))).isFalse();
+ assertThat(DefaultMirrorSelector.isExternalRepo(getRepo("foo", "http://127.0.0.1:9090"))).isFalse();
+ assertThat(DefaultMirrorSelector.isExternalRepo(getRepo("foo", "file://localhost/somepath"))).isFalse();
+ assertThat(DefaultMirrorSelector.isExternalRepo(getRepo("foo", "file://localhost/D:/somepath"))).isFalse();
+ assertThat(DefaultMirrorSelector.isExternalRepo(getRepo("foo", "http://localhost"))).isFalse();
+ assertThat(DefaultMirrorSelector.isExternalRepo(getRepo("foo", "http://127.0.0.1"))).isFalse();
+ assertThat(DefaultMirrorSelector.isExternalRepo(getRepo("foo", "file:///somepath"))).isFalse();
+ assertThat(DefaultMirrorSelector.isExternalRepo(getRepo("foo", "file://D:/somepath"))).isFalse();
// not a proper url so returns false;
- assertFalse(DefaultMirrorSelector.isExternalRepo(getRepo("foo", "192.168.101.1")));
- assertFalse(DefaultMirrorSelector.isExternalRepo(getRepo("foo", "")));
+ assertThat(DefaultMirrorSelector.isExternalRepo(getRepo("foo", "192.168.101.1"))).isFalse();
+ assertThat(DefaultMirrorSelector.isExternalRepo(getRepo("foo", ""))).isFalse();
}
@Test
- void testMirrorLookup() {
+ void mirrorLookup() {
Mirror mirrorA = newMirror("a", "a", "http://a");
Mirror mirrorB = newMirror("b", "b", "http://b");
List mirrors = Arrays.asList(mirrorA, mirrorB);
- assertSame(mirrorA, mirrorSelector.getMirror(getRepo("a", "http://a.a"), mirrors));
+ assertThat(mirrorSelector.getMirror(getRepo("a", "http://a.a"), mirrors)).isSameAs(mirrorA);
- assertSame(mirrorB, mirrorSelector.getMirror(getRepo("b", "http://a.a"), mirrors));
+ assertThat(mirrorSelector.getMirror(getRepo("b", "http://a.a"), mirrors)).isSameAs(mirrorB);
- assertNull(mirrorSelector.getMirror(getRepo("c", "http://c.c"), mirrors));
+ assertThat(mirrorSelector.getMirror(getRepo("c", "http://c.c"), mirrors)).isNull();
}
@Test
- void testMirrorWildcardLookup() {
+ void mirrorWildcardLookup() {
Mirror mirrorA = newMirror("a", "a", "http://a");
Mirror mirrorB = newMirror("b", "b", "http://b");
Mirror mirrorC = newMirror("c", "*", "http://wildcard");
List mirrors = Arrays.asList(mirrorA, mirrorB, mirrorC);
- assertSame(mirrorA, mirrorSelector.getMirror(getRepo("a", "http://a.a"), mirrors));
+ assertThat(mirrorSelector.getMirror(getRepo("a", "http://a.a"), mirrors)).isSameAs(mirrorA);
- assertSame(mirrorB, mirrorSelector.getMirror(getRepo("b", "http://a.a"), mirrors));
+ assertThat(mirrorSelector.getMirror(getRepo("b", "http://a.a"), mirrors)).isSameAs(mirrorB);
- assertSame(mirrorC, mirrorSelector.getMirror(getRepo("c", "http://c.c"), mirrors));
+ assertThat(mirrorSelector.getMirror(getRepo("c", "http://c.c"), mirrors)).isSameAs(mirrorC);
}
@Test
- void testMirrorStopOnFirstMatch() {
+ void mirrorStopOnFirstMatch() {
// exact matches win first
Mirror mirrorA2 = newMirror("a2", "a,b", "http://a2");
Mirror mirrorA = newMirror("a", "a", "http://a");
@@ -110,90 +107,90 @@ void testMirrorStopOnFirstMatch() {
List mirrors = Arrays.asList(mirrorA2, mirrorA, mirrorA3, mirrorB, mirrorC, mirrorC2, mirrorC3);
- assertSame(mirrorA, mirrorSelector.getMirror(getRepo("a", "http://a.a"), mirrors));
+ assertThat(mirrorSelector.getMirror(getRepo("a", "http://a.a"), mirrors)).isSameAs(mirrorA);
- assertSame(mirrorB, mirrorSelector.getMirror(getRepo("b", "http://a.a"), mirrors));
+ assertThat(mirrorSelector.getMirror(getRepo("b", "http://a.a"), mirrors)).isSameAs(mirrorB);
- assertSame(mirrorC2, mirrorSelector.getMirror(getRepo("c", "http://c.c"), mirrors));
+ assertThat(mirrorSelector.getMirror(getRepo("c", "http://c.c"), mirrors)).isSameAs(mirrorC2);
- assertSame(mirrorC, mirrorSelector.getMirror(getRepo("d", "http://d"), mirrors));
+ assertThat(mirrorSelector.getMirror(getRepo("d", "http://d"), mirrors)).isSameAs(mirrorC);
- assertSame(mirrorC, mirrorSelector.getMirror(getRepo("e", "http://e"), mirrors));
+ assertThat(mirrorSelector.getMirror(getRepo("e", "http://e"), mirrors)).isSameAs(mirrorC);
- assertSame(mirrorC2, mirrorSelector.getMirror(getRepo("f", "http://f"), mirrors));
+ assertThat(mirrorSelector.getMirror(getRepo("f", "http://f"), mirrors)).isSameAs(mirrorC2);
}
@Test
- void testPatterns() {
- assertTrue(DefaultMirrorSelector.matchPattern(getRepo("a"), "*"));
- assertTrue(DefaultMirrorSelector.matchPattern(getRepo("a"), "*,"));
- assertTrue(DefaultMirrorSelector.matchPattern(getRepo("a"), ",*,"));
- assertTrue(DefaultMirrorSelector.matchPattern(getRepo("a"), "*,"));
+ void patterns() {
+ assertThat(DefaultMirrorSelector.matchPattern(getRepo("a"), "*")).isTrue();
+ assertThat(DefaultMirrorSelector.matchPattern(getRepo("a"), "*,")).isTrue();
+ assertThat(DefaultMirrorSelector.matchPattern(getRepo("a"), ",*,")).isTrue();
+ assertThat(DefaultMirrorSelector.matchPattern(getRepo("a"), "*,")).isTrue();
- assertTrue(DefaultMirrorSelector.matchPattern(getRepo("a"), "a"));
- assertTrue(DefaultMirrorSelector.matchPattern(getRepo("a"), "a,"));
- assertTrue(DefaultMirrorSelector.matchPattern(getRepo("a"), ",a,"));
- assertTrue(DefaultMirrorSelector.matchPattern(getRepo("a"), "a,"));
+ assertThat(DefaultMirrorSelector.matchPattern(getRepo("a"), "a")).isTrue();
+ assertThat(DefaultMirrorSelector.matchPattern(getRepo("a"), "a,")).isTrue();
+ assertThat(DefaultMirrorSelector.matchPattern(getRepo("a"), ",a,")).isTrue();
+ assertThat(DefaultMirrorSelector.matchPattern(getRepo("a"), "a,")).isTrue();
- assertFalse(DefaultMirrorSelector.matchPattern(getRepo("b"), "a"));
- assertFalse(DefaultMirrorSelector.matchPattern(getRepo("b"), "a,"));
- assertFalse(DefaultMirrorSelector.matchPattern(getRepo("b"), ",a"));
- assertFalse(DefaultMirrorSelector.matchPattern(getRepo("b"), ",a,"));
+ assertThat(DefaultMirrorSelector.matchPattern(getRepo("b"), "a")).isFalse();
+ assertThat(DefaultMirrorSelector.matchPattern(getRepo("b"), "a,")).isFalse();
+ assertThat(DefaultMirrorSelector.matchPattern(getRepo("b"), ",a")).isFalse();
+ assertThat(DefaultMirrorSelector.matchPattern(getRepo("b"), ",a,")).isFalse();
- assertTrue(DefaultMirrorSelector.matchPattern(getRepo("a"), "a,b"));
- assertTrue(DefaultMirrorSelector.matchPattern(getRepo("b"), "a,b"));
+ assertThat(DefaultMirrorSelector.matchPattern(getRepo("a"), "a,b")).isTrue();
+ assertThat(DefaultMirrorSelector.matchPattern(getRepo("b"), "a,b")).isTrue();
- assertFalse(DefaultMirrorSelector.matchPattern(getRepo("c"), "a,b"));
+ assertThat(DefaultMirrorSelector.matchPattern(getRepo("c"), "a,b")).isFalse();
- assertTrue(DefaultMirrorSelector.matchPattern(getRepo("a"), "*"));
- assertTrue(DefaultMirrorSelector.matchPattern(getRepo("a"), "*,b"));
- assertTrue(DefaultMirrorSelector.matchPattern(getRepo("a"), "*,!b"));
+ assertThat(DefaultMirrorSelector.matchPattern(getRepo("a"), "*")).isTrue();
+ assertThat(DefaultMirrorSelector.matchPattern(getRepo("a"), "*,b")).isTrue();
+ assertThat(DefaultMirrorSelector.matchPattern(getRepo("a"), "*,!b")).isTrue();
- assertFalse(DefaultMirrorSelector.matchPattern(getRepo("a"), "*,!a"));
- assertFalse(DefaultMirrorSelector.matchPattern(getRepo("a"), "!a,*"));
+ assertThat(DefaultMirrorSelector.matchPattern(getRepo("a"), "*,!a")).isFalse();
+ assertThat(DefaultMirrorSelector.matchPattern(getRepo("a"), "!a,*")).isFalse();
- assertTrue(DefaultMirrorSelector.matchPattern(getRepo("c"), "*,!a"));
- assertTrue(DefaultMirrorSelector.matchPattern(getRepo("c"), "!a,*"));
+ assertThat(DefaultMirrorSelector.matchPattern(getRepo("c"), "*,!a")).isTrue();
+ assertThat(DefaultMirrorSelector.matchPattern(getRepo("c"), "!a,*")).isTrue();
- assertFalse(DefaultMirrorSelector.matchPattern(getRepo("c"), "!a,!c"));
- assertFalse(DefaultMirrorSelector.matchPattern(getRepo("d"), "!a,!c*"));
+ assertThat(DefaultMirrorSelector.matchPattern(getRepo("c"), "!a,!c")).isFalse();
+ assertThat(DefaultMirrorSelector.matchPattern(getRepo("d"), "!a,!c*")).isFalse();
}
@Test
- void testPatternsWithExternal() {
- assertTrue(DefaultMirrorSelector.matchPattern(getRepo("a", "http://localhost"), "*"));
- assertFalse(DefaultMirrorSelector.matchPattern(getRepo("a", "http://localhost"), "external:*"));
+ void patternsWithExternal() {
+ assertThat(DefaultMirrorSelector.matchPattern(getRepo("a", "http://localhost"), "*")).isTrue();
+ assertThat(DefaultMirrorSelector.matchPattern(getRepo("a", "http://localhost"), "external:*")).isFalse();
- assertTrue(DefaultMirrorSelector.matchPattern(getRepo("a", "http://localhost"), "external:*,a"));
- assertFalse(DefaultMirrorSelector.matchPattern(getRepo("a", "http://localhost"), "external:*,!a"));
- assertTrue(DefaultMirrorSelector.matchPattern(getRepo("a", "http://localhost"), "a,external:*"));
- assertFalse(DefaultMirrorSelector.matchPattern(getRepo("a", "http://localhost"), "!a,external:*"));
+ assertThat(DefaultMirrorSelector.matchPattern(getRepo("a", "http://localhost"), "external:*,a")).isTrue();
+ assertThat(DefaultMirrorSelector.matchPattern(getRepo("a", "http://localhost"), "external:*,!a")).isFalse();
+ assertThat(DefaultMirrorSelector.matchPattern(getRepo("a", "http://localhost"), "a,external:*")).isTrue();
+ assertThat(DefaultMirrorSelector.matchPattern(getRepo("a", "http://localhost"), "!a,external:*")).isFalse();
- assertFalse(DefaultMirrorSelector.matchPattern(getRepo("c", "http://localhost"), "!a,external:*"));
- assertTrue(DefaultMirrorSelector.matchPattern(getRepo("c", "http://somehost"), "!a,external:*"));
+ assertThat(DefaultMirrorSelector.matchPattern(getRepo("c", "http://localhost"), "!a,external:*")).isFalse();
+ assertThat(DefaultMirrorSelector.matchPattern(getRepo("c", "http://somehost"), "!a,external:*")).isTrue();
}
@Test
- void testLayoutPattern() {
- assertTrue(DefaultMirrorSelector.matchesLayout("default", null));
- assertTrue(DefaultMirrorSelector.matchesLayout("default", ""));
- assertTrue(DefaultMirrorSelector.matchesLayout("default", "*"));
+ void layoutPattern() {
+ assertThat(DefaultMirrorSelector.matchesLayout("default", null)).isTrue();
+ assertThat(DefaultMirrorSelector.matchesLayout("default", "")).isTrue();
+ assertThat(DefaultMirrorSelector.matchesLayout("default", "*")).isTrue();
- assertTrue(DefaultMirrorSelector.matchesLayout("default", "default"));
- assertFalse(DefaultMirrorSelector.matchesLayout("default", "legacy"));
+ assertThat(DefaultMirrorSelector.matchesLayout("default", "default")).isTrue();
+ assertThat(DefaultMirrorSelector.matchesLayout("default", "legacy")).isFalse();
- assertTrue(DefaultMirrorSelector.matchesLayout("default", "legacy,default"));
- assertTrue(DefaultMirrorSelector.matchesLayout("default", "default,legacy"));
+ assertThat(DefaultMirrorSelector.matchesLayout("default", "legacy,default")).isTrue();
+ assertThat(DefaultMirrorSelector.matchesLayout("default", "default,legacy")).isTrue();
- assertFalse(DefaultMirrorSelector.matchesLayout("default", "legacy,!default"));
- assertFalse(DefaultMirrorSelector.matchesLayout("default", "!default,legacy"));
+ assertThat(DefaultMirrorSelector.matchesLayout("default", "legacy,!default")).isFalse();
+ assertThat(DefaultMirrorSelector.matchesLayout("default", "!default,legacy")).isFalse();
- assertFalse(DefaultMirrorSelector.matchesLayout("default", "*,!default"));
- assertFalse(DefaultMirrorSelector.matchesLayout("default", "!default,*"));
+ assertThat(DefaultMirrorSelector.matchesLayout("default", "*,!default")).isFalse();
+ assertThat(DefaultMirrorSelector.matchesLayout("default", "!default,*")).isFalse();
}
@Test
- void testMirrorLayoutConsideredForMatching() {
+ void mirrorLayoutConsideredForMatching() {
ArtifactRepository repo = getRepo("a");
Mirror mirrorA = newMirror("a", "a", null, "http://a");
@@ -202,11 +199,11 @@ void testMirrorLayoutConsideredForMatching() {
Mirror mirrorC = newMirror("c", "*", null, "http://c");
Mirror mirrorD = newMirror("d", "*", "p2", "http://d");
- assertSame(mirrorA, mirrorSelector.getMirror(repo, Arrays.asList(mirrorA)));
- assertNull(mirrorSelector.getMirror(repo, Arrays.asList(mirrorB)));
+ assertThat(mirrorSelector.getMirror(repo, Arrays.asList(mirrorA))).isSameAs(mirrorA);
+ assertThat(mirrorSelector.getMirror(repo, Arrays.asList(mirrorB))).isNull();
- assertSame(mirrorC, mirrorSelector.getMirror(repo, Arrays.asList(mirrorC)));
- assertNull(mirrorSelector.getMirror(repo, Arrays.asList(mirrorD)));
+ assertThat(mirrorSelector.getMirror(repo, Arrays.asList(mirrorC))).isSameAs(mirrorC);
+ assertThat(mirrorSelector.getMirror(repo, Arrays.asList(mirrorD))).isNull();
}
/**
diff --git a/compat/maven-compat/src/test/java/org/apache/maven/repository/legacy/DefaultUpdateCheckManagerTest.java b/compat/maven-compat/src/test/java/org/apache/maven/repository/legacy/DefaultUpdateCheckManagerTest.java
index e06318c1db31..381efada1966 100644
--- a/compat/maven-compat/src/test/java/org/apache/maven/repository/legacy/DefaultUpdateCheckManagerTest.java
+++ b/compat/maven-compat/src/test/java/org/apache/maven/repository/legacy/DefaultUpdateCheckManagerTest.java
@@ -33,11 +33,7 @@
import org.junit.jupiter.api.BeforeEach;
import org.junit.jupiter.api.Test;
-import static org.junit.jupiter.api.Assertions.assertEquals;
-import static org.junit.jupiter.api.Assertions.assertFalse;
-import static org.junit.jupiter.api.Assertions.assertNotNull;
-import static org.junit.jupiter.api.Assertions.assertNull;
-import static org.junit.jupiter.api.Assertions.assertTrue;
+import static org.assertj.core.api.Assertions.assertThat;
@Deprecated
class DefaultUpdateCheckManagerTest extends AbstractArtifactComponentTestCase {
@@ -61,7 +57,7 @@ public void setUp() throws Exception {
}
@Test
- void testArtifact() throws Exception {
+ void artifact() throws Exception {
ArtifactRepository remoteRepository = remoteRepository();
ArtifactRepository localRepository = localRepository();
@@ -74,22 +70,21 @@ void testArtifact() throws Exception {
File touchFile = updateCheckManager.getTouchfile(a);
touchFile.delete();
- assertTrue(updateCheckManager.isUpdateRequired(a, remoteRepository));
+ assertThat(updateCheckManager.isUpdateRequired(a, remoteRepository)).isTrue();
file.getParentFile().mkdirs();
file.createNewFile();
updateCheckManager.touch(a, remoteRepository, null);
- assertFalse(updateCheckManager.isUpdateRequired(a, remoteRepository));
+ assertThat(updateCheckManager.isUpdateRequired(a, remoteRepository)).isFalse();
- assertNull(
- updateCheckManager.readLastUpdated(touchFile, updateCheckManager.getRepositoryKey(remoteRepository)));
+ assertThat(updateCheckManager.readLastUpdated(touchFile, updateCheckManager.getRepositoryKey(remoteRepository))).isNull();
- assertFalse(updateCheckManager.getTouchfile(a).exists());
+ assertThat(updateCheckManager.getTouchfile(a).exists()).isFalse();
}
@Test
- void testMissingArtifact() throws Exception {
+ void missingArtifact() throws Exception {
ArtifactRepository remoteRepository = remoteRepository();
ArtifactRepository localRepository = localRepository();
@@ -102,19 +97,18 @@ void testMissingArtifact() throws Exception {
File touchFile = updateCheckManager.getTouchfile(a);
touchFile.delete();
- assertTrue(updateCheckManager.isUpdateRequired(a, remoteRepository));
+ assertThat(updateCheckManager.isUpdateRequired(a, remoteRepository)).isTrue();
updateCheckManager.touch(a, remoteRepository, null);
- assertFalse(updateCheckManager.isUpdateRequired(a, remoteRepository));
+ assertThat(updateCheckManager.isUpdateRequired(a, remoteRepository)).isFalse();
- assertFalse(file.exists());
- assertNotNull(
- updateCheckManager.readLastUpdated(touchFile, updateCheckManager.getRepositoryKey(remoteRepository)));
+ assertThat(file.exists()).isFalse();
+ assertThat(updateCheckManager.readLastUpdated(touchFile, updateCheckManager.getRepositoryKey(remoteRepository))).isNotNull();
}
@Test
- void testPom() throws Exception {
+ void pom() throws Exception {
ArtifactRepository remoteRepository = remoteRepository();
ArtifactRepository localRepository = localRepository();
@@ -127,22 +121,21 @@ void testPom() throws Exception {
File touchFile = updateCheckManager.getTouchfile(a);
touchFile.delete();
- assertTrue(updateCheckManager.isUpdateRequired(a, remoteRepository));
+ assertThat(updateCheckManager.isUpdateRequired(a, remoteRepository)).isTrue();
file.getParentFile().mkdirs();
file.createNewFile();
updateCheckManager.touch(a, remoteRepository, null);
- assertFalse(updateCheckManager.isUpdateRequired(a, remoteRepository));
+ assertThat(updateCheckManager.isUpdateRequired(a, remoteRepository)).isFalse();
- assertNull(
- updateCheckManager.readLastUpdated(touchFile, updateCheckManager.getRepositoryKey(remoteRepository)));
+ assertThat(updateCheckManager.readLastUpdated(touchFile, updateCheckManager.getRepositoryKey(remoteRepository))).isNull();
- assertFalse(updateCheckManager.getTouchfile(a).exists());
+ assertThat(updateCheckManager.getTouchfile(a).exists()).isFalse();
}
@Test
- void testMissingPom() throws Exception {
+ void missingPom() throws Exception {
ArtifactRepository remoteRepository = remoteRepository();
ArtifactRepository localRepository = localRepository();
@@ -155,19 +148,18 @@ void testMissingPom() throws Exception {
File touchFile = updateCheckManager.getTouchfile(a);
touchFile.delete();
- assertTrue(updateCheckManager.isUpdateRequired(a, remoteRepository));
+ assertThat(updateCheckManager.isUpdateRequired(a, remoteRepository)).isTrue();
updateCheckManager.touch(a, remoteRepository, null);
- assertFalse(updateCheckManager.isUpdateRequired(a, remoteRepository));
+ assertThat(updateCheckManager.isUpdateRequired(a, remoteRepository)).isFalse();
- assertFalse(file.exists());
- assertNotNull(
- updateCheckManager.readLastUpdated(touchFile, updateCheckManager.getRepositoryKey(remoteRepository)));
+ assertThat(file.exists()).isFalse();
+ assertThat(updateCheckManager.readLastUpdated(touchFile, updateCheckManager.getRepositoryKey(remoteRepository))).isNotNull();
}
@Test
- void testMetadata() throws Exception {
+ void metadata() throws Exception {
ArtifactRepository remoteRepository = remoteRepository();
ArtifactRepository localRepository = localRepository();
@@ -182,20 +174,20 @@ void testMetadata() throws Exception {
File touchFile = updateCheckManager.getTouchfile(metadata, file);
touchFile.delete();
- assertTrue(updateCheckManager.isUpdateRequired(metadata, remoteRepository, file));
+ assertThat(updateCheckManager.isUpdateRequired(metadata, remoteRepository, file)).isTrue();
file.getParentFile().mkdirs();
file.createNewFile();
updateCheckManager.touch(metadata, remoteRepository, file);
- assertFalse(updateCheckManager.isUpdateRequired(metadata, remoteRepository, file));
+ assertThat(updateCheckManager.isUpdateRequired(metadata, remoteRepository, file)).isFalse();
- assertNotNull(updateCheckManager.readLastUpdated(
- touchFile, updateCheckManager.getMetadataKey(remoteRepository, file)));
+ assertThat(updateCheckManager.readLastUpdated(
+ touchFile, updateCheckManager.getMetadataKey(remoteRepository, file))).isNotNull();
}
@Test
- void testMissingMetadata() throws Exception {
+ void missingMetadata() throws Exception {
ArtifactRepository remoteRepository = remoteRepository();
ArtifactRepository localRepository = localRepository();
@@ -210,34 +202,30 @@ void testMissingMetadata() throws Exception {
File touchFile = updateCheckManager.getTouchfile(metadata, file);
touchFile.delete();
- assertTrue(updateCheckManager.isUpdateRequired(metadata, remoteRepository, file));
+ assertThat(updateCheckManager.isUpdateRequired(metadata, remoteRepository, file)).isTrue();
updateCheckManager.touch(metadata, remoteRepository, file);
- assertFalse(updateCheckManager.isUpdateRequired(metadata, remoteRepository, file));
+ assertThat(updateCheckManager.isUpdateRequired(metadata, remoteRepository, file)).isFalse();
- assertNotNull(updateCheckManager.readLastUpdated(
- touchFile, updateCheckManager.getMetadataKey(remoteRepository, file)));
+ assertThat(updateCheckManager.readLastUpdated(
+ touchFile, updateCheckManager.getMetadataKey(remoteRepository, file))).isNotNull();
}
@Test
- void testArtifactTouchFileName() throws Exception {
+ void artifactTouchFileName() throws Exception {
ArtifactRepository localRepository = localRepository();
Artifact a = artifactFactory.createArtifactWithClassifier("groupId", "a", "0.0.1-SNAPSHOT", "jar", null);
File file = new File(localRepository.getBasedir(), localRepository.pathOf(a));
a.setFile(file);
- assertEquals(
- "a-0.0.1-SNAPSHOT.jar.lastUpdated",
- updateCheckManager.getTouchfile(a).getName());
+ assertThat(updateCheckManager.getTouchfile(a).getName()).isEqualTo("a-0.0.1-SNAPSHOT.jar.lastUpdated");
a = artifactFactory.createArtifactWithClassifier("groupId", "a", "0.0.1-SNAPSHOT", "jar", "classifier");
file = new File(localRepository.getBasedir(), localRepository.pathOf(a));
a.setFile(file);
- assertEquals(
- "a-0.0.1-SNAPSHOT-classifier.jar.lastUpdated",
- updateCheckManager.getTouchfile(a).getName());
+ assertThat(updateCheckManager.getTouchfile(a).getName()).isEqualTo("a-0.0.1-SNAPSHOT-classifier.jar.lastUpdated");
}
}
diff --git a/compat/maven-compat/src/test/java/org/apache/maven/repository/legacy/DefaultWagonManagerTest.java b/compat/maven-compat/src/test/java/org/apache/maven/repository/legacy/DefaultWagonManagerTest.java
index bc3d21540236..6bc623fa8e3b 100644
--- a/compat/maven-compat/src/test/java/org/apache/maven/repository/legacy/DefaultWagonManagerTest.java
+++ b/compat/maven-compat/src/test/java/org/apache/maven/repository/legacy/DefaultWagonManagerTest.java
@@ -48,13 +48,10 @@
import org.junit.jupiter.api.Disabled;
import org.junit.jupiter.api.Test;
+import static org.assertj.core.api.Assertions.assertThat;
+import static org.assertj.core.api.AssertionsForClassTypes.assertThatExceptionOfType;
import static org.codehaus.plexus.testing.PlexusExtension.getTestFile;
-import static org.junit.jupiter.api.Assertions.assertEquals;
-import static org.junit.jupiter.api.Assertions.assertFalse;
-import static org.junit.jupiter.api.Assertions.assertNotNull;
import static org.junit.jupiter.api.Assertions.assertNotSame;
-import static org.junit.jupiter.api.Assertions.assertThrows;
-import static org.junit.jupiter.api.Assertions.assertTrue;
/**
*/
@@ -73,7 +70,7 @@ class DefaultWagonManagerTest {
private ArtifactRepositoryFactory artifactRepositoryFactory;
@Test
- void testUnnecessaryRepositoryLookup() throws Exception {
+ void unnecessaryRepositoryLookup() throws Exception {
Artifact artifact = createTestPomArtifact("target/test-data/get-missing-pom");
List repos = new ArrayList<>();
@@ -101,33 +98,33 @@ public void transferInitiated(TransferEvent transferEvent) {
TransferListener listener = new TransferListener();
wagonManager.getArtifact(artifact, repos, listener, false);
- assertEquals(1, listener.events.size());
+ assertThat(listener.events.size()).isEqualTo(1);
}
@Test
- void testGetMissingJar() throws TransferFailedException, UnsupportedProtocolException, IOException {
+ void getMissingJar() throws TransferFailedException, UnsupportedProtocolException, IOException {
Artifact artifact = createTestArtifact("target/test-data/get-missing-jar", "jar");
ArtifactRepository repo = createStringRepo();
- assertThrows(ResourceDoesNotExistException.class, () -> wagonManager.getArtifact(artifact, repo, null, false));
+ assertThatExceptionOfType(ResourceDoesNotExistException.class).isThrownBy(() -> wagonManager.getArtifact(artifact, repo, null, false));
- assertFalse(artifact.getFile().exists());
+ assertThat(artifact.getFile().exists()).isFalse();
}
@Test
- void testGetMissingJarForced() throws TransferFailedException, UnsupportedProtocolException, IOException {
+ void getMissingJarForced() throws TransferFailedException, UnsupportedProtocolException, IOException {
Artifact artifact = createTestArtifact("target/test-data/get-missing-jar", "jar");
ArtifactRepository repo = createStringRepo();
- assertThrows(ResourceDoesNotExistException.class, () -> wagonManager.getArtifact(artifact, repo, null, true));
+ assertThatExceptionOfType(ResourceDoesNotExistException.class).isThrownBy(() -> wagonManager.getArtifact(artifact, repo, null, true));
- assertFalse(artifact.getFile().exists());
+ assertThat(artifact.getFile().exists()).isFalse();
}
@Test
- void testGetRemoteJar()
+ void getRemoteJar()
throws TransferFailedException, ResourceDoesNotExistException, UnsupportedProtocolException, IOException {
Artifact artifact = createTestArtifact("target/test-data/get-remote-jar", "jar");
@@ -139,8 +136,8 @@ void testGetRemoteJar()
wagonManager.getArtifact(artifact, repo, null, false);
- assertTrue(artifact.getFile().exists());
- assertEquals("expected", FileUtils.fileRead(artifact.getFile(), "UTF-8"));
+ assertThat(artifact.getFile().exists()).isTrue();
+ assertThat(FileUtils.fileRead(artifact.getFile(), "UTF-8")).isEqualTo("expected");
}
private Artifact createTestPomArtifact(String directory) throws IOException {
@@ -150,7 +147,7 @@ private Artifact createTestPomArtifact(String directory) throws IOException {
Artifact artifact = artifactFactory.createProjectArtifact("test", "test", "1.0");
artifact.setFile(new File(testData, "test-1.0.pom"));
- assertFalse(artifact.getFile().exists());
+ assertThat(artifact.getFile().exists()).isFalse();
return artifact;
}
@@ -167,7 +164,7 @@ private Artifact createTestArtifact(String directory, String version, String typ
artifact.setFile(new File(
testData,
"test-" + version + "." + artifact.getArtifactHandler().getExtension()));
- assertFalse(artifact.getFile().exists());
+ assertThat(artifact.getFile().exists()).isFalse();
return artifact;
}
@@ -198,7 +195,7 @@ private ArtifactRepository getRepo(String id) {
}
@Test
- void testDefaultWagonManager() throws Exception {
+ void defaultWagonManager() throws Exception {
assertWagon("a");
assertWagon("b");
@@ -207,14 +204,14 @@ void testDefaultWagonManager() throws Exception {
assertWagon("string");
- assertThrows(UnsupportedProtocolException.class, () -> assertWagon("d"));
+ assertThatExceptionOfType(UnsupportedProtocolException.class).isThrownBy(() -> assertWagon("d"));
}
/**
* Check that transfer listeners are properly removed after getArtifact and putArtifact
*/
@Test
- void testWagonTransferListenerRemovedAfterGetArtifactAndPutArtifact() throws Exception {
+ void wagonTransferListenerRemovedAfterGetArtifactAndPutArtifact() throws Exception {
Artifact artifact = createTestArtifact("target/test-data/transfer-listener", "jar");
ArtifactRepository repo = createStringRepo();
StringWagon wagon = (StringWagon) wagonManager.getWagon("string");
@@ -222,25 +219,17 @@ void testWagonTransferListenerRemovedAfterGetArtifactAndPutArtifact() throws Exc
wagon.addExpectedContent(repo.getLayout().pathOf(artifact) + ".md5", "cd26d9e10ce691cc69aa2b90dcebbdac");
/* getArtifact */
- assertFalse(
- wagon.getTransferEventSupport().hasTransferListener(transferListener),
- "Transfer listener is registered before test");
+ assertThat(wagon.getTransferEventSupport().hasTransferListener(transferListener)).as("Transfer listener is registered before test").isFalse();
wagonManager.getArtifact(artifact, repo, transferListener, false);
- assertFalse(
- wagon.getTransferEventSupport().hasTransferListener(transferListener),
- "Transfer listener still registered after getArtifact");
+ assertThat(wagon.getTransferEventSupport().hasTransferListener(transferListener)).as("Transfer listener still registered after getArtifact").isFalse();
/* putArtifact */
File sampleFile = getTestFile("target/test-file");
FileUtils.fileWrite(sampleFile.getAbsolutePath(), "sample file");
- assertFalse(
- wagon.getTransferEventSupport().hasTransferListener(transferListener),
- "Transfer listener is registered before test");
+ assertThat(wagon.getTransferEventSupport().hasTransferListener(transferListener)).as("Transfer listener is registered before test").isFalse();
wagonManager.putArtifact(sampleFile, artifact, repo, transferListener);
- assertFalse(
- wagon.getTransferEventSupport().hasTransferListener(transferListener),
- "Transfer listener still registered after putArtifact");
+ assertThat(wagon.getTransferEventSupport().hasTransferListener(transferListener)).as("Transfer listener still registered after putArtifact").isFalse();
}
/**
@@ -248,7 +237,7 @@ void testWagonTransferListenerRemovedAfterGetArtifactAndPutArtifact() throws Exc
*/
@Disabled
@Test
- void testChecksumVerification() throws Exception {
+ void checksumVerification() throws Exception {
ArtifactRepositoryPolicy policy = new ArtifactRepositoryPolicy(
true, ArtifactRepositoryPolicy.UPDATE_POLICY_ALWAYS, ArtifactRepositoryPolicy.CHECKSUM_POLICY_FAIL);
@@ -280,10 +269,7 @@ void testChecksumVerification() throws Exception {
wagon.clearExpectedContent();
wagon.addExpectedContent("path", "expected-failure");
wagon.addExpectedContent("path.sha1", "b7bb97d7d0b9244398d9b47296907f73313663e6");
- assertThrows(
- ChecksumFailedException.class,
- () -> wagonManager.getArtifact(artifact, repo, null, false),
- "Checksum verification did not fail");
+ assertThatExceptionOfType(ChecksumFailedException.class).as("Checksum verification did not fail").isThrownBy(() -> wagonManager.getArtifact(artifact, repo, null, false));
wagon.clearExpectedContent();
wagon.addExpectedContent("path", "lower-case-checksum");
@@ -298,14 +284,11 @@ void testChecksumVerification() throws Exception {
wagon.clearExpectedContent();
wagon.addExpectedContent("path", "expected-failure");
wagon.addExpectedContent("path.md5", "b7bb97d7d0b9244398d9b47296907f73313663e6");
- assertThrows(
- ChecksumFailedException.class,
- () -> wagonManager.getArtifact(artifact, repo, null, false),
- "Checksum verification did not fail");
+ assertThatExceptionOfType(ChecksumFailedException.class).as("Checksum verification did not fail").isThrownBy(() -> wagonManager.getArtifact(artifact, repo, null, false));
}
@Test
- void testPerLookupInstantiation() throws Exception {
+ void perLookupInstantiation() throws Exception {
String protocol = "perlookup";
Wagon one = wagonManager.getWagon(protocol);
@@ -317,7 +300,7 @@ void testPerLookupInstantiation() throws Exception {
private void assertWagon(String protocol) throws Exception {
Wagon wagon = wagonManager.getWagon(protocol);
- assertNotNull(wagon, "Check wagon, protocol=" + protocol);
+ assertThat(wagon).as("Check wagon, protocol=" + protocol).isNotNull();
}
private final class ArtifactRepositoryLayoutStub implements ArtifactRepositoryLayout {
diff --git a/compat/maven-compat/src/test/java/org/apache/maven/repository/legacy/LegacyRepositorySystemTest.java b/compat/maven-compat/src/test/java/org/apache/maven/repository/legacy/LegacyRepositorySystemTest.java
index 82554ea83ac7..498ce2cef3f4 100644
--- a/compat/maven-compat/src/test/java/org/apache/maven/repository/legacy/LegacyRepositorySystemTest.java
+++ b/compat/maven-compat/src/test/java/org/apache/maven/repository/legacy/LegacyRepositorySystemTest.java
@@ -29,8 +29,7 @@
import org.codehaus.plexus.testing.PlexusTest;
import org.junit.jupiter.api.Test;
-import static org.junit.jupiter.api.Assertions.assertEquals;
-import static org.junit.jupiter.api.Assertions.assertNotNull;
+import static org.assertj.core.api.Assertions.assertThat;
/**
* Tests {@link LegacyRepositorySystem}.
@@ -43,14 +42,14 @@ class LegacyRepositorySystemTest {
private LegacyRepositorySystem repositorySystem;
@Test
- void testThatLocalRepositoryWithSpacesIsProperlyHandled() throws Exception {
+ void thatLocalRepositoryWithSpacesIsProperlyHandled() throws Exception {
File basedir = new File("target/spacy path").getAbsoluteFile();
ArtifactRepository repo = repositorySystem.createLocalRepository(basedir);
- assertEquals(basedir, new File(repo.getBasedir()));
+ assertThat(new File(repo.getBasedir())).isEqualTo(basedir);
}
@Test
- void testAuthenticationHandling() {
+ void authenticationHandling() {
Server server = new Server();
server.setId("repository");
server.setUsername("jason");
@@ -60,8 +59,8 @@ void testAuthenticationHandling() {
repositorySystem.createArtifactRepository("repository", "http://foo", null, null, null);
repositorySystem.injectAuthentication(Arrays.asList(repository), Arrays.asList(server));
Authentication authentication = repository.getAuthentication();
- assertNotNull(authentication);
- assertEquals("jason", authentication.getUsername());
- assertEquals("abc123", authentication.getPassword());
+ assertThat(authentication).isNotNull();
+ assertThat(authentication.getUsername()).isEqualTo("jason");
+ assertThat(authentication.getPassword()).isEqualTo("abc123");
}
}
diff --git a/compat/maven-compat/src/test/java/org/apache/maven/repository/legacy/resolver/DefaultArtifactCollectorTest.java b/compat/maven-compat/src/test/java/org/apache/maven/repository/legacy/resolver/DefaultArtifactCollectorTest.java
index f3cf58135349..70f89fd97097 100644
--- a/compat/maven-compat/src/test/java/org/apache/maven/repository/legacy/resolver/DefaultArtifactCollectorTest.java
+++ b/compat/maven-compat/src/test/java/org/apache/maven/repository/legacy/resolver/DefaultArtifactCollectorTest.java
@@ -53,10 +53,8 @@
import org.junit.jupiter.api.Disabled;
import org.junit.jupiter.api.Test;
-import static org.junit.jupiter.api.Assertions.assertEquals;
-import static org.junit.jupiter.api.Assertions.assertNotNull;
-import static org.junit.jupiter.api.Assertions.assertThrows;
-import static org.junit.jupiter.api.Assertions.assertTrue;
+import static org.assertj.core.api.Assertions.assertThat;
+import static org.assertj.core.api.AssertionsForClassTypes.assertThatExceptionOfType;
/**
* Test the default artifact collector.
@@ -86,32 +84,26 @@ void setUp() throws Exception {
@Test
@Disabled("works, but we don't fail on cycles presently")
- void testCircularDependencyNotIncludingCurrentProject()
+ void circularDependencyNotIncludingCurrentProject()
throws ArtifactResolutionException, InvalidVersionSpecificationException {
ArtifactSpec a = createArtifactSpec("a", "1.0");
ArtifactSpec b = a.addDependency("b", "1.0");
b.addDependency("a", "1.0");
- assertThrows(
- CyclicDependencyException.class,
- () -> collect(a),
- "Should have failed on cyclic dependency not involving project");
+ assertThatExceptionOfType(CyclicDependencyException.class).as("Should have failed on cyclic dependency not involving project").isThrownBy(() -> collect(a));
}
@Test
@Disabled("works, but we don't fail on cycles presently")
- void testCircularDependencyIncludingCurrentProject()
+ void circularDependencyIncludingCurrentProject()
throws ArtifactResolutionException, InvalidVersionSpecificationException {
ArtifactSpec a = createArtifactSpec("a", "1.0");
ArtifactSpec b = a.addDependency("b", "1.0");
b.addDependency("project", "1.0");
- assertThrows(
- CyclicDependencyException.class,
- () -> collect(a),
- "Should have failed on cyclic dependency not involving project");
+ assertThatExceptionOfType(CyclicDependencyException.class).as("Should have failed on cyclic dependency not involving project").isThrownBy(() -> collect(a));
}
@Test
- void testResolveWithFilter() throws ArtifactResolutionException, InvalidVersionSpecificationException {
+ void resolveWithFilter() throws ArtifactResolutionException, InvalidVersionSpecificationException {
ArtifactSpec a = createArtifactSpec("a", "1.0");
ArtifactSpec b = a.addDependency("b", "1.0");
ArtifactSpec c = a.addDependency("c", "3.0");
@@ -120,18 +112,15 @@ void testResolveWithFilter() throws ArtifactResolutionException, InvalidVersionS
ArtifactSpec d = b.addDependency("d", "4.0");
ArtifactResolutionResult res = collect(a);
- assertEquals(
- createSet(new Object[] {a.artifact, b.artifact, c.artifact, d.artifact}),
- res.getArtifacts(),
- "Check artifact list");
+ assertThat(res.getArtifacts()).as("Check artifact list").isEqualTo(createSet(new Object[]{a.artifact, b.artifact, c.artifact, d.artifact}));
ArtifactFilter filter = new ExclusionSetFilter(new String[] {"b"});
res = collect(a, filter);
- assertEquals(createSet(new Object[] {a.artifact, c.artifact}), res.getArtifacts(), "Check artifact list");
+ assertThat(res.getArtifacts()).as("Check artifact list").isEqualTo(createSet(new Object[]{a.artifact, c.artifact}));
}
@Test
- void testResolveCorrectDependenciesWhenDifferentDependenciesOnNearest()
+ void resolveCorrectDependenciesWhenDifferentDependenciesOnNearest()
throws ArtifactResolutionException, InvalidVersionSpecificationException {
ArtifactSpec a = createArtifactSpec("a", "1.0");
ArtifactSpec b = a.addDependency("b", "1.0");
@@ -143,16 +132,13 @@ void testResolveCorrectDependenciesWhenDifferentDependenciesOnNearest()
ArtifactSpec f = c1.addDependency("f", "1.0");
ArtifactResolutionResult res = collect(createSet(new Object[] {a.artifact, e.artifact}));
- assertEquals(
- createSet(new Object[] {a.artifact, b.artifact, e.artifact, c1.artifact, f.artifact}),
- res.getArtifacts(),
- "Check artifact list");
- assertEquals("1.0", getArtifact("c", res.getArtifacts()).getVersion(), "Check version");
+ assertThat(res.getArtifacts()).as("Check artifact list").isEqualTo(createSet(new Object[]{a.artifact, b.artifact, e.artifact, c1.artifact, f.artifact}));
+ assertThat(getArtifact("c", res.getArtifacts()).getVersion()).as("Check version").isEqualTo("1.0");
}
@Test
@Disabled
- void testResolveCorrectDependenciesWhenDifferentDependenciesOnNewest()
+ void resolveCorrectDependenciesWhenDifferentDependenciesOnNewest()
throws ArtifactResolutionException, InvalidVersionSpecificationException {
// TODO use newest conflict resolver
ArtifactSpec a = createArtifactSpec("a", "1.0");
@@ -165,16 +151,13 @@ void testResolveCorrectDependenciesWhenDifferentDependenciesOnNewest()
c1.addDependency("f", "1.0");
ArtifactResolutionResult res = collect(createSet(new Object[] {a.artifact, e.artifact}));
- assertEquals(
- createSet(new Object[] {a.artifact, b.artifact, e.artifact, c2.artifact, d.artifact}),
- res.getArtifacts(),
- "Check artifact list");
- assertEquals("2.0", getArtifact("c", res.getArtifacts()).getVersion(), "Check version");
+ assertThat(res.getArtifacts()).as("Check artifact list").isEqualTo(createSet(new Object[]{a.artifact, b.artifact, e.artifact, c2.artifact, d.artifact}));
+ assertThat(getArtifact("c", res.getArtifacts()).getVersion()).as("Check version").isEqualTo("2.0");
}
@Test
@Disabled
- void testResolveCorrectDependenciesWhenDifferentDependenciesOnNewestVersionReplaced()
+ void resolveCorrectDependenciesWhenDifferentDependenciesOnNewestVersionReplaced()
throws ArtifactResolutionException, InvalidVersionSpecificationException {
// TODO use newest conflict resolver
ArtifactSpec a = createArtifactSpec("a", "1.0");
@@ -189,13 +172,13 @@ void testResolveCorrectDependenciesWhenDifferentDependenciesOnNewestVersionRepla
ArtifactResolutionResult res = collect(createSet(new Object[] {a.artifact}));
Object[] artifacts = new Object[] {a.artifact, c.artifact, d1.artifact, b2.artifact, e.artifact, g.artifact};
- assertEquals(createSet(artifacts), res.getArtifacts(), "Check artifact list");
- assertEquals("1.0", getArtifact("d", res.getArtifacts()).getVersion(), "Check version");
- assertEquals("2.0", getArtifact("b", res.getArtifacts()).getVersion(), "Check version");
+ assertThat(res.getArtifacts()).as("Check artifact list").isEqualTo(createSet(artifacts));
+ assertThat(getArtifact("d", res.getArtifacts()).getVersion()).as("Check version").isEqualTo("1.0");
+ assertThat(getArtifact("b", res.getArtifacts()).getVersion()).as("Check version").isEqualTo("2.0");
}
@Test
- void testResolveNearestNewestIsNearest() throws ArtifactResolutionException, InvalidVersionSpecificationException {
+ void resolveNearestNewestIsNearest() throws ArtifactResolutionException, InvalidVersionSpecificationException {
ArtifactSpec a = createArtifactSpec("a", "1.0");
ArtifactSpec b = a.addDependency("b", "1.0");
ArtifactSpec c = a.addDependency("c", "3.0");
@@ -203,15 +186,12 @@ void testResolveNearestNewestIsNearest() throws ArtifactResolutionException, Inv
b.addDependency("c", "2.0");
ArtifactResolutionResult res = collect(a);
- assertEquals(
- createSet(new Object[] {a.artifact, b.artifact, c.artifact}),
- res.getArtifacts(),
- "Check artifact list");
- assertEquals("3.0", getArtifact("c", res.getArtifacts()).getVersion(), "Check version");
+ assertThat(res.getArtifacts()).as("Check artifact list").isEqualTo(createSet(new Object[]{a.artifact, b.artifact, c.artifact}));
+ assertThat(getArtifact("c", res.getArtifacts()).getVersion()).as("Check version").isEqualTo("3.0");
}
@Test
- void testResolveNearestOldestIsNearest() throws ArtifactResolutionException, InvalidVersionSpecificationException {
+ void resolveNearestOldestIsNearest() throws ArtifactResolutionException, InvalidVersionSpecificationException {
ArtifactSpec a = createArtifactSpec("a", "1.0");
ArtifactSpec b = a.addDependency("b", "1.0");
ArtifactSpec c = a.addDependency("c", "2.0");
@@ -219,65 +199,60 @@ void testResolveNearestOldestIsNearest() throws ArtifactResolutionException, Inv
b.addDependency("c", "3.0");
ArtifactResolutionResult res = collect(a);
- assertEquals(
- createSet(new Object[] {a.artifact, b.artifact, c.artifact}),
- res.getArtifacts(),
- "Check artifact list");
- assertEquals("2.0", getArtifact("c", res.getArtifacts()).getVersion(), "Check version");
+ assertThat(res.getArtifacts()).as("Check artifact list").isEqualTo(createSet(new Object[]{a.artifact, b.artifact, c.artifact}));
+ assertThat(getArtifact("c", res.getArtifacts()).getVersion()).as("Check version").isEqualTo("2.0");
}
@Test
- void testResolveLocalNewestIsLocal() throws ArtifactResolutionException, InvalidVersionSpecificationException {
+ void resolveLocalNewestIsLocal() throws ArtifactResolutionException, InvalidVersionSpecificationException {
ArtifactSpec a = createArtifactSpec("a", "1.0");
a.addDependency("b", "2.0");
ArtifactSpec b = createArtifactSpec("b", "3.0");
ArtifactResolutionResult res = collect(createSet(new Object[] {a.artifact, b.artifact}));
- assertEquals(createSet(new Object[] {a.artifact, b.artifact}), res.getArtifacts(), "Check artifact list");
- assertEquals("3.0", getArtifact("b", res.getArtifacts()).getVersion(), "Check version");
+ assertThat(res.getArtifacts()).as("Check artifact list").isEqualTo(createSet(new Object[]{a.artifact, b.artifact}));
+ assertThat(getArtifact("b", res.getArtifacts()).getVersion()).as("Check version").isEqualTo("3.0");
}
@Test
- void testResolveLocalOldestIsLocal() throws ArtifactResolutionException, InvalidVersionSpecificationException {
+ void resolveLocalOldestIsLocal() throws ArtifactResolutionException, InvalidVersionSpecificationException {
ArtifactSpec a = createArtifactSpec("a", "1.0");
a.addDependency("b", "3.0");
ArtifactSpec b = createArtifactSpec("b", "2.0");
ArtifactResolutionResult res = collect(createSet(new Object[] {a.artifact, b.artifact}));
- assertEquals(createSet(new Object[] {a.artifact, b.artifact}), res.getArtifacts(), "Check artifact list");
- assertEquals("2.0", getArtifact("b", res.getArtifacts()).getVersion(), "Check version");
+ assertThat(res.getArtifacts()).as("Check artifact list").isEqualTo(createSet(new Object[]{a.artifact, b.artifact}));
+ assertThat(getArtifact("b", res.getArtifacts()).getVersion()).as("Check version").isEqualTo("2.0");
}
@Test
- void testResolveLocalWithNewerVersionButLesserScope()
+ void resolveLocalWithNewerVersionButLesserScope()
throws ArtifactResolutionException, InvalidVersionSpecificationException {
ArtifactSpec a = createArtifactSpec("commons-logging", "1.0");
a.addDependency("junit", "3.7");
ArtifactSpec b = createArtifactSpec("junit", "3.8.1", Artifact.SCOPE_TEST);
ArtifactResolutionResult res = collect(createSet(new Object[] {a.artifact, b.artifact}));
- assertEquals(createSet(new Object[] {a.artifact, b.artifact}), res.getArtifacts(), "Check artifact list");
- assertEquals("3.8.1", getArtifact("junit", res.getArtifacts()).getVersion(), "Check version");
- assertEquals(
- Artifact.SCOPE_TEST, getArtifact("junit", res.getArtifacts()).getScope(), "Check artifactScope");
+ assertThat(res.getArtifacts()).as("Check artifact list").isEqualTo(createSet(new Object[]{a.artifact, b.artifact}));
+ assertThat(getArtifact("junit", res.getArtifacts()).getVersion()).as("Check version").isEqualTo("3.8.1");
+ assertThat(getArtifact("junit", res.getArtifacts()).getScope()).as("Check artifactScope").isEqualTo(Artifact.SCOPE_TEST);
}
@Test
- void testResolveLocalWithNewerVersionButLesserScopeResolvedFirst()
+ void resolveLocalWithNewerVersionButLesserScopeResolvedFirst()
throws ArtifactResolutionException, InvalidVersionSpecificationException {
ArtifactSpec b = createArtifactSpec("junit", "3.8.1", Artifact.SCOPE_TEST);
ArtifactSpec a = createArtifactSpec("commons-logging", "1.0");
a.addDependency("junit", "3.7");
ArtifactResolutionResult res = collect(createSet(new Object[] {a.artifact, b.artifact}));
- assertEquals(createSet(new Object[] {a.artifact, b.artifact}), res.getArtifacts(), "Check artifact list");
- assertEquals("3.8.1", getArtifact("junit", res.getArtifacts()).getVersion(), "Check version");
- assertEquals(
- Artifact.SCOPE_TEST, getArtifact("junit", res.getArtifacts()).getScope(), "Check artifactScope");
+ assertThat(res.getArtifacts()).as("Check artifact list").isEqualTo(createSet(new Object[]{a.artifact, b.artifact}));
+ assertThat(getArtifact("junit", res.getArtifacts()).getVersion()).as("Check version").isEqualTo("3.8.1");
+ assertThat(getArtifact("junit", res.getArtifacts()).getScope()).as("Check artifactScope").isEqualTo(Artifact.SCOPE_TEST);
}
@Test
- void testResolveNearestWithRanges() throws ArtifactResolutionException, InvalidVersionSpecificationException {
+ void resolveNearestWithRanges() throws ArtifactResolutionException, InvalidVersionSpecificationException {
ArtifactSpec a = createArtifactSpec("a", "1.0");
ArtifactSpec b = a.addDependency("b", "1.0");
ArtifactSpec c = a.addDependency("c", "2.0");
@@ -285,29 +260,25 @@ void testResolveNearestWithRanges() throws ArtifactResolutionException, InvalidV
b.addDependency("c", "[1.0,3.0]");
ArtifactResolutionResult res = collect(a);
- assertEquals(
- createSet(new Object[] {a.artifact, b.artifact, c.artifact}),
- res.getArtifacts(),
- "Check artifact list");
- assertEquals("2.0", getArtifact("c", res.getArtifacts()).getVersion(), "Check version");
+ assertThat(res.getArtifacts()).as("Check artifact list").isEqualTo(createSet(new Object[]{a.artifact, b.artifact, c.artifact}));
+ assertThat(getArtifact("c", res.getArtifacts()).getVersion()).as("Check version").isEqualTo("2.0");
}
@Test
@SuppressWarnings("checkstyle:UnusedLocalVariable")
- void testResolveRangeWithManagedVersion() throws ArtifactResolutionException, InvalidVersionSpecificationException {
+ void resolveRangeWithManagedVersion() throws ArtifactResolutionException, InvalidVersionSpecificationException {
ArtifactSpec a = createArtifactSpec("a", "1.0");
ArtifactSpec b = a.addDependency("b", "[1.0,3.0]");
ArtifactSpec managedB = createArtifactSpec("b", "5.0");
ArtifactResolutionResult res = collect(a, managedB.artifact);
- assertEquals(
- createSet(new Object[] {a.artifact, managedB.artifact}), res.getArtifacts(), "Check artifact list");
- assertEquals("5.0", getArtifact("b", res.getArtifacts()).getVersion(), "Check version");
+ assertThat(res.getArtifacts()).as("Check artifact list").isEqualTo(createSet(new Object[]{a.artifact, managedB.artifact}));
+ assertThat(getArtifact("b", res.getArtifacts()).getVersion()).as("Check version").isEqualTo("5.0");
}
@Test
- void testCompatibleRanges() throws ArtifactResolutionException, InvalidVersionSpecificationException {
+ void compatibleRanges() throws ArtifactResolutionException, InvalidVersionSpecificationException {
ArtifactSpec a = createArtifactSpec("a", "1.0");
ArtifactSpec b = a.addDependency("b", "1.0");
a.addDependency("c", "[2.0,2.5]");
@@ -316,15 +287,12 @@ void testCompatibleRanges() throws ArtifactResolutionException, InvalidVersionSp
ArtifactResolutionResult res = collect(a);
- assertEquals(
- createSet(new Object[] {a.artifact, b.artifact, c.artifact}),
- res.getArtifacts(),
- "Check artifact list");
- assertEquals("2.5", getArtifact("c", res.getArtifacts()).getVersion(), "Check version");
+ assertThat(res.getArtifacts()).as("Check artifact list").isEqualTo(createSet(new Object[]{a.artifact, b.artifact, c.artifact}));
+ assertThat(getArtifact("c", res.getArtifacts()).getVersion()).as("Check version").isEqualTo("2.5");
}
@Test
- void testIncompatibleRanges() throws ArtifactResolutionException, InvalidVersionSpecificationException {
+ void incompatibleRanges() throws ArtifactResolutionException, InvalidVersionSpecificationException {
ArtifactSpec a = createArtifactSpec("a", "1.0");
ArtifactSpec b = a.addDependency("b", "1.0");
a.addDependency("c", "[2.4,3.0]");
@@ -333,11 +301,11 @@ void testIncompatibleRanges() throws ArtifactResolutionException, InvalidVersion
ArtifactResolutionResult res = collect(a);
- assertTrue(res.hasVersionRangeViolations());
+ assertThat(res.hasVersionRangeViolations()).isTrue();
}
@Test
- void testUnboundedRangeWhenVersionUnavailable()
+ void unboundedRangeWhenVersionUnavailable()
throws ArtifactResolutionException, InvalidVersionSpecificationException {
ArtifactSpec a = createArtifactSpec("a", "1.0");
ArtifactSpec b = a.addDependency("b", "1.0");
@@ -346,11 +314,11 @@ void testUnboundedRangeWhenVersionUnavailable()
ArtifactResolutionResult res = collect(a);
- assertTrue(res.hasVersionRangeViolations());
+ assertThat(res.hasVersionRangeViolations()).isTrue();
}
@Test
- void testUnboundedRangeBelowLastRelease() throws ArtifactResolutionException, InvalidVersionSpecificationException {
+ void unboundedRangeBelowLastRelease() throws ArtifactResolutionException, InvalidVersionSpecificationException {
ArtifactSpec a = createArtifactSpec("a", "1.0");
createArtifactSpec("c", "1.5");
ArtifactSpec c = createArtifactSpec("c", "2.0");
@@ -359,23 +327,23 @@ void testUnboundedRangeBelowLastRelease() throws ArtifactResolutionException, In
ArtifactResolutionResult res = collect(a);
- assertEquals(createSet(new Object[] {a.artifact, c.artifact}), res.getArtifacts(), "Check artifact list");
- assertEquals("2.0", getArtifact("c", res.getArtifacts()).getVersion(), "Check version");
+ assertThat(res.getArtifacts()).as("Check artifact list").isEqualTo(createSet(new Object[]{a.artifact, c.artifact}));
+ assertThat(getArtifact("c", res.getArtifacts()).getVersion()).as("Check version").isEqualTo("2.0");
}
@Test
- void testUnboundedRangeAboveLastRelease() throws ArtifactResolutionException, InvalidVersionSpecificationException {
+ void unboundedRangeAboveLastRelease() throws ArtifactResolutionException, InvalidVersionSpecificationException {
ArtifactSpec a = createArtifactSpec("a", "1.0");
createArtifactSpec("c", "2.0");
a.addDependency("c", "[10.0,)");
ArtifactResolutionResult res = collect(a);
- assertTrue(res.hasVersionRangeViolations());
+ assertThat(res.hasVersionRangeViolations()).isTrue();
}
@Test
- void testResolveManagedVersion() throws ArtifactResolutionException, InvalidVersionSpecificationException {
+ void resolveManagedVersion() throws ArtifactResolutionException, InvalidVersionSpecificationException {
ArtifactSpec a = createArtifactSpec("a", "1.0");
a.addDependency("b", "3.0", Artifact.SCOPE_RUNTIME);
@@ -383,11 +351,11 @@ void testResolveManagedVersion() throws ArtifactResolutionException, InvalidVers
Artifact modifiedB = createArtifactSpec("b", "5.0", Artifact.SCOPE_RUNTIME).artifact;
ArtifactResolutionResult res = collect(a, managedVersion);
- assertEquals(createSet(new Object[] {a.artifact, modifiedB}), res.getArtifacts(), "Check artifact list");
+ assertThat(res.getArtifacts()).as("Check artifact list").isEqualTo(createSet(new Object[]{a.artifact, modifiedB}));
}
@Test
- void testCollectChangesVersionOfOriginatingArtifactIfInDependencyManagementHasDifferentVersion()
+ void collectChangesVersionOfOriginatingArtifactIfInDependencyManagementHasDifferentVersion()
throws ArtifactResolutionException, InvalidVersionSpecificationException {
ArtifactSpec a = createArtifactSpec("a", "1.0");
@@ -396,15 +364,15 @@ void testCollectChangesVersionOfOriginatingArtifactIfInDependencyManagementHasDi
ArtifactResolutionResult result = collect(a, managedVersion);
- assertEquals("1.0", artifact.getVersion(), "collect has modified version in originating artifact");
+ assertThat(artifact.getVersion()).as("collect has modified version in originating artifact").isEqualTo("1.0");
Artifact resolvedArtifact = result.getArtifacts().iterator().next();
- assertEquals("1.0", resolvedArtifact.getVersion(), "Resolved version don't match original artifact version");
+ assertThat(resolvedArtifact.getVersion()).as("Resolved version don't match original artifact version").isEqualTo("1.0");
}
@Test
- void testResolveCompileScopeOverTestScope()
+ void resolveCompileScopeOverTestScope()
throws ArtifactResolutionException, InvalidVersionSpecificationException {
ArtifactSpec a = createArtifactSpec("a", "1.0");
ArtifactSpec c = createArtifactSpec("c", "3.0", Artifact.SCOPE_TEST);
@@ -414,15 +382,15 @@ void testResolveCompileScopeOverTestScope()
Artifact modifiedC = createArtifactSpec("c", "3.0", Artifact.SCOPE_COMPILE).artifact;
ArtifactResolutionResult res = collect(createSet(new Object[] {a.artifact, c.artifact}));
- assertEquals(createSet(new Object[] {a.artifact, modifiedC}), res.getArtifacts(), "Check artifact list");
+ assertThat(res.getArtifacts()).as("Check artifact list").isEqualTo(createSet(new Object[]{a.artifact, modifiedC}));
Artifact artifact = getArtifact("c", res.getArtifacts());
// local wins now, and irrelevant if not local as test/provided aren't transitive
// assertEquals( Artifact.SCOPE_COMPILE, artifact.getArtifactScope(), "Check artifactScope" );
- assertEquals(Artifact.SCOPE_TEST, artifact.getScope(), "Check artifactScope");
+ assertThat(artifact.getScope()).as("Check artifactScope").isEqualTo(Artifact.SCOPE_TEST);
}
@Test
- void testResolveRuntimeScopeOverTestScope()
+ void resolveRuntimeScopeOverTestScope()
throws ArtifactResolutionException, InvalidVersionSpecificationException {
ArtifactSpec a = createArtifactSpec("a", "1.0");
ArtifactSpec c = createArtifactSpec("c", "3.0", Artifact.SCOPE_TEST);
@@ -432,15 +400,15 @@ void testResolveRuntimeScopeOverTestScope()
Artifact modifiedC = createArtifactSpec("c", "3.0", Artifact.SCOPE_RUNTIME).artifact;
ArtifactResolutionResult res = collect(createSet(new Object[] {a.artifact, c.artifact}));
- assertEquals(createSet(new Object[] {a.artifact, modifiedC}), res.getArtifacts(), "Check artifact list");
+ assertThat(res.getArtifacts()).as("Check artifact list").isEqualTo(createSet(new Object[]{a.artifact, modifiedC}));
Artifact artifact = getArtifact("c", res.getArtifacts());
// local wins now, and irrelevant if not local as test/provided aren't transitive
// assertEquals( Artifact.SCOPE_RUNTIME, artifact.getArtifactScope(), "Check artifactScope" );
- assertEquals(Artifact.SCOPE_TEST, artifact.getScope(), "Check artifactScope");
+ assertThat(artifact.getScope()).as("Check artifactScope").isEqualTo(Artifact.SCOPE_TEST);
}
@Test
- void testResolveCompileScopeOverRuntimeScope()
+ void resolveCompileScopeOverRuntimeScope()
throws ArtifactResolutionException, InvalidVersionSpecificationException {
ArtifactSpec root = createArtifactSpec("root", "1.0");
ArtifactSpec a = root.addDependency("a", "1.0");
@@ -451,16 +419,13 @@ void testResolveCompileScopeOverRuntimeScope()
Artifact modifiedC = createArtifactSpec("c", "3.0", Artifact.SCOPE_COMPILE).artifact;
ArtifactResolutionResult res = collect(createSet(new Object[] {root.artifact}));
- assertEquals(
- createSet(new Object[] {a.artifact, root.artifact, modifiedC}),
- res.getArtifacts(),
- "Check artifact list");
+ assertThat(res.getArtifacts()).as("Check artifact list").isEqualTo(createSet(new Object[]{a.artifact, root.artifact, modifiedC}));
Artifact artifact = getArtifact("c", res.getArtifacts());
- assertEquals(Artifact.SCOPE_COMPILE, artifact.getScope(), "Check artifactScope");
+ assertThat(artifact.getScope()).as("Check artifactScope").isEqualTo(Artifact.SCOPE_COMPILE);
}
@Test
- void testResolveCompileScopeOverProvidedScope()
+ void resolveCompileScopeOverProvidedScope()
throws ArtifactResolutionException, InvalidVersionSpecificationException {
ArtifactSpec a = createArtifactSpec("a", "1.0");
ArtifactSpec c = createArtifactSpec("c", "3.0", Artifact.SCOPE_PROVIDED);
@@ -470,15 +435,15 @@ void testResolveCompileScopeOverProvidedScope()
Artifact modifiedC = createArtifactSpec("c", "3.0", Artifact.SCOPE_COMPILE).artifact;
ArtifactResolutionResult res = collect(createSet(new Object[] {a.artifact, c.artifact}));
- assertEquals(createSet(new Object[] {a.artifact, modifiedC}), res.getArtifacts(), "Check artifact list");
+ assertThat(res.getArtifacts()).as("Check artifact list").isEqualTo(createSet(new Object[]{a.artifact, modifiedC}));
Artifact artifact = getArtifact("c", res.getArtifacts());
// local wins now, and irrelevant if not local as test/provided aren't transitive
// assertEquals( Artifact.SCOPE_COMPILE, artifact.getArtifactScope(), "Check artifactScope" );
- assertEquals(Artifact.SCOPE_PROVIDED, artifact.getScope(), "Check artifactScope");
+ assertThat(artifact.getScope()).as("Check artifactScope").isEqualTo(Artifact.SCOPE_PROVIDED);
}
@Test
- void testResolveRuntimeScopeOverProvidedScope()
+ void resolveRuntimeScopeOverProvidedScope()
throws ArtifactResolutionException, InvalidVersionSpecificationException {
ArtifactSpec a = createArtifactSpec("a", "1.0");
ArtifactSpec c = createArtifactSpec("c", "3.0", Artifact.SCOPE_PROVIDED);
@@ -488,45 +453,45 @@ void testResolveRuntimeScopeOverProvidedScope()
Artifact modifiedC = createArtifactSpec("c", "3.0", Artifact.SCOPE_RUNTIME).artifact;
ArtifactResolutionResult res = collect(createSet(new Object[] {a.artifact, c.artifact}));
- assertEquals(createSet(new Object[] {a.artifact, modifiedC}), res.getArtifacts(), "Check artifact list");
+ assertThat(res.getArtifacts()).as("Check artifact list").isEqualTo(createSet(new Object[]{a.artifact, modifiedC}));
Artifact artifact = getArtifact("c", res.getArtifacts());
// local wins now, and irrelevant if not local as test/provided aren't transitive
// assertEquals( Artifact.SCOPE_RUNTIME, artifact.getArtifactScope(), "Check artifactScope" );
- assertEquals(Artifact.SCOPE_PROVIDED, artifact.getScope(), "Check artifactScope");
+ assertThat(artifact.getScope()).as("Check artifactScope").isEqualTo(Artifact.SCOPE_PROVIDED);
}
@Test
- void testProvidedScopeNotTransitive() throws ArtifactResolutionException, InvalidVersionSpecificationException {
+ void providedScopeNotTransitive() throws ArtifactResolutionException, InvalidVersionSpecificationException {
ArtifactSpec a = createArtifactSpec("a", "1.0", Artifact.SCOPE_PROVIDED);
ArtifactSpec b = createArtifactSpec("b", "1.0");
b.addDependency("c", "3.0", Artifact.SCOPE_PROVIDED);
ArtifactResolutionResult res = collect(createSet(new Object[] {a.artifact, b.artifact}));
- assertEquals(createSet(new Object[] {a.artifact, b.artifact}), res.getArtifacts(), "Check artifact list");
+ assertThat(res.getArtifacts()).as("Check artifact list").isEqualTo(createSet(new Object[]{a.artifact, b.artifact}));
}
@Test
- void testOptionalNotTransitive() throws ArtifactResolutionException, InvalidVersionSpecificationException {
+ void optionalNotTransitive() throws ArtifactResolutionException, InvalidVersionSpecificationException {
ArtifactSpec a = createArtifactSpec("a", "1.0");
ArtifactSpec b = createArtifactSpec("b", "1.0");
b.addDependency("c", "3.0", true);
ArtifactResolutionResult res = collect(createSet(new Object[] {a.artifact, b.artifact}));
- assertEquals(createSet(new Object[] {a.artifact, b.artifact}), res.getArtifacts(), "Check artifact list");
+ assertThat(res.getArtifacts()).as("Check artifact list").isEqualTo(createSet(new Object[]{a.artifact, b.artifact}));
}
@Test
- void testOptionalIncludedAtRoot() throws ArtifactResolutionException, InvalidVersionSpecificationException {
+ void optionalIncludedAtRoot() throws ArtifactResolutionException, InvalidVersionSpecificationException {
ArtifactSpec a = createArtifactSpec("a", "1.0");
ArtifactSpec b = createArtifactSpec("b", "1.0", true);
ArtifactResolutionResult res = collect(createSet(new Object[] {a.artifact, b.artifact}));
- assertEquals(createSet(new Object[] {a.artifact, b.artifact}), res.getArtifacts(), "Check artifact list");
+ assertThat(res.getArtifacts()).as("Check artifact list").isEqualTo(createSet(new Object[]{a.artifact, b.artifact}));
}
@Test
- void testScopeUpdate() throws InvalidVersionSpecificationException, ArtifactResolutionException {
+ void scopeUpdate() throws InvalidVersionSpecificationException, ArtifactResolutionException {
/* farthest = compile */
checkScopeUpdate(Artifact.SCOPE_COMPILE, Artifact.SCOPE_COMPILE, Artifact.SCOPE_COMPILE);
checkScopeUpdate(Artifact.SCOPE_COMPILE, Artifact.SCOPE_PROVIDED, Artifact.SCOPE_COMPILE);
@@ -613,21 +578,21 @@ private void checkScopeUpdate(ArtifactSpec a, ArtifactSpec b, String expectedSco
ArtifactResolutionResult res = collect(createSet(new Object[] {a.artifact, b.artifact}), filter);
Artifact artifact = getArtifact("d", res.getArtifacts());
- assertNotNull(artifact, "MNG-1895 Dependency was not added to resolution");
- assertEquals(expectedScope, artifact.getScope(), "Check artifactScope");
- assertEquals(expectedVersion, artifact.getVersion(), "Check version");
+ assertThat(artifact).as("MNG-1895 Dependency was not added to resolution").isNotNull();
+ assertThat(artifact.getScope()).as("Check artifactScope").isEqualTo(expectedScope);
+ assertThat(artifact.getVersion()).as("Check version").isEqualTo(expectedVersion);
ArtifactSpec d = createArtifactSpec("d", "1.0");
res = collect(createSet(new Object[] {a.artifact, b.artifact, d.artifact}), filter);
artifact = getArtifact("d", res.getArtifacts());
- assertNotNull(artifact, "MNG-1895 Dependency was not added to resolution");
- assertEquals(d.artifact.getScope(), artifact.getScope(), "Check artifactScope");
- assertEquals("1.0", artifact.getVersion(), "Check version");
+ assertThat(artifact).as("MNG-1895 Dependency was not added to resolution").isNotNull();
+ assertThat(artifact.getScope()).as("Check artifactScope").isEqualTo(d.artifact.getScope());
+ assertThat(artifact.getVersion()).as("Check version").isEqualTo("1.0");
}
@Test
@Disabled
- void testOptionalNotTransitiveButVersionIsInfluential()
+ void optionalNotTransitiveButVersionIsInfluential()
throws ArtifactResolutionException, InvalidVersionSpecificationException {
ArtifactSpec a = createArtifactSpec("a", "1.0");
ArtifactSpec b = createArtifactSpec("b", "1.0");
@@ -639,33 +604,30 @@ void testOptionalNotTransitiveButVersionIsInfluential()
ArtifactSpec c = createArtifactSpec("c", "3.0");
ArtifactResolutionResult res = collect(createSet(new Object[] {a.artifact, b.artifact}));
- assertEquals(
- createSet(new Object[] {a.artifact, b.artifact, c.artifact, d.artifact, e.artifact}),
- res.getArtifacts(),
- "Check artifact list");
+ assertThat(res.getArtifacts()).as("Check artifact list").isEqualTo(createSet(new Object[]{a.artifact, b.artifact, c.artifact, d.artifact, e.artifact}));
Artifact artifact = getArtifact("c", res.getArtifacts());
- assertEquals("3.0", artifact.getVersion(), "Check version");
+ assertThat(artifact.getVersion()).as("Check version").isEqualTo("3.0");
}
@Test
- void testTestScopeNotTransitive() throws ArtifactResolutionException, InvalidVersionSpecificationException {
+ void testScopeNotTransitive() throws ArtifactResolutionException, InvalidVersionSpecificationException {
ArtifactSpec a = createArtifactSpec("a", "1.0", Artifact.SCOPE_TEST);
ArtifactSpec b = createArtifactSpec("b", "1.0");
b.addDependency("c", "3.0", Artifact.SCOPE_TEST);
ArtifactResolutionResult res = collect(createSet(new Object[] {a.artifact, b.artifact}));
- assertEquals(createSet(new Object[] {a.artifact, b.artifact}), res.getArtifacts(), "Check artifact list");
+ assertThat(res.getArtifacts()).as("Check artifact list").isEqualTo(createSet(new Object[]{a.artifact, b.artifact}));
}
@Test
- void testSnapshotNotIncluded() throws ArtifactResolutionException, InvalidVersionSpecificationException {
+ void snapshotNotIncluded() throws ArtifactResolutionException, InvalidVersionSpecificationException {
ArtifactSpec a = createArtifactSpec("a", "1.0");
a.addDependency("b", "[1.0,)");
createArtifactSpec("b", "1.0-SNAPSHOT");
ArtifactResolutionResult res = collect(a);
- assertTrue(res.hasVersionRangeViolations());
+ assertThat(res.hasVersionRangeViolations()).isTrue();
/*
* try { ArtifactResolutionResult res = collect( a ); fail( "Expected b not to resolve: " + res ); } catch (
@@ -677,7 +639,7 @@ void testSnapshotNotIncluded() throws ArtifactResolutionException, InvalidVersio
@Test
@Disabled("that one does not work")
@SuppressWarnings("checkstyle:UnusedLocalVariable")
- void testOverConstrainedVersionException()
+ void overConstrainedVersionException()
throws ArtifactResolutionException, InvalidVersionSpecificationException {
ArtifactSpec a = createArtifactSpec("a", "1.0");
a.addDependency("b", "[1.0, 2.0)");
@@ -688,10 +650,9 @@ void testOverConstrainedVersionException()
ArtifactSpec c = createArtifactSpec("c", "3.2.1-v3235e");
- OverConstrainedVersionException e = assertThrows(
- OverConstrainedVersionException.class, () -> collect(createSet(new Object[] {a.artifact})));
- assertTrue(e.getMessage().contains("[3.2.1-v3235e, 3.3.0-v3346]"), "Versions unordered");
- assertTrue(e.getMessage().contains("Path to dependency:"), "DependencyTrail unresolved");
+ OverConstrainedVersionException e = assertThatExceptionOfType(OverConstrainedVersionException.class).isThrownBy(() -> collect(createSet(new Object[]{a.artifact}))).actual();
+ assertThat(e.getMessage().contains("[3.2.1-v3235e, 3.3.0-v3346]")).as("Versions unordered").isTrue();
+ assertThat(e.getMessage().contains("Path to dependency:")).as("DependencyTrail unresolved").isTrue();
}
private Artifact getArtifact(String id, Set artifacts) {
diff --git a/compat/maven-compat/src/test/java/org/apache/maven/repository/legacy/resolver/conflict/AbstractConflictResolverTest.java b/compat/maven-compat/src/test/java/org/apache/maven/repository/legacy/resolver/conflict/AbstractConflictResolverTest.java
index 2bbfc00915fd..55a83ce28c86 100644
--- a/compat/maven-compat/src/test/java/org/apache/maven/repository/legacy/resolver/conflict/AbstractConflictResolverTest.java
+++ b/compat/maven-compat/src/test/java/org/apache/maven/repository/legacy/resolver/conflict/AbstractConflictResolverTest.java
@@ -31,8 +31,7 @@
import org.codehaus.plexus.testing.PlexusTest;
import org.junit.jupiter.api.BeforeEach;
-import static org.junit.jupiter.api.Assertions.assertEquals;
-import static org.junit.jupiter.api.Assertions.assertNotNull;
+import static org.assertj.core.api.Assertions.assertThat;
/**
* Provides a basis for testing conflict resolvers.
@@ -93,8 +92,8 @@ protected void assertResolveConflict(
ResolutionNode expectedNode, ResolutionNode actualNode1, ResolutionNode actualNode2) {
ResolutionNode resolvedNode = getConflictResolver().resolveConflict(actualNode1, actualNode2);
- assertNotNull(resolvedNode, "Expected resolvable");
- assertEquals(expectedNode, resolvedNode, "Resolution node");
+ assertThat(resolvedNode).as("Expected resolvable").isNotNull();
+ assertThat(resolvedNode).as("Resolution node").isEqualTo(expectedNode);
}
protected Artifact createArtifact(String id, String version) throws InvalidVersionSpecificationException {
diff --git a/compat/maven-compat/src/test/java/org/apache/maven/repository/legacy/resolver/conflict/FarthestConflictResolverTest.java b/compat/maven-compat/src/test/java/org/apache/maven/repository/legacy/resolver/conflict/FarthestConflictResolverTest.java
index 25aa5124f9da..ff8c62f0921a 100644
--- a/compat/maven-compat/src/test/java/org/apache/maven/repository/legacy/resolver/conflict/FarthestConflictResolverTest.java
+++ b/compat/maven-compat/src/test/java/org/apache/maven/repository/legacy/resolver/conflict/FarthestConflictResolverTest.java
@@ -44,7 +44,7 @@ class FarthestConflictResolverTest extends AbstractConflictResolverTest {
*
*/
@Test
- void testDepth() {
+ void depth() {
ResolutionNode a1n = createResolutionNode(a1);
ResolutionNode b1n = createResolutionNode(b1);
ResolutionNode a2n = createResolutionNode(a2, b1n);
@@ -60,7 +60,7 @@ void testDepth() {
*
*/
@Test
- void testDepthReversed() {
+ void depthReversed() {
ResolutionNode b1n = createResolutionNode(b1);
ResolutionNode a2n = createResolutionNode(a2, b1n);
ResolutionNode a1n = createResolutionNode(a1);
@@ -76,7 +76,7 @@ void testDepthReversed() {
*
*/
@Test
- void testEqual() {
+ void equal() {
ResolutionNode a1n = createResolutionNode(a1);
ResolutionNode a2n = createResolutionNode(a2);
@@ -91,7 +91,7 @@ void testEqual() {
*
*/
@Test
- void testEqualReversed() {
+ void equalReversed() {
ResolutionNode a2n = createResolutionNode(a2);
ResolutionNode a1n = createResolutionNode(a1);
diff --git a/compat/maven-compat/src/test/java/org/apache/maven/repository/legacy/resolver/conflict/NearestConflictResolverTest.java b/compat/maven-compat/src/test/java/org/apache/maven/repository/legacy/resolver/conflict/NearestConflictResolverTest.java
index 605d2aca0858..a25f51b7838b 100644
--- a/compat/maven-compat/src/test/java/org/apache/maven/repository/legacy/resolver/conflict/NearestConflictResolverTest.java
+++ b/compat/maven-compat/src/test/java/org/apache/maven/repository/legacy/resolver/conflict/NearestConflictResolverTest.java
@@ -44,7 +44,7 @@ class NearestConflictResolverTest extends AbstractConflictResolverTest {
*
*/
@Test
- void testDepth() {
+ void depth() {
ResolutionNode a1n = createResolutionNode(a1);
ResolutionNode b1n = createResolutionNode(b1);
ResolutionNode a2n = createResolutionNode(a2, b1n);
@@ -60,7 +60,7 @@ void testDepth() {
*
*/
@Test
- void testDepthReversed() {
+ void depthReversed() {
ResolutionNode b1n = createResolutionNode(b1);
ResolutionNode a2n = createResolutionNode(a2, b1n);
ResolutionNode a1n = createResolutionNode(a1);
@@ -76,7 +76,7 @@ void testDepthReversed() {
*
*/
@Test
- void testEqual() {
+ void equal() {
ResolutionNode a1n = createResolutionNode(a1);
ResolutionNode a2n = createResolutionNode(a2);
@@ -91,7 +91,7 @@ void testEqual() {
*
*/
@Test
- void testEqualReversed() {
+ void equalReversed() {
ResolutionNode a2n = createResolutionNode(a2);
ResolutionNode a1n = createResolutionNode(a1);
diff --git a/compat/maven-compat/src/test/java/org/apache/maven/repository/legacy/resolver/conflict/NewestConflictResolverTest.java b/compat/maven-compat/src/test/java/org/apache/maven/repository/legacy/resolver/conflict/NewestConflictResolverTest.java
index c8b46637f7ac..10dcf530bbe0 100644
--- a/compat/maven-compat/src/test/java/org/apache/maven/repository/legacy/resolver/conflict/NewestConflictResolverTest.java
+++ b/compat/maven-compat/src/test/java/org/apache/maven/repository/legacy/resolver/conflict/NewestConflictResolverTest.java
@@ -44,7 +44,7 @@ class NewestConflictResolverTest extends AbstractConflictResolverTest {
*
*/
@Test
- void testDepth() {
+ void depth() {
ResolutionNode a1n = createResolutionNode(a1);
ResolutionNode b1n = createResolutionNode(b1);
ResolutionNode a2n = createResolutionNode(a2, b1n);
@@ -60,7 +60,7 @@ void testDepth() {
*
*/
@Test
- void testDepthReversed() {
+ void depthReversed() {
ResolutionNode b1n = createResolutionNode(b1);
ResolutionNode a2n = createResolutionNode(a2, b1n);
ResolutionNode a1n = createResolutionNode(a1);
@@ -76,7 +76,7 @@ void testDepthReversed() {
*
*/
@Test
- void testEqual() {
+ void equal() {
ResolutionNode a1n = createResolutionNode(a1);
ResolutionNode a2n = createResolutionNode(a2);
@@ -91,7 +91,7 @@ void testEqual() {
*
*/
@Test
- void testEqualReversed() {
+ void equalReversed() {
ResolutionNode a2n = createResolutionNode(a2);
ResolutionNode a1n = createResolutionNode(a1);
diff --git a/compat/maven-compat/src/test/java/org/apache/maven/repository/legacy/resolver/conflict/OldestConflictResolverTest.java b/compat/maven-compat/src/test/java/org/apache/maven/repository/legacy/resolver/conflict/OldestConflictResolverTest.java
index 153f00c8ceed..a6b47e738d81 100644
--- a/compat/maven-compat/src/test/java/org/apache/maven/repository/legacy/resolver/conflict/OldestConflictResolverTest.java
+++ b/compat/maven-compat/src/test/java/org/apache/maven/repository/legacy/resolver/conflict/OldestConflictResolverTest.java
@@ -44,7 +44,7 @@ class OldestConflictResolverTest extends AbstractConflictResolverTest {
*
*/
@Test
- void testDepth() {
+ void depth() {
ResolutionNode a1n = createResolutionNode(a1);
ResolutionNode b1n = createResolutionNode(b1);
ResolutionNode a2n = createResolutionNode(a2, b1n);
@@ -60,7 +60,7 @@ void testDepth() {
*
*/
@Test
- void testDepthReversed() {
+ void depthReversed() {
ResolutionNode b1n = createResolutionNode(b1);
ResolutionNode a2n = createResolutionNode(a2, b1n);
ResolutionNode a1n = createResolutionNode(a1);
@@ -76,7 +76,7 @@ void testDepthReversed() {
*
*/
@Test
- void testEqual() {
+ void equal() {
ResolutionNode a1n = createResolutionNode(a1);
ResolutionNode a2n = createResolutionNode(a2);
@@ -91,7 +91,7 @@ void testEqual() {
*
*/
@Test
- void testEqualReversed() {
+ void equalReversed() {
ResolutionNode a2n = createResolutionNode(a2);
ResolutionNode a1n = createResolutionNode(a1);
diff --git a/compat/maven-compat/src/test/java/org/apache/maven/repository/metadata/DefaultClasspathTransformationTestType.java b/compat/maven-compat/src/test/java/org/apache/maven/repository/metadata/DefaultClasspathTransformationTestType.java
index 495db2d21528..b2aa870b22a5 100644
--- a/compat/maven-compat/src/test/java/org/apache/maven/repository/metadata/DefaultClasspathTransformationTestType.java
+++ b/compat/maven-compat/src/test/java/org/apache/maven/repository/metadata/DefaultClasspathTransformationTestType.java
@@ -25,8 +25,7 @@
import org.junit.jupiter.api.BeforeEach;
import org.junit.jupiter.api.Test;
-import static org.junit.jupiter.api.Assertions.assertEquals;
-import static org.junit.jupiter.api.Assertions.assertNotNull;
+import static org.assertj.core.api.Assertions.assertThat;
/**
*
@@ -76,44 +75,44 @@ void setUp() throws Exception {
// ------------------------------------------------------------------------------------------
@Test
- void testCompileClasspathTransform() throws Exception {
+ void compileClasspathTransform() throws Exception {
ClasspathContainer res;
res = transform.transform(graph, ArtifactScopeEnum.compile, false);
- assertNotNull(res, "null classpath container after compile transform");
- assertNotNull(res.getClasspath(), "null classpath after compile transform");
- assertEquals(3, res.getClasspath().size(), "compile classpath should have 3 entries");
+ assertThat(res).as("null classpath container after compile transform").isNotNull();
+ assertThat(res.getClasspath()).as("null classpath after compile transform").isNotNull();
+ assertThat(res.getClasspath().size()).as("compile classpath should have 3 entries").isEqualTo(3);
}
// ------------------------------------------------------------------------------------------
@Test
- void testRuntimeClasspathTransform() throws Exception {
+ void runtimeClasspathTransform() throws Exception {
ClasspathContainer res;
res = transform.transform(graph, ArtifactScopeEnum.runtime, false);
- assertNotNull(res, "null classpath container after runtime transform");
- assertNotNull(res.getClasspath(), "null classpath after runtime transform");
- assertEquals(4, res.getClasspath().size(), "runtime classpath should have 4 entries");
+ assertThat(res).as("null classpath container after runtime transform").isNotNull();
+ assertThat(res.getClasspath()).as("null classpath after runtime transform").isNotNull();
+ assertThat(res.getClasspath().size()).as("runtime classpath should have 4 entries").isEqualTo(4);
ArtifactMetadata md = res.getClasspath().get(3);
- assertEquals("1.1", md.getVersion(), "runtime artifact version should be 1.1");
+ assertThat(md.getVersion()).as("runtime artifact version should be 1.1").isEqualTo("1.1");
}
// ------------------------------------------------------------------------------------------
@Test
- void testTestClasspathTransform() throws Exception {
+ void testClasspathTransform() throws Exception {
ClasspathContainer res;
res = transform.transform(graph, ArtifactScopeEnum.test, false);
- assertNotNull(res, "null classpath container after test transform");
- assertNotNull(res.getClasspath(), "null classpath after test transform");
- assertEquals(4, res.getClasspath().size(), "test classpath should have 4 entries");
+ assertThat(res).as("null classpath container after test transform").isNotNull();
+ assertThat(res.getClasspath()).as("null classpath after test transform").isNotNull();
+ assertThat(res.getClasspath().size()).as("test classpath should have 4 entries").isEqualTo(4);
ArtifactMetadata md = res.getClasspath().get(3);
- assertEquals("1.2", md.getVersion(), "test artifact version should be 1.2");
+ assertThat(md.getVersion()).as("test artifact version should be 1.2").isEqualTo("1.2");
}
// ------------------------------------------------------------------------------------------
// ------------------------------------------------------------------------------------------
diff --git a/compat/maven-compat/src/test/java/org/apache/maven/repository/metadata/DefaultGraphConflictResolutionPolicyTest.java b/compat/maven-compat/src/test/java/org/apache/maven/repository/metadata/DefaultGraphConflictResolutionPolicyTest.java
index 15da1b3315ab..5de728f6c09d 100644
--- a/compat/maven-compat/src/test/java/org/apache/maven/repository/metadata/DefaultGraphConflictResolutionPolicyTest.java
+++ b/compat/maven-compat/src/test/java/org/apache/maven/repository/metadata/DefaultGraphConflictResolutionPolicyTest.java
@@ -21,7 +21,7 @@
import org.junit.jupiter.api.BeforeEach;
import org.junit.jupiter.api.Test;
-import static org.junit.jupiter.api.Assertions.assertEquals;
+import static org.assertj.core.api.Assertions.assertThat;
/**
*
@@ -45,14 +45,14 @@ void setUp() throws Exception {
// ------------------------------------------------------------------------------------------
@Test
- void testDefaultPolicy() throws Exception {
+ void defaultPolicy() throws Exception {
MetadataGraphEdge res;
res = policy.apply(e1, e2);
- assertEquals("1.1", res.getVersion(), "Wrong depth edge selected");
+ assertThat(res.getVersion()).as("Wrong depth edge selected").isEqualTo("1.1");
res = policy.apply(e1, e3);
- assertEquals("1.2", res.getVersion(), "Wrong version edge selected");
+ assertThat(res.getVersion()).as("Wrong version edge selected").isEqualTo("1.2");
}
// ------------------------------------------------------------------------------------------
// ------------------------------------------------------------------------------------------
diff --git a/compat/maven-compat/src/test/java/org/apache/maven/repository/metadata/DefaultGraphConflictResolverTest.java b/compat/maven-compat/src/test/java/org/apache/maven/repository/metadata/DefaultGraphConflictResolverTest.java
index 94625d1fc0e9..9d27fb096989 100644
--- a/compat/maven-compat/src/test/java/org/apache/maven/repository/metadata/DefaultGraphConflictResolverTest.java
+++ b/compat/maven-compat/src/test/java/org/apache/maven/repository/metadata/DefaultGraphConflictResolverTest.java
@@ -25,8 +25,7 @@
import org.junit.jupiter.api.BeforeEach;
import org.junit.jupiter.api.Test;
-import static org.junit.jupiter.api.Assertions.assertEquals;
-import static org.junit.jupiter.api.Assertions.assertNotNull;
+import static org.assertj.core.api.Assertions.assertThat;
/**
*
@@ -76,126 +75,75 @@ void setUp() throws Exception {
// ------------------------------------------------------------------------------------------
@Test
- void testCompileResolution() throws Exception {
+ void compileResolution() throws Exception {
MetadataGraph res;
res = resolver.resolveConflicts(graph, ArtifactScopeEnum.compile);
- assertNotNull(res, "null graph after resolver");
- assertNotNull(res.getVertices(), "no vertices in the resulting graph after resolver");
-
- assertNotNull(res.getExcidentEdges(v1), "no edges in the resulting graph after resolver");
-
- assertEquals(4, res.getVertices().size(), "wrong # of vertices in the resulting graph after resolver");
- assertEquals(
- 2,
- res.getExcidentEdges(v1).size(),
- "wrong # of excident edges in the resulting graph entry after resolver");
-
- assertEquals(
- 1,
- res.getIncidentEdges(v2).size(),
- "wrong # of v2 incident edges in the resulting graph after resolver");
- assertEquals(
- "1.2",
- res.getIncidentEdges(v2).get(0).getVersion(),
- "wrong edge v1-v2 in the resulting graph after resolver");
-
- assertEquals(
- 1, res.getIncidentEdges(v3).size(), "wrong # of edges v1-v3 in the resulting graph after resolver");
- assertEquals(
- "1.1",
- res.getIncidentEdges(v3).get(0).getVersion(),
- "wrong edge v1-v3 in the resulting graph after resolver");
-
- assertEquals(
- 1, res.getIncidentEdges(v4).size(), "wrong # of edges v3-v4 in the resulting graph after resolver");
- assertEquals(
- "1.2",
- res.getIncidentEdges(v4).get(0).getVersion(),
- "wrong edge v3-v4 in the resulting graph after resolver");
+ assertThat(res).as("null graph after resolver").isNotNull();
+ assertThat(res.getVertices()).as("no vertices in the resulting graph after resolver").isNotNull();
+
+ assertThat(res.getExcidentEdges(v1)).as("no edges in the resulting graph after resolver").isNotNull();
+
+ assertThat(res.getVertices().size()).as("wrong # of vertices in the resulting graph after resolver").isEqualTo(4);
+ assertThat(res.getExcidentEdges(v1).size()).as("wrong # of excident edges in the resulting graph entry after resolver").isEqualTo(2);
+
+ assertThat(res.getIncidentEdges(v2).size()).as("wrong # of v2 incident edges in the resulting graph after resolver").isEqualTo(1);
+ assertThat(res.getIncidentEdges(v2).get(0).getVersion()).as("wrong edge v1-v2 in the resulting graph after resolver").isEqualTo("1.2");
+
+ assertThat(res.getIncidentEdges(v3).size()).as("wrong # of edges v1-v3 in the resulting graph after resolver").isEqualTo(1);
+ assertThat(res.getIncidentEdges(v3).get(0).getVersion()).as("wrong edge v1-v3 in the resulting graph after resolver").isEqualTo("1.1");
+
+ assertThat(res.getIncidentEdges(v4).size()).as("wrong # of edges v3-v4 in the resulting graph after resolver").isEqualTo(1);
+ assertThat(res.getIncidentEdges(v4).get(0).getVersion()).as("wrong edge v3-v4 in the resulting graph after resolver").isEqualTo("1.2");
}
// ------------------------------------------------------------------------------------------
@Test
- void testRuntimeResolution() throws Exception {
+ void runtimeResolution() throws Exception {
MetadataGraph res;
res = resolver.resolveConflicts(graph, ArtifactScopeEnum.runtime);
- assertNotNull(res, "null graph after resolver");
- assertNotNull(res.getVertices(), "no vertices in the resulting graph after resolver");
- assertNotNull(res.getExcidentEdges(v1), "no edges in the resulting graph after resolver");
-
- assertEquals(4, res.getVertices().size(), "wrong # of vertices in the resulting graph after resolver");
- assertEquals(
- 2,
- res.getExcidentEdges(v1).size(),
- "wrong # of excident edges in the resulting graph entry after resolver");
-
- assertEquals(
- 1,
- res.getIncidentEdges(v2).size(),
- "wrong # of v2 incident edges in the resulting graph after resolver");
- assertEquals(
- "1.2",
- res.getIncidentEdges(v2).get(0).getVersion(),
- "wrong edge v1-v2 in the resulting graph after resolver");
-
- assertEquals(
- 1, res.getIncidentEdges(v3).size(), "wrong # of edges v1-v3 in the resulting graph after resolver");
- assertEquals(
- "1.1",
- res.getIncidentEdges(v3).get(0).getVersion(),
- "wrong edge v1-v3 in the resulting graph after resolver");
-
- assertEquals(
- 1, res.getIncidentEdges(v4).size(), "wrong # of edges v3-v4 in the resulting graph after resolver");
- assertEquals(
- "1.1",
- res.getIncidentEdges(v4).get(0).getVersion(),
- "wrong edge v3-v4 in the resulting graph after resolver");
+ assertThat(res).as("null graph after resolver").isNotNull();
+ assertThat(res.getVertices()).as("no vertices in the resulting graph after resolver").isNotNull();
+ assertThat(res.getExcidentEdges(v1)).as("no edges in the resulting graph after resolver").isNotNull();
+
+ assertThat(res.getVertices().size()).as("wrong # of vertices in the resulting graph after resolver").isEqualTo(4);
+ assertThat(res.getExcidentEdges(v1).size()).as("wrong # of excident edges in the resulting graph entry after resolver").isEqualTo(2);
+
+ assertThat(res.getIncidentEdges(v2).size()).as("wrong # of v2 incident edges in the resulting graph after resolver").isEqualTo(1);
+ assertThat(res.getIncidentEdges(v2).get(0).getVersion()).as("wrong edge v1-v2 in the resulting graph after resolver").isEqualTo("1.2");
+
+ assertThat(res.getIncidentEdges(v3).size()).as("wrong # of edges v1-v3 in the resulting graph after resolver").isEqualTo(1);
+ assertThat(res.getIncidentEdges(v3).get(0).getVersion()).as("wrong edge v1-v3 in the resulting graph after resolver").isEqualTo("1.1");
+
+ assertThat(res.getIncidentEdges(v4).size()).as("wrong # of edges v3-v4 in the resulting graph after resolver").isEqualTo(1);
+ assertThat(res.getIncidentEdges(v4).get(0).getVersion()).as("wrong edge v3-v4 in the resulting graph after resolver").isEqualTo("1.1");
}
// ------------------------------------------------------------------------------------------
@Test
- void testTestResolution() throws Exception {
+ void testResolution() throws Exception {
MetadataGraph res;
res = resolver.resolveConflicts(graph, ArtifactScopeEnum.test);
- assertNotNull(res, "null graph after resolver");
- assertNotNull(res.getVertices(), "no vertices in the resulting graph after resolver");
- assertNotNull(res.getExcidentEdges(v1), "no edges in the resulting graph after resolver");
-
- assertEquals(4, res.getVertices().size(), "wrong # of vertices in the resulting graph after resolver");
- assertEquals(
- 2,
- res.getExcidentEdges(v1).size(),
- "wrong # of excident edges in the resulting graph entry after resolver");
-
- assertEquals(
- 1,
- res.getIncidentEdges(v2).size(),
- "wrong # of v2 incident edges in the resulting graph after resolver");
- assertEquals(
- "1.2",
- res.getIncidentEdges(v2).get(0).getVersion(),
- "wrong edge v1-v2 in the resulting graph after resolver");
-
- assertEquals(
- 1, res.getIncidentEdges(v3).size(), "wrong # of edges v1-v3 in the resulting graph after resolver");
- assertEquals(
- "1.1",
- res.getIncidentEdges(v3).get(0).getVersion(),
- "wrong edge v1-v3 in the resulting graph after resolver");
-
- assertEquals(
- 1, res.getIncidentEdges(v4).size(), "wrong # of edges v3-v4 in the resulting graph after resolver");
- assertEquals(
- "1.2",
- res.getIncidentEdges(v4).get(0).getVersion(),
- "wrong edge v3-v4 in the resulting graph after resolver");
+ assertThat(res).as("null graph after resolver").isNotNull();
+ assertThat(res.getVertices()).as("no vertices in the resulting graph after resolver").isNotNull();
+ assertThat(res.getExcidentEdges(v1)).as("no edges in the resulting graph after resolver").isNotNull();
+
+ assertThat(res.getVertices().size()).as("wrong # of vertices in the resulting graph after resolver").isEqualTo(4);
+ assertThat(res.getExcidentEdges(v1).size()).as("wrong # of excident edges in the resulting graph entry after resolver").isEqualTo(2);
+
+ assertThat(res.getIncidentEdges(v2).size()).as("wrong # of v2 incident edges in the resulting graph after resolver").isEqualTo(1);
+ assertThat(res.getIncidentEdges(v2).get(0).getVersion()).as("wrong edge v1-v2 in the resulting graph after resolver").isEqualTo("1.2");
+
+ assertThat(res.getIncidentEdges(v3).size()).as("wrong # of edges v1-v3 in the resulting graph after resolver").isEqualTo(1);
+ assertThat(res.getIncidentEdges(v3).get(0).getVersion()).as("wrong edge v1-v3 in the resulting graph after resolver").isEqualTo("1.1");
+
+ assertThat(res.getIncidentEdges(v4).size()).as("wrong # of edges v3-v4 in the resulting graph after resolver").isEqualTo(1);
+ assertThat(res.getIncidentEdges(v4).get(0).getVersion()).as("wrong edge v3-v4 in the resulting graph after resolver").isEqualTo("1.2");
}
// ------------------------------------------------------------------------------------------
// ------------------------------------------------------------------------------------------
diff --git a/compat/maven-compat/src/test/java/org/apache/maven/toolchain/DefaultToolchainManagerTest.java b/compat/maven-compat/src/test/java/org/apache/maven/toolchain/DefaultToolchainManagerTest.java
index 18de14738221..0ab4d2193f69 100644
--- a/compat/maven-compat/src/test/java/org/apache/maven/toolchain/DefaultToolchainManagerTest.java
+++ b/compat/maven-compat/src/test/java/org/apache/maven/toolchain/DefaultToolchainManagerTest.java
@@ -32,6 +32,7 @@
import org.apache.maven.execution.DefaultMavenExecutionRequest;
import org.apache.maven.execution.MavenExecutionRequest;
import org.apache.maven.execution.MavenSession;
+import org.junit.jupiter.api.AfterEach;
import org.junit.jupiter.api.BeforeEach;
import org.junit.jupiter.api.Test;
import org.mockito.ArgumentMatchers;
@@ -39,7 +40,7 @@
import org.mockito.MockitoAnnotations;
import org.slf4j.Logger;
-import static org.junit.jupiter.api.Assertions.assertEquals;
+import static org.assertj.core.api.Assertions.assertThat;
import static org.mockito.ArgumentMatchers.any;
import static org.mockito.ArgumentMatchers.anyMap;
import static org.mockito.ArgumentMatchers.anyString;
@@ -50,6 +51,7 @@
import static org.mockito.Mockito.when;
class DefaultToolchainManagerTest {
+ private AutoCloseable mocks;
// Mocks to inject into toolchainManager
@Mock
private Logger logger;
@@ -67,7 +69,7 @@ class DefaultToolchainManagerTest {
@BeforeEach
void onSetup() throws Exception {
- MockitoAnnotations.initMocks(this);
+ mocks = MockitoAnnotations.openMocks(this);
Map factories = new HashMap<>();
factories.put("basic", toolchainFactoryBasicType);
@@ -81,18 +83,18 @@ void onSetup() throws Exception {
}
@Test
- void testNoModels() {
+ void noModels() {
MavenSession session = mock(MavenSession.class);
MavenExecutionRequest executionRequest = new DefaultMavenExecutionRequest();
when(session.getRequest()).thenReturn(executionRequest);
List toolchains = toolchainManager.getToolchains(session, "unknown", null);
- assertEquals(0, toolchains.size());
+ assertThat(toolchains.size()).isEqualTo(0);
}
@Test
- void testModelNoFactory() {
+ void modelNoFactory() {
MavenSession session = mock(MavenSession.class);
MavenExecutionRequest executionRequest = new DefaultMavenExecutionRequest();
List toolchainModels = new ArrayList<>();
@@ -104,12 +106,12 @@ void testModelNoFactory() {
List toolchains = toolchainManager.getToolchains(session, "unknown", null);
- assertEquals(0, toolchains.size());
+ assertThat(toolchains.size()).isEqualTo(0);
verify(logger).error("Missing toolchain factory for type: unknown. Possibly caused by misconfigured project.");
}
@Test
- void testModelAndFactory() {
+ void modelAndFactory() {
MavenSession session = mock(MavenSession.class);
List toolchainModels = List.of(
ToolchainModel.newBuilder().type("basic").build(),
@@ -124,11 +126,11 @@ void testModelAndFactory() {
List toolchains = toolchainManager.getToolchains(session, "rare", null);
- assertEquals(1, toolchains.size());
+ assertThat(toolchains.size()).isEqualTo(1);
}
@Test
- void testModelsAndFactory() {
+ void modelsAndFactory() {
MavenSession session = mock(MavenSession.class);
Session sessionv4 = mock(Session.class);
when(session.getSession()).thenReturn(sessionv4);
@@ -145,11 +147,11 @@ void testModelsAndFactory() {
List toolchains = toolchainManager.getToolchains(session, "basic", null);
- assertEquals(2, toolchains.size());
+ assertThat(toolchains.size()).isEqualTo(2);
}
@Test
- void testRequirements() throws Exception {
+ void requirements() throws Exception {
MavenSession session = mock(MavenSession.class);
MavenExecutionRequest executionRequest = new DefaultMavenExecutionRequest();
when(session.getRequest()).thenReturn(executionRequest);
@@ -170,11 +172,11 @@ void testRequirements() throws Exception {
List toolchains =
toolchainManager.getToolchains(session, "basic", Collections.singletonMap("key", "value"));
- assertEquals(1, toolchains.size());
+ assertThat(toolchains.size()).isEqualTo(1);
}
@Test
- void testToolchainsForAvailableType() throws Exception {
+ void toolchainsForAvailableType() throws Exception {
// prepare
MavenSession session = mock(MavenSession.class);
MavenExecutionRequest req = new DefaultMavenExecutionRequest();
@@ -192,11 +194,11 @@ void testToolchainsForAvailableType() throws Exception {
// verify
verify(logger, never()).error(anyString());
- assertEquals(1, toolchains.length);
+ assertThat(toolchains.length).isEqualTo(1);
}
@Test
- void testToolchainsForUnknownType() throws Exception {
+ void toolchainsForUnknownType() throws Exception {
// prepare
MavenSession session = mock(MavenSession.class);
MavenExecutionRequest req = new DefaultMavenExecutionRequest();
@@ -212,11 +214,11 @@ void testToolchainsForUnknownType() throws Exception {
// verify
verify(logger).error("Missing toolchain factory for type: unknown. Possibly caused by misconfigured project.");
- assertEquals(0, toolchains.length);
+ assertThat(toolchains.length).isEqualTo(0);
}
@Test
- void testToolchainsForConfiguredType() throws Exception {
+ void toolchainsForConfiguredType() throws Exception {
// prepare
MavenSession session = mock(MavenSession.class);
MavenExecutionRequest req = new DefaultMavenExecutionRequest();
@@ -243,11 +245,11 @@ void testToolchainsForConfiguredType() throws Exception {
// verify
verify(logger, never()).error(anyString());
- assertEquals(2, toolchains.length);
+ assertThat(toolchains.length).isEqualTo(2);
}
@Test
- void testMisconfiguredToolchain() throws Exception {
+ void misconfiguredToolchain() throws Exception {
// prepare
MavenSession session = mock(MavenSession.class);
MavenExecutionRequest req = new DefaultMavenExecutionRequest();
@@ -259,6 +261,11 @@ void testMisconfiguredToolchain() throws Exception {
ToolchainPrivate[] basics = toolchainManager.getToolchainsForType("basic", session);
// verify
- assertEquals(0, basics.length);
+ assertThat(basics.length).isEqualTo(0);
+ }
+
+ @AfterEach
+ void tearDown() throws Exception {
+ mocks.close();
}
}
diff --git a/compat/maven-compat/src/test/java/org/apache/maven/toolchain/DefaultToolchainTest.java b/compat/maven-compat/src/test/java/org/apache/maven/toolchain/DefaultToolchainTest.java
index d6efd846dfac..831111c0b0c3 100644
--- a/compat/maven-compat/src/test/java/org/apache/maven/toolchain/DefaultToolchainTest.java
+++ b/compat/maven-compat/src/test/java/org/apache/maven/toolchain/DefaultToolchainTest.java
@@ -23,23 +23,23 @@
import org.apache.maven.toolchain.java.DefaultJavaToolChain;
import org.apache.maven.toolchain.model.ToolchainModel;
import org.codehaus.plexus.util.xml.Xpp3Dom;
+import org.junit.jupiter.api.AfterEach;
import org.junit.jupiter.api.BeforeEach;
import org.junit.jupiter.api.Test;
import org.mockito.MockitoAnnotations;
import org.slf4j.Logger;
-import static org.junit.jupiter.api.Assertions.assertEquals;
-import static org.junit.jupiter.api.Assertions.assertFalse;
-import static org.junit.jupiter.api.Assertions.assertNotEquals;
+import static org.assertj.core.api.Assertions.assertThat;
import static org.mockito.Mockito.mock;
import static org.mockito.Mockito.verify;
class DefaultToolchainTest {
+ private AutoCloseable mocks;
private final Logger logger = mock(Logger.class);
@BeforeEach
void setUp() throws Exception {
- MockitoAnnotations.initMocks(this);
+ mocks = MockitoAnnotations.openMocks(this);
}
private DefaultToolchain newDefaultToolchain(ToolchainModel model) {
@@ -61,53 +61,53 @@ public String findTool(String toolName) {
}
@Test
- void testGetModel() {
+ void getModel() {
ToolchainModel model = new ToolchainModel();
DefaultToolchain toolchain = newDefaultToolchain(model);
- assertEquals(model, toolchain.getModel());
+ assertThat(toolchain.getModel()).isEqualTo(model);
}
@Test
- void testGetType() {
+ void getType() {
ToolchainModel model = new ToolchainModel();
DefaultToolchain toolchain = newDefaultToolchain(model, "TYPE");
- assertEquals("TYPE", toolchain.getType());
+ assertThat(toolchain.getType()).isEqualTo("TYPE");
model.setType("MODEL_TYPE");
toolchain = newDefaultToolchain(model);
- assertEquals("MODEL_TYPE", toolchain.getType());
+ assertThat(toolchain.getType()).isEqualTo("MODEL_TYPE");
}
@Test
- void testGetLogger() {
+ void getLogger() {
ToolchainModel model = new ToolchainModel();
DefaultToolchain toolchain = newDefaultToolchain(model);
- assertEquals(logger, toolchain.getLog());
+ assertThat(toolchain.getLog()).isEqualTo(logger);
}
@Test
- void testMissingRequirementProperty() {
+ void missingRequirementProperty() {
ToolchainModel model = new ToolchainModel();
model.setType("TYPE");
DefaultToolchain toolchain = newDefaultToolchain(model);
- assertFalse(toolchain.matchesRequirements(Collections.singletonMap("name", "John Doe")));
+ assertThat(toolchain.matchesRequirements(Collections.singletonMap("name", "John Doe"))).isFalse();
verify(logger).debug("Toolchain {} is missing required property: {}", toolchain, "name");
}
@Test
- void testNonMatchingRequirementProperty() {
+ void nonMatchingRequirementProperty() {
ToolchainModel model = new ToolchainModel();
model.setType("TYPE");
DefaultToolchain toolchain = newDefaultToolchain(model);
toolchain.addProvideToken("name", RequirementMatcherFactory.createExactMatcher("Jane Doe"));
- assertFalse(toolchain.matchesRequirements(Collections.singletonMap("name", "John Doe")));
+ assertThat(toolchain.matchesRequirements(Collections.singletonMap("name", "John Doe"))).isFalse();
verify(logger).debug("Toolchain {} doesn't match required property: {}", toolchain, "name");
}
@Test
- void testEquals() {
+ void equals() {
ToolchainModel tm1 = new ToolchainModel();
tm1.setType("jdk");
tm1.addProvide("version", "1.5");
@@ -131,9 +131,14 @@ void testEquals() {
DefaultToolchain tc1 = new DefaultJavaToolChain(tm1, null);
DefaultToolchain tc2 = new DefaultJavaToolChain(tm2, null);
- assertEquals(tc1, tc1);
- assertNotEquals(tc1, tc2);
- assertNotEquals(tc2, tc1);
- assertEquals(tc2, tc2);
+ assertThat(tc1).isEqualTo(tc1);
+ assertThat(tc2).isNotEqualTo(tc1);
+ assertThat(tc1).isNotEqualTo(tc2);
+ assertThat(tc2).isEqualTo(tc2);
+ }
+
+ @AfterEach
+ void tearDown() throws Exception {
+ mocks.close();
}
}
diff --git a/compat/maven-compat/src/test/java/org/apache/maven/toolchain/RequirementMatcherFactoryTest.java b/compat/maven-compat/src/test/java/org/apache/maven/toolchain/RequirementMatcherFactoryTest.java
index 7cb3b23ca0bb..d670e36a1ccf 100644
--- a/compat/maven-compat/src/test/java/org/apache/maven/toolchain/RequirementMatcherFactoryTest.java
+++ b/compat/maven-compat/src/test/java/org/apache/maven/toolchain/RequirementMatcherFactoryTest.java
@@ -20,9 +20,7 @@
import org.junit.jupiter.api.Test;
-import static org.junit.jupiter.api.Assertions.assertEquals;
-import static org.junit.jupiter.api.Assertions.assertFalse;
-import static org.junit.jupiter.api.Assertions.assertTrue;
+import static org.assertj.core.api.Assertions.assertThat;
/**
*
@@ -33,33 +31,33 @@ class RequirementMatcherFactoryTest {
* Test of createExactMatcher method, of class RequirementMatcherFactory.
*/
@Test
- void testCreateExactMatcher() {
+ void createExactMatcher() {
RequirementMatcher matcher;
matcher = RequirementMatcherFactory.createExactMatcher("foo");
- assertFalse(matcher.matches("bar"));
- assertFalse(matcher.matches("foobar"));
- assertFalse(matcher.matches("foob"));
- assertTrue(matcher.matches("foo"));
+ assertThat(matcher.matches("bar")).isFalse();
+ assertThat(matcher.matches("foobar")).isFalse();
+ assertThat(matcher.matches("foob")).isFalse();
+ assertThat(matcher.matches("foo")).isTrue();
}
/**
* Test of createVersionMatcher method, of class RequirementMatcherFactory.
*/
@Test
- void testCreateVersionMatcher() {
+ void createVersionMatcher() {
RequirementMatcher matcher;
matcher = RequirementMatcherFactory.createVersionMatcher("1.5.2");
- assertFalse(matcher.matches("1.5"));
- assertTrue(matcher.matches("1.5.2"));
- assertFalse(matcher.matches("[1.4,1.5)"));
- assertFalse(matcher.matches("[1.5,1.5.2)"));
- assertFalse(matcher.matches("(1.5.2,1.6)"));
- assertTrue(matcher.matches("(1.4,1.5.2]"));
- assertTrue(matcher.matches("(1.5,)"));
- assertEquals("1.5.2", matcher.toString());
+ assertThat(matcher.matches("1.5")).isFalse();
+ assertThat(matcher.matches("1.5.2")).isTrue();
+ assertThat(matcher.matches("[1.4,1.5)")).isFalse();
+ assertThat(matcher.matches("[1.5,1.5.2)")).isFalse();
+ assertThat(matcher.matches("(1.5.2,1.6)")).isFalse();
+ assertThat(matcher.matches("(1.4,1.5.2]")).isTrue();
+ assertThat(matcher.matches("(1.5,)")).isTrue();
+ assertThat(matcher.toString()).isEqualTo("1.5.2");
// Ensure it is not printed as 1.5.0
matcher = RequirementMatcherFactory.createVersionMatcher("1.5");
- assertEquals("1.5", matcher.toString());
+ assertThat(matcher.toString()).isEqualTo("1.5");
}
}
diff --git a/compat/maven-embedder/src/test/java/org/apache/maven/cli/CLIManagerDocumentationTest.java b/compat/maven-embedder/src/test/java/org/apache/maven/cli/CLIManagerDocumentationTest.java
index 1a531085cf02..f5d6d6e8ac86 100644
--- a/compat/maven-embedder/src/test/java/org/apache/maven/cli/CLIManagerDocumentationTest.java
+++ b/compat/maven-embedder/src/test/java/org/apache/maven/cli/CLIManagerDocumentationTest.java
@@ -113,7 +113,7 @@ String getOptionsAsHtml() {
}
@Test
- void testOptionsAsHtml() throws IOException {
+ void optionsAsHtml() throws IOException {
Path options = Paths.get("target/test-classes/options.html");
Files.writeString(options, getOptionsAsHtml(), StandardCharsets.UTF_8);
}
diff --git a/compat/maven-embedder/src/test/java/org/apache/maven/cli/CLIReportingUtilsTest.java b/compat/maven-embedder/src/test/java/org/apache/maven/cli/CLIReportingUtilsTest.java
index 3f5e70b7f59a..40604ee70df4 100644
--- a/compat/maven-embedder/src/test/java/org/apache/maven/cli/CLIReportingUtilsTest.java
+++ b/compat/maven-embedder/src/test/java/org/apache/maven/cli/CLIReportingUtilsTest.java
@@ -20,21 +20,21 @@
import org.junit.jupiter.api.Test;
-import static org.junit.jupiter.api.Assertions.assertEquals;
+import static org.assertj.core.api.Assertions.assertThat;
@Deprecated
class CLIReportingUtilsTest {
@Test
- void testFormatDuration() {
- assertEquals("0.001 s", CLIReportingUtils.formatDuration(1));
- assertEquals("0.999 s", CLIReportingUtils.formatDuration(1000 - 1));
- assertEquals("1.000 s", CLIReportingUtils.formatDuration(1000));
- assertEquals("59.999 s", CLIReportingUtils.formatDuration(60 * 1000 - 1));
- assertEquals("01:00 min", CLIReportingUtils.formatDuration(60 * 1000));
- assertEquals("59:59 min", CLIReportingUtils.formatDuration(60 * 60 * 1000 - 1));
- assertEquals("01:00 h", CLIReportingUtils.formatDuration(60 * 60 * 1000));
- assertEquals("23:59 h", CLIReportingUtils.formatDuration(24 * 60 * 60 * 1000 - 1));
- assertEquals("1 d 00:00 h", CLIReportingUtils.formatDuration(24 * 60 * 60 * 1000));
+ void formatDuration() {
+ assertThat(CLIReportingUtils.formatDuration(1)).isEqualTo("0.001 s");
+ assertThat(CLIReportingUtils.formatDuration(1000 - 1)).isEqualTo("0.999 s");
+ assertThat(CLIReportingUtils.formatDuration(1000)).isEqualTo("1.000 s");
+ assertThat(CLIReportingUtils.formatDuration(60 * 1000 - 1)).isEqualTo("59.999 s");
+ assertThat(CLIReportingUtils.formatDuration(60 * 1000)).isEqualTo("01:00 min");
+ assertThat(CLIReportingUtils.formatDuration(60 * 60 * 1000 - 1)).isEqualTo("59:59 min");
+ assertThat(CLIReportingUtils.formatDuration(60 * 60 * 1000)).isEqualTo("01:00 h");
+ assertThat(CLIReportingUtils.formatDuration(24 * 60 * 60 * 1000 - 1)).isEqualTo("23:59 h");
+ assertThat(CLIReportingUtils.formatDuration(24 * 60 * 60 * 1000)).isEqualTo("1 d 00:00 h");
}
}
diff --git a/compat/maven-embedder/src/test/java/org/apache/maven/cli/CleanArgumentTest.java b/compat/maven-embedder/src/test/java/org/apache/maven/cli/CleanArgumentTest.java
index 396cab4bb80a..6d5c8e803122 100644
--- a/compat/maven-embedder/src/test/java/org/apache/maven/cli/CleanArgumentTest.java
+++ b/compat/maven-embedder/src/test/java/org/apache/maven/cli/CleanArgumentTest.java
@@ -20,7 +20,7 @@
import org.junit.jupiter.api.Test;
-import static org.junit.jupiter.api.Assertions.assertEquals;
+import static org.assertj.core.api.Assertions.assertThat;
/**
*/
@@ -39,26 +39,26 @@ void cleanArgs() {
void cleanArgsShouldRemoveWrongSurroundingQuotes() {
String[] args = {"\"-Dfoo=bar", "\"-Dfoo2=bar two\""};
String[] cleanArgs = CleanArgument.cleanArgs(args);
- assertEquals(args.length, cleanArgs.length);
- assertEquals("-Dfoo=bar", cleanArgs[0]);
- assertEquals("-Dfoo2=bar two", cleanArgs[1]);
+ assertThat(cleanArgs.length).isEqualTo(args.length);
+ assertThat(cleanArgs[0]).isEqualTo("-Dfoo=bar");
+ assertThat(cleanArgs[1]).isEqualTo("-Dfoo2=bar two");
}
@Test
- void testCleanArgsShouldNotTouchCorrectlyQuotedArgumentsUsingDoubleQuotes() {
+ void cleanArgsShouldNotTouchCorrectlyQuotedArgumentsUsingDoubleQuotes() {
String information = "-Dinformation=\"The Information is important.\"";
String[] args = {information};
String[] cleanArgs = CleanArgument.cleanArgs(args);
- assertEquals(args.length, cleanArgs.length);
- assertEquals(information, cleanArgs[0]);
+ assertThat(cleanArgs.length).isEqualTo(args.length);
+ assertThat(cleanArgs[0]).isEqualTo(information);
}
@Test
- void testCleanArgsShouldNotTouchCorrectlyQuotedArgumentsUsingSingleQuotes() {
+ void cleanArgsShouldNotTouchCorrectlyQuotedArgumentsUsingSingleQuotes() {
String information = "-Dinformation='The Information is important.'";
String[] args = {information};
String[] cleanArgs = CleanArgument.cleanArgs(args);
- assertEquals(args.length, cleanArgs.length);
- assertEquals(information, cleanArgs[0]);
+ assertThat(cleanArgs.length).isEqualTo(args.length);
+ assertThat(cleanArgs[0]).isEqualTo(information);
}
}
diff --git a/compat/maven-embedder/src/test/java/org/apache/maven/cli/MavenCliTest.java b/compat/maven-embedder/src/test/java/org/apache/maven/cli/MavenCliTest.java
index ae1f439dc751..65e849eb28ed 100644
--- a/compat/maven-embedder/src/test/java/org/apache/maven/cli/MavenCliTest.java
+++ b/compat/maven-embedder/src/test/java/org/apache/maven/cli/MavenCliTest.java
@@ -68,16 +68,14 @@
import static java.util.Arrays.asList;
import static org.apache.maven.cli.MavenCli.performProfileActivation;
import static org.apache.maven.cli.MavenCli.performProjectActivation;
+import static org.assertj.core.api.Assertions.assertThat;
+import static org.assertj.core.api.AssertionsForClassTypes.assertThatExceptionOfType;
import static org.hamcrest.CoreMatchers.equalTo;
import static org.hamcrest.CoreMatchers.is;
import static org.hamcrest.CoreMatchers.notNullValue;
import static org.hamcrest.CoreMatchers.nullValue;
import static org.hamcrest.MatcherAssert.assertThat;
import static org.hamcrest.collection.IsIterableContainingInAnyOrder.containsInAnyOrder;
-import static org.junit.jupiter.api.Assertions.assertEquals;
-import static org.junit.jupiter.api.Assertions.assertFalse;
-import static org.junit.jupiter.api.Assertions.assertThrows;
-import static org.junit.jupiter.api.Assertions.assertTrue;
import static org.junit.jupiter.api.Assumptions.assumeTrue;
import static org.mockito.ArgumentMatchers.any;
import static org.mockito.Mockito.inOrder;
@@ -134,7 +132,7 @@ void testPerformProfileActivation() throws ParseException {
}
@Test
- void testDetermineProjectActivation() throws ParseException {
+ void determineProjectActivation() throws ParseException {
final CommandLineParser parser = new DefaultParser();
final Options options = new Options();
@@ -161,29 +159,29 @@ void testDetermineProjectActivation() throws ParseException {
}
@Test
- void testCalculateDegreeOfConcurrency() {
- assertThrows(IllegalArgumentException.class, () -> cli.calculateDegreeOfConcurrency("0"));
- assertThrows(IllegalArgumentException.class, () -> cli.calculateDegreeOfConcurrency("-1"));
- assertThrows(IllegalArgumentException.class, () -> cli.calculateDegreeOfConcurrency("0x4"));
- assertThrows(IllegalArgumentException.class, () -> cli.calculateDegreeOfConcurrency("1.0"));
- assertThrows(IllegalArgumentException.class, () -> cli.calculateDegreeOfConcurrency("1."));
- assertThrows(IllegalArgumentException.class, () -> cli.calculateDegreeOfConcurrency("AA"));
- assertThrows(IllegalArgumentException.class, () -> cli.calculateDegreeOfConcurrency("C"));
- assertThrows(IllegalArgumentException.class, () -> cli.calculateDegreeOfConcurrency("C2.2C"));
- assertThrows(IllegalArgumentException.class, () -> cli.calculateDegreeOfConcurrency("C2.2"));
- assertThrows(IllegalArgumentException.class, () -> cli.calculateDegreeOfConcurrency("2C2"));
- assertThrows(IllegalArgumentException.class, () -> cli.calculateDegreeOfConcurrency("CXXX"));
- assertThrows(IllegalArgumentException.class, () -> cli.calculateDegreeOfConcurrency("XXXC"));
+ void calculateDegreeOfConcurrency() {
+ assertThatExceptionOfType(IllegalArgumentException.class).isThrownBy(() -> cli.calculateDegreeOfConcurrency("0"));
+ assertThatExceptionOfType(IllegalArgumentException.class).isThrownBy(() -> cli.calculateDegreeOfConcurrency("-1"));
+ assertThatExceptionOfType(IllegalArgumentException.class).isThrownBy(() -> cli.calculateDegreeOfConcurrency("0x4"));
+ assertThatExceptionOfType(IllegalArgumentException.class).isThrownBy(() -> cli.calculateDegreeOfConcurrency("1.0"));
+ assertThatExceptionOfType(IllegalArgumentException.class).isThrownBy(() -> cli.calculateDegreeOfConcurrency("1."));
+ assertThatExceptionOfType(IllegalArgumentException.class).isThrownBy(() -> cli.calculateDegreeOfConcurrency("AA"));
+ assertThatExceptionOfType(IllegalArgumentException.class).isThrownBy(() -> cli.calculateDegreeOfConcurrency("C"));
+ assertThatExceptionOfType(IllegalArgumentException.class).isThrownBy(() -> cli.calculateDegreeOfConcurrency("C2.2C"));
+ assertThatExceptionOfType(IllegalArgumentException.class).isThrownBy(() -> cli.calculateDegreeOfConcurrency("C2.2"));
+ assertThatExceptionOfType(IllegalArgumentException.class).isThrownBy(() -> cli.calculateDegreeOfConcurrency("2C2"));
+ assertThatExceptionOfType(IllegalArgumentException.class).isThrownBy(() -> cli.calculateDegreeOfConcurrency("CXXX"));
+ assertThatExceptionOfType(IllegalArgumentException.class).isThrownBy(() -> cli.calculateDegreeOfConcurrency("XXXC"));
int cpus = Runtime.getRuntime().availableProcessors();
- assertEquals((int) (cpus * 2.2), cli.calculateDegreeOfConcurrency("2.2C"));
- assertEquals(1, cli.calculateDegreeOfConcurrency("0.0001C"));
- assertThrows(IllegalArgumentException.class, () -> cli.calculateDegreeOfConcurrency("-2.2C"));
- assertThrows(IllegalArgumentException.class, () -> cli.calculateDegreeOfConcurrency("0C"));
+ assertThat(cli.calculateDegreeOfConcurrency("2.2C")).isEqualTo((int) (cpus * 2.2));
+ assertThat(cli.calculateDegreeOfConcurrency("0.0001C")).isEqualTo(1);
+ assertThatExceptionOfType(IllegalArgumentException.class).isThrownBy(() -> cli.calculateDegreeOfConcurrency("-2.2C"));
+ assertThatExceptionOfType(IllegalArgumentException.class).isThrownBy(() -> cli.calculateDegreeOfConcurrency("0C"));
}
@Test
- void testMavenConfig() throws Exception {
+ void mavenConfig() throws Exception {
System.setProperty(
MavenCli.MULTIMODULE_PROJECT_DIRECTORY, new File("src/test/projects/config").getCanonicalPath());
CliRequest request = new CliRequest(new String[0], null);
@@ -191,24 +189,24 @@ void testMavenConfig() throws Exception {
// read .mvn/maven.config
cli.initialize(request);
cli.cli(request);
- assertEquals("multithreaded", request.commandLine.getOptionValue(CLIManager.BUILDER));
- assertEquals("8", request.commandLine.getOptionValue(CLIManager.THREADS));
+ assertThat(request.commandLine.getOptionValue(CLIManager.BUILDER)).isEqualTo("multithreaded");
+ assertThat(request.commandLine.getOptionValue(CLIManager.THREADS)).isEqualTo("8");
// override from command line
request = new CliRequest(new String[] {"--builder", "foobar"}, null);
cli.cli(request);
- assertEquals("foobar", request.commandLine.getOptionValue("builder"));
+ assertThat(request.commandLine.getOptionValue("builder")).isEqualTo("foobar");
}
@Test
- void testMavenConfigInvalid() throws Exception {
+ void mavenConfigInvalid() throws Exception {
System.setProperty(
MavenCli.MULTIMODULE_PROJECT_DIRECTORY,
new File("src/test/projects/config-illegal").getCanonicalPath());
CliRequest request = new CliRequest(new String[0], null);
cli.initialize(request);
- assertThrows(ParseException.class, () -> cli.cli(request));
+ assertThatExceptionOfType(ParseException.class).isThrownBy(() -> cli.cli(request));
}
/**
@@ -225,7 +223,7 @@ void testMavenConfigInvalid() throws Exception {
* @throws Exception in case of failure.
*/
@Test
- void testMVNConfigurationThreadCanBeOverwrittenViaCommandLine() throws Exception {
+ void mvnConfigurationThreadCanBeOverwrittenViaCommandLine() throws Exception {
System.setProperty(
MavenCli.MULTIMODULE_PROJECT_DIRECTORY,
new File("src/test/projects/mavenConfigProperties").getCanonicalPath());
@@ -235,7 +233,7 @@ void testMVNConfigurationThreadCanBeOverwrittenViaCommandLine() throws Exception
// read .mvn/maven.config
cli.cli(request);
- assertEquals("5", request.commandLine.getOptionValue(CLIManager.THREADS));
+ assertThat(request.commandLine.getOptionValue(CLIManager.THREADS)).isEqualTo("5");
}
/**
@@ -252,7 +250,7 @@ void testMVNConfigurationThreadCanBeOverwrittenViaCommandLine() throws Exception
* @throws Exception
*/
@Test
- void testMVNConfigurationDefinedPropertiesCanBeOverwrittenViaCommandLine() throws Exception {
+ void mvnConfigurationDefinedPropertiesCanBeOverwrittenViaCommandLine() throws Exception {
System.setProperty(
MavenCli.MULTIMODULE_PROJECT_DIRECTORY,
new File("src/test/projects/mavenConfigProperties").getCanonicalPath());
@@ -264,7 +262,7 @@ void testMVNConfigurationDefinedPropertiesCanBeOverwrittenViaCommandLine() throw
cli.properties(request);
String revision = request.getUserProperties().getProperty("revision");
- assertEquals("8.1.0", revision);
+ assertThat(revision).isEqualTo("8.1.0");
}
/**
@@ -281,7 +279,7 @@ void testMVNConfigurationDefinedPropertiesCanBeOverwrittenViaCommandLine() throw
* @throws Exception
*/
@Test
- void testMVNConfigurationCLIRepeatedPropertiesLastWins() throws Exception {
+ void mvnConfigurationCLIRepeatedPropertiesLastWins() throws Exception {
System.setProperty(
MavenCli.MULTIMODULE_PROJECT_DIRECTORY,
new File("src/test/projects/mavenConfigProperties").getCanonicalPath());
@@ -293,7 +291,7 @@ void testMVNConfigurationCLIRepeatedPropertiesLastWins() throws Exception {
cli.properties(request);
String revision = request.getUserProperties().getProperty("revision");
- assertEquals("8.2.0", revision);
+ assertThat(revision).isEqualTo("8.2.0");
}
/**
@@ -310,7 +308,7 @@ void testMVNConfigurationCLIRepeatedPropertiesLastWins() throws Exception {
* @throws Exception
*/
@Test
- void testMVNConfigurationFunkyArguments() throws Exception {
+ void mvnConfigurationFunkyArguments() throws Exception {
System.setProperty(
MavenCli.MULTIMODULE_PROJECT_DIRECTORY,
new File("src/test/projects/mavenConfigProperties").getCanonicalPath());
@@ -325,20 +323,20 @@ void testMVNConfigurationFunkyArguments() throws Exception {
cli.cli(request);
cli.properties(request);
- assertEquals("3", request.commandLine.getOptionValue(CLIManager.THREADS));
+ assertThat(request.commandLine.getOptionValue(CLIManager.THREADS)).isEqualTo("3");
String revision = request.getUserProperties().getProperty("revision");
- assertEquals("8.2.0", revision);
+ assertThat(revision).isEqualTo("8.2.0");
- assertEquals("bar ", request.getUserProperties().getProperty("foo"));
- assertEquals("bar two", request.getUserProperties().getProperty("foo2"));
- assertEquals("Apache Maven", request.getUserProperties().getProperty("label"));
+ assertThat(request.getUserProperties().getProperty("foo")).isEqualTo("bar ");
+ assertThat(request.getUserProperties().getProperty("foo2")).isEqualTo("bar two");
+ assertThat(request.getUserProperties().getProperty("label")).isEqualTo("Apache Maven");
- assertEquals("-Dpom.xml", request.getCommandLine().getOptionValue(CLIManager.ALTERNATE_POM_FILE));
+ assertThat(request.getCommandLine().getOptionValue(CLIManager.ALTERNATE_POM_FILE)).isEqualTo("-Dpom.xml");
}
@Test
- void testStyleColors() throws Exception {
+ void styleColors() throws Exception {
assumeTrue(MessageUtils.isColorEnabled(), "ANSI not supported");
CliRequest request;
@@ -347,21 +345,21 @@ void testStyleColors() throws Exception {
cli.cli(request);
cli.properties(request);
cli.logging(request);
- assertFalse(MessageUtils.isColorEnabled());
+ assertThat(MessageUtils.isColorEnabled()).isFalse();
MessageUtils.setColorEnabled(true);
request = new CliRequest(new String[] {"--non-interactive"}, null);
cli.cli(request);
cli.properties(request);
cli.logging(request);
- assertFalse(MessageUtils.isColorEnabled());
+ assertThat(MessageUtils.isColorEnabled()).isFalse();
MessageUtils.setColorEnabled(true);
request = new CliRequest(new String[] {"--force-interactive", "--non-interactive"}, null);
cli.cli(request);
cli.properties(request);
cli.logging(request);
- assertTrue(MessageUtils.isColorEnabled());
+ assertThat(MessageUtils.isColorEnabled()).isTrue();
MessageUtils.setColorEnabled(true);
request = new CliRequest(new String[] {"-l", "target/temp/mvn.log"}, null);
@@ -369,21 +367,21 @@ void testStyleColors() throws Exception {
cli.cli(request);
cli.properties(request);
cli.logging(request);
- assertFalse(MessageUtils.isColorEnabled());
+ assertThat(MessageUtils.isColorEnabled()).isFalse();
MessageUtils.setColorEnabled(false);
request = new CliRequest(new String[] {"-Dstyle.color=always"}, null);
cli.cli(request);
cli.properties(request);
cli.logging(request);
- assertTrue(MessageUtils.isColorEnabled());
+ assertThat(MessageUtils.isColorEnabled()).isTrue();
MessageUtils.setColorEnabled(true);
request = new CliRequest(new String[] {"-Dstyle.color=never"}, null);
cli.cli(request);
cli.properties(request);
cli.logging(request);
- assertFalse(MessageUtils.isColorEnabled());
+ assertThat(MessageUtils.isColorEnabled()).isFalse();
MessageUtils.setColorEnabled(false);
request = new CliRequest(new String[] {"-Dstyle.color=always", "-B", "-l", "target/temp/mvn.log"}, null);
@@ -391,7 +389,7 @@ void testStyleColors() throws Exception {
cli.cli(request);
cli.properties(request);
cli.logging(request);
- assertTrue(MessageUtils.isColorEnabled());
+ assertThat(MessageUtils.isColorEnabled()).isTrue();
MessageUtils.setColorEnabled(false);
CliRequest maybeColorRequest =
@@ -399,15 +397,14 @@ void testStyleColors() throws Exception {
request.workingDirectory = "target/temp";
cli.cli(maybeColorRequest);
cli.properties(maybeColorRequest);
- assertThrows(
- IllegalArgumentException.class, () -> cli.logging(maybeColorRequest), "maybe is not a valid option");
+ assertThatExceptionOfType(IllegalArgumentException.class).as("maybe is not a valid option").isThrownBy(() -> cli.logging(maybeColorRequest));
}
/**
* Verifies MNG-6558
*/
@Test
- void testToolchainsBuildingEvents() throws Exception {
+ void toolchainsBuildingEvents() throws Exception {
final EventSpyDispatcher eventSpyDispatcherMock = mock(EventSpyDispatcher.class);
MavenCli customizedMavenCli = new MavenCli() {
@Override
@@ -489,7 +486,7 @@ void verifyLocalRepositoryPath() throws Exception {
* @throws Exception cli invocation.
*/
@Test
- void testVersionStringWithoutAnsi() throws Exception {
+ void versionStringWithoutAnsi() throws Exception {
// given
// - request with version and batch mode
CliRequest cliRequest = new CliRequest(new String[] {"--version", "--batch-mode"}, null);
@@ -509,7 +506,7 @@ void testVersionStringWithoutAnsi() throws Exception {
String versionOut = new String(systemOut.toByteArray(), StandardCharsets.UTF_8);
// then
- assertEquals(stripAnsiCodes(versionOut), versionOut);
+ assertThat(versionOut).isEqualTo(stripAnsiCodes(versionOut));
}
@Test
@@ -579,13 +576,13 @@ void populatePropertiesOverwrite() throws Exception {
}
@Test
- public void findRootProjectWithAttribute() {
+ void findRootProjectWithAttribute() {
Path test = Paths.get("src/test/projects/root-attribute");
- assertEquals(test, new DefaultRootLocator().findRoot(test.resolve("child")));
+ assertThat(new DefaultRootLocator().findRoot(test.resolve("child"))).isEqualTo(test);
}
@Test
- public void testPropertiesInterpolation() throws Exception {
+ void propertiesInterpolation() throws Exception {
FileSystem fs = Jimfs.newFileSystem(Configuration.windows());
Path mavenHome = fs.getPath("C:\\maven");
@@ -643,14 +640,14 @@ public void testPropertiesInterpolation() throws Exception {
}
@Test
- public void testEmptyProfile() throws Exception {
+ void emptyProfile() throws Exception {
CliRequest request = new CliRequest(new String[] {"-P", ""}, null);
cli.cli(request);
cli.populateRequest(request);
}
@Test
- public void testEmptyProject() throws Exception {
+ void emptyProject() throws Exception {
CliRequest request = new CliRequest(new String[] {"-pl", ""}, null);
cli.cli(request);
cli.populateRequest(request);
@@ -658,7 +655,7 @@ public void testEmptyProject() throws Exception {
@ParameterizedTest
@MethodSource("activateBatchModeArguments")
- public void activateBatchMode(boolean ciEnv, String[] cliArgs, boolean isBatchMode) throws Exception {
+ void activateBatchMode(boolean ciEnv, String[] cliArgs, boolean isBatchMode) throws Exception {
CliRequest request = new CliRequest(cliArgs, null);
if (ciEnv) {
request.getSystemProperties().put("env.CI", "true");
@@ -685,7 +682,7 @@ public static Stream activateBatchModeArguments() {
@ParameterizedTest
@MethodSource("calculateTransferListenerArguments")
- public void calculateTransferListener(boolean ciEnv, String[] cliArgs, Class expectedSubClass)
+ void calculateTransferListener(boolean ciEnv, String[] cliArgs, Class expectedSubClass)
throws Exception {
CliRequest request = new CliRequest(cliArgs, null);
if (ciEnv) {
diff --git a/compat/maven-embedder/src/test/java/org/apache/maven/cli/event/ExecutionEventLoggerTest.java b/compat/maven-embedder/src/test/java/org/apache/maven/cli/event/ExecutionEventLoggerTest.java
index 9d9a8f19c061..b2f935721e1d 100644
--- a/compat/maven-embedder/src/test/java/org/apache/maven/cli/event/ExecutionEventLoggerTest.java
+++ b/compat/maven-embedder/src/test/java/org/apache/maven/cli/event/ExecutionEventLoggerTest.java
@@ -65,7 +65,7 @@ void beforeEach() {
}
@Test
- void testProjectStarted() {
+ void projectStarted() {
// prepare
File basedir = new File("").getAbsoluteFile();
ExecutionEvent event = mock(ExecutionEvent.class);
@@ -98,7 +98,7 @@ void testProjectStarted() {
}
@Test
- void testProjectStartedOverflow() {
+ void projectStartedOverflow() {
// prepare
File basedir = new File("").getAbsoluteFile();
ExecutionEvent event = mock(ExecutionEvent.class);
@@ -130,7 +130,7 @@ void testProjectStartedOverflow() {
}
@Test
- void testTerminalWidth() {
+ void terminalWidth() {
// prepare
Logger logger = mock(Logger.class);
when(logger.isInfoEnabled()).thenReturn(true);
@@ -170,7 +170,7 @@ void testTerminalWidth() {
}
@Test
- void testProjectStartedNoPom() {
+ void projectStartedNoPom() {
// prepare
File basedir = new File("").getAbsoluteFile();
ExecutionEvent event = mock(ExecutionEvent.class);
@@ -196,7 +196,7 @@ void testProjectStartedNoPom() {
}
@Test
- void testMultiModuleProjectProgress() {
+ void multiModuleProjectProgress() {
// prepare
MavenProject project1 = generateMavenProject("Apache Maven Embedder 1");
MavenProject project2 = generateMavenProject("Apache Maven Embedder 2");
@@ -229,7 +229,7 @@ void testMultiModuleProjectProgress() {
}
@Test
- void testMultiModuleProjectResumeFromProgress() {
+ void multiModuleProjectResumeFromProgress() {
// prepare
MavenProject project1 = generateMavenProject("Apache Maven Embedder 1");
MavenProject project2 = generateMavenProject("Apache Maven Embedder 2");
diff --git a/compat/maven-embedder/src/test/java/org/apache/maven/cli/props/MavenPropertiesLoaderTest.java b/compat/maven-embedder/src/test/java/org/apache/maven/cli/props/MavenPropertiesLoaderTest.java
index c54dd22d9f25..8664b5bb86b3 100644
--- a/compat/maven-embedder/src/test/java/org/apache/maven/cli/props/MavenPropertiesLoaderTest.java
+++ b/compat/maven-embedder/src/test/java/org/apache/maven/cli/props/MavenPropertiesLoaderTest.java
@@ -28,15 +28,14 @@
import com.google.common.jimfs.Jimfs;
import org.junit.jupiter.api.Test;
-import static org.junit.jupiter.api.Assertions.assertEquals;
-import static org.junit.jupiter.api.Assertions.assertNull;
-import static org.junit.jupiter.api.Assertions.assertThrows;
+import static org.assertj.core.api.Assertions.assertThat;
+import static org.assertj.core.api.AssertionsForClassTypes.assertThatExceptionOfType;
@Deprecated
class MavenPropertiesLoaderTest {
@Test
- void testIncludes() throws Exception {
+ void includes() throws Exception {
FileSystem fs = Jimfs.newFileSystem(Configuration.unix());
Path mavenHome = fs.getPath("/maven");
@@ -52,17 +51,16 @@ void testIncludes() throws Exception {
Properties p = new Properties();
p.put("java.version", "11");
- assertThrows(
- NoSuchFileException.class, () -> MavenPropertiesLoader.loadProperties(p, mavenUserProps, null, false));
+ assertThatExceptionOfType(NoSuchFileException.class).isThrownBy(() -> MavenPropertiesLoader.loadProperties(p, mavenUserProps, null, false));
Path another = propsPath.resolveSibling("another.properties");
Files.writeString(another, "bar = chti${java.version}\n");
MavenPropertiesLoader.loadProperties(p, mavenUserProps, null, false);
- assertEquals("chti11z", p.getProperty("fro"));
+ assertThat(p.getProperty("fro")).isEqualTo("chti11z");
}
@Test
- void testIncludes3() throws Exception {
+ void includes3() throws Exception {
FileSystem fs = Jimfs.newFileSystem(Configuration.unix());
Path mavenHome = fs.getPath("/maven");
@@ -83,14 +81,14 @@ void testIncludes3() throws Exception {
Properties p = new Properties();
p.put("user.home", userDirectory.toString());
MavenPropertiesLoader.loadProperties(p, mavenUserProps, p::getProperty, false);
- assertEquals("bar", p.getProperty("foo"));
- assertNull(p.getProperty("foo-env"));
+ assertThat(p.getProperty("foo")).isEqualTo("bar");
+ assertThat(p.getProperty("foo-env")).isNull();
p = new Properties();
p.put("user.home", userDirectory.toString());
p.put("env.envName", "ci");
MavenPropertiesLoader.loadProperties(p, mavenUserProps, p::getProperty, false);
- assertEquals("bar-env", p.getProperty("foo"));
- assertEquals("bar", p.getProperty("foo-env"));
+ assertThat(p.getProperty("foo")).isEqualTo("bar-env");
+ assertThat(p.getProperty("foo-env")).isEqualTo("bar");
}
}
diff --git a/compat/maven-embedder/src/test/java/org/apache/maven/cli/props/MavenPropertiesTest.java b/compat/maven-embedder/src/test/java/org/apache/maven/cli/props/MavenPropertiesTest.java
index 07aa1e8ba664..b664de6e61a7 100644
--- a/compat/maven-embedder/src/test/java/org/apache/maven/cli/props/MavenPropertiesTest.java
+++ b/compat/maven-embedder/src/test/java/org/apache/maven/cli/props/MavenPropertiesTest.java
@@ -31,15 +31,13 @@
import org.junit.jupiter.api.BeforeEach;
import org.junit.jupiter.api.Test;
-import static org.junit.jupiter.api.Assertions.assertEquals;
-import static org.junit.jupiter.api.Assertions.assertNotNull;
-import static org.junit.jupiter.api.Assertions.assertTrue;
+import static org.assertj.core.api.Assertions.assertThat;
/**
* Unit tests on MavenProperties.
*/
@Deprecated
-public class MavenPropertiesTest {
+class MavenPropertiesTest {
private static final String LINE_SEPARATOR = System.getProperty("line.separator");
private static final String COMMENT = "# comment";
@@ -65,13 +63,13 @@ public class MavenPropertiesTest {
* @see junit.framework.TestCase#setUp()
*/
@BeforeEach
- public void setUp() throws Exception {
+ void setUp() throws Exception {
properties = new MavenProperties();
properties.load(new StringReader(TEST_PROPERTIES));
}
@Test
- public void testSpaces() throws Exception {
+ void spaces() throws Exception {
String config = "\n" + "\n"
+ " \n"
+ " \n"
@@ -108,74 +106,74 @@ public void testSpaces() throws Exception {
props2.load(new StringReader(config));
String s325 = props1.getProperty(" \r");
- assertEquals("\n \t \f", s325, "1");
+ assertThat(s325).as("1").isEqualTo("\n \t \f");
String s324 = props1.getProperty("a");
- assertEquals("a", s324, "2");
+ assertThat(s324).as("2").isEqualTo("a");
String s323 = props1.getProperty("b");
- assertEquals("bb as,dn ", s323, "3");
+ assertThat(s323).as("3").isEqualTo("bb as,dn ");
String s322 = props1.getProperty("c\r \t\nu");
- assertEquals(":: cu", s322, "4");
+ assertThat(s322).as("4").isEqualTo(":: cu");
String s321 = props1.getProperty("bu");
- assertEquals("bu", s321, "5");
+ assertThat(s321).as("5").isEqualTo("bu");
String s320 = props1.getProperty("d");
- assertEquals("d\r\ne=e", s320, "6");
+ assertThat(s320).as("6").isEqualTo("d\r\ne=e");
String s319 = props1.getProperty("f");
- assertEquals("fff", s319, "7");
+ assertThat(s319).as("7").isEqualTo("fff");
String s318 = props1.getProperty("g");
- assertEquals("g", s318, "8");
+ assertThat(s318).as("8").isEqualTo("g");
String s317 = props1.getProperty("h h");
- assertEquals("", s317, "9");
+ assertThat(s317).as("9").isEqualTo("");
String s316 = props1.getProperty(" ");
- assertEquals("i=i", s316, "10");
+ assertThat(s316).as("10").isEqualTo("i=i");
String s315 = props1.getProperty("j");
- assertEquals(" j", s315, "11");
+ assertThat(s315).as("11").isEqualTo(" j");
String s314 = props1.getProperty("space");
- assertEquals(" c", s314, "12");
+ assertThat(s314).as("12").isEqualTo(" c");
String s313 = props1.getProperty("dblbackslash");
- assertEquals("\\", s313, "13");
+ assertThat(s313).as("13").isEqualTo("\\");
String s312 = props2.getProperty(" \r");
- assertEquals("\n \t \f", s312, "1");
+ assertThat(s312).as("1").isEqualTo("\n \t \f");
String s311 = props2.getProperty("a");
- assertEquals("a", s311, "2");
+ assertThat(s311).as("2").isEqualTo("a");
String s310 = props2.getProperty("b");
- assertEquals("bb as,dn ", s310, "3");
+ assertThat(s310).as("3").isEqualTo("bb as,dn ");
String s39 = props2.getProperty("c\r \t\nu");
- assertEquals(":: cu", s39, "4");
+ assertThat(s39).as("4").isEqualTo(":: cu");
String s38 = props2.getProperty("bu");
- assertEquals("bu", s38, "5");
+ assertThat(s38).as("5").isEqualTo("bu");
String s37 = props2.getProperty("d");
- assertEquals("d\r\ne=e", s37, "6");
+ assertThat(s37).as("6").isEqualTo("d\r\ne=e");
String s36 = props2.getProperty("f");
- assertEquals("fff", s36, "7");
+ assertThat(s36).as("7").isEqualTo("fff");
String s35 = props2.getProperty("g");
- assertEquals("g", s35, "8");
+ assertThat(s35).as("8").isEqualTo("g");
String s34 = props2.getProperty("h h");
- assertEquals("", s34, "9");
+ assertThat(s34).as("9").isEqualTo("");
String s33 = props2.getProperty(" ");
- assertEquals("i=i", s33, "10");
+ assertThat(s33).as("10").isEqualTo("i=i");
String s32 = props2.getProperty("j");
- assertEquals(" j", s32, "11");
+ assertThat(s32).as("11").isEqualTo(" j");
String s31 = props2.getProperty("space");
- assertEquals(" c", s31, "12");
+ assertThat(s31).as("12").isEqualTo(" c");
String s3 = props2.getProperty("dblbackslash");
- assertEquals("\\", s3, "13");
- assertEquals(props1, props2);
+ assertThat(s3).as("13").isEqualTo("\\");
+ assertThat(props2).isEqualTo(props1);
}
@Test
- public void testConfigInterpolation() throws IOException {
+ void configInterpolation() throws IOException {
String config = "a=$\\\\\\\\{var}\n" + "ab=${a}b\n" + "abc=${ab}c";
Map expected = Map.of("a", "$\\{var}", "ab", "$\\{var}b", "abc", "$\\{var}bc");
java.util.Properties props1 = new java.util.Properties();
props1.load(new StringReader(config));
new DefaultInterpolator().performSubstitution((Map) props1, null, true);
- assertEquals(expected, props1);
+ assertThat(props1).isEqualTo(expected);
MavenProperties props2 = new MavenProperties();
props2.load(new StringReader(config));
- assertEquals(expected, props2);
+ assertThat(props2).isEqualTo(expected);
}
/**
@@ -186,13 +184,13 @@ public void testConfigInterpolation() throws IOException {
* @throws Exception
*/
@Test
- public void testGettingProperty() throws Exception {
+ void gettingProperty() throws Exception {
Object o2 = properties.get("test");
- assertEquals("test", o2);
+ assertThat(o2).isEqualTo("test");
}
@Test
- public void testLoadSave() throws IOException {
+ void loadSave() throws IOException {
StringWriter sw = new StringWriter();
PrintWriter pw = new PrintWriter(sw);
pw.println("# ");
@@ -225,19 +223,19 @@ public void testLoadSave() throws IOException {
}
@Test
- public void testJavaUtilPropertiesCompatibility() throws Exception {
+ void javaUtilPropertiesCompatibility() throws Exception {
MavenProperties properties = new MavenProperties();
properties.load(new StringReader(TEST_PROPERTIES));
String test = properties.getProperty("test");
- assertEquals("test", test);
+ assertThat(test).isEqualTo("test");
String defaultValue = properties.getProperty("notfound", "default");
- assertEquals("default", defaultValue);
+ assertThat(defaultValue).isEqualTo("default");
properties.setProperty("another", "another");
Object o1 = properties.getProperty("another");
- assertEquals("another", o1);
+ assertThat(o1).isEqualTo("another");
properties.store(System.err, null);
System.err.println("====");
@@ -246,55 +244,55 @@ public void testJavaUtilPropertiesCompatibility() throws Exception {
private static final String RESULT1 = COMMENT + LINE_SEPARATOR + KEY1A + " = " + VALUE1 + LINE_SEPARATOR;
@Test
- public void testSaveComment1() throws Exception {
+ void saveComment1() throws Exception {
properties.put(KEY1, COMMENT, VALUE1);
StringWriter sw = new StringWriter();
properties.save(sw);
String msg = sw.toString();
- assertTrue(sw.toString().endsWith(RESULT1), msg);
+ assertThat(sw.toString().endsWith(RESULT1)).as(msg).isTrue();
}
private static final String RESULT1A = COMMENT + LINE_SEPARATOR + KEY2A + " = " + VALUE1 + LINE_SEPARATOR;
@Test
- public void testSaveComment1a() throws Exception {
+ void saveComment1a() throws Exception {
properties.put(KEY2, COMMENT, VALUE1);
StringWriter sw = new StringWriter();
properties.save(sw);
String msg = sw.toString();
- assertTrue(sw.toString().endsWith(RESULT1A), msg);
+ assertThat(sw.toString().endsWith(RESULT1A)).as(msg).isTrue();
}
private static final String RESULT2 =
COMMENT + LINE_SEPARATOR + COMMENT + LINE_SEPARATOR + KEY1A + " = " + VALUE1 + LINE_SEPARATOR;
@Test
- public void testSaveComment2() throws Exception {
+ void saveComment2() throws Exception {
properties.put(KEY1, List.of(new String[] {COMMENT, COMMENT}), VALUE1);
StringWriter sw = new StringWriter();
properties.save(sw);
String msg = sw.toString();
- assertTrue(sw.toString().endsWith(RESULT2), msg);
+ assertThat(sw.toString().endsWith(RESULT2)).as(msg).isTrue();
}
private static final String RESULT3 = COMMENT + LINE_SEPARATOR + COMMENT + LINE_SEPARATOR + KEY1A + " = " + VALUE1
+ "\\" + LINE_SEPARATOR + VALUE1 + LINE_SEPARATOR;
@Test
- public void testSaveComment3() throws Exception {
+ void saveComment3() throws Exception {
properties.put(KEY1, List.of(new String[] {COMMENT, COMMENT}), List.of(new String[] {VALUE1, VALUE1}));
StringWriter sw = new StringWriter();
properties.save(sw);
String msg = sw.toString();
- assertTrue(sw.toString().endsWith(RESULT3), msg);
+ assertThat(sw.toString().endsWith(RESULT3)).as(msg).isTrue();
List rawValue = properties.getRaw(KEY1);
- assertEquals(2, (Object) rawValue.size());
- assertEquals(KEY1A + " = " + VALUE1, rawValue.get(0));
- assertEquals(VALUE1, rawValue.get(1));
+ assertThat((Object) rawValue.size()).isEqualTo(2);
+ assertThat(rawValue.get(0)).isEqualTo(KEY1A + " = " + VALUE1);
+ assertThat(rawValue.get(1)).isEqualTo(VALUE1);
}
@Test
- public void testEntrySetValue() throws Exception {
+ void entrySetValue() throws Exception {
properties.put(KEY1, VALUE1);
ByteArrayOutputStream baos = new ByteArrayOutputStream();
@@ -303,12 +301,12 @@ public void testEntrySetValue() throws Exception {
properties = new MavenProperties();
properties.load(new ByteArrayInputStream(baos.toByteArray()));
Object o22 = properties.get(KEY1);
- assertEquals(VALUE1, o22);
+ assertThat(o22).isEqualTo(VALUE1);
for (Map.Entry entry : properties.entrySet()) {
entry.setValue(entry.getValue() + "x");
}
Object o21 = properties.get(KEY1);
- assertEquals(VALUE1 + "x", o21);
+ assertThat(o21).isEqualTo(VALUE1 + "x");
baos = new ByteArrayOutputStream();
properties.save(baos);
@@ -316,11 +314,11 @@ public void testEntrySetValue() throws Exception {
properties = new MavenProperties();
properties.load(new ByteArrayInputStream(baos.toByteArray()));
Object o2 = properties.get(KEY1);
- assertEquals(VALUE1 + "x", o2);
+ assertThat(o2).isEqualTo(VALUE1 + "x");
}
@Test
- public void testMultiValueEscaping() throws IOException {
+ void multiValueEscaping() throws IOException {
StringWriter sw = new StringWriter();
PrintWriter pw = new PrintWriter(sw);
pw.println("fruits apple, banana, pear, \\");
@@ -330,16 +328,16 @@ public void testMultiValueEscaping() throws IOException {
java.util.Properties p = new java.util.Properties();
p.load(new StringReader(sw.toString()));
Object o24 = p.getProperty("fruits");
- assertEquals("apple, banana, pear, cantaloupe, watermelon, kiwi, mango", o24);
+ assertThat(o24).isEqualTo("apple, banana, pear, cantaloupe, watermelon, kiwi, mango");
MavenProperties props = new MavenProperties();
props.load(new StringReader(sw.toString()));
Object o23 = props.getProperty("fruits");
- assertEquals("apple, banana, pear, cantaloupe, watermelon, kiwi, mango", o23);
+ assertThat(o23).isEqualTo("apple, banana, pear, cantaloupe, watermelon, kiwi, mango");
List raw = props.getRaw("fruits");
- assertNotNull(raw);
- assertEquals(3, (Object) raw.size());
- assertEquals("fruits apple, banana, pear, ", raw.get(0));
+ assertThat(raw).isNotNull();
+ assertThat((Object) raw.size()).isEqualTo(3);
+ assertThat(raw.get(0)).isEqualTo("fruits apple, banana, pear, ");
props = new MavenProperties();
props.put(
@@ -350,22 +348,22 @@ public void testMultiValueEscaping() throws IOException {
" cantaloupe, watermelon, ",
" kiwi, mango"));
Object o22 = props.getProperty("fruits");
- assertEquals("apple, banana, pear, cantaloupe, watermelon, kiwi, mango", o22);
+ assertThat(o22).isEqualTo("apple, banana, pear, cantaloupe, watermelon, kiwi, mango");
raw = props.getRaw("fruits");
- assertNotNull(raw);
- assertEquals(3, (Object) raw.size());
- assertEquals("fruits apple, banana, pear, ", raw.get(0));
+ assertThat(raw).isNotNull();
+ assertThat((Object) raw.size()).isEqualTo(3);
+ assertThat(raw.get(0)).isEqualTo("fruits apple, banana, pear, ");
sw = new StringWriter();
props.save(sw);
props = new MavenProperties();
props.load(new StringReader(sw.toString()));
Object o21 = props.getProperty("fruits");
- assertEquals("apple, banana, pear, cantaloupe, watermelon, kiwi, mango", o21);
+ assertThat(o21).isEqualTo("apple, banana, pear, cantaloupe, watermelon, kiwi, mango");
raw = props.getRaw("fruits");
- assertNotNull(raw);
- assertEquals(3, (Object) raw.size());
- assertEquals("fruits apple, banana, pear, ", raw.get(0));
+ assertThat(raw).isNotNull();
+ assertThat((Object) raw.size()).isEqualTo(3);
+ assertThat(raw.get(0)).isEqualTo("fruits apple, banana, pear, ");
props = new MavenProperties();
props.put(
@@ -376,15 +374,15 @@ public void testMultiValueEscaping() throws IOException {
" cantaloupe, watermelon, ",
" kiwi, mango"));
Object o2 = props.getProperty("fruits");
- assertEquals("apple, banana, pear, cantaloupe, watermelon, kiwi, mango", o2);
+ assertThat(o2).isEqualTo("apple, banana, pear, cantaloupe, watermelon, kiwi, mango");
raw = props.getRaw("fruits");
- assertNotNull(raw);
- assertEquals(3, (Object) raw.size());
- assertEquals("fruits = apple, banana, pear, ", raw.get(0));
+ assertThat(raw).isNotNull();
+ assertThat((Object) raw.size()).isEqualTo(3);
+ assertThat(raw.get(0)).isEqualTo("fruits = apple, banana, pear, ");
}
@Test
- public void testUpdate() throws Exception {
+ void update() throws Exception {
MavenProperties p1 = new MavenProperties();
p1.put(
"fruits",
@@ -404,19 +402,19 @@ public void testUpdate() throws Exception {
p2.put("trees", "fir, oak, maple");
p1.update(p2);
- assertEquals(2, (Object) p1.size());
+ assertThat((Object) p1.size()).isEqualTo(2);
Object o23 = p1.getComments("trees");
- assertEquals(List.of("#", "# List of trees", "#"), o23);
+ assertThat(o23).isEqualTo(List.of("#", "# List of trees", "#"));
Object o22 = p1.getProperty("trees");
- assertEquals("fir, oak, maple", o22);
+ assertThat(o22).isEqualTo("fir, oak, maple");
Object o21 = p1.getComments("fruits");
- assertEquals(List.of("#", "# List of good fruits", "#"), o21);
+ assertThat(o21).isEqualTo(List.of("#", "# List of good fruits", "#"));
Object o2 = p1.getProperty("fruits");
- assertEquals("apple, banana, pear", o2);
+ assertThat(o2).isEqualTo("apple, banana, pear");
}
@Test
- public void testSubstitution() throws IOException {
+ void substitution() throws IOException {
String str = "port = 4141" + LINE_SEPARATOR + "host = localhost"
+ LINE_SEPARATOR + "url = https://${host}:${port}/service"
+ LINE_SEPARATOR;
@@ -426,6 +424,6 @@ public void testSubstitution() throws IOException {
StringWriter sw = new StringWriter();
properties.save(sw);
Object o2 = sw.toString();
- assertEquals(str, o2);
+ assertThat(o2).isEqualTo(str);
}
}
diff --git a/compat/maven-embedder/src/test/java/org/apache/maven/cli/transfer/FileSizeFormatTest.java b/compat/maven-embedder/src/test/java/org/apache/maven/cli/transfer/FileSizeFormatTest.java
index f13aa48c1294..d4b7fb0db757 100644
--- a/compat/maven-embedder/src/test/java/org/apache/maven/cli/transfer/FileSizeFormatTest.java
+++ b/compat/maven-embedder/src/test/java/org/apache/maven/cli/transfer/FileSizeFormatTest.java
@@ -21,194 +21,194 @@
import org.apache.maven.cli.transfer.FileSizeFormat.ScaleUnit;
import org.junit.jupiter.api.Test;
-import static org.junit.jupiter.api.Assertions.assertEquals;
-import static org.junit.jupiter.api.Assertions.assertThrows;
+import static org.assertj.core.api.Assertions.assertThat;
+import static org.assertj.core.api.AssertionsForClassTypes.assertThatExceptionOfType;
@Deprecated
class FileSizeFormatTest {
@Test
- void testNegativeSize() {
+ void negativeSize() {
FileSizeFormat format = new FileSizeFormat();
long negativeSize = -100L;
- assertThrows(IllegalArgumentException.class, () -> format.format(negativeSize));
+ assertThatExceptionOfType(IllegalArgumentException.class).isThrownBy(() -> format.format(negativeSize));
}
@Test
- void testSize() {
+ void size() {
FileSizeFormat format = new FileSizeFormat();
- assertEquals("0 B", format.format(0L));
- assertEquals("5 B", format.format(5L));
- assertEquals("10 B", format.format(10L));
- assertEquals("15 B", format.format(15L));
- assertEquals("999 B", format.format(999L));
- assertEquals("1.0 kB", format.format(1000L));
- assertEquals("5.5 kB", format.format(5500L));
- assertEquals("10 kB", format.format(10L * 1000L));
- assertEquals("15 kB", format.format(15L * 1000L));
- assertEquals("999 kB", format.format(999L * 1000L));
- assertEquals("1.0 MB", format.format(1000L * 1000L));
- assertEquals("5.5 MB", format.format(5500L * 1000L));
- assertEquals("10 MB", format.format(10L * 1000L * 1000L));
- assertEquals("15 MB", format.format(15L * 1000L * 1000L));
- assertEquals("999 MB", format.format(999L * 1000L * 1000L));
- assertEquals("1.0 GB", format.format(1000L * 1000L * 1000L));
- assertEquals("5.5 GB", format.format(5500L * 1000L * 1000L));
- assertEquals("10 GB", format.format(10L * 1000L * 1000L * 1000L));
- assertEquals("15 GB", format.format(15L * 1000L * 1000L * 1000L));
- assertEquals("1000 GB", format.format(1000L * 1000L * 1000L * 1000L));
+ assertThat(format.format(0L)).isEqualTo("0 B");
+ assertThat(format.format(5L)).isEqualTo("5 B");
+ assertThat(format.format(10L)).isEqualTo("10 B");
+ assertThat(format.format(15L)).isEqualTo("15 B");
+ assertThat(format.format(999L)).isEqualTo("999 B");
+ assertThat(format.format(1000L)).isEqualTo("1.0 kB");
+ assertThat(format.format(5500L)).isEqualTo("5.5 kB");
+ assertThat(format.format(10L * 1000L)).isEqualTo("10 kB");
+ assertThat(format.format(15L * 1000L)).isEqualTo("15 kB");
+ assertThat(format.format(999L * 1000L)).isEqualTo("999 kB");
+ assertThat(format.format(1000L * 1000L)).isEqualTo("1.0 MB");
+ assertThat(format.format(5500L * 1000L)).isEqualTo("5.5 MB");
+ assertThat(format.format(10L * 1000L * 1000L)).isEqualTo("10 MB");
+ assertThat(format.format(15L * 1000L * 1000L)).isEqualTo("15 MB");
+ assertThat(format.format(999L * 1000L * 1000L)).isEqualTo("999 MB");
+ assertThat(format.format(1000L * 1000L * 1000L)).isEqualTo("1.0 GB");
+ assertThat(format.format(5500L * 1000L * 1000L)).isEqualTo("5.5 GB");
+ assertThat(format.format(10L * 1000L * 1000L * 1000L)).isEqualTo("10 GB");
+ assertThat(format.format(15L * 1000L * 1000L * 1000L)).isEqualTo("15 GB");
+ assertThat(format.format(1000L * 1000L * 1000L * 1000L)).isEqualTo("1000 GB");
}
@Test
- void testSizeWithSelectedScaleUnit() {
+ void sizeWithSelectedScaleUnit() {
FileSizeFormat format = new FileSizeFormat();
- assertEquals("0 B", format.format(0L));
- assertEquals("0 B", format.format(0L, ScaleUnit.BYTE));
- assertEquals("0 kB", format.format(0L, ScaleUnit.KILOBYTE));
- assertEquals("0 MB", format.format(0L, ScaleUnit.MEGABYTE));
- assertEquals("0 GB", format.format(0L, ScaleUnit.GIGABYTE));
-
- assertEquals("5 B", format.format(5L));
- assertEquals("5 B", format.format(5L, ScaleUnit.BYTE));
- assertEquals("0 kB", format.format(5L, ScaleUnit.KILOBYTE));
- assertEquals("0 MB", format.format(5L, ScaleUnit.MEGABYTE));
- assertEquals("0 GB", format.format(5L, ScaleUnit.GIGABYTE));
-
- assertEquals("49 B", format.format(49L));
- assertEquals("49 B", format.format(49L, ScaleUnit.BYTE));
- assertEquals("0 kB", format.format(49L, ScaleUnit.KILOBYTE));
- assertEquals("0 MB", format.format(49L, ScaleUnit.MEGABYTE));
- assertEquals("0 GB", format.format(49L, ScaleUnit.GIGABYTE));
-
- assertEquals("50 B", format.format(50L));
- assertEquals("50 B", format.format(50L, ScaleUnit.BYTE));
- assertEquals("0.1 kB", format.format(50L, ScaleUnit.KILOBYTE));
- assertEquals("0 MB", format.format(50L, ScaleUnit.MEGABYTE));
- assertEquals("0 GB", format.format(50L, ScaleUnit.GIGABYTE));
-
- assertEquals("999 B", format.format(999L));
- assertEquals("999 B", format.format(999L, ScaleUnit.BYTE));
- assertEquals("1.0 kB", format.format(999L, ScaleUnit.KILOBYTE));
- assertEquals("0 MB", format.format(999L, ScaleUnit.MEGABYTE));
- assertEquals("0 GB", format.format(999L, ScaleUnit.GIGABYTE));
-
- assertEquals("1.0 kB", format.format(1000L));
- assertEquals("1000 B", format.format(1000L, ScaleUnit.BYTE));
- assertEquals("1.0 kB", format.format(1000L, ScaleUnit.KILOBYTE));
- assertEquals("0 MB", format.format(1000L, ScaleUnit.MEGABYTE));
- assertEquals("0 GB", format.format(1000L, ScaleUnit.GIGABYTE));
-
- assertEquals("49 kB", format.format(49L * 1000L));
- assertEquals("49000 B", format.format(49L * 1000L, ScaleUnit.BYTE));
- assertEquals("49 kB", format.format(49L * 1000L, ScaleUnit.KILOBYTE));
- assertEquals("0 MB", format.format(49L * 1000L, ScaleUnit.MEGABYTE));
- assertEquals("0 GB", format.format(49L * 1000L, ScaleUnit.GIGABYTE));
-
- assertEquals("50 kB", format.format(50L * 1000L));
- assertEquals("50000 B", format.format(50L * 1000L, ScaleUnit.BYTE));
- assertEquals("50 kB", format.format(50L * 1000L, ScaleUnit.KILOBYTE));
- assertEquals("0.1 MB", format.format(50L * 1000L, ScaleUnit.MEGABYTE));
- assertEquals("0 GB", format.format(50L * 1000L, ScaleUnit.GIGABYTE));
-
- assertEquals("999 kB", format.format(999L * 1000L));
- assertEquals("999000 B", format.format(999L * 1000L, ScaleUnit.BYTE));
- assertEquals("999 kB", format.format(999L * 1000L, ScaleUnit.KILOBYTE));
- assertEquals("1.0 MB", format.format(999L * 1000L, ScaleUnit.MEGABYTE));
- assertEquals("0 GB", format.format(999L * 1000L, ScaleUnit.GIGABYTE));
-
- assertEquals("1.0 MB", format.format(1000L * 1000L));
- assertEquals("1000000 B", format.format(1000L * 1000L, ScaleUnit.BYTE));
- assertEquals("1000 kB", format.format(1000L * 1000L, ScaleUnit.KILOBYTE));
- assertEquals("1.0 MB", format.format(1000L * 1000L, ScaleUnit.MEGABYTE));
- assertEquals("0 GB", format.format(1000L * 1000L, ScaleUnit.GIGABYTE));
-
- assertEquals("49 MB", format.format(49L * 1000L * 1000L));
- assertEquals("49000000 B", format.format(49L * 1000L * 1000L, ScaleUnit.BYTE));
- assertEquals("49000 kB", format.format(49L * 1000L * 1000L, ScaleUnit.KILOBYTE));
- assertEquals("49 MB", format.format(49L * 1000L * 1000L, ScaleUnit.MEGABYTE));
- assertEquals("0 GB", format.format(49L * 1000L * 1000L, ScaleUnit.GIGABYTE));
-
- assertEquals("50 MB", format.format(50L * 1000L * 1000L));
- assertEquals("50000000 B", format.format(50L * 1000L * 1000L, ScaleUnit.BYTE));
- assertEquals("50000 kB", format.format(50L * 1000L * 1000L, ScaleUnit.KILOBYTE));
- assertEquals("50 MB", format.format(50L * 1000L * 1000L, ScaleUnit.MEGABYTE));
- assertEquals("0.1 GB", format.format(50L * 1000L * 1000L, ScaleUnit.GIGABYTE));
-
- assertEquals("999 MB", format.format(999L * 1000L * 1000L));
- assertEquals("999000000 B", format.format(999L * 1000L * 1000L, ScaleUnit.BYTE));
- assertEquals("999000 kB", format.format(999L * 1000L * 1000L, ScaleUnit.KILOBYTE));
- assertEquals("999 MB", format.format(999L * 1000L * 1000L, ScaleUnit.MEGABYTE));
- assertEquals("1.0 GB", format.format(999L * 1000L * 1000L, ScaleUnit.GIGABYTE));
-
- assertEquals("1.0 GB", format.format(1000L * 1000L * 1000L));
- assertEquals("1000000000 B", format.format(1000L * 1000L * 1000L, ScaleUnit.BYTE));
- assertEquals("1000000 kB", format.format(1000L * 1000L * 1000L, ScaleUnit.KILOBYTE));
- assertEquals("1000 MB", format.format(1000L * 1000L * 1000L, ScaleUnit.MEGABYTE));
- assertEquals("1.0 GB", format.format(1000L * 1000L * 1000L, ScaleUnit.GIGABYTE));
+ assertThat(format.format(0L)).isEqualTo("0 B");
+ assertThat(format.format(0L, ScaleUnit.BYTE)).isEqualTo("0 B");
+ assertThat(format.format(0L, ScaleUnit.KILOBYTE)).isEqualTo("0 kB");
+ assertThat(format.format(0L, ScaleUnit.MEGABYTE)).isEqualTo("0 MB");
+ assertThat(format.format(0L, ScaleUnit.GIGABYTE)).isEqualTo("0 GB");
+
+ assertThat(format.format(5L)).isEqualTo("5 B");
+ assertThat(format.format(5L, ScaleUnit.BYTE)).isEqualTo("5 B");
+ assertThat(format.format(5L, ScaleUnit.KILOBYTE)).isEqualTo("0 kB");
+ assertThat(format.format(5L, ScaleUnit.MEGABYTE)).isEqualTo("0 MB");
+ assertThat(format.format(5L, ScaleUnit.GIGABYTE)).isEqualTo("0 GB");
+
+ assertThat(format.format(49L)).isEqualTo("49 B");
+ assertThat(format.format(49L, ScaleUnit.BYTE)).isEqualTo("49 B");
+ assertThat(format.format(49L, ScaleUnit.KILOBYTE)).isEqualTo("0 kB");
+ assertThat(format.format(49L, ScaleUnit.MEGABYTE)).isEqualTo("0 MB");
+ assertThat(format.format(49L, ScaleUnit.GIGABYTE)).isEqualTo("0 GB");
+
+ assertThat(format.format(50L)).isEqualTo("50 B");
+ assertThat(format.format(50L, ScaleUnit.BYTE)).isEqualTo("50 B");
+ assertThat(format.format(50L, ScaleUnit.KILOBYTE)).isEqualTo("0.1 kB");
+ assertThat(format.format(50L, ScaleUnit.MEGABYTE)).isEqualTo("0 MB");
+ assertThat(format.format(50L, ScaleUnit.GIGABYTE)).isEqualTo("0 GB");
+
+ assertThat(format.format(999L)).isEqualTo("999 B");
+ assertThat(format.format(999L, ScaleUnit.BYTE)).isEqualTo("999 B");
+ assertThat(format.format(999L, ScaleUnit.KILOBYTE)).isEqualTo("1.0 kB");
+ assertThat(format.format(999L, ScaleUnit.MEGABYTE)).isEqualTo("0 MB");
+ assertThat(format.format(999L, ScaleUnit.GIGABYTE)).isEqualTo("0 GB");
+
+ assertThat(format.format(1000L)).isEqualTo("1.0 kB");
+ assertThat(format.format(1000L, ScaleUnit.BYTE)).isEqualTo("1000 B");
+ assertThat(format.format(1000L, ScaleUnit.KILOBYTE)).isEqualTo("1.0 kB");
+ assertThat(format.format(1000L, ScaleUnit.MEGABYTE)).isEqualTo("0 MB");
+ assertThat(format.format(1000L, ScaleUnit.GIGABYTE)).isEqualTo("0 GB");
+
+ assertThat(format.format(49L * 1000L)).isEqualTo("49 kB");
+ assertThat(format.format(49L * 1000L, ScaleUnit.BYTE)).isEqualTo("49000 B");
+ assertThat(format.format(49L * 1000L, ScaleUnit.KILOBYTE)).isEqualTo("49 kB");
+ assertThat(format.format(49L * 1000L, ScaleUnit.MEGABYTE)).isEqualTo("0 MB");
+ assertThat(format.format(49L * 1000L, ScaleUnit.GIGABYTE)).isEqualTo("0 GB");
+
+ assertThat(format.format(50L * 1000L)).isEqualTo("50 kB");
+ assertThat(format.format(50L * 1000L, ScaleUnit.BYTE)).isEqualTo("50000 B");
+ assertThat(format.format(50L * 1000L, ScaleUnit.KILOBYTE)).isEqualTo("50 kB");
+ assertThat(format.format(50L * 1000L, ScaleUnit.MEGABYTE)).isEqualTo("0.1 MB");
+ assertThat(format.format(50L * 1000L, ScaleUnit.GIGABYTE)).isEqualTo("0 GB");
+
+ assertThat(format.format(999L * 1000L)).isEqualTo("999 kB");
+ assertThat(format.format(999L * 1000L, ScaleUnit.BYTE)).isEqualTo("999000 B");
+ assertThat(format.format(999L * 1000L, ScaleUnit.KILOBYTE)).isEqualTo("999 kB");
+ assertThat(format.format(999L * 1000L, ScaleUnit.MEGABYTE)).isEqualTo("1.0 MB");
+ assertThat(format.format(999L * 1000L, ScaleUnit.GIGABYTE)).isEqualTo("0 GB");
+
+ assertThat(format.format(1000L * 1000L)).isEqualTo("1.0 MB");
+ assertThat(format.format(1000L * 1000L, ScaleUnit.BYTE)).isEqualTo("1000000 B");
+ assertThat(format.format(1000L * 1000L, ScaleUnit.KILOBYTE)).isEqualTo("1000 kB");
+ assertThat(format.format(1000L * 1000L, ScaleUnit.MEGABYTE)).isEqualTo("1.0 MB");
+ assertThat(format.format(1000L * 1000L, ScaleUnit.GIGABYTE)).isEqualTo("0 GB");
+
+ assertThat(format.format(49L * 1000L * 1000L)).isEqualTo("49 MB");
+ assertThat(format.format(49L * 1000L * 1000L, ScaleUnit.BYTE)).isEqualTo("49000000 B");
+ assertThat(format.format(49L * 1000L * 1000L, ScaleUnit.KILOBYTE)).isEqualTo("49000 kB");
+ assertThat(format.format(49L * 1000L * 1000L, ScaleUnit.MEGABYTE)).isEqualTo("49 MB");
+ assertThat(format.format(49L * 1000L * 1000L, ScaleUnit.GIGABYTE)).isEqualTo("0 GB");
+
+ assertThat(format.format(50L * 1000L * 1000L)).isEqualTo("50 MB");
+ assertThat(format.format(50L * 1000L * 1000L, ScaleUnit.BYTE)).isEqualTo("50000000 B");
+ assertThat(format.format(50L * 1000L * 1000L, ScaleUnit.KILOBYTE)).isEqualTo("50000 kB");
+ assertThat(format.format(50L * 1000L * 1000L, ScaleUnit.MEGABYTE)).isEqualTo("50 MB");
+ assertThat(format.format(50L * 1000L * 1000L, ScaleUnit.GIGABYTE)).isEqualTo("0.1 GB");
+
+ assertThat(format.format(999L * 1000L * 1000L)).isEqualTo("999 MB");
+ assertThat(format.format(999L * 1000L * 1000L, ScaleUnit.BYTE)).isEqualTo("999000000 B");
+ assertThat(format.format(999L * 1000L * 1000L, ScaleUnit.KILOBYTE)).isEqualTo("999000 kB");
+ assertThat(format.format(999L * 1000L * 1000L, ScaleUnit.MEGABYTE)).isEqualTo("999 MB");
+ assertThat(format.format(999L * 1000L * 1000L, ScaleUnit.GIGABYTE)).isEqualTo("1.0 GB");
+
+ assertThat(format.format(1000L * 1000L * 1000L)).isEqualTo("1.0 GB");
+ assertThat(format.format(1000L * 1000L * 1000L, ScaleUnit.BYTE)).isEqualTo("1000000000 B");
+ assertThat(format.format(1000L * 1000L * 1000L, ScaleUnit.KILOBYTE)).isEqualTo("1000000 kB");
+ assertThat(format.format(1000L * 1000L * 1000L, ScaleUnit.MEGABYTE)).isEqualTo("1000 MB");
+ assertThat(format.format(1000L * 1000L * 1000L, ScaleUnit.GIGABYTE)).isEqualTo("1.0 GB");
}
@Test
- void testNegativeProgressedSize() {
+ void negativeProgressedSize() {
FileSizeFormat format = new FileSizeFormat();
long negativeProgressedSize = -100L;
- assertThrows(IllegalArgumentException.class, () -> format.formatProgress(negativeProgressedSize, 10L));
+ assertThatExceptionOfType(IllegalArgumentException.class).isThrownBy(() -> format.formatProgress(negativeProgressedSize, 10L));
}
@Test
- void testNegativeProgressedSizeBiggerThanSize() {
+ void negativeProgressedSizeBiggerThanSize() {
FileSizeFormat format = new FileSizeFormat();
- assertThrows(IllegalArgumentException.class, () -> format.formatProgress(100L, 10L));
+ assertThatExceptionOfType(IllegalArgumentException.class).isThrownBy(() -> format.formatProgress(100L, 10L));
}
@Test
- void testProgressedSizeWithoutSize() {
+ void progressedSizeWithoutSize() {
FileSizeFormat format = new FileSizeFormat();
- assertEquals("0 B", format.formatProgress(0L, -1L));
- assertEquals("1.0 kB", format.formatProgress(1000L, -1L));
- assertEquals("1.0 MB", format.formatProgress(1000L * 1000L, -1L));
- assertEquals("1.0 GB", format.formatProgress(1000L * 1000L * 1000L, -1L));
+ assertThat(format.formatProgress(0L, -1L)).isEqualTo("0 B");
+ assertThat(format.formatProgress(1000L, -1L)).isEqualTo("1.0 kB");
+ assertThat(format.formatProgress(1000L * 1000L, -1L)).isEqualTo("1.0 MB");
+ assertThat(format.formatProgress(1000L * 1000L * 1000L, -1L)).isEqualTo("1.0 GB");
}
@Test
- void testProgressedBothZero() {
+ void progressedBothZero() {
FileSizeFormat format = new FileSizeFormat();
- assertEquals("0 B", format.formatProgress(0L, 0L));
+ assertThat(format.formatProgress(0L, 0L)).isEqualTo("0 B");
}
@Test
- void testProgressedSizeWithSize() {
+ void progressedSizeWithSize() {
FileSizeFormat format = new FileSizeFormat();
- assertEquals("0/800 B", format.formatProgress(0L, 800L));
- assertEquals("400/800 B", format.formatProgress(400L, 800L));
- assertEquals("800 B", format.formatProgress(800L, 800L));
-
- assertEquals("0/8.0 kB", format.formatProgress(0L, 8000L));
- assertEquals("0.4/8.0 kB", format.formatProgress(400L, 8000L));
- assertEquals("4.0/8.0 kB", format.formatProgress(4000L, 8000L));
- assertEquals("8.0 kB", format.formatProgress(8000L, 8000L));
- assertEquals("8.0/50 kB", format.formatProgress(8000L, 50000L));
- assertEquals("16/50 kB", format.formatProgress(16000L, 50000L));
- assertEquals("50 kB", format.formatProgress(50000L, 50000L));
-
- assertEquals("0/5.0 MB", format.formatProgress(0L, 5000000L));
- assertEquals("0.5/5.0 MB", format.formatProgress(500000L, 5000000L));
- assertEquals("1.0/5.0 MB", format.formatProgress(1000000L, 5000000L));
- assertEquals("5.0 MB", format.formatProgress(5000000L, 5000000L));
- assertEquals("5.0/15 MB", format.formatProgress(5000000L, 15000000L));
- assertEquals("15 MB", format.formatProgress(15000000L, 15000000L));
-
- assertEquals("0/500 MB", format.formatProgress(0L, 500000000L));
- assertEquals("1.0/5.0 GB", format.formatProgress(1000000000L, 5000000000L));
- assertEquals("5.0 GB", format.formatProgress(5000000000L, 5000000000L));
- assertEquals("5.0/15 GB", format.formatProgress(5000000000L, 15000000000L));
- assertEquals("15 GB", format.formatProgress(15000000000L, 15000000000L));
+ assertThat(format.formatProgress(0L, 800L)).isEqualTo("0/800 B");
+ assertThat(format.formatProgress(400L, 800L)).isEqualTo("400/800 B");
+ assertThat(format.formatProgress(800L, 800L)).isEqualTo("800 B");
+
+ assertThat(format.formatProgress(0L, 8000L)).isEqualTo("0/8.0 kB");
+ assertThat(format.formatProgress(400L, 8000L)).isEqualTo("0.4/8.0 kB");
+ assertThat(format.formatProgress(4000L, 8000L)).isEqualTo("4.0/8.0 kB");
+ assertThat(format.formatProgress(8000L, 8000L)).isEqualTo("8.0 kB");
+ assertThat(format.formatProgress(8000L, 50000L)).isEqualTo("8.0/50 kB");
+ assertThat(format.formatProgress(16000L, 50000L)).isEqualTo("16/50 kB");
+ assertThat(format.formatProgress(50000L, 50000L)).isEqualTo("50 kB");
+
+ assertThat(format.formatProgress(0L, 5000000L)).isEqualTo("0/5.0 MB");
+ assertThat(format.formatProgress(500000L, 5000000L)).isEqualTo("0.5/5.0 MB");
+ assertThat(format.formatProgress(1000000L, 5000000L)).isEqualTo("1.0/5.0 MB");
+ assertThat(format.formatProgress(5000000L, 5000000L)).isEqualTo("5.0 MB");
+ assertThat(format.formatProgress(5000000L, 15000000L)).isEqualTo("5.0/15 MB");
+ assertThat(format.formatProgress(15000000L, 15000000L)).isEqualTo("15 MB");
+
+ assertThat(format.formatProgress(0L, 500000000L)).isEqualTo("0/500 MB");
+ assertThat(format.formatProgress(1000000000L, 5000000000L)).isEqualTo("1.0/5.0 GB");
+ assertThat(format.formatProgress(5000000000L, 5000000000L)).isEqualTo("5.0 GB");
+ assertThat(format.formatProgress(5000000000L, 15000000000L)).isEqualTo("5.0/15 GB");
+ assertThat(format.formatProgress(15000000000L, 15000000000L)).isEqualTo("15 GB");
}
}
diff --git a/compat/maven-embedder/src/test/java/org/apache/maven/cli/transfer/SimplexTransferListenerTest.java b/compat/maven-embedder/src/test/java/org/apache/maven/cli/transfer/SimplexTransferListenerTest.java
index 4484be95e9aa..1b3c441af701 100644
--- a/compat/maven-embedder/src/test/java/org/apache/maven/cli/transfer/SimplexTransferListenerTest.java
+++ b/compat/maven-embedder/src/test/java/org/apache/maven/cli/transfer/SimplexTransferListenerTest.java
@@ -29,7 +29,7 @@
import org.junit.jupiter.api.Test;
import org.mockito.Mockito;
-import static org.junit.jupiter.api.Assertions.assertThrows;
+import static org.assertj.core.api.AssertionsForClassTypes.assertThatExceptionOfType;
@Deprecated
class SimplexTransferListenerTest {
@@ -75,9 +75,7 @@ public void transferFailed(TransferEvent event) {}
Thread.sleep(500); // to make sure queue is processed, cancellation applied
// subsequent call will cancel
- assertThrows(
- TransferCancelledException.class,
- () -> listener.transferStarted(event(session, resource, TransferEvent.EventType.STARTED)));
+ assertThatExceptionOfType(TransferCancelledException.class).isThrownBy(() -> listener.transferStarted(event(session, resource, TransferEvent.EventType.STARTED)));
}
@Test
diff --git a/compat/maven-model-builder/src/test/java/org/apache/maven/model/building/ComplexActivationTest.java b/compat/maven-model-builder/src/test/java/org/apache/maven/model/building/ComplexActivationTest.java
index da43f0ca33d5..cccd192253cc 100644
--- a/compat/maven-model-builder/src/test/java/org/apache/maven/model/building/ComplexActivationTest.java
+++ b/compat/maven-model-builder/src/test/java/org/apache/maven/model/building/ComplexActivationTest.java
@@ -23,9 +23,7 @@
import org.junit.jupiter.api.Test;
-import static org.junit.jupiter.api.Assertions.assertEquals;
-import static org.junit.jupiter.api.Assertions.assertNotNull;
-import static org.junit.jupiter.api.Assertions.assertNull;
+import static org.assertj.core.api.Assertions.assertThat;
/**
*/
@@ -37,12 +35,12 @@ private File getPom(String name) {
}
@Test
- void testAndConditionInActivation() throws Exception {
+ void andConditionInActivation() throws Exception {
Properties sysProperties = new Properties();
sysProperties.setProperty("myproperty", "test");
ModelBuilder builder = new DefaultModelBuilderFactory().newInstance();
- assertNotNull(builder);
+ assertThat(builder).isNotNull();
DefaultModelBuildingRequest request = new DefaultModelBuildingRequest();
request.setProcessPlugins(true);
@@ -50,9 +48,9 @@ void testAndConditionInActivation() throws Exception {
request.setSystemProperties(sysProperties);
ModelBuildingResult result = builder.build(request);
- assertNotNull(result);
- assertNotNull(result.getEffectiveModel());
- assertEquals("activated-1", result.getEffectiveModel().getProperties().get("profile.file"));
- assertNull(result.getEffectiveModel().getProperties().get("profile.miss"));
+ assertThat(result).isNotNull();
+ assertThat(result.getEffectiveModel()).isNotNull();
+ assertThat(result.getEffectiveModel().getProperties().get("profile.file")).isEqualTo("activated-1");
+ assertThat(result.getEffectiveModel().getProperties().get("profile.miss")).isNull();
}
}
diff --git a/compat/maven-model-builder/src/test/java/org/apache/maven/model/building/DefaultModelBuilderFactoryTest.java b/compat/maven-model-builder/src/test/java/org/apache/maven/model/building/DefaultModelBuilderFactoryTest.java
index ecb73cc02955..c0eb8f152755 100644
--- a/compat/maven-model-builder/src/test/java/org/apache/maven/model/building/DefaultModelBuilderFactoryTest.java
+++ b/compat/maven-model-builder/src/test/java/org/apache/maven/model/building/DefaultModelBuilderFactoryTest.java
@@ -28,9 +28,7 @@
import org.codehaus.plexus.util.xml.Xpp3Dom;
import org.junit.jupiter.api.Test;
-import static org.junit.jupiter.api.Assertions.assertEquals;
-import static org.junit.jupiter.api.Assertions.assertNotNull;
-import static org.junit.jupiter.api.Assertions.assertTrue;
+import static org.assertj.core.api.Assertions.assertThat;
/**
*/
@@ -45,29 +43,29 @@ private File getPom(String name) {
}
@Test
- void testCompleteWiring() throws Exception {
+ void completeWiring() throws Exception {
ModelBuilder builder = new DefaultModelBuilderFactory().newInstance();
- assertNotNull(builder);
+ assertThat(builder).isNotNull();
DefaultModelBuildingRequest request = new DefaultModelBuildingRequest();
request.setProcessPlugins(true);
request.setPomFile(getPom("simple"));
ModelBuildingResult result = builder.build(request);
- assertNotNull(result);
- assertNotNull(result.getEffectiveModel());
- assertEquals("activated", result.getEffectiveModel().getProperties().get("profile.file"));
+ assertThat(result).isNotNull();
+ assertThat(result.getEffectiveModel()).isNotNull();
+ assertThat(result.getEffectiveModel().getProperties().get("profile.file")).isEqualTo("activated");
Xpp3Dom conf = (Xpp3Dom)
result.getEffectiveModel().getBuild().getPlugins().get(0).getConfiguration();
- assertNotNull(conf);
- assertEquals("1.5", conf.getChild("source").getValue());
- assertEquals(" 1.5 ", conf.getChild("target").getValue());
+ assertThat(conf).isNotNull();
+ assertThat(conf.getChild("source").getValue()).isEqualTo("1.5");
+ assertThat(conf.getChild("target").getValue()).isEqualTo(" 1.5 ");
}
@Test
- void testPomChanges() throws Exception {
+ void pomChanges() throws Exception {
ModelBuilder builder = new DefaultModelBuilderFactory().newInstance();
- assertNotNull(builder);
+ assertThat(builder).isNotNull();
File pom = getPom("simple");
String originalExists =
@@ -84,14 +82,14 @@ void testPomChanges() throws Exception {
.getFile()
.getExists();
- assertEquals(originalExists, resultExists);
- assertTrue(result.getEffectiveModel()
+ assertThat(resultExists).isEqualTo(originalExists);
+ assertThat(result.getEffectiveModel()
.getProfiles()
.get(1)
.getActivation()
.getFile()
.getExists()
- .contains(BASE_DIR));
+ .contains(BASE_DIR)).isTrue();
}
private static Model readPom(File file) throws Exception {
diff --git a/compat/maven-model-builder/src/test/java/org/apache/maven/model/building/DefaultModelBuilderTest.java b/compat/maven-model-builder/src/test/java/org/apache/maven/model/building/DefaultModelBuilderTest.java
index 92b45cf465b5..f29977f63bb7 100644
--- a/compat/maven-model-builder/src/test/java/org/apache/maven/model/building/DefaultModelBuilderTest.java
+++ b/compat/maven-model-builder/src/test/java/org/apache/maven/model/building/DefaultModelBuilderTest.java
@@ -26,13 +26,13 @@
import org.apache.maven.model.resolution.UnresolvableModelException;
import org.junit.jupiter.api.Test;
-import static org.junit.jupiter.api.Assertions.assertNotNull;
-import static org.junit.jupiter.api.Assertions.assertThrows;
+import static org.assertj.core.api.Assertions.assertThat;
+import static org.assertj.core.api.AssertionsForClassTypes.assertThatExceptionOfType;
/**
*/
@Deprecated
-public class DefaultModelBuilderTest {
+class DefaultModelBuilderTest {
private static final String BASE1_ID = "thegroup:base1:pom";
private static final String BASE1_ID2 = "thegroup:base1:1";
@@ -77,15 +77,15 @@ public class DefaultModelBuilderTest {
+ "\n";
@Test
- public void testCycleInImports() throws Exception {
+ void cycleInImports() throws Exception {
ModelBuilder builder = new DefaultModelBuilderFactory().newInstance();
- assertNotNull(builder);
+ assertThat(builder).isNotNull();
DefaultModelBuildingRequest request = new DefaultModelBuildingRequest();
request.setModelSource(new StringModelSource(BASE1));
request.setModelResolver(new CycleInImportsResolver());
- assertThrows(ModelBuildingException.class, () -> builder.build(request));
+ assertThatExceptionOfType(ModelBuildingException.class).isThrownBy(() -> builder.build(request));
}
static class CycleInImportsResolver extends BaseModelResolver {
diff --git a/compat/maven-model-builder/src/test/java/org/apache/maven/model/building/FileModelSourceTest.java b/compat/maven-model-builder/src/test/java/org/apache/maven/model/building/FileModelSourceTest.java
index a03184de6b83..d2d28d70f92e 100644
--- a/compat/maven-model-builder/src/test/java/org/apache/maven/model/building/FileModelSourceTest.java
+++ b/compat/maven-model-builder/src/test/java/org/apache/maven/model/building/FileModelSourceTest.java
@@ -24,8 +24,7 @@
import org.codehaus.plexus.util.Os;
import org.junit.jupiter.api.Test;
-import static org.junit.jupiter.api.Assertions.assertFalse;
-import static org.junit.jupiter.api.Assertions.assertTrue;
+import static org.assertj.core.api.Assertions.assertThat;
import static org.junit.jupiter.api.Assumptions.assumeTrue;
/**
@@ -39,18 +38,18 @@ class FileModelSourceTest {
* Test of equals method, of class FileModelSource.
*/
@Test
- void testEquals() throws Exception {
+ void equals() throws Exception {
File tempFile = createTempFile("pomTest");
FileModelSource instance = new FileModelSource(tempFile);
- assertFalse(instance.equals(null));
- assertFalse(instance.equals(new Object()));
- assertTrue(instance.equals(instance));
- assertTrue(instance.equals(new FileModelSource(tempFile)));
+ assertThat(instance).isNotEqualTo(null);
+ assertThat(new Object()).isNotEqualTo(instance);
+ assertThat(instance).isEqualTo(instance);
+ assertThat(new FileModelSource(tempFile)).isEqualTo(instance);
}
@Test
- void testWindowsPaths() throws Exception {
+ void windowsPaths() throws Exception {
assumeTrue(Os.isFamily("Windows"));
File upperCaseFile = createTempFile("TESTE");
@@ -60,7 +59,7 @@ void testWindowsPaths() throws Exception {
FileModelSource upperCaseFileSource = new FileModelSource(upperCaseFile);
FileModelSource lowerCaseFileSource = new FileModelSource(lowerCaseFile);
- assertTrue(upperCaseFileSource.equals(lowerCaseFileSource));
+ assertThat(lowerCaseFileSource).isEqualTo(upperCaseFileSource);
}
private File createTempFile(String name) throws IOException {
diff --git a/compat/maven-model-builder/src/test/java/org/apache/maven/model/building/FileToRawModelMergerTest.java b/compat/maven-model-builder/src/test/java/org/apache/maven/model/building/FileToRawModelMergerTest.java
index e5ad5b01d348..3229962b9c89 100644
--- a/compat/maven-model-builder/src/test/java/org/apache/maven/model/building/FileToRawModelMergerTest.java
+++ b/compat/maven-model-builder/src/test/java/org/apache/maven/model/building/FileToRawModelMergerTest.java
@@ -38,7 +38,7 @@ class FileToRawModelMergerTest {
* Ensures that all list-merge methods are overridden
*/
@Test
- void testOverriddenMergeMethods() {
+ void overriddenMergeMethods() {
List methodNames = Stream.of(MavenMerger.class.getDeclaredMethods())
.filter(m -> m.getName().startsWith("merge"))
.filter(m -> {
diff --git a/compat/maven-model-builder/src/test/java/org/apache/maven/model/building/GraphTest.java b/compat/maven-model-builder/src/test/java/org/apache/maven/model/building/GraphTest.java
index 6b5178ac2714..58ff1518b922 100644
--- a/compat/maven-model-builder/src/test/java/org/apache/maven/model/building/GraphTest.java
+++ b/compat/maven-model-builder/src/test/java/org/apache/maven/model/building/GraphTest.java
@@ -27,20 +27,20 @@
import org.junit.jupiter.api.Test;
-import static org.junit.jupiter.api.Assertions.assertThrows;
+import static org.assertj.core.api.AssertionsForClassTypes.assertThatExceptionOfType;
@Deprecated
-public class GraphTest {
+class GraphTest {
@Test
- void testCycle() throws Graph.CycleDetectedException {
+ void cycle() throws Graph.CycleDetectedException {
Graph graph = new Graph();
graph.addEdge("a1", "a2");
- assertThrows(Graph.CycleDetectedException.class, () -> graph.addEdge("a2", "a1"));
+ assertThatExceptionOfType(Graph.CycleDetectedException.class).isThrownBy(() -> graph.addEdge("a2", "a1"));
}
@Test
- public void testPerf() throws IOException {
+ void perf() throws IOException {
List data = new ArrayList<>();
String k = null;
for (String line : Files.readAllLines(Paths.get("src/test/resources/dag.txt"))) {
diff --git a/compat/maven-model-builder/src/test/java/org/apache/maven/model/inheritance/DefaultInheritanceAssemblerTest.java b/compat/maven-model-builder/src/test/java/org/apache/maven/model/inheritance/DefaultInheritanceAssemblerTest.java
index 72d742a13664..30c8b18589bc 100644
--- a/compat/maven-model-builder/src/test/java/org/apache/maven/model/inheritance/DefaultInheritanceAssemblerTest.java
+++ b/compat/maven-model-builder/src/test/java/org/apache/maven/model/inheritance/DefaultInheritanceAssemblerTest.java
@@ -30,9 +30,9 @@
import org.junit.jupiter.api.Test;
import org.xmlunit.matchers.CompareMatcher;
+import static org.assertj.core.api.Assertions.assertThat;
+import static org.assertj.core.api.AssertionsForClassTypes.assertThatExceptionOfType;
import static org.hamcrest.MatcherAssert.assertThat;
-import static org.junit.jupiter.api.Assertions.assertThrows;
-import static org.junit.jupiter.api.Assertions.assertTrue;
/**
*/
@@ -60,7 +60,7 @@ private Model getModel(String name) throws IOException {
}
@Test
- void testPluginConfiguration() throws Exception {
+ void pluginConfiguration() throws Exception {
testInheritance("plugin-configuration");
}
@@ -70,7 +70,7 @@ void testPluginConfiguration() throws Exception {
* @throws IOException Model read problem
*/
@Test
- void testUrls() throws Exception {
+ void urls() throws Exception {
testInheritance("urls");
}
@@ -79,7 +79,7 @@ void testUrls() throws Exception {
* @throws IOException Model read problem
*/
@Test
- void testFlatUrls() throws IOException {
+ void flatUrls() throws IOException {
testInheritance("flat-urls");
}
@@ -88,7 +88,7 @@ void testFlatUrls() throws IOException {
* @throws Exception
*/
@Test
- void testNoAppendUrls() throws Exception {
+ void noAppendUrls() throws Exception {
testInheritance("no-append-urls");
}
@@ -97,7 +97,7 @@ void testNoAppendUrls() throws Exception {
* @throws Exception
*/
@Test
- void testNoAppendUrls2() throws Exception {
+ void noAppendUrls2() throws Exception {
testInheritance("no-append-urls2");
}
@@ -106,7 +106,7 @@ void testNoAppendUrls2() throws Exception {
* @throws Exception
*/
@Test
- void testNoAppendUrls3() throws Exception {
+ void noAppendUrls3() throws Exception {
testInheritance("no-append-urls3");
}
@@ -117,7 +117,7 @@ void testNoAppendUrls3() throws Exception {
* @throws IOException Model read problem
*/
@Test
- void testFlatTrickyUrls() throws IOException {
+ void flatTrickyUrls() throws IOException {
// parent references child with artifactId (which is not directory name)
// then relative path calculation will fail during build from disk but success when calculated from repo
try {
@@ -126,12 +126,10 @@ void testFlatTrickyUrls() throws IOException {
// fail( "should have failed since module reference == artifactId != directory name" );
} catch (AssertionError afe) {
// expected failure: wrong relative path calculation
- assertTrue(
- afe.getMessage()
- .contains(
- "Expected text value 'http://www.apache.org/path/to/parent/child-artifact-id/' but was "
- + "'http://www.apache.org/path/to/parent/../child-artifact-id/'"),
- afe.getMessage());
+ assertThat(afe.getMessage()
+ .contains(
+ "Expected text value 'http://www.apache.org/path/to/parent/child-artifact-id/' but was "
+ + "'http://www.apache.org/path/to/parent/../child-artifact-id/'")).as(afe.getMessage()).isTrue();
}
// but ok from repo: local disk is ignored
testInheritance("tricky-flat-artifactId-urls", true);
@@ -140,21 +138,16 @@ void testFlatTrickyUrls() throws IOException {
// then relative path calculation will success during build from disk but fail when calculated from repo
testInheritance("tricky-flat-directory-urls", false);
- AssertionError afe = assertThrows(
- AssertionError.class,
- () -> testInheritance("tricky-flat-directory-urls", true),
- "should have failed since module reference == directory name != artifactId");
+ AssertionError afe = assertThatExceptionOfType(AssertionError.class).as("should have failed since module reference == directory name != artifactId").isThrownBy(() -> testInheritance("tricky-flat-directory-urls", true)).actual();
// expected failure
- assertTrue(
- afe.getMessage()
- .contains(
- "Expected text value 'http://www.apache.org/path/to/parent/../child-artifact-id/' but was "
- + "'http://www.apache.org/path/to/parent/child-artifact-id/'"),
- afe.getMessage());
+ assertThat(afe.getMessage()
+ .contains(
+ "Expected text value 'http://www.apache.org/path/to/parent/../child-artifact-id/' but was "
+ + "'http://www.apache.org/path/to/parent/child-artifact-id/'")).as(afe.getMessage()).isTrue();
}
@Test
- void testWithEmptyUrl() throws IOException {
+ void withEmptyUrl() throws IOException {
testInheritance("empty-urls", false);
}
@@ -195,7 +188,7 @@ public void testInheritance(String baseName, boolean fromRepo) throws IOExceptio
}
@Test
- void testModulePathNotArtifactId() throws IOException {
+ void modulePathNotArtifactId() throws IOException {
Model parent = getModel("module-path-not-artifactId-parent");
Model child = getModel("module-path-not-artifactId-child");
diff --git a/compat/maven-model-builder/src/test/java/org/apache/maven/model/interpolation/AbstractModelInterpolatorTest.java b/compat/maven-model-builder/src/test/java/org/apache/maven/model/interpolation/AbstractModelInterpolatorTest.java
index 6d0fa698f193..7c272802273f 100644
--- a/compat/maven-model-builder/src/test/java/org/apache/maven/model/interpolation/AbstractModelInterpolatorTest.java
+++ b/compat/maven-model-builder/src/test/java/org/apache/maven/model/interpolation/AbstractModelInterpolatorTest.java
@@ -39,9 +39,7 @@
import org.junit.jupiter.api.BeforeEach;
import org.junit.jupiter.api.Test;
-import static org.junit.jupiter.api.Assertions.assertEquals;
-import static org.junit.jupiter.api.Assertions.assertNotNull;
-import static org.junit.jupiter.api.Assertions.assertTrue;
+import static org.assertj.core.api.Assertions.assertThat;
/**
*/
@@ -57,17 +55,17 @@ public void setUp() {
}
protected void assertProblemFree(SimpleProblemCollector collector) {
- assertEquals(0, collector.getErrors().size(), "Expected no errors");
- assertEquals(0, collector.getWarnings().size(), "Expected no warnings");
- assertEquals(0, collector.getFatals().size(), "Expected no fatals");
+ assertThat(collector.getErrors().size()).as("Expected no errors").isEqualTo(0);
+ assertThat(collector.getWarnings().size()).as("Expected no warnings").isEqualTo(0);
+ assertThat(collector.getFatals().size()).as("Expected no fatals").isEqualTo(0);
}
@SuppressWarnings("SameParameterValue")
protected void assertCollectorState(
int numFatals, int numErrors, int numWarnings, SimpleProblemCollector collector) {
- assertEquals(numErrors, collector.getErrors().size(), "Errors");
- assertEquals(numWarnings, collector.getWarnings().size(), "Warnings");
- assertEquals(numFatals, collector.getFatals().size(), "Fatals");
+ assertThat(collector.getErrors().size()).as("Errors").isEqualTo(numErrors);
+ assertThat(collector.getWarnings().size()).as("Warnings").isEqualTo(numWarnings);
+ assertThat(collector.getFatals().size()).as("Fatals").isEqualTo(numFatals);
}
private ModelBuildingRequest createModelBuildingRequest(Properties p) {
@@ -79,7 +77,7 @@ private ModelBuildingRequest createModelBuildingRequest(Properties p) {
}
@Test
- public void testDefaultBuildTimestampFormatShouldFormatTimeIn24HourFormat() {
+ public void defaultBuildTimestampFormatShouldFormatTimeIn24HourFormat() {
Calendar cal = Calendar.getInstance();
cal.setTimeZone(MavenBuildTimestamp.DEFAULT_BUILD_TIME_ZONE);
cal.set(Calendar.HOUR, 12);
@@ -105,12 +103,12 @@ public void testDefaultBuildTimestampFormatShouldFormatTimeIn24HourFormat() {
SimpleDateFormat format = new SimpleDateFormat(MavenBuildTimestamp.DEFAULT_BUILD_TIMESTAMP_FORMAT);
format.setTimeZone(MavenBuildTimestamp.DEFAULT_BUILD_TIME_ZONE);
- assertEquals("1976-11-11T00:16:00Z", format.format(firstTestDate));
- assertEquals("1976-11-11T23:16:00Z", format.format(secondTestDate));
+ assertThat(format.format(firstTestDate)).isEqualTo("1976-11-11T00:16:00Z");
+ assertThat(format.format(secondTestDate)).isEqualTo("1976-11-11T23:16:00Z");
}
@Test
- public void testDefaultBuildTimestampFormatWithLocalTimeZoneMidnightRollover() {
+ public void defaultBuildTimestampFormatWithLocalTimeZoneMidnightRollover() {
Calendar cal = Calendar.getInstance();
cal.setTimeZone(TimeZone.getTimeZone("Europe/Berlin"));
@@ -129,12 +127,12 @@ public void testDefaultBuildTimestampFormatWithLocalTimeZoneMidnightRollover() {
SimpleDateFormat format = new SimpleDateFormat(MavenBuildTimestamp.DEFAULT_BUILD_TIMESTAMP_FORMAT);
format.setTimeZone(MavenBuildTimestamp.DEFAULT_BUILD_TIME_ZONE);
- assertEquals("2014-06-15T23:16:00Z", format.format(firstTestDate));
- assertEquals("2014-11-16T00:16:00Z", format.format(secondTestDate));
+ assertThat(format.format(firstTestDate)).isEqualTo("2014-06-15T23:16:00Z");
+ assertThat(format.format(secondTestDate)).isEqualTo("2014-11-16T00:16:00Z");
}
@Test
- public void testShouldNotThrowExceptionOnReferenceToNonExistentValue() throws Exception {
+ public void shouldNotThrowExceptionOnReferenceToNonExistentValue() throws Exception {
Model model = new Model(org.apache.maven.api.model.Model.newBuilder()
.scm(org.apache.maven.api.model.Scm.newBuilder()
.connection("${test}/somepath")
@@ -147,11 +145,11 @@ public void testShouldNotThrowExceptionOnReferenceToNonExistentValue() throws Ex
Model out = interpolator.interpolateModel(model, new File("."), createModelBuildingRequest(context), collector);
assertProblemFree(collector);
- assertEquals("${test}/somepath", out.getScm().getConnection());
+ assertThat(out.getScm().getConnection()).isEqualTo("${test}/somepath");
}
@Test
- public void testShouldThrowExceptionOnRecursiveScmConnectionReference() throws Exception {
+ public void shouldThrowExceptionOnRecursiveScmConnectionReference() throws Exception {
var model = new Model(org.apache.maven.api.model.Model.newBuilder()
.scm(org.apache.maven.api.model.Scm.newBuilder()
.connection("${project.scm.connection}/somepath")
@@ -166,7 +164,7 @@ public void testShouldThrowExceptionOnRecursiveScmConnectionReference() throws E
}
@Test
- public void testShouldNotThrowExceptionOnReferenceToValueContainingNakedExpression() throws Exception {
+ public void shouldNotThrowExceptionOnReferenceToValueContainingNakedExpression() throws Exception {
Map props = new HashMap<>();
props.put("test", "test");
Model model = new Model(org.apache.maven.api.model.Model.newBuilder()
@@ -183,7 +181,7 @@ public void testShouldNotThrowExceptionOnReferenceToValueContainingNakedExpressi
assertProblemFree(collector);
- assertEquals("test/somepath", out.getScm().getConnection());
+ assertThat(out.getScm().getConnection()).isEqualTo("test/somepath");
}
@Test
@@ -202,7 +200,7 @@ public void shouldInterpolateOrganizationNameCorrectly() throws Exception {
Model out = interpolator.interpolateModel(
model, new File("."), createModelBuildingRequest(context), new SimpleProblemCollector());
- assertEquals(orgName + " Tools", out.getName());
+ assertThat(out.getName()).isEqualTo(orgName + " Tools");
}
@Test
@@ -220,11 +218,11 @@ public void shouldInterpolateDependencyVersionToSetSameAsProjectVersion() throws
Model out = interpolator.interpolateModel(model, new File("."), createModelBuildingRequest(context), collector);
assertCollectorState(0, 0, 0, collector);
- assertEquals("3.8.1", (out.getDependencies().get(0)).getVersion());
+ assertThat((out.getDependencies().get(0)).getVersion()).isEqualTo("3.8.1");
}
@Test
- public void testShouldNotInterpolateDependencyVersionWithInvalidReference() throws Exception {
+ public void shouldNotInterpolateDependencyVersionWithInvalidReference() throws Exception {
Model model = new Model(org.apache.maven.api.model.Model.newBuilder()
.version("3.8.1")
.dependencies(Collections.singletonList(org.apache.maven.api.model.Dependency.newBuilder()
@@ -238,11 +236,11 @@ public void testShouldNotInterpolateDependencyVersionWithInvalidReference() thro
Model out = interpolator.interpolateModel(model, new File("."), createModelBuildingRequest(context), collector);
assertProblemFree(collector);
- assertEquals("${something}", (out.getDependencies().get(0)).getVersion());
+ assertThat((out.getDependencies().get(0)).getVersion()).isEqualTo("${something}");
}
@Test
- public void testTwoReferences() throws Exception {
+ public void twoReferences() throws Exception {
Model model = new Model(org.apache.maven.api.model.Model.newBuilder()
.version("3.8.1")
.artifactId("foo")
@@ -257,11 +255,11 @@ public void testTwoReferences() throws Exception {
Model out = interpolator.interpolateModel(model, new File("."), createModelBuildingRequest(context), collector);
assertCollectorState(0, 0, 0, collector);
- assertEquals("foo-3.8.1", (out.getDependencies().get(0)).getVersion());
+ assertThat((out.getDependencies().get(0)).getVersion()).isEqualTo("foo-3.8.1");
}
@Test
- public void testBasedir() throws Exception {
+ public void basedir() throws Exception {
Model model = new Model(org.apache.maven.api.model.Model.newBuilder()
.version("3.8.1")
.artifactId("foo")
@@ -276,12 +274,11 @@ public void testBasedir() throws Exception {
Model out = interpolator.interpolateModel(model, null, createModelBuildingRequest(context), collector);
assertProblemFree(collector);
- assertEquals(
- "file://localhost/myBasedir/temp-repo", (out.getRepositories().get(0)).getUrl());
+ assertThat((out.getRepositories().get(0)).getUrl()).isEqualTo("file://localhost/myBasedir/temp-repo");
}
@Test
- public void testBaseUri() throws Exception {
+ public void baseUri() throws Exception {
Model model = new Model(org.apache.maven.api.model.Model.newBuilder()
.version("3.8.1")
.artifactId("foo")
@@ -296,11 +293,11 @@ public void testBaseUri() throws Exception {
Model out = interpolator.interpolateModel(model, null, createModelBuildingRequest(context), collector);
assertProblemFree(collector);
- assertEquals("myBaseUri/temp-repo", (out.getRepositories().get(0)).getUrl());
+ assertThat((out.getRepositories().get(0)).getUrl()).isEqualTo("myBaseUri/temp-repo");
}
@Test
- public void testEnvars() throws Exception {
+ public void envars() throws Exception {
context.put("env.HOME", "/path/to/home");
Map modelProperties = new HashMap<>();
@@ -316,7 +313,7 @@ public void testEnvars() throws Exception {
Model out = interpolator.interpolateModel(model, new File("."), createModelBuildingRequest(context), collector);
assertProblemFree(collector);
- assertEquals("/path/to/home", out.getProperties().get("outputDirectory"));
+ assertThat(out.getProperties().get("outputDirectory")).isEqualTo("/path/to/home");
}
@Test
@@ -335,7 +332,7 @@ public void envarExpressionThatEvaluatesToNullReturnsTheLiteralString() throws E
Model out = interpolator.interpolateModel(model, new File("."), createModelBuildingRequest(context), collector);
assertProblemFree(collector);
- assertEquals("${env.DOES_NOT_EXIST}", out.getProperties().get("outputDirectory"));
+ assertThat(out.getProperties().get("outputDirectory")).isEqualTo("${env.DOES_NOT_EXIST}");
}
@Test
@@ -353,7 +350,7 @@ public void expressionThatEvaluatesToNullReturnsTheLiteralString() throws Except
Model out = interpolator.interpolateModel(model, new File("."), createModelBuildingRequest(context), collector);
assertProblemFree(collector);
- assertEquals("${DOES_NOT_EXIST}", out.getProperties().get("outputDirectory"));
+ assertThat(out.getProperties().get("outputDirectory")).isEqualTo("${DOES_NOT_EXIST}");
}
@Test
@@ -376,7 +373,7 @@ public void shouldInterpolateSourceDirectoryReferencedFromResourceDirectoryCorre
List outResources = out.getBuild().getResources();
Iterator resIt = outResources.iterator();
- assertEquals(model.getBuild().getSourceDirectory(), resIt.next().getDirectory());
+ assertThat(resIt.next().getDirectory()).isEqualTo(model.getBuild().getSourceDirectory());
}
@Test
@@ -395,15 +392,13 @@ public void shouldInterpolateUnprefixedBasedirExpression() throws Exception {
assertProblemFree(collector);
List rDeps = result.getDependencies();
- assertNotNull(rDeps);
- assertEquals(1, rDeps.size());
- assertEquals(
- new File(basedir, "artifact.jar").getAbsolutePath(),
- new File(rDeps.get(0).getSystemPath()).getAbsolutePath());
+ assertThat(rDeps).isNotNull();
+ assertThat(rDeps.size()).isEqualTo(1);
+ assertThat(new File(rDeps.get(0).getSystemPath()).getAbsolutePath()).isEqualTo(new File(basedir, "artifact.jar").getAbsolutePath());
}
@Test
- public void testRecursiveExpressionCycleNPE() throws Exception {
+ public void recursiveExpressionCycleNPE() throws Exception {
Map props = new HashMap<>();
props.put("aa", "${bb}");
props.put("bb", "${aa}");
@@ -417,11 +412,11 @@ public void testRecursiveExpressionCycleNPE() throws Exception {
interpolator.interpolateModel(model, null, request, collector);
assertCollectorState(0, 2, 0, collector);
- assertTrue(collector.getErrors().get(0).contains("Detected the following recursive expression cycle"));
+ assertThat(collector.getErrors().get(0).contains("Detected the following recursive expression cycle")).isTrue();
}
@Test
- public void testRecursiveExpressionCycleBaseDir() throws Exception {
+ public void recursiveExpressionCycleBaseDir() throws Exception {
Map props = new HashMap<>();
props.put("basedir", "${basedir}");
DefaultModelBuildingRequest request = new DefaultModelBuildingRequest();
@@ -434,9 +429,7 @@ public void testRecursiveExpressionCycleBaseDir() throws Exception {
interpolator.interpolateModel(model, null, request, collector);
assertCollectorState(0, 1, 0, collector);
- assertEquals(
- "Resolving expression: '${basedir}': Detected the following recursive expression cycle in 'basedir': [basedir]",
- collector.getErrors().get(0));
+ assertThat(collector.getErrors().get(0)).isEqualTo("Resolving expression: '${basedir}': Detected the following recursive expression cycle in 'basedir': [basedir]");
}
protected abstract ModelInterpolator createInterpolator() throws Exception;
diff --git a/compat/maven-model-builder/src/test/java/org/apache/maven/model/interpolation/MavenBuildTimestampTest.java b/compat/maven-model-builder/src/test/java/org/apache/maven/model/interpolation/MavenBuildTimestampTest.java
index cdc92814af8c..1416fcbd6806 100644
--- a/compat/maven-model-builder/src/test/java/org/apache/maven/model/interpolation/MavenBuildTimestampTest.java
+++ b/compat/maven-model-builder/src/test/java/org/apache/maven/model/interpolation/MavenBuildTimestampTest.java
@@ -23,16 +23,16 @@
import org.junit.jupiter.api.Test;
-import static org.junit.jupiter.api.Assertions.assertTrue;
+import static org.assertj.core.api.Assertions.assertThat;
@Deprecated
class MavenBuildTimestampTest {
@Test
- void testMavenBuildTimestampUsesUTC() {
+ void mavenBuildTimestampUsesUTC() {
Properties interpolationProperties = new Properties();
interpolationProperties.put("maven.build.timestamp.format", "yyyyMMdd'T'HHmm'Z'");
MavenBuildTimestamp timestamp = new MavenBuildTimestamp(new Date(), interpolationProperties);
String formattedTimestamp = timestamp.formattedTimestamp();
- assertTrue(formattedTimestamp.endsWith("Z"), "We expect the UTC marker at the end of the timestamp.");
+ assertThat(formattedTimestamp.endsWith("Z")).as("We expect the UTC marker at the end of the timestamp.").isTrue();
}
}
diff --git a/compat/maven-model-builder/src/test/java/org/apache/maven/model/interpolation/reflection/ReflectionValueExtractorTest.java b/compat/maven-model-builder/src/test/java/org/apache/maven/model/interpolation/reflection/ReflectionValueExtractorTest.java
index 861804ea841d..a4ece86ad957 100644
--- a/compat/maven-model-builder/src/test/java/org/apache/maven/model/interpolation/reflection/ReflectionValueExtractorTest.java
+++ b/compat/maven-model-builder/src/test/java/org/apache/maven/model/interpolation/reflection/ReflectionValueExtractorTest.java
@@ -42,15 +42,13 @@
import org.junit.jupiter.api.BeforeEach;
import org.junit.jupiter.api.Test;
-import static org.junit.jupiter.api.Assertions.assertEquals;
-import static org.junit.jupiter.api.Assertions.assertNotNull;
-import static org.junit.jupiter.api.Assertions.assertNull;
+import static org.assertj.core.api.Assertions.assertThat;
/**
* ReflectionValueExtractorTest class.
*/
@Deprecated
-public class ReflectionValueExtractorTest {
+class ReflectionValueExtractorTest {
private Project project;
/**
@@ -87,26 +85,26 @@ void setUp() {
* @throws Exception if any.
*/
@Test
- void testValueExtraction() throws Exception {
+ void valueExtraction() throws Exception {
// ----------------------------------------------------------------------
// Top level values
// ----------------------------------------------------------------------
- assertEquals("4.0.0", ReflectionValueExtractor.evaluate("project.modelVersion", project));
+ assertThat(ReflectionValueExtractor.evaluate("project.modelVersion", project)).isEqualTo("4.0.0");
- assertEquals("org.apache.maven", ReflectionValueExtractor.evaluate("project.groupId", project));
+ assertThat(ReflectionValueExtractor.evaluate("project.groupId", project)).isEqualTo("org.apache.maven");
- assertEquals("maven-core", ReflectionValueExtractor.evaluate("project.artifactId", project));
+ assertThat(ReflectionValueExtractor.evaluate("project.artifactId", project)).isEqualTo("maven-core");
- assertEquals("Maven", ReflectionValueExtractor.evaluate("project.name", project));
+ assertThat(ReflectionValueExtractor.evaluate("project.name", project)).isEqualTo("Maven");
- assertEquals("2.0-SNAPSHOT", ReflectionValueExtractor.evaluate("project.version", project));
+ assertThat(ReflectionValueExtractor.evaluate("project.version", project)).isEqualTo("2.0-SNAPSHOT");
// ----------------------------------------------------------------------
// SCM
// ----------------------------------------------------------------------
- assertEquals("scm-connection", ReflectionValueExtractor.evaluate("project.scm.connection", project));
+ assertThat(ReflectionValueExtractor.evaluate("project.scm.connection", project)).isEqualTo("scm-connection");
// ----------------------------------------------------------------------
// Dependencies
@@ -114,9 +112,9 @@ void testValueExtraction() throws Exception {
List> dependencies = (List) ReflectionValueExtractor.evaluate("project.dependencies", project);
- assertNotNull(dependencies);
+ assertThat(dependencies).isNotNull();
- assertEquals(2, dependencies.size());
+ assertThat(dependencies.size()).isEqualTo(2);
// ----------------------------------------------------------------------
// Dependencies - using index notation
@@ -125,37 +123,37 @@ void testValueExtraction() throws Exception {
// List
Dependency dependency = (Dependency) ReflectionValueExtractor.evaluate("project.dependencies[0]", project);
- assertNotNull(dependency);
+ assertThat(dependency).isNotNull();
- assertEquals("dep1", dependency.getArtifactId());
+ assertThat(dependency.getArtifactId()).isEqualTo("dep1");
String artifactId = (String) ReflectionValueExtractor.evaluate("project.dependencies[1].artifactId", project);
- assertEquals("dep2", artifactId);
+ assertThat(artifactId).isEqualTo("dep2");
// Array
dependency = (Dependency) ReflectionValueExtractor.evaluate("project.dependenciesAsArray[0]", project);
- assertNotNull(dependency);
+ assertThat(dependency).isNotNull();
- assertEquals("dep1", dependency.getArtifactId());
+ assertThat(dependency.getArtifactId()).isEqualTo("dep1");
artifactId = (String) ReflectionValueExtractor.evaluate("project.dependenciesAsArray[1].artifactId", project);
- assertEquals("dep2", artifactId);
+ assertThat(artifactId).isEqualTo("dep2");
// Map
dependency = (Dependency) ReflectionValueExtractor.evaluate("project.dependenciesAsMap(dep1)", project);
- assertNotNull(dependency);
+ assertThat(dependency).isNotNull();
- assertEquals("dep1", dependency.getArtifactId());
+ assertThat(dependency.getArtifactId()).isEqualTo("dep1");
artifactId = (String) ReflectionValueExtractor.evaluate("project.dependenciesAsMap(dep2).artifactId", project);
- assertEquals("dep2", artifactId);
+ assertThat(artifactId).isEqualTo("dep2");
// ----------------------------------------------------------------------
// Build
@@ -163,7 +161,7 @@ void testValueExtraction() throws Exception {
Build build = (Build) ReflectionValueExtractor.evaluate("project.build", project);
- assertNotNull(build);
+ assertThat(build).isNotNull();
}
/**
@@ -172,10 +170,10 @@ void testValueExtraction() throws Exception {
* @throws Exception if any.
*/
@Test
- public void testValueExtractorWithAInvalidExpression() throws Exception {
- assertNull(ReflectionValueExtractor.evaluate("project.foo", project));
- assertNull(ReflectionValueExtractor.evaluate("project.dependencies[10]", project));
- assertNull(ReflectionValueExtractor.evaluate("project.dependencies[0].foo", project));
+ void valueExtractorWithAInvalidExpression() throws Exception {
+ assertThat(ReflectionValueExtractor.evaluate("project.foo", project)).isNull();
+ assertThat(ReflectionValueExtractor.evaluate("project.dependencies[10]", project)).isNull();
+ assertThat(ReflectionValueExtractor.evaluate("project.dependencies[0].foo", project)).isNull();
}
/**
@@ -184,11 +182,11 @@ public void testValueExtractorWithAInvalidExpression() throws Exception {
* @throws Exception if any.
*/
@Test
- public void testMappedDottedKey() throws Exception {
+ void mappedDottedKey() throws Exception {
Map map = new HashMap();
map.put("a.b", "a.b-value");
- assertEquals("a.b-value", ReflectionValueExtractor.evaluate("h.value(a.b)", new ValueHolder(map)));
+ assertThat(ReflectionValueExtractor.evaluate("h.value(a.b)", new ValueHolder(map))).isEqualTo("a.b-value");
}
/**
@@ -197,13 +195,13 @@ public void testMappedDottedKey() throws Exception {
* @throws Exception if any.
*/
@Test
- public void testIndexedMapped() throws Exception {
+ void indexedMapped() throws Exception {
Map