-
Notifications
You must be signed in to change notification settings - Fork 2.8k
avoid false IO catch on mkdirs()
#2396
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
avoid false IO catch on mkdirs()
#2396
Conversation
mkdirs()IO catch on mkdirs()
|
is this any good? |
elharo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. Most comments are the same across the files
...aven-it-plugin-active-collection/src/main/java/org/apache/maven/plugin/coreit/CheckMojo.java
Show resolved
Hide resolved
its/core-it-suite/src/test/resources/mng-2135/plugin/src/main/java/coreit/ItMojo.java
Show resolved
Hide resolved
...in-active-collection/src/main/java/org/apache/maven/plugin/coreit/CheckThreadSafetyMojo.java
Show resolved
Hide resolved
...aven-it-plugin-class-loader/src/main/java/org/apache/maven/plugin/coreit/PropertiesUtil.java
Show resolved
Hide resolved
...in-core-stubs/maven-clean-plugin/src/main/java/org/apache/maven/plugin/coreit/CleanMojo.java
Outdated
Show resolved
Hide resolved
...ven-it-plugin-configuration/src/main/java/org/apache/maven/plugin/coreit/PropertiesUtil.java
Show resolved
Hide resolved
...tubs/maven-compiler-plugin/src/main/java/org/apache/maven/plugin/coreit/TestCompileMojo.java
Outdated
Show resolved
Hide resolved
...re-stubs/maven-compiler-plugin/src/main/java/org/apache/maven/plugin/coreit/CompileMojo.java
Outdated
Show resolved
Hide resolved
...-core-stubs/maven-deploy-plugin/src/main/java/org/apache/maven/plugin/coreit/DeployMojo.java
Show resolved
Hide resolved
dd3aa4d to
c642b8b
Compare
Pankraz76
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
will continue/dedicate in
...aven-it-plugin-class-loader/src/main/java/org/apache/maven/plugin/coreit/PropertiesUtil.java
Show resolved
Hide resolved
...ven-it-plugin-configuration/src/main/java/org/apache/maven/plugin/coreit/PropertiesUtil.java
Show resolved
Hide resolved
c642b8b to
469a8e6
Compare
its/core-it-suite/src/test/resources/mng-2135/plugin/src/main/java/coreit/ItMojo.java
Show resolved
Hide resolved
...maven-it-plugin-uses-wagon/src/main/java/org/apache/maven/plugin/coreit/LookupWagonMojo.java
Show resolved
Hide resolved
469a8e6 to
6502d96
Compare
gnodet
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see no benefit in this change.
|
its simply false catch and hindering will give dedicated example. But yes it should be done in combination with |
indeed, not all, as its a mix of: |

AbstractMojo#createFile(File)#2395