From 6502d965dac4e9c8dd1371bf90641bbe375061d7 Mon Sep 17 00:00:00 2001 From: Vincent Potucek Date: Tue, 27 May 2025 22:18:42 +0200 Subject: [PATCH] avoid false IO catch on mkdirs() --- .../resources/mng-2135/plugin/src/main/java/coreit/ItMojo.java | 2 +- .../main/java/org/apache/maven/plugin/coreit/CheckMojo.java | 2 +- .../org/apache/maven/plugin/coreit/CheckThreadSafetyMojo.java | 2 +- .../java/org/apache/maven/plugin/coreit/PropertiesUtil.java | 2 +- .../java/org/apache/maven/plugin/coreit/PropertiesUtil.java | 2 +- .../main/java/org/apache/maven/plugin/coreit/CleanMojo.java | 3 +-- .../main/java/org/apache/maven/plugin/coreit/CompileMojo.java | 3 +-- .../java/org/apache/maven/plugin/coreit/TestCompileMojo.java | 3 +-- .../main/java/org/apache/maven/plugin/coreit/DeployMojo.java | 2 +- .../src/main/java/org/apache/maven/plugin/coreit/EarMojo.java | 2 +- .../apache/maven/plugin/coreit/GenerateApplicationXmlMojo.java | 2 +- .../src/main/java/org/apache/maven/plugin/coreit/EjbMojo.java | 2 +- .../main/java/org/apache/maven/plugin/coreit/InstallMojo.java | 2 +- .../src/main/java/org/apache/maven/plugin/coreit/JarMojo.java | 2 +- .../src/main/java/org/apache/maven/plugin/coreit/JarMojo.java | 2 +- .../java/org/apache/maven/plugin/coreit/DescriptorMojo.java | 2 +- .../src/main/java/org/apache/maven/plugin/coreit/RarMojo.java | 2 +- .../java/org/apache/maven/plugin/coreit/ResourcesMojo.java | 2 +- .../java/org/apache/maven/plugin/coreit/TestResourcesMojo.java | 2 +- .../org/apache/maven/plugin/coreit/AttachDescriptorMojo.java | 2 +- .../main/java/org/apache/maven/plugin/coreit/DeployMojo.java | 2 +- .../src/main/java/org/apache/maven/plugin/coreit/SiteMojo.java | 2 +- .../src/main/java/org/apache/maven/plugin/coreit/JarMojo.java | 2 +- .../src/main/java/org/apache/maven/plugin/coreit/TestMojo.java | 2 +- .../src/main/java/org/apache/maven/plugin/coreit/WarMojo.java | 2 +- .../src/main/java/org/apache/maven/plugin/coreit/ItMojo.java | 2 +- .../main/java/org/apache/maven/plugin/coreit/TouchMojo.java | 2 +- .../main/java/org/apache/maven/plugin/coreit/AppendMojo.java | 2 +- .../src/main/java/org/apache/maven/plugin/coreit/ItMojo.java | 2 +- .../main/java/org/apache/maven/plugin/coreit/InfoReport.java | 2 +- .../main/java/org/apache/maven/plugin/coreit/CoreItMojo.java | 2 +- .../main/java/org/apache/maven/plugin/coreit/FindToolMojo.java | 2 +- .../java/org/apache/maven/plugin/coreit/LookupWagonMojo.java | 2 +- 33 files changed, 33 insertions(+), 36 deletions(-) diff --git a/its/core-it-suite/src/test/resources/mng-2135/plugin/src/main/java/coreit/ItMojo.java b/its/core-it-suite/src/test/resources/mng-2135/plugin/src/main/java/coreit/ItMojo.java index 07093cd0b05a..cdd528049922 100644 --- a/its/core-it-suite/src/test/resources/mng-2135/plugin/src/main/java/coreit/ItMojo.java +++ b/its/core-it-suite/src/test/resources/mng-2135/plugin/src/main/java/coreit/ItMojo.java @@ -52,8 +52,8 @@ public class ItMojo extends AbstractMojo { private File outputFile; public void execute() throws MojoExecutionException { + outputFile.getParentFile().mkdirs(); try { - outputFile.getParentFile().mkdirs(); outputFile.createNewFile(); } catch (IOException e) { throw new MojoExecutionException("Failed to create touch file: " + e.getMessage(), e); diff --git a/its/core-it-support/core-it-plugins/maven-it-plugin-active-collection/src/main/java/org/apache/maven/plugin/coreit/CheckMojo.java b/its/core-it-support/core-it-plugins/maven-it-plugin-active-collection/src/main/java/org/apache/maven/plugin/coreit/CheckMojo.java index aa0e9325d7d2..40e7d9c4f994 100644 --- a/its/core-it-support/core-it-plugins/maven-it-plugin-active-collection/src/main/java/org/apache/maven/plugin/coreit/CheckMojo.java +++ b/its/core-it-support/core-it-plugins/maven-it-plugin-active-collection/src/main/java/org/apache/maven/plugin/coreit/CheckMojo.java @@ -118,8 +118,8 @@ public void execute() throws MojoExecutionException, MojoFailureException { getLog().info("[MAVEN-CORE-IT-LOG] Creating output file " + outputFile); OutputStream out = null; + outputFile.getParentFile().mkdirs(); try { - outputFile.getParentFile().mkdirs(); out = new FileOutputStream(outputFile); componentProperties.store(out, "MAVEN-CORE-IT-LOG"); } catch (IOException e) { diff --git a/its/core-it-support/core-it-plugins/maven-it-plugin-active-collection/src/main/java/org/apache/maven/plugin/coreit/CheckThreadSafetyMojo.java b/its/core-it-support/core-it-plugins/maven-it-plugin-active-collection/src/main/java/org/apache/maven/plugin/coreit/CheckThreadSafetyMojo.java index f8f4441bd7cf..06d7574ba382 100644 --- a/its/core-it-support/core-it-plugins/maven-it-plugin-active-collection/src/main/java/org/apache/maven/plugin/coreit/CheckThreadSafetyMojo.java +++ b/its/core-it-support/core-it-plugins/maven-it-plugin-active-collection/src/main/java/org/apache/maven/plugin/coreit/CheckThreadSafetyMojo.java @@ -134,8 +134,8 @@ public void run() { getLog().info("[MAVEN-CORE-IT-LOG] Creating output file " + outputFile); OutputStream out = null; + outputFile.getParentFile().mkdirs(); try { - outputFile.getParentFile().mkdirs(); out = new FileOutputStream(outputFile); componentProperties.store(out, "MAVEN-CORE-IT-LOG"); } catch (IOException e) { diff --git a/its/core-it-support/core-it-plugins/maven-it-plugin-class-loader/maven-it-plugin-class-loader/src/main/java/org/apache/maven/plugin/coreit/PropertiesUtil.java b/its/core-it-support/core-it-plugins/maven-it-plugin-class-loader/maven-it-plugin-class-loader/src/main/java/org/apache/maven/plugin/coreit/PropertiesUtil.java index a4c04791352b..cce44511e687 100644 --- a/its/core-it-support/core-it-plugins/maven-it-plugin-class-loader/maven-it-plugin-class-loader/src/main/java/org/apache/maven/plugin/coreit/PropertiesUtil.java +++ b/its/core-it-support/core-it-plugins/maven-it-plugin-class-loader/maven-it-plugin-class-loader/src/main/java/org/apache/maven/plugin/coreit/PropertiesUtil.java @@ -36,8 +36,8 @@ class PropertiesUtil { public static void write(File outputFile, Properties props) throws MojoExecutionException { OutputStream out = null; + outputFile.getParentFile().mkdirs(); try { - outputFile.getParentFile().mkdirs(); out = new FileOutputStream(outputFile); props.store(out, "MAVEN-CORE-IT-LOG"); } catch (IOException e) { diff --git a/its/core-it-support/core-it-plugins/maven-it-plugin-configuration/src/main/java/org/apache/maven/plugin/coreit/PropertiesUtil.java b/its/core-it-support/core-it-plugins/maven-it-plugin-configuration/src/main/java/org/apache/maven/plugin/coreit/PropertiesUtil.java index 9d0a9a4414f5..e91b770d029c 100644 --- a/its/core-it-support/core-it-plugins/maven-it-plugin-configuration/src/main/java/org/apache/maven/plugin/coreit/PropertiesUtil.java +++ b/its/core-it-support/core-it-plugins/maven-it-plugin-configuration/src/main/java/org/apache/maven/plugin/coreit/PropertiesUtil.java @@ -70,8 +70,8 @@ public static Properties read(File inputFile) throws MojoExecutionException { public static void write(File outputFile, Properties props) throws MojoExecutionException { OutputStream os = null; + outputFile.getParentFile().mkdirs(); try { - outputFile.getParentFile().mkdirs(); os = new FileOutputStream(outputFile); props.store(os, "MAVEN-CORE-IT-LOG"); } catch (IOException e) { diff --git a/its/core-it-support/core-it-plugins/maven-it-plugin-core-stubs/maven-clean-plugin/src/main/java/org/apache/maven/plugin/coreit/CleanMojo.java b/its/core-it-support/core-it-plugins/maven-it-plugin-core-stubs/maven-clean-plugin/src/main/java/org/apache/maven/plugin/coreit/CleanMojo.java index ec70b87b2ea1..33b90d5913b4 100644 --- a/its/core-it-support/core-it-plugins/maven-it-plugin-core-stubs/maven-clean-plugin/src/main/java/org/apache/maven/plugin/coreit/CleanMojo.java +++ b/its/core-it-support/core-it-plugins/maven-it-plugin-core-stubs/maven-clean-plugin/src/main/java/org/apache/maven/plugin/coreit/CleanMojo.java @@ -70,10 +70,9 @@ public void execute() throws MojoExecutionException, MojoFailureException { outputFile = new File(project.getBasedir(), pathname).getAbsoluteFile(); } - getLog().info("[MAVEN-CORE-IT-LOG] Creating output file: " + outputFile); + outputFile.getParentFile().mkdirs(); try { - outputFile.getParentFile().mkdirs(); outputFile.createNewFile(); } catch (IOException e) { throw new MojoExecutionException("Output file could not be created: " + pathname, e); diff --git a/its/core-it-support/core-it-plugins/maven-it-plugin-core-stubs/maven-compiler-plugin/src/main/java/org/apache/maven/plugin/coreit/CompileMojo.java b/its/core-it-support/core-it-plugins/maven-it-plugin-core-stubs/maven-compiler-plugin/src/main/java/org/apache/maven/plugin/coreit/CompileMojo.java index 17dbb9b77bda..95dcbc358458 100644 --- a/its/core-it-support/core-it-plugins/maven-it-plugin-core-stubs/maven-compiler-plugin/src/main/java/org/apache/maven/plugin/coreit/CompileMojo.java +++ b/its/core-it-support/core-it-plugins/maven-it-plugin-core-stubs/maven-compiler-plugin/src/main/java/org/apache/maven/plugin/coreit/CompileMojo.java @@ -70,10 +70,9 @@ public void execute() throws MojoExecutionException, MojoFailureException { outputFile = new File(project.getBasedir(), pathname).getAbsoluteFile(); } - getLog().info("[MAVEN-CORE-IT-LOG] Creating output file: " + outputFile); + outputFile.getParentFile().mkdirs(); try { - outputFile.getParentFile().mkdirs(); outputFile.createNewFile(); } catch (IOException e) { throw new MojoExecutionException("Output file could not be created: " + pathname, e); diff --git a/its/core-it-support/core-it-plugins/maven-it-plugin-core-stubs/maven-compiler-plugin/src/main/java/org/apache/maven/plugin/coreit/TestCompileMojo.java b/its/core-it-support/core-it-plugins/maven-it-plugin-core-stubs/maven-compiler-plugin/src/main/java/org/apache/maven/plugin/coreit/TestCompileMojo.java index dd3d216cae26..c43dffc20efb 100644 --- a/its/core-it-support/core-it-plugins/maven-it-plugin-core-stubs/maven-compiler-plugin/src/main/java/org/apache/maven/plugin/coreit/TestCompileMojo.java +++ b/its/core-it-support/core-it-plugins/maven-it-plugin-core-stubs/maven-compiler-plugin/src/main/java/org/apache/maven/plugin/coreit/TestCompileMojo.java @@ -70,10 +70,9 @@ public void execute() throws MojoExecutionException, MojoFailureException { outputFile = new File(project.getBasedir(), pathname).getAbsoluteFile(); } - getLog().info("[MAVEN-CORE-IT-LOG] Creating output file: " + outputFile); + outputFile.getParentFile().mkdirs(); try { - outputFile.getParentFile().mkdirs(); outputFile.createNewFile(); } catch (IOException e) { throw new MojoExecutionException("Output file could not be created: " + pathname, e); diff --git a/its/core-it-support/core-it-plugins/maven-it-plugin-core-stubs/maven-deploy-plugin/src/main/java/org/apache/maven/plugin/coreit/DeployMojo.java b/its/core-it-support/core-it-plugins/maven-it-plugin-core-stubs/maven-deploy-plugin/src/main/java/org/apache/maven/plugin/coreit/DeployMojo.java index a76b27f4cda9..0f528522aa58 100644 --- a/its/core-it-support/core-it-plugins/maven-it-plugin-core-stubs/maven-deploy-plugin/src/main/java/org/apache/maven/plugin/coreit/DeployMojo.java +++ b/its/core-it-support/core-it-plugins/maven-it-plugin-core-stubs/maven-deploy-plugin/src/main/java/org/apache/maven/plugin/coreit/DeployMojo.java @@ -72,8 +72,8 @@ public void execute() throws MojoExecutionException, MojoFailureException { getLog().info("[MAVEN-CORE-IT-LOG] Creating output file: " + outputFile); + outputFile.getParentFile().mkdirs(); try { - outputFile.getParentFile().mkdirs(); outputFile.createNewFile(); } catch (IOException e) { throw new MojoExecutionException("Output file could not be created: " + pathname, e); diff --git a/its/core-it-support/core-it-plugins/maven-it-plugin-core-stubs/maven-ear-plugin/src/main/java/org/apache/maven/plugin/coreit/EarMojo.java b/its/core-it-support/core-it-plugins/maven-it-plugin-core-stubs/maven-ear-plugin/src/main/java/org/apache/maven/plugin/coreit/EarMojo.java index 56629d493389..ddbee47303ab 100644 --- a/its/core-it-support/core-it-plugins/maven-it-plugin-core-stubs/maven-ear-plugin/src/main/java/org/apache/maven/plugin/coreit/EarMojo.java +++ b/its/core-it-support/core-it-plugins/maven-it-plugin-core-stubs/maven-ear-plugin/src/main/java/org/apache/maven/plugin/coreit/EarMojo.java @@ -72,8 +72,8 @@ public void execute() throws MojoExecutionException, MojoFailureException { getLog().info("[MAVEN-CORE-IT-LOG] Creating output file: " + outputFile); + outputFile.getParentFile().mkdirs(); try { - outputFile.getParentFile().mkdirs(); outputFile.createNewFile(); } catch (IOException e) { throw new MojoExecutionException("Output file could not be created: " + pathname, e); diff --git a/its/core-it-support/core-it-plugins/maven-it-plugin-core-stubs/maven-ear-plugin/src/main/java/org/apache/maven/plugin/coreit/GenerateApplicationXmlMojo.java b/its/core-it-support/core-it-plugins/maven-it-plugin-core-stubs/maven-ear-plugin/src/main/java/org/apache/maven/plugin/coreit/GenerateApplicationXmlMojo.java index 3ce9072a63bf..b850a151cb08 100644 --- a/its/core-it-support/core-it-plugins/maven-it-plugin-core-stubs/maven-ear-plugin/src/main/java/org/apache/maven/plugin/coreit/GenerateApplicationXmlMojo.java +++ b/its/core-it-support/core-it-plugins/maven-it-plugin-core-stubs/maven-ear-plugin/src/main/java/org/apache/maven/plugin/coreit/GenerateApplicationXmlMojo.java @@ -72,8 +72,8 @@ public void execute() throws MojoExecutionException, MojoFailureException { getLog().info("[MAVEN-CORE-IT-LOG] Creating output file: " + outputFile); + outputFile.getParentFile().mkdirs(); try { - outputFile.getParentFile().mkdirs(); outputFile.createNewFile(); } catch (IOException e) { throw new MojoExecutionException("Output file could not be created: " + pathname, e); diff --git a/its/core-it-support/core-it-plugins/maven-it-plugin-core-stubs/maven-ejb-plugin/src/main/java/org/apache/maven/plugin/coreit/EjbMojo.java b/its/core-it-support/core-it-plugins/maven-it-plugin-core-stubs/maven-ejb-plugin/src/main/java/org/apache/maven/plugin/coreit/EjbMojo.java index 9a98643afec5..ff976a7f2fc0 100644 --- a/its/core-it-support/core-it-plugins/maven-it-plugin-core-stubs/maven-ejb-plugin/src/main/java/org/apache/maven/plugin/coreit/EjbMojo.java +++ b/its/core-it-support/core-it-plugins/maven-it-plugin-core-stubs/maven-ejb-plugin/src/main/java/org/apache/maven/plugin/coreit/EjbMojo.java @@ -72,8 +72,8 @@ public void execute() throws MojoExecutionException, MojoFailureException { getLog().info("[MAVEN-CORE-IT-LOG] Creating output file: " + outputFile); + outputFile.getParentFile().mkdirs(); try { - outputFile.getParentFile().mkdirs(); outputFile.createNewFile(); } catch (IOException e) { throw new MojoExecutionException("Output file could not be created: " + pathname, e); diff --git a/its/core-it-support/core-it-plugins/maven-it-plugin-core-stubs/maven-install-plugin/src/main/java/org/apache/maven/plugin/coreit/InstallMojo.java b/its/core-it-support/core-it-plugins/maven-it-plugin-core-stubs/maven-install-plugin/src/main/java/org/apache/maven/plugin/coreit/InstallMojo.java index 75a78a21b041..f7f29776193f 100644 --- a/its/core-it-support/core-it-plugins/maven-it-plugin-core-stubs/maven-install-plugin/src/main/java/org/apache/maven/plugin/coreit/InstallMojo.java +++ b/its/core-it-support/core-it-plugins/maven-it-plugin-core-stubs/maven-install-plugin/src/main/java/org/apache/maven/plugin/coreit/InstallMojo.java @@ -72,8 +72,8 @@ public void execute() throws MojoExecutionException, MojoFailureException { getLog().info("[MAVEN-CORE-IT-LOG] Creating output file: " + outputFile); + outputFile.getParentFile().mkdirs(); try { - outputFile.getParentFile().mkdirs(); outputFile.createNewFile(); } catch (IOException e) { throw new MojoExecutionException("Output file could not be created: " + pathname, e); diff --git a/its/core-it-support/core-it-plugins/maven-it-plugin-core-stubs/maven-jar-plugin/src/main/java/org/apache/maven/plugin/coreit/JarMojo.java b/its/core-it-support/core-it-plugins/maven-it-plugin-core-stubs/maven-jar-plugin/src/main/java/org/apache/maven/plugin/coreit/JarMojo.java index 3c456da35f36..ad1b18fcce86 100644 --- a/its/core-it-support/core-it-plugins/maven-it-plugin-core-stubs/maven-jar-plugin/src/main/java/org/apache/maven/plugin/coreit/JarMojo.java +++ b/its/core-it-support/core-it-plugins/maven-it-plugin-core-stubs/maven-jar-plugin/src/main/java/org/apache/maven/plugin/coreit/JarMojo.java @@ -72,8 +72,8 @@ public void execute() throws MojoExecutionException, MojoFailureException { getLog().info("[MAVEN-CORE-IT-LOG] Creating output file: " + outputFile); + outputFile.getParentFile().mkdirs(); try { - outputFile.getParentFile().mkdirs(); outputFile.createNewFile(); } catch (IOException e) { throw new MojoExecutionException("Output file could not be created: " + pathname, e); diff --git a/its/core-it-support/core-it-plugins/maven-it-plugin-core-stubs/maven-javadoc-plugin/src/main/java/org/apache/maven/plugin/coreit/JarMojo.java b/its/core-it-support/core-it-plugins/maven-it-plugin-core-stubs/maven-javadoc-plugin/src/main/java/org/apache/maven/plugin/coreit/JarMojo.java index 948dbc8fbb21..b81cbce3b0be 100644 --- a/its/core-it-support/core-it-plugins/maven-it-plugin-core-stubs/maven-javadoc-plugin/src/main/java/org/apache/maven/plugin/coreit/JarMojo.java +++ b/its/core-it-support/core-it-plugins/maven-it-plugin-core-stubs/maven-javadoc-plugin/src/main/java/org/apache/maven/plugin/coreit/JarMojo.java @@ -72,8 +72,8 @@ public void execute() throws MojoExecutionException, MojoFailureException { getLog().info("[MAVEN-CORE-IT-LOG] Creating output file: " + outputFile); + outputFile.getParentFile().mkdirs(); try { - outputFile.getParentFile().mkdirs(); outputFile.createNewFile(); } catch (IOException e) { throw new MojoExecutionException("Output file could not be created: " + pathname, e); diff --git a/its/core-it-support/core-it-plugins/maven-it-plugin-core-stubs/maven-plugin-plugin/src/main/java/org/apache/maven/plugin/coreit/DescriptorMojo.java b/its/core-it-support/core-it-plugins/maven-it-plugin-core-stubs/maven-plugin-plugin/src/main/java/org/apache/maven/plugin/coreit/DescriptorMojo.java index a851911f20ae..674dc302eaab 100644 --- a/its/core-it-support/core-it-plugins/maven-it-plugin-core-stubs/maven-plugin-plugin/src/main/java/org/apache/maven/plugin/coreit/DescriptorMojo.java +++ b/its/core-it-support/core-it-plugins/maven-it-plugin-core-stubs/maven-plugin-plugin/src/main/java/org/apache/maven/plugin/coreit/DescriptorMojo.java @@ -72,8 +72,8 @@ public void execute() throws MojoExecutionException, MojoFailureException { getLog().info("[MAVEN-CORE-IT-LOG] Creating output file: " + outputFile); + outputFile.getParentFile().mkdirs(); try { - outputFile.getParentFile().mkdirs(); outputFile.createNewFile(); } catch (IOException e) { throw new MojoExecutionException("Output file could not be created: " + pathname, e); diff --git a/its/core-it-support/core-it-plugins/maven-it-plugin-core-stubs/maven-rar-plugin/src/main/java/org/apache/maven/plugin/coreit/RarMojo.java b/its/core-it-support/core-it-plugins/maven-it-plugin-core-stubs/maven-rar-plugin/src/main/java/org/apache/maven/plugin/coreit/RarMojo.java index 14777f405e9b..05a7c9a5e475 100644 --- a/its/core-it-support/core-it-plugins/maven-it-plugin-core-stubs/maven-rar-plugin/src/main/java/org/apache/maven/plugin/coreit/RarMojo.java +++ b/its/core-it-support/core-it-plugins/maven-it-plugin-core-stubs/maven-rar-plugin/src/main/java/org/apache/maven/plugin/coreit/RarMojo.java @@ -72,8 +72,8 @@ public void execute() throws MojoExecutionException, MojoFailureException { getLog().info("[MAVEN-CORE-IT-LOG] Creating output file: " + outputFile); + outputFile.getParentFile().mkdirs(); try { - outputFile.getParentFile().mkdirs(); outputFile.createNewFile(); } catch (IOException e) { throw new MojoExecutionException("Output file could not be created: " + pathname, e); diff --git a/its/core-it-support/core-it-plugins/maven-it-plugin-core-stubs/maven-resources-plugin/src/main/java/org/apache/maven/plugin/coreit/ResourcesMojo.java b/its/core-it-support/core-it-plugins/maven-it-plugin-core-stubs/maven-resources-plugin/src/main/java/org/apache/maven/plugin/coreit/ResourcesMojo.java index a4efc5736e1c..d74d72ea06c4 100644 --- a/its/core-it-support/core-it-plugins/maven-it-plugin-core-stubs/maven-resources-plugin/src/main/java/org/apache/maven/plugin/coreit/ResourcesMojo.java +++ b/its/core-it-support/core-it-plugins/maven-it-plugin-core-stubs/maven-resources-plugin/src/main/java/org/apache/maven/plugin/coreit/ResourcesMojo.java @@ -81,8 +81,8 @@ public void execute() throws MojoExecutionException, MojoFailureException { getLog().info("[MAVEN-CORE-IT-LOG] Creating output file: " + outputFile); + outputFile.getParentFile().mkdirs(); try { - outputFile.getParentFile().mkdirs(); if (message != null && message.length() > 0) { getLog().info("[MAVEN-CORE-IT-LOG] " + message); diff --git a/its/core-it-support/core-it-plugins/maven-it-plugin-core-stubs/maven-resources-plugin/src/main/java/org/apache/maven/plugin/coreit/TestResourcesMojo.java b/its/core-it-support/core-it-plugins/maven-it-plugin-core-stubs/maven-resources-plugin/src/main/java/org/apache/maven/plugin/coreit/TestResourcesMojo.java index af1f7be7fe6e..0fba15aa830d 100644 --- a/its/core-it-support/core-it-plugins/maven-it-plugin-core-stubs/maven-resources-plugin/src/main/java/org/apache/maven/plugin/coreit/TestResourcesMojo.java +++ b/its/core-it-support/core-it-plugins/maven-it-plugin-core-stubs/maven-resources-plugin/src/main/java/org/apache/maven/plugin/coreit/TestResourcesMojo.java @@ -72,8 +72,8 @@ public void execute() throws MojoExecutionException, MojoFailureException { getLog().info("[MAVEN-CORE-IT-LOG] Creating output file: " + outputFile); + outputFile.getParentFile().mkdirs(); try { - outputFile.getParentFile().mkdirs(); outputFile.createNewFile(); } catch (IOException e) { throw new MojoExecutionException("Output file could not be created: " + pathname, e); diff --git a/its/core-it-support/core-it-plugins/maven-it-plugin-core-stubs/maven-site-plugin/src/main/java/org/apache/maven/plugin/coreit/AttachDescriptorMojo.java b/its/core-it-support/core-it-plugins/maven-it-plugin-core-stubs/maven-site-plugin/src/main/java/org/apache/maven/plugin/coreit/AttachDescriptorMojo.java index ac097c685cfd..be45066378c2 100644 --- a/its/core-it-support/core-it-plugins/maven-it-plugin-core-stubs/maven-site-plugin/src/main/java/org/apache/maven/plugin/coreit/AttachDescriptorMojo.java +++ b/its/core-it-support/core-it-plugins/maven-it-plugin-core-stubs/maven-site-plugin/src/main/java/org/apache/maven/plugin/coreit/AttachDescriptorMojo.java @@ -72,8 +72,8 @@ public void execute() throws MojoExecutionException, MojoFailureException { getLog().info("[MAVEN-CORE-IT-LOG] Creating output file: " + outputFile); + outputFile.getParentFile().mkdirs(); try { - outputFile.getParentFile().mkdirs(); outputFile.createNewFile(); } catch (IOException e) { throw new MojoExecutionException("Output file could not be created: " + pathname, e); diff --git a/its/core-it-support/core-it-plugins/maven-it-plugin-core-stubs/maven-site-plugin/src/main/java/org/apache/maven/plugin/coreit/DeployMojo.java b/its/core-it-support/core-it-plugins/maven-it-plugin-core-stubs/maven-site-plugin/src/main/java/org/apache/maven/plugin/coreit/DeployMojo.java index 6570d573e296..1fdf4ec07009 100644 --- a/its/core-it-support/core-it-plugins/maven-it-plugin-core-stubs/maven-site-plugin/src/main/java/org/apache/maven/plugin/coreit/DeployMojo.java +++ b/its/core-it-support/core-it-plugins/maven-it-plugin-core-stubs/maven-site-plugin/src/main/java/org/apache/maven/plugin/coreit/DeployMojo.java @@ -72,8 +72,8 @@ public void execute() throws MojoExecutionException, MojoFailureException { getLog().info("[MAVEN-CORE-IT-LOG] Creating output file: " + outputFile); + outputFile.getParentFile().mkdirs(); try { - outputFile.getParentFile().mkdirs(); outputFile.createNewFile(); } catch (IOException e) { throw new MojoExecutionException("Output file could not be created: " + pathname, e); diff --git a/its/core-it-support/core-it-plugins/maven-it-plugin-core-stubs/maven-site-plugin/src/main/java/org/apache/maven/plugin/coreit/SiteMojo.java b/its/core-it-support/core-it-plugins/maven-it-plugin-core-stubs/maven-site-plugin/src/main/java/org/apache/maven/plugin/coreit/SiteMojo.java index da0450f0c4a5..06d9ad2f740f 100644 --- a/its/core-it-support/core-it-plugins/maven-it-plugin-core-stubs/maven-site-plugin/src/main/java/org/apache/maven/plugin/coreit/SiteMojo.java +++ b/its/core-it-support/core-it-plugins/maven-it-plugin-core-stubs/maven-site-plugin/src/main/java/org/apache/maven/plugin/coreit/SiteMojo.java @@ -72,8 +72,8 @@ public void execute() throws MojoExecutionException, MojoFailureException { getLog().info("[MAVEN-CORE-IT-LOG] Creating output file: " + outputFile); + outputFile.getParentFile().mkdirs(); try { - outputFile.getParentFile().mkdirs(); outputFile.createNewFile(); } catch (IOException e) { throw new MojoExecutionException("Output file could not be created: " + pathname, e); diff --git a/its/core-it-support/core-it-plugins/maven-it-plugin-core-stubs/maven-source-plugin/src/main/java/org/apache/maven/plugin/coreit/JarMojo.java b/its/core-it-support/core-it-plugins/maven-it-plugin-core-stubs/maven-source-plugin/src/main/java/org/apache/maven/plugin/coreit/JarMojo.java index 926bb0004604..366623fe27d6 100644 --- a/its/core-it-support/core-it-plugins/maven-it-plugin-core-stubs/maven-source-plugin/src/main/java/org/apache/maven/plugin/coreit/JarMojo.java +++ b/its/core-it-support/core-it-plugins/maven-it-plugin-core-stubs/maven-source-plugin/src/main/java/org/apache/maven/plugin/coreit/JarMojo.java @@ -72,8 +72,8 @@ public void execute() throws MojoExecutionException, MojoFailureException { getLog().info("[MAVEN-CORE-IT-LOG] Creating output file: " + outputFile); + outputFile.getParentFile().mkdirs(); try { - outputFile.getParentFile().mkdirs(); outputFile.createNewFile(); } catch (IOException e) { throw new MojoExecutionException("Output file could not be created: " + pathname, e); diff --git a/its/core-it-support/core-it-plugins/maven-it-plugin-core-stubs/maven-surefire-plugin/src/main/java/org/apache/maven/plugin/coreit/TestMojo.java b/its/core-it-support/core-it-plugins/maven-it-plugin-core-stubs/maven-surefire-plugin/src/main/java/org/apache/maven/plugin/coreit/TestMojo.java index 615041e6dcea..27672341b8e2 100644 --- a/its/core-it-support/core-it-plugins/maven-it-plugin-core-stubs/maven-surefire-plugin/src/main/java/org/apache/maven/plugin/coreit/TestMojo.java +++ b/its/core-it-support/core-it-plugins/maven-it-plugin-core-stubs/maven-surefire-plugin/src/main/java/org/apache/maven/plugin/coreit/TestMojo.java @@ -72,8 +72,8 @@ public void execute() throws MojoExecutionException, MojoFailureException { getLog().info("[MAVEN-CORE-IT-LOG] Creating output file: " + outputFile); + outputFile.getParentFile().mkdirs(); try { - outputFile.getParentFile().mkdirs(); outputFile.createNewFile(); } catch (IOException e) { throw new MojoExecutionException("Output file could not be created: " + pathname, e); diff --git a/its/core-it-support/core-it-plugins/maven-it-plugin-core-stubs/maven-war-plugin/src/main/java/org/apache/maven/plugin/coreit/WarMojo.java b/its/core-it-support/core-it-plugins/maven-it-plugin-core-stubs/maven-war-plugin/src/main/java/org/apache/maven/plugin/coreit/WarMojo.java index 847510188edb..6a6801f5419a 100644 --- a/its/core-it-support/core-it-plugins/maven-it-plugin-core-stubs/maven-war-plugin/src/main/java/org/apache/maven/plugin/coreit/WarMojo.java +++ b/its/core-it-support/core-it-plugins/maven-it-plugin-core-stubs/maven-war-plugin/src/main/java/org/apache/maven/plugin/coreit/WarMojo.java @@ -72,8 +72,8 @@ public void execute() throws MojoExecutionException, MojoFailureException { getLog().info("[MAVEN-CORE-IT-LOG] Creating output file: " + outputFile); + outputFile.getParentFile().mkdirs(); try { - outputFile.getParentFile().mkdirs(); outputFile.createNewFile(); } catch (IOException e) { throw new MojoExecutionException("Output file could not be created: " + pathname, e); diff --git a/its/core-it-support/core-it-plugins/maven-it-plugin-no-default-comp/src/main/java/org/apache/maven/plugin/coreit/ItMojo.java b/its/core-it-support/core-it-plugins/maven-it-plugin-no-default-comp/src/main/java/org/apache/maven/plugin/coreit/ItMojo.java index c762b710a9c6..203a0f11e519 100644 --- a/its/core-it-support/core-it-plugins/maven-it-plugin-no-default-comp/src/main/java/org/apache/maven/plugin/coreit/ItMojo.java +++ b/its/core-it-support/core-it-plugins/maven-it-plugin-no-default-comp/src/main/java/org/apache/maven/plugin/coreit/ItMojo.java @@ -65,8 +65,8 @@ public void execute() throws MojoExecutionException { getLog().info("[MAVEN-CORE-IT-LOG] Creating output file: " + outputFile); + outputFile.getParentFile().mkdirs(); try { - outputFile.getParentFile().mkdirs(); try (FileOutputStream os = new FileOutputStream(outputFile)) { props.store(os, "MAVEN-CORE-IT-LOG"); } diff --git a/its/core-it-support/core-it-plugins/maven-it-plugin-online/src/main/java/org/apache/maven/plugin/coreit/TouchMojo.java b/its/core-it-support/core-it-plugins/maven-it-plugin-online/src/main/java/org/apache/maven/plugin/coreit/TouchMojo.java index f584d808741c..8b4e370ccbed 100644 --- a/its/core-it-support/core-it-plugins/maven-it-plugin-online/src/main/java/org/apache/maven/plugin/coreit/TouchMojo.java +++ b/its/core-it-support/core-it-plugins/maven-it-plugin-online/src/main/java/org/apache/maven/plugin/coreit/TouchMojo.java @@ -49,8 +49,8 @@ public class TouchMojo extends AbstractMojo { public void execute() throws MojoExecutionException { getLog().info("[MAVEN-CORE-IT-LOG] Creating output file: " + outputFile); + outputFile.getParentFile().mkdirs(); try { - outputFile.getParentFile().mkdirs(); outputFile.createNewFile(); } catch (IOException e) { throw new MojoExecutionException("Output file could not be created: " + outputFile, e); diff --git a/its/core-it-support/core-it-plugins/maven-it-plugin-packaging/src/main/java/org/apache/maven/plugin/coreit/AppendMojo.java b/its/core-it-support/core-it-plugins/maven-it-plugin-packaging/src/main/java/org/apache/maven/plugin/coreit/AppendMojo.java index 91eaa0aebab2..d7b5facf2ef0 100644 --- a/its/core-it-support/core-it-plugins/maven-it-plugin-packaging/src/main/java/org/apache/maven/plugin/coreit/AppendMojo.java +++ b/its/core-it-support/core-it-plugins/maven-it-plugin-packaging/src/main/java/org/apache/maven/plugin/coreit/AppendMojo.java @@ -49,8 +49,8 @@ public class AppendMojo extends AbstractMojo { public void execute() throws MojoExecutionException { getLog().info("[MAVEN-CORE-IT-LOG] Creating output file: " + outputFile); + outputFile.getParentFile().mkdirs(); try { - outputFile.getParentFile().mkdirs(); getLog().info("[MAVEN-CORE-IT-LOG] " + message); diff --git a/its/core-it-support/core-it-plugins/maven-it-plugin-singleton-component/src/main/java/org/apache/maven/plugin/coreit/ItMojo.java b/its/core-it-support/core-it-plugins/maven-it-plugin-singleton-component/src/main/java/org/apache/maven/plugin/coreit/ItMojo.java index b3013ffc008a..4a28602e4f5b 100644 --- a/its/core-it-support/core-it-plugins/maven-it-plugin-singleton-component/src/main/java/org/apache/maven/plugin/coreit/ItMojo.java +++ b/its/core-it-support/core-it-plugins/maven-it-plugin-singleton-component/src/main/java/org/apache/maven/plugin/coreit/ItMojo.java @@ -96,8 +96,8 @@ public void execute() throws MojoExecutionException { getLog().info("[MAVEN-CORE-IT-LOG] Creating output file: " + outputFile); + outputFile.getParentFile().mkdirs(); try { - outputFile.getParentFile().mkdirs(); try (FileOutputStream os = new FileOutputStream(outputFile)) { props.store(os, "MAVEN-CORE-IT-LOG"); } diff --git a/its/core-it-support/core-it-plugins/maven-it-plugin-site/src/main/java/org/apache/maven/plugin/coreit/InfoReport.java b/its/core-it-support/core-it-plugins/maven-it-plugin-site/src/main/java/org/apache/maven/plugin/coreit/InfoReport.java index 76912a72ce76..010c02d327ae 100644 --- a/its/core-it-support/core-it-plugins/maven-it-plugin-site/src/main/java/org/apache/maven/plugin/coreit/InfoReport.java +++ b/its/core-it-support/core-it-plugins/maven-it-plugin-site/src/main/java/org/apache/maven/plugin/coreit/InfoReport.java @@ -97,8 +97,8 @@ public void execute() throws MojoExecutionException, MojoFailureException { getLog().info("[MAVEN-CORE-IT-LOG] Creating output file: " + outputFile); OutputStream out = null; + outputFile.getParentFile().mkdirs(); try { - outputFile.getParentFile().mkdirs(); out = new FileOutputStream(outputFile); props.store(out, "MAVEN-CORE-IT-LOG"); } catch (IOException e) { diff --git a/its/core-it-support/core-it-plugins/maven-it-plugin-toolchain/src/main/java/org/apache/maven/plugin/coreit/CoreItMojo.java b/its/core-it-support/core-it-plugins/maven-it-plugin-toolchain/src/main/java/org/apache/maven/plugin/coreit/CoreItMojo.java index e04db7350829..5d09476b77f4 100644 --- a/its/core-it-support/core-it-plugins/maven-it-plugin-toolchain/src/main/java/org/apache/maven/plugin/coreit/CoreItMojo.java +++ b/its/core-it-support/core-it-plugins/maven-it-plugin-toolchain/src/main/java/org/apache/maven/plugin/coreit/CoreItMojo.java @@ -106,8 +106,8 @@ public void execute() throws MojoExecutionException { } OutputStream out = null; + outputFile.getParentFile().mkdirs(); try { - outputFile.getParentFile().mkdirs(); out = new FileOutputStream(outputFile); properties.store(out, "MAVEN-CORE-IT-LOG"); } catch (IOException e) { diff --git a/its/core-it-support/core-it-plugins/maven-it-plugin-toolchain/src/main/java/org/apache/maven/plugin/coreit/FindToolMojo.java b/its/core-it-support/core-it-plugins/maven-it-plugin-toolchain/src/main/java/org/apache/maven/plugin/coreit/FindToolMojo.java index 11884b1a6b4e..346327e67fc7 100644 --- a/its/core-it-support/core-it-plugins/maven-it-plugin-toolchain/src/main/java/org/apache/maven/plugin/coreit/FindToolMojo.java +++ b/its/core-it-support/core-it-plugins/maven-it-plugin-toolchain/src/main/java/org/apache/maven/plugin/coreit/FindToolMojo.java @@ -88,8 +88,8 @@ public void execute() throws MojoExecutionException { } OutputStream out = null; + outputFile.getParentFile().mkdirs(); try { - outputFile.getParentFile().mkdirs(); out = new FileOutputStream(outputFile); properties.store(out, "MAVEN-CORE-IT-LOG"); } catch (IOException e) { diff --git a/its/core-it-support/core-it-plugins/maven-it-plugin-uses-wagon/src/main/java/org/apache/maven/plugin/coreit/LookupWagonMojo.java b/its/core-it-support/core-it-plugins/maven-it-plugin-uses-wagon/src/main/java/org/apache/maven/plugin/coreit/LookupWagonMojo.java index 278868010a17..fbd35c4ef080 100644 --- a/its/core-it-support/core-it-plugins/maven-it-plugin-uses-wagon/src/main/java/org/apache/maven/plugin/coreit/LookupWagonMojo.java +++ b/its/core-it-support/core-it-plugins/maven-it-plugin-uses-wagon/src/main/java/org/apache/maven/plugin/coreit/LookupWagonMojo.java @@ -93,8 +93,8 @@ public void execute() throws MojoExecutionException, MojoFailureException { getLog().info("[MAVEN-CORE-IT-LOG] Creating output file " + outputFile); OutputStream out = null; + outputFile.getParentFile().mkdirs(); try { - outputFile.getParentFile().mkdirs(); out = new FileOutputStream(outputFile); loaderProperties.store(out, "MAVEN-CORE-IT-LOG"); } catch (IOException e) {