builder: Add private includes only to specific packages

m-gorecki · sjanc · commit 0ce1291b2aee · 2024-04-16T17:14:31.000+02:00
Instead of adding private includes paths to every package
we should add them to the specific packages
diff --git a/newt/builder/build.go b/newt/builder/build.go
@@ -322,6 +322,10 @@ func (b *Builder) collectCompileEntriesBpkg(bpkg *BuildPackage) (
 		return nil, err
 	}
 
+	var privateIncCi toolchain.CompilerInfo
+	privateIncCi.Includes = bpkg.privateIncludeDirs(b)
+	c.AddInfo(&privateIncCi)
+
 	srcDirs := []string{}
 
 	if len(bpkg.SourceDirectories) > 0 {
diff --git a/newt/builder/buildpackage.go b/newt/builder/buildpackage.go
@@ -243,7 +243,7 @@ func (bpkg *BuildPackage) CompilerInfo(
 		return nil, err
 	}
 
-	ci.Includes = append(bpkg.privateIncludeDirs(b), includePaths...)
+	ci.Includes = append(ci.Includes, includePaths...)
 	bpkg.ci = ci
 
 	return bpkg.ci, nil

Original file line number	Diff line number	Diff line change
`@@ -322,6 +322,10 @@ func (b Builder) collectCompileEntriesBpkg(bpkg BuildPackage) (`
`322`	`322`	`return nil, err`
`323`	`323`	`}`
`324`	`324`
	`325`	`+ var privateIncCi toolchain.CompilerInfo`
	`326`	`+ privateIncCi.Includes = bpkg.privateIncludeDirs(b)`
	`327`	`+ c.AddInfo(&privateIncCi)`
	`328`	`+`
`325`	`329`	`srcDirs := []string{}`
`326`	`330`
`327`	`331`	`if len(bpkg.SourceDirectories) > 0 {`
Original file line number	Diff line number	Diff line change
`@@ -243,7 +243,7 @@ func (bpkg *BuildPackage) CompilerInfo(`
`243`	`243`	`return nil, err`
`244`	`244`	`}`
`245`	`245`
`246`		`- ci.Includes = append(bpkg.privateIncludeDirs(b), includePaths...)`
	`246`	`+ ci.Includes = append(ci.Includes, includePaths...)`
`247`	`247`	`bpkg.ci = ci`
`248`	`248`
`249`	`249`	`return bpkg.ci, nil`